Re: ports/182985 maintainer timeout
On Mar 27, 2014, at 18:51, Darren Pilgrim dar...@laskoprinting.com wrote: I hate to nag about this, but can we get this fixed sometime soon? In the three weeks since Mark's email, osa updated the port to 1.4.7, but didn't bother fixing this issue. What happened to this being a showstopper in a major port? Terribly sorry this has taken so long. It appears osa has been AFK and I have been so busy myself lately that I haven't had time to sit down and actually look into this. I've now verified that the proposed change does indeed match the behavior of the nginx-devel identically and the logic seems sound. The commit is in, sorry it has taken so long. You did the right thing by sending a reminder. osa, feel free to slap me if this causes any problems for you... ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: ports/182985 maintainer timeout
On 3/7/2014 4:52 AM, Mark Felder wrote:
On Fri, Mar 7, 2014, at 1:49, Scot Hetzel wrote:
Darren is correct, the intent of bsd.openssl.mk is to build using the
security/openssl port when WITH_OPENSSL_PORT is defined in
/etc/make.conf by the local administrator. What the www/nginx port
does is it forces the build to always use the base version when
${OSVERSION} = 128 by setting WITH_OPENSSL_BASE. The port should
not be doing this.
Correct, but I did not cover that scenario as he did not initially
indicate he was setting WITH_OPENSSL_PORT in his make.conf :-)
Now that this is clear we should be able to get this resolved.
I hate to nag about this, but can we get this fixed sometime soon? In
the three weeks since Mark's email, osa updated the port to 1.4.7, but
didn't bother fixing this issue. What happened to this being a
showstopper in a major port?
Regards,
Darren Pilgrim
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: ports/182985 maintainer timeout
On Fri, Mar 7, 2014, at 1:49, Scot Hetzel wrote:
Darren is correct, the intent of bsd.openssl.mk is to build using the
security/openssl port when WITH_OPENSSL_PORT is defined in
/etc/make.conf by the local administrator. What the www/nginx port
does is it forces the build to always use the base version when
${OSVERSION} = 128 by setting WITH_OPENSSL_BASE. The port should
not be doing this.
Correct, but I did not cover that scenario as he did not initially
indicate he was setting WITH_OPENSSL_PORT in his make.conf :-)
Now that this is clear we should be able to get this resolved.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: ports/182985 maintainer timeout
Can someone please look at this and commit the fix? I've had no
response and the issue means the nginx is broken for the best practices
case.
On 2/28/2014 3:09 PM, Darren Pilgrim wrote:
A recent change to the www/nginx Makefile broke the port for the case
where you have the OpenSSL port installed on FreeBSD 10. The breakage
is due to incorrectly setting WITH_OPENSSL_BASE and the fix is to remove
two lines in the Makefile:
--- Makefile.old2014-01-30 02:01:51.0 -0800
+++ Makefile2014-02-06 16:02:21.385735156 -0800
@@ -850,8 +850,6 @@
.if ${PORT_OPTIONS:MSPDY}
.if ${OSVERSION} 128
WITH_OPENSSL_PORT= yes
-.else
-WITH_OPENSSL_BASE= yes
.endif
.endif
.endif
Osa didn't reply to my email back on February 6 and there hasn't been
any reponse at all to the issue when it was raised in the PR almost two
months ago. Would some kind commiter please push this fix?
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: ports/182985 maintainer timeout
Hi Darren, I'm trying to understand exactly what we're looking at here. Is the problem: nginx always builds against OpenSSL in base (for FreeBSD 10+?) ? If so, that's correct; it should not build against OpenSSL from ports just because the version from ports happens to be installed. It should, however, install against the version from ports if that option is selected. If there is not an option to do so we should add one. If an option exists to build against OpenSSL from ports and it still builds against the version in base, we definitely have a problem. Nginx is a pretty important port so I just want to make sure we understand the full scope of the problem so a committer can test before making a commit. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: ports/182985 maintainer timeout
On 3/6/2014 3:07 PM, Mark Felder wrote: Hi Darren, I'm trying to understand exactly what we're looking at here. Is the problem: nginx always builds against OpenSSL in base (for FreeBSD 10+?) ? If so, that's correct; it should not build against OpenSSL from ports just because the version from ports happens to be installed. No, actually, that's exactly what it should do. If I install OpenSSL from ports and set WITH_OPENSSL_PORT in /etc/make.conf, the express intent is to require all OpenSSL-using ports to link to the ports version. Nginx with SPDY needs NPN, which means OpenSSL 1.0.1 or later. Thus for 9.x and earlier we need to set WITH_OPENSSL_PORT. For 10.0 and later, both versions will work, so the correct behaviour for nginx is to say it does not specifically require either by not setting either WITH_OPENSSL_* variable. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
Re: ports/182985 maintainer timeout
On Thu, Mar 6, 2014 at 8:05 PM, Darren Pilgrim dar...@laskoprinting.com wrote:
On 3/6/2014 3:07 PM, Mark Felder wrote:
Hi Darren,
I'm trying to understand exactly what we're looking at here. Is the
problem:
nginx always builds against OpenSSL in base (for FreeBSD 10+?) ?
If so, that's correct; it should not build against OpenSSL from ports
just because the version from ports happens to be installed.
No, actually, that's exactly what it should do. If I install OpenSSL from
ports and set WITH_OPENSSL_PORT in /etc/make.conf, the express intent is to
require all OpenSSL-using ports to link to the ports version.
Nginx with SPDY needs NPN, which means OpenSSL 1.0.1 or later. Thus for 9.x
and earlier we need to set WITH_OPENSSL_PORT. For 10.0 and later, both
versions will work, so the correct behaviour for nginx is to say it does not
specifically require either by not setting either WITH_OPENSSL_* variable.
Darren is correct, the intent of bsd.openssl.mk is to build using the
security/openssl port when WITH_OPENSSL_PORT is defined in
/etc/make.conf by the local administrator. What the www/nginx port
does is it forces the build to always use the base version when
${OSVERSION} = 128 by setting WITH_OPENSSL_BASE. The port should
not be doing this.
--
DISCLAIMER:
No electrons were maimed while sending this message. Only slightly bruised.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
ports/182985 maintainer timeout
A recent change to the www/nginx Makefile broke the port for the case
where you have the OpenSSL port installed on FreeBSD 10. The breakage
is due to incorrectly setting WITH_OPENSSL_BASE and the fix is to remove
two lines in the Makefile:
--- Makefile.old2014-01-30 02:01:51.0 -0800
+++ Makefile2014-02-06 16:02:21.385735156 -0800
@@ -850,8 +850,6 @@
.if ${PORT_OPTIONS:MSPDY}
.if ${OSVERSION} 128
WITH_OPENSSL_PORT= yes
-.else
-WITH_OPENSSL_BASE= yes
.endif
.endif
.endif
Osa didn't reply to my email back on February 6 and there hasn't been
any reponse at all to the issue when it was raised in the PR almost two
months ago. Would some kind commiter please push this fix?
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org
