Re: make installworld creates empty dirs which are deleted by make delete-old

2016-01-16 Thread Miroslav Lachman

Miroslav Lachman wrote on 01/16/2016 14:28:

Philippe Michel wrote on 01/16/2016 13:51:

On Sat, 16 Jan 2016, freebsd-stable-requ...@freebsd.org wrote:


I updated the server 3 times in one week (to 10.2-p8, -p9, -p10).



Those directories were deleted by delete-old

# make -DBATCH_DELETE_OLD_FILES delete-old
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
/usr/share/doc/atf
/usr/share/atf
/usr/include/atf-c++
/usr/include/atf-c
>>> Old directories removed
To remove old libraries run 'make delete-old-libs'.

By after next installworld, they are back.


You build world WITHOUT_TESTS=true, don't you ?

There are many of these flags that are somehow missed when creating
directories at install.


I don't use WITHOUT flags for buildworld / installwordl. The only
WITHOUT is one for kernel:
WITHOUT_KERNEL_SYMBOLS=yes


[...]


I think some similar cases were fixed a few months ago by NGie Cooper
but it was apparently those he stumbled on by himself or some specific
bug reports rather than the start of a more exhaustive sweep.

I suppose opening a PR could have helped but I procrastinated :-(.


OK, I will open PR for this today.

Thank you for your suggestions.


I found a half year old PR for this

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201072

Miroslav Lachman
___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"


Re: make installworld creates empty dirs which are deleted by make delete-old

2016-01-16 Thread Miroslav Lachman

Philippe Michel wrote on 01/16/2016 13:51:

On Sat, 16 Jan 2016, freebsd-stable-requ...@freebsd.org wrote:


I updated the server 3 times in one week (to 10.2-p8, -p9, -p10).



Those directories were deleted by delete-old

# make -DBATCH_DELETE_OLD_FILES delete-old
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
/usr/share/doc/atf
/usr/share/atf
/usr/include/atf-c++
/usr/include/atf-c
>>> Old directories removed
To remove old libraries run 'make delete-old-libs'.

By after next installworld, they are back.


You build world WITHOUT_TESTS=true, don't you ?

There are many of these flags that are somehow missed when creating
directories at install.


I don't use WITHOUT flags for buildworld / installwordl. The only 
WITHOUT is one for kernel:

WITHOUT_KERNEL_SYMBOLS=yes


Full content of src.conf and make.conf

root@sm-reserve ~/# cat /etc/src.conf
## src.conf

WITHOUT_KERNEL_SYMBOLS=yes


root@sm-reserve ~/# cat /etc/make.conf
## make.conf

WITH_PKGNG= yes

SVN_UPDATE=yes
SVN="/usr/local/bin/svnup"
SVNFLAGS=""


WITH_GHOSTSCRIPT_VER=9

DEFAULT_VERSIONS= perl=5.20 mysql=5.5m php=55 python=2.7 apache=2.4

## https://wiki.freebsd.org/Ports/Options/OptionsNG
## OptionsNG sets DOCS, EXAMPLES and NLS as default - we do not need them
OPTIONS_UNSET= X11 GUI CUPS DOCS EXAMPLES NLS


## cd /usr/ports/www/apache22 && make print-closest-mirrors
MASTER_SITE_APACHE_HTTPD?= http://apache.miloslavbrada.cz/httpd/ 
http://mirror.hosting90.cz/apache/httpd/ 
ftp://mirror.hosting90.cz/apache/httpd/ http://www.eu.apache.org/dist/httpd/


## closest PHP mirror
MASTER_SITE_PHP= http://cz.php.net/%SUBDIR%/



FWIW, with more WITHOUT flags set to true, my own list of directories
created again and again is :

Removing old directories

/usr/share/snmp/mibs
/usr/share/snmp/defs
/usr/share/snmp
/usr/share/examples/pf
/usr/share/examples/ipfilter
/usr/share/examples/hast
/usr/share/examples/bhyve
/usr/share/doc/smm/07.lpd
/usr/share/doc/atm
/usr/share/doc/atf
/usr/share/atf
/usr/libexec/lpr/ru
/usr/libexec/lpr
/usr/include/netnatm/sig
/usr/include/netnatm/saal
/usr/include/netnatm/msg
/usr/include/netnatm/api
/usr/include/netgraph/bluetooth/include
/usr/include/netgraph/bluetooth
/usr/include/krb5
/usr/include/kadm5
/usr/include/gpib
/usr/include/dev/ieee488
/usr/include/bsnmp
/usr/include/atf-c++
/usr/include/atf-c
/etc/bluetooth
/etc/autofs

Old directories removed


I think some similar cases were fixed a few months ago by NGie Cooper
but it was apparently those he stumbled on by himself or some specific
bug reports rather than the start of a more exhaustive sweep.

I suppose opening a PR could have helped but I procrastinated :-(.


OK, I will open PR for this today.

Thank you for your suggestions.

Miroslav Lachman
___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"


Re: make installworld creates empty dirs which are deleted by make delete-old

2016-01-16 Thread Philippe Michel

On Sat, 16 Jan 2016, freebsd-stable-requ...@freebsd.org wrote:


I updated the server 3 times in one week (to 10.2-p8, -p9, -p10).



Those directories were deleted by delete-old

# make -DBATCH_DELETE_OLD_FILES delete-old
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
/usr/share/doc/atf
/usr/share/atf
/usr/include/atf-c++
/usr/include/atf-c
>>> Old directories removed
To remove old libraries run 'make delete-old-libs'.

By after next installworld, they are back.


You build world WITHOUT_TESTS=true, don't you ?

There are many of these flags that are somehow missed when creating 
directories at install.


FWIW, with more WITHOUT flags set to true, my own list of directories 
created again and again is :

Removing old directories

/usr/share/snmp/mibs
/usr/share/snmp/defs
/usr/share/snmp
/usr/share/examples/pf
/usr/share/examples/ipfilter
/usr/share/examples/hast
/usr/share/examples/bhyve
/usr/share/doc/smm/07.lpd
/usr/share/doc/atm
/usr/share/doc/atf
/usr/share/atf
/usr/libexec/lpr/ru
/usr/libexec/lpr
/usr/include/netnatm/sig
/usr/include/netnatm/saal
/usr/include/netnatm/msg
/usr/include/netnatm/api
/usr/include/netgraph/bluetooth/include
/usr/include/netgraph/bluetooth
/usr/include/krb5
/usr/include/kadm5
/usr/include/gpib
/usr/include/dev/ieee488
/usr/include/bsnmp
/usr/include/atf-c++
/usr/include/atf-c
/etc/bluetooth
/etc/autofs

Old directories removed


I think some similar cases were fixed a few months ago by NGie Cooper but 
it was apparently those he stumbled on by himself or some specific bug 
reports rather than the start of a more exhaustive sweep.


I suppose opening a PR could have helped but I procrastinated :-(.
___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"


make installworld creates empty dirs which are deleted by make delete-old

2016-01-15 Thread Miroslav Lachman

I updated the server 3 times in one week (to 10.2-p8, -p9, -p10).

make check-old lists these directories on each update

# make check-old
>>> Checking for old files
>>> Checking for old libraries
>>> Checking for old directories
/usr/include/atf-c
/usr/include/atf-c++
/usr/share/atf
/usr/share/doc/atf
To remove old files and directories run 'make delete-old'.
To remove old libraries run 'make delete-old-libs'.

Those directories were deleted by delete-old

# make -DBATCH_DELETE_OLD_FILES delete-old
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
/usr/share/doc/atf
/usr/share/atf
/usr/include/atf-c++
/usr/include/atf-c
>>> Old directories removed
To remove old libraries run 'make delete-old-libs'.

By after next installworld, they are back.

I think there is some bug (leftover) in make install / mtree or 
something like this and those directories should not be created any more.


Miroslav Lachman
___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"