[Freeciv-Dev] [patch #1205] Named user unit type flags

[Marko Lindqvist]

URL:
  

 Summary: Named user unit type flags
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tuesday 07/28/2009 at 02:42
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

There is no special code related to "Airbase" unit type flag in Freeciv
codebase. All its functionality comes from ruleset; some units have it, and
airbase requires it. I call such flags user flags.

Attached patch:
- Increases number of user flags from 1 ("Airbase") to 4
- Makes actual flag names ruleset defined



___

File Attachments:


---
Date: Tuesday 07/28/2009 at 02:42  Name: UserUnitTypeFlags.diff  Size: 9kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1201] Setting to control distance of traderoutes.

[pepeto]

Follow-up Comment #3, patch #1201 (project freeciv):

I'm not totally convinced by this patch.  Something is hard to understand
when you are playing.  If you count the minimal tile distance between cities
to be able to establish a trade route, you count 9 tiles, and setting is set
to 8.  I would prefer change the calculation like ">= game.info.trademindist"
instead of "> game.info.trademindist" and set the default value to 9.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

[pepeto]

Follow-up Comment #9, bug #13891 (project freeciv):

> Patches in this ticket can go in first. Sending plain text to
> clients without featured text capabilities should be next step
> (or at least before server sends any featured text)

My patch for this is nearly ready, but I have some problems to make the patch
without the previous applied.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1204] Separate desktop files for gtk2, sdl and xaw clients

[Marko Lindqvist]

URL:
  

 Summary: Separate desktop files for gtk2,sdl and xaw clients
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tuesday 07/28/2009 at 01:06
Category: client
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

Currently there is one desktop file for client, and it tries to execute
gtk-client no matter which client is built.

Attached patch makes separate desktop file for each of the clients gtk2, sdl
and xaw. Only those desktop files that refer to actually built clients get
installed.

In addition to applying this patch file bootstrap/freeciv.desktop.in must be
renamed as bootstrap/freeciv-gtk2.desktop.in




___

File Attachments:


---
Date: Tuesday 07/28/2009 at 01:06  Name: DesktopForEachGui.diff  Size: 5kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1203] move ruleset option illness into its own section

[Matthias Pfafferodt]

Follow-up Comment #1, patch #1203 (project freeciv):

I did a complete cleanup of the game.ruleset files. The
content is not changed, only sorted and missing default
entries are added.

(file #6276)
___

Additional Item Attachment:

File name: cleanup_game_ruleset_files.patch Size:19 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1201] Setting to control distance of traderoutes.

[Marko Lindqvist]

Update of patch #1201 (project freeciv):

 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1202] [Patch] struct civ_game clean up

[Marko Lindqvist]

Update of patch #1202 (project freeciv):

 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1203] move ruleset option illness into its own section

[Marko Lindqvist]

Update of patch #1203 (project freeciv):

 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1203] move ruleset option illness into its own section

[Matthias Pfafferodt]

URL:
  

 Summary: move ruleset option illness into its own section
 Project: Freeciv
Submitted by: syntron
Submitted on: Montag 27.07.2009 um 20:26
Category: general
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

see summary

the section 'civstyle' in game.ruleset is a little
crowed - move illness option into their own section



___

File Attachments:


---
Date: Montag 27.07.2009 um 20:26  Name:
0001-move-ruleset-option-illness-into-its-own-section.patch  Size: 6kB   By:
syntron



___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1201] Setting to control distance of traderoutes.

[Matthias Pfafferodt]

Follow-up Comment #2, patch #1201 (project freeciv):

sorry; You are right, I did forgot to attach the patch ...

(file #6274)
___

Additional Item Attachment:

File name: 0001-Setting-to-control-distance-of-traderoutes.patch Size:5 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1201] Setting to control distance of traderoutes.

[Marko Lindqvist]

Follow-up Comment #1, patch #1201 (project freeciv):

Do you mean patch should be fetched from git, or did you just forgot to
attach it?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

[Marko Lindqvist]

Follow-up Comment #8, bug #13891 (project freeciv):

> (I'm not sure about the usage client_info packet instead of
> server_join_req).

server_join_req itself contains capability information. Capabilities cannot
be checked before it is sent. I rather avoid making incompatible versions of
server_join_req packet.

Patches in this ticket can go in first. Sending plain text to clients without
featured text capabilities should be next step (or at least before server
sends any featured text)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13931] implement reset command

[Matthias Pfafferodt]

Follow-up Comment #8, bug #13931 (project freeciv):

version3 - I did miss one small change ...

this one is tested as the only patch to trunk
of 20090727

(file #6273)
___

Additional Item Attachment:

File name: reset_command-version3.patch   Size:7 KB


___

Reply to this item at:

  <http://gna.org/bugs/?13931>

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13931] implement reset command

[Matthias Pfafferodt]

Follow-up Comment #7, bug #13931 (project freeciv):

I updated the patch to current trunk. The comment
is also corrected.

Late August is one month away - I think that is
a nice time frame. I will save the settings rework
for after the S2.2 branching.

(file #6272)
___

Additional Item Attachment:

File name: reset_command-version2.patch   Size:7 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13931] implement reset command

[Marko Lindqvist]

Follow-up Comment #6, bug #13931 (project freeciv):

> So freeciv 2.2 is around the corner? Does this means
> that at the moment the focus is on removing bugs and
> not add new things?

S2_2 branch should be created late August. New features can still be added,
but we (I?) really have to prioritize which ones we process. I don't think I
can process patch series size of settings changes before S2_2 branching.

There's no TODO list and I wonder if it's possible to do meta tickets in gna
like we have had in RT for previous releases.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1202] [Patch] struct civ_game clean up

[pepeto]

Follow-up Comment #1, patch #1202 (project freeciv):

Version for S2_1, with game.player_ptr moved to game.client.player_ptr.


(file #6271)
___

Additional Item Attachment:

File name: S2_1_struct_civ_game.diff.gz   Size:63 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1202] [Patch] struct civ_game clean up

[pepeto]

URL:
  

 Summary: [Patch] struct civ_game clean up
 Project: Freeciv
Submitted by: pepeto
Submitted on: Monday 07/27/2009 at 13:51
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

The attached patch moves all fields of the civ_game structure which are only
used in the server side into a game.server structure.  Maybe, some of this
datas should be moved into the server structure later.  For the moment, there
is no client only dependences in this structure.

Also, it removes 2 unused members of the structure:
* version: it was only used to read the savegame, replaced by a local
variable.
* ai_goal_government: it was not used at all.




___

File Attachments:


---
Date: Monday 07/27/2009 at 13:51  Name: trunk_struct_civ_game.diff.gz  Size:
11kB   By: pepeto



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1188] proposed menu and command key revamp

[John Keller]

Follow-up Comment #6, patch #1188 (project freeciv):

Glad to hear the patches worked for you, Marko!

I had split the patch into two patches in order to avoid "noise" created by
the renaming. That makes it possible to see the basic restructuring
("menu.c.01_reorg.diff") and the (necessary) refinements (to allow shortcuts
to coexist, etc - "menu.c.02_accels_revised.diff").

The documentation patch isn't really useful on its own either, and in fact
includes some changes that address prior command changes (by other
developers) which aren't currently shown in the help system.

This was why I've included three patches in one ticket. Moving items around
in the menu and then renaming them is actually an atomic operation - the goal
is a large menu and command redesign.

I can place patch "menu.c.01_reorg.diff" and "menu.c.02_accels_revised.diff"
in two tickets - would you like me to go forward on that?

But I'm not sure that there's any other way to reduce the patch size further.
I'd be happy to make changes if you had suggestions, I'm still trying to learn
the process for this project...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements

[pepeto]

Follow-up Comment #7, bug #13891 (project freeciv):

featured_text4.diff:

* Fixed link id initialization.

client_implementation3.diff:

* Parse colors only once.
* Links are clickable.  The colors used are the traditionnal warclient
ones.  The graphical implementation is not done yet.


(file #6266, file #6267)
___

Additional Item Attachment:

File name: featured_text4.diffSize:38 KB
File name: client_implementation3.diffSize:13 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13931] implement reset command

[Matthias Pfafferodt]

Follow-up Comment #5, bug #13931 (project freeciv):

Is there a TODO-list for freeciv 2.2?

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13931] implement reset command

[Matthias Pfafferodt]

Follow-up Comment #4, bug #13931 (project freeciv):

> I propose we add reset command first so it makes
> it to 2.2 and make settings changes only to 2.3.
> Would that be ok? 

So freeciv 2.2 is around the corner? Does this means
that at the moment the focus is on removing bugs and
not add new things?

I will update the reset patch to trunk and also look
into the open bugs. Below some information to my
tickets.

The settings update and all connected changes can be
put aside till 2.3-devel. This are the tracker ids
* bug #13867
* bug #13868
* bug #13869
* bug #13870
* bug #13871
* bug #13872
* bug #13873
* patch #1197
* patch #1198
* patch #1199
* patch #1200

The following tracker ids are superseded by the above
and can be closed:
* bug #13621
* bug #13805
* bug #13810

Are the following tickets considered for 2.2?

* Setting to control distance of traderoutes. (patch #1201)
* add illness information to gui-win32 (bug #14015)

The patch 'pollution on lakes / ocean' (bug #13599)
is only interesting for 2.3-devel as some code for
the AI to clean up the new pollution has to be written.


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13621] [patch] load game settings from ruleset

[Matthias Pfafferodt]

Follow-up Comment #11, bug #13621 (project freeciv):

a new version can be found in gna bug #13873

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13942] No way to unload a busy worker from a transport.

[Matthias Pfafferodt]

Follow-up Comment #2, bug #13942 (project freeciv):

I also would like to have workers / settlers /
engineers only working on land tiles. I think
two additional unit are needed:

* boot engineer: transformation of ocean tiles;
  later removal of pollution from ocean tiles
* amphibious engineer (as helicopter unit):
  emergency pollution cleaning on land/ocean/see
  tiles; transformation of inland sees

If ocean cities are added boot settlers would
also be needed.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev