[Freeciv-Dev] [patch #1208] City warmap alternative
Follow-up Comment #2, patch #1208 (project freeciv): It seems it's impossible to deal just with unit classes. So the current version of this patch works with unit types. (file #6288) ___ Additional Item Attachment: File name: trunk_city_warmap_alternative2.diff Size:6 KB ___ Reply to this item at: http://gna.org/patch/?1208 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13958] View traderoutes always shows 0/4 for cities of other players
Additional Item Attachment, bug #13958 (project freeciv): File name: trunk_foreigner_city_trade_routes.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?13958 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14030] Multiple unit load sometimes crashes
URL: http://gna.org/bugs/?14030 Summary: Multiple unit load sometimes crashes Project: Freeciv Submitted by: pepeto Submitted on: Wednesday 07/29/2009 at 07:27 Category: general Severity: 4 - Important Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: In trunk, if you select many units and you attempt to load them whereas some of them cannot load in any transporter, then it crashes. ___ File Attachments: --- Date: Wednesday 07/29/2009 at 07:27 Name: trunk_load_multiple_units.diff Size: 444B By: pepeto http://gna.org/bugs/download.php?file_id=6290 ___ Reply to this item at: http://gna.org/bugs/?14030 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14031] Multiple units unload all crash
URL:
http://gna.org/bugs/?14031
Summary: Multiple units unload all crash
Project: Freeciv
Submitted by: pepeto
Submitted on: Wednesday 07/29/2009 at 07:50
Category: client
Severity: 4 - Important
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release:
Operating System: None
___
Details:
When many transporters are doing unload all, the client usually crashes,
because the function could be simplified by:
unit_list_iterate(list, punit) {
unit_list_unlink_all(list);
} unit_list_iterate_end;
Back trace:
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f3a986a66f0 (LWP 6313)]
0x0041b552 in key_unit_unload_all () at control.c:2471
2471 unit_list_iterate(get_units_in_focus(), punit) {
(gdb) bt
#0 0x0041b552 in key_unit_unload_all () at control.c:2471
#1 0x7f3a96ca6bbf in g_closure_invoke () from
/usr/lib/libgobject-2.0.so.0
#2 0x7f3a96cba7e8 in ?? () from /usr/lib/libgobject-2.0.so.0
#3 0x7f3a96cbc245 in g_signal_emit_valist ()
from /usr/lib/libgobject-2.0.so.0
#4 0x7f3a96cbc633 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#5 0x7f3a98145b5b in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#6 0x7f3a96ca6bbf in g_closure_invoke () from
/usr/lib/libgobject-2.0.so.0
#7 0x7f3a96cba7e8 in ?? () from /usr/lib/libgobject-2.0.so.0
#8 0x7f3a96cbbf6f in g_signal_emit_valist ()
from /usr/lib/libgobject-2.0.so.0
#9 0x7f3a96cbc633 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#10 0x7f3a97f5b506 in gtk_accel_group_activate ()
from /usr/lib/libgtk-x11-2.0.so.0
#11 0x7f3a97f5b60f in gtk_accel_groups_activate ()
from /usr/lib/libgtk-x11-2.0.so.0
#12 0x7f3a981534f8 in gtk_window_activate_key ()
from /usr/lib/libgtk-x11-2.0.so.0
#13 0x7f3a98153569 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#14 0x7f3a9803987f in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#15 0x7f3a96ca6bbf in g_closure_invoke () from
/usr/lib/libgobject-2.0.so.0
#16 0x7f3a96cbabc8 in ?? () from /usr/lib/libgobject-2.0.so.0
#17 0x7f3a96cbbf6f in g_signal_emit_valist ()
---Type return to continue, or q return to quit---
from /usr/lib/libgobject-2.0.so.0
#18 0x7f3a96cbc633 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#19 0x7f3a98140e55 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#20 0x7f3a98032c4d in gtk_propagate_event ()
from /usr/lib/libgtk-x11-2.0.so.0
#21 0x7f3a98033b35 in gtk_main_do_event ()
from /usr/lib/libgtk-x11-2.0.so.0
#22 0x7f3a97c9d58c in ?? () from /usr/lib/libgdk-x11-2.0.so.0
#23 0x7f3a9660a384 in g_main_context_dispatch ()
from /usr/lib/libglib-2.0.so.0
#24 0x7f3a9660d695 in ?? () from /usr/lib/libglib-2.0.so.0
#25 0x7f3a9660d9b5 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#26 0x7f3a98033f03 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#27 0x004be1da in ui_main (argc=1, argv=0x7fffa06d8ba8)
at gui_main.c:1654
#28 0x00414ab0 in main (argc=value optimized out,
argv=0x7fffa06d8ba8) at civclient.c:417
Patch for both S2_1 and trunk.
___
File Attachments:
---
Date: Wednesday 07/29/2009 at 07:50 Name: unload_multiple_units.diff Size:
3kB By: pepeto
http://gna.org/bugs/download.php?file_id=6291
___
Reply to this item at:
http://gna.org/bugs/?14031
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14031] Multiple units unload all crash
Follow-up Comment #1, bug #14031 (project freeciv): Right patch attached. (file #6295) ___ Additional Item Attachment: File name: unload_multiple_units.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?14031 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14032] Unloading foreigner units make log error messages
URL: http://gna.org/bugs/?14032 Summary: Unloading foreigner units make log error messages Project: Freeciv Submitted by: pepeto Submitted on: Wednesday 07/29/2009 at 08:13 Category: client Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: When you attempt to unload foreigner units from your transporters, you get some server log error messages handle_unit_change_activity() invalid unit. The attached patch removes the problem with preventing the client to send invalid packets in a such case. ___ File Attachments: --- Date: Wednesday 07/29/2009 at 08:13 Name: trunk_unload_unit.diff Size: 744B By: pepeto http://gna.org/bugs/download.php?file_id=6296 --- Date: Wednesday 07/29/2009 at 08:13 Name: S2_1_unload_unit.diff Size: 732B By: pepeto http://gna.org/bugs/download.php?file_id=6297 ___ Reply to this item at: http://gna.org/bugs/?14032 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14031] Multiple units unload all crash
Update of bug #14031 (project freeciv): Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?14031 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13667] Game end message not visible
Follow-up Comment #1, bug #13667 (project freeciv): Actually, the problem is that the client is not allowed to show messages when the game is over. Only trunk is affected. (file #6298) ___ Additional Item Attachment: File name: trunk_game_over_message.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?13667 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13763] gtk assertion VALID_ITER failed when detaching
Follow-up Comment #1, bug #13763 (project freeciv): The problem is that temporary, the player_ptr is not valid. The game has been reset in the client side, and the new connection status not received yet. So, the client tries to insert a player observer into a non-initialized parent node. The attached patch switches to trunk solution, listing player observers in the player iteration. (file #6299) ___ Additional Item Attachment: File name: S2_1_remove_detach_gtk_warnings.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?13763 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #8, patch #1188 (project freeciv): Wow, Marco. Thanks for the willingness to experiment! I definitely understand and respect not wanting to make different key usage in different clients. I tried to make these changes logical and at the same time not too disruptive (I don't think anyone would want to have the basic go-to changed to Z :-D ), and tried to think of the other clients while working on the GTK client (I think I've actually reduced the number of Ctrl-key combinations, nicer for everyone). So it's entirely logical to want to bring these changes to other clients, and is my hope as well. I've looked at the other clients, and I'd be willing and able to create patches for SDL, XAW and Windows native clients. I'd just change the keys (to keep consistency between clients) but not the menu layout (so as to avoid breakage). Then the maintainers for the two other clients with menus (XAW and Windows) could revise menu structure per the final GTK implementation, as they saw fit. I could have those three patches for this weekend; would you be interested? Would that help get these changes in for 2.1? Here's my reasoning for hoping to get my changes in for 2.1: 0 In the GTK client as it stands, there are new keys for selecting units, and the editing mode is implemented (both new since 2.0) - my patches affect both. I'd love to have my new key structure implemented so that it could get revised during the 2.1 cycle (more people testing = more input). 0 I'm hoping to move the GTK client's menu to GtkUIManager instead of GtkItemFactory. This would permit some big UI fixes, potentially also helping the editor. (Whether implemented in 2.1 or not would depend on the project's policy for UI changes to released versions, which I'm not familiar with). I certainly don't want to pressure you, and am happy to follow your decision. On the other hand, I've been itching for years to get started with this work (hampered by time but also the old RT bug tracker), so if I sound eager it's because I am. :-) ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #9, patch #1188 (project freeciv): Excuse me, I must have a tired brain. I meant 2.2 where I wrote 2.1 in my previous comment... i.e. hoping to get these changes into 2.2 before it's branched. ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14017] server crash when transferring a boat due to citizen migration
Follow-up Comment #1, bug #14017 (project freeciv): The Trireme is a sea unit and I think it is transported (teleported) to an inland city, there it can't exist. This is also stated in the comment to this function (unit_change_homecity_handling() in unithand.c): This new homecity must be valid for this unit. 1) I think, a quick solution is a check in the migration code. 2) A general solution could include the following: * change homecity does _only_ changes the homecity (the unit stays there it is) * if the unit is in its homecity and the city is destroyed move the unit to the nearest tile there it can survive (within the city map; if there is no such a place destroy the unit) Is such a general solution needed? Are there other situations there units are teleported? I will look into this and create a patch ... ___ Reply to this item at: http://gna.org/bugs/?14017 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13667] Game end message not visible
Update of bug #13667 (project freeciv): Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?13667 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14004] Client should show plague risk as 0 when illness disabled
Follow-up Comment #4, bug #14004 (project freeciv): attached patch removes the newline (file #6300) ___ Additional Item Attachment: File name: version2-report-illness-only-if-activated-in-the-ruleset.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?14004 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #10, bug #13891 (project freeciv): maybe it would try to translate the link name to the local language in text_tag_replace_text() Yes, that sounds like right thing to do. Just realized that rest of the message is translated at the server side. Link name also should be translated server side to make translation at least consistent, if not one translated for client's local language. This is how things currently (before your patch) work anyway. ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1203] move ruleset option illness into its own section
Follow-up Comment #3, patch #1203 (project freeciv): as mentioned in the last comment I did * insert the function secfile_lookup_int_default_min_max() * added all ruleset options as constants (default/min/max) * use the function to load them * cleanup of the game.ruleset files * move illness to its own section I hope the limits are chosen, that old files work without problems ... (file #6301) ___ Additional Item Attachment: File name: cleanup_of_ruleset_c.patch Size:51 KB ___ Reply to this item at: http://gna.org/patch/?1203 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1203] move ruleset option illness into its own section
Follow-up Comment #4, patch #1203 (project freeciv): update version * delete GAME_DEFAULT_SLOW_INVASIONS from game.c as it is initialised by the ruleset (file #6302) ___ Additional Item Attachment: File name: version2-cleanup_of_ruleset_c.patch Size:51 KB ___ Reply to this item at: http://gna.org/patch/?1203 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1202] [Patch] struct civ_game clean up
Update of patch #1202 (project freeciv): Status:None = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1202 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13931] implement reset command
Update of bug #13931 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13931 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13891] [Patch] Chat colors and other improvements
Follow-up Comment #11, bug #13891 (project freeciv): Just realized that rest of the message is translated at the server side. Link name also should be translated server side to make translation at least consistent, if not one translated for client's local language. This is how things currently (before your patch) work anyway. I was actually mainly thinking about chat. But you are totally right. Anyway, in the chat case, people are supposed to chat in the same language than the server, so it's not a problem if the server translate the unit links. (file #6303) ___ Additional Item Attachment: File name: featured_text5.diffSize:38 KB ___ Reply to this item at: http://gna.org/bugs/?13891 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14017] server crash when transferring a boat due to citizen migration
Follow-up Comment #2, bug #14017 (project freeciv): check if unit can exist at the new tile in transfer_unit(); if not delete the unit (file #6304) ___ Additional Item Attachment: File name: 0001-check-if-unit-can-exist-on-new-tile-in-transfer_unit.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?14017 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14017] server crash when transferring a boat due to citizen migration
Follow-up Comment #3, bug #14017 (project freeciv): check if unit can exist at the new tile in transfer_unit(); if not delete the unit What about gameloss units? ___ Reply to this item at: http://gna.org/bugs/?14017 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1209] struct civ_map clean up
URL: http://gna.org/patch/?1209 Summary: struct civ_map clean up Project: Freeciv Submitted by: pepeto Submitted on: Wednesday 07/29/2009 at 21:39 Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any ___ Details: Like for struct civ_game, all fields of the civ_map structure which are only used in the server side are moved into a map.server structure. ___ File Attachments: --- Date: Wednesday 07/29/2009 at 21:39 Name: trunk_struct_civ_map.diff Size: 48kB By: pepeto http://gna.org/patch/download.php?file_id=6305 ___ Reply to this item at: http://gna.org/patch/?1209 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1209] struct civ_map clean up
Update of patch #1209 (project freeciv): Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/patch/?1209 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1206] Constant parameters for movement functions
Update of patch #1206 (project freeciv): Status:None = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1206 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14017] server crash when transferring a boat due to citizen migration
Follow-up Comment #4, bug #14017 (project freeciv): good question - I never played a game with a gameloss unit. Should the unit teleported to a random place? try the next city? the capital? ___ Reply to this item at: http://gna.org/bugs/?14017 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
