[Freeciv-Dev] [patch #1235] variable city radii
Follow-up Comment #1, patch #1235 (project freeciv): one remark to this patch series: Using this patch, the city map in the city windows is scaled down. It's hard to see that's on the tiles. The size of the city map is defined in citydlg_common.c:generate_citydlg_dimensions(). I would propose to use the default city radius of 2 (pr 3?) to define the dimensions of the city map window. If the city radius is greater than this radius, scroll bars appear for the city map window. I don't know gtk to code this ... ___ Reply to this item at: http://gna.org/patch/?1235 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13931] implement reset command
Follow-up Comment #11, bug #13931 (project freeciv): As written in [...] tickets can depend on each other Perhaps such a meta ticket is possible? That would be great, though I haven't been able to figure out how to set dependencies in the Savane interface. Besides meta tickets, that would also be very useful for multi-patch groups. Maybe a permissions issue for normal users? ___ Reply to this item at: http://gna.org/bugs/?13931 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14106] civserver should use --bind= address when connecting to the metaserver, too
URL:
http://gna.org/bugs/?14106
Summary: civserver should use --bind= address when
connecting to the metaserver, too
Project: Freeciv
Submitted by: None
Submitted on: Tuesday 08/11/2009 at 19:26 CEST
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email: oneing...@gmail.com
Open/Closed: Open
Discussion Lock: Any
Release:
Operating System: None
___
Details:
Currently, civserver has an option to bind () on a certain IP address. This
option is, however, useless for my multihomed system, as it still tries to
connect to the metaserver from the other IP, resulting in a non-working
metaserver list entry.
Alternatively, a separate option (e. g.: --meta-bind=) could be added.
... Perhaps, the change is something like adding the bits like the following
ones of sernet.c (server_open_socket):
952if (!net_lookup_service(srvarg.bind_addr, srvarg.port, src,
FALSE)) {
953 freelog(LOG_FATAL, _(Server: bad address: %s:%d.),
954 srvarg.bind_addr, srvarg.port);
955 exit(EXIT_FAILURE);
956}
999if(bind(sock, src.saddr, sockaddr_size(src)) == -1) {
1000 freelog(LOG_FATAL, Server bind failed: %s,
fc_strerror(fc_get_errno()));
1001 sockaddr_debug(src);
1002 exit(EXIT_FAILURE);
1003}
... to meta.c (send_to_metaserver), in between the calls to socket () and
fc_connect ():
217if ((sock = socket(meta_addr.saddr.sa_family, SOCK_STREAM, 0)) ==
-1) {
218 freelog(LOG_ERROR, Metaserver: can't open stream socket: %s,
219 fc_strerror(fc_get_errno()));
220 metaserver_failed();
221 return FALSE;
222}
223
224if (fc_connect(sock, meta_addr.saddr,
225 sockaddr_size(meta_addr)) == -1) {
226 freelog(LOG_ERROR, Metaserver: connect failed: %s,
fc_strerror(fc_get_errno()));
227 metaserver_failed();
228 fc_closesocket(sock);
229 return FALSE;
230}
Hopefully I'd be able to do the change and try it soon.
TIA.
___
Reply to this item at:
http://gna.org/bugs/?14106
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14037] unit_change_homecity_handling() teleports units
Follow-up Comment #8, bug #14037 (project freeciv): I decided to change it to a homeless unit. If no possible homecity can be found, the current homecity is the last city of this player ... This is perhaps not so good. It could be used to create homeless units if there are two players who work together. This means that if the last city is conquered, all units supported by this city are disbanded. Does freeciv checks for players without cities / units? Other opinions? ___ Reply to this item at: http://gna.org/bugs/?14037 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14106] civserver should use --bind= address when connecting to the metaserver, too
Additional Item Attachment, bug #14106 (project freeciv): File name: freeciv-2.1.9- Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?14106 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14106] civserver should use --bind= address when connecting to the metaserver, too
Follow-up Comment #1, bug #14106 (project freeciv): FWIW, the patch I've made (attached) seems to work. ___ Reply to this item at: http://gna.org/bugs/?14106 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14106] civserver should use --bind= address when connecting to the metaserver, too
Additional Item Attachment, bug #14106 (project freeciv): File name: metabind.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?14106 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1241] AI should not complain about its own treaty
URL: http://gna.org/patch/?1241 Summary: AI should not complain about its own treaty Project: Freeciv Submitted by: kudra Submitted on: Tuesday 08/11/2009 at 21:48 Category: ai Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any ___ Details: When the AI is proposing a treaty, an evaluation of the treaty in progress may not be fair to the AI. Currently, this means that the AI complains: This deal is not very good for us, Player! which is somewhat illogical. This patch introduces a check so that if the AI is the one proposing the treaty it will not complain. The patch is against trunk, revision 15873. ___ File Attachments: --- Date: Tuesday 08/11/2009 at 21:48 Name: no_object_own_treaty.diff Size: 768B By: kudra http://gna.org/patch/download.php?file_id=6414 ___ Reply to this item at: http://gna.org/patch/?1241 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1242] Eritrean nation
URL: http://gna.org/patch/?1242 Summary: Eritrean nation Project: Freeciv Submitted by: kudra Submitted on: Tuesday 08/11/2009 at 23:00 Category: rulesets Priority: 3 - Low Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any ___ Details: Patch adds Eritrea. PNG are not included in the patch although they are referenced in data/flags/Makefile.am, data/misc/shields.spec, data/misc/flags.spec. Patch is against trunk, r15873. The SVG is from the Open Clip Art Library, which released it explicitly into the public domain, using the Creative Commons Public Domain Dedication. ___ File Attachments: --- Date: Tuesday 08/11/2009 at 23:00 Name: eritrean.diff Size: 16kB By: kudra http://gna.org/patch/download.php?file_id=6417 ___ Reply to this item at: http://gna.org/patch/?1242 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
