[Freeciv-Dev] [bug #14745] UI for management of trade routes non-obvious or non-existant

2009-11-11 Thread anonymous 

Follow-up Comment #2, bug #14745 (project freeciv):

Yes, I did eventually find that (is any of that left-hold-for-info-bubble
stuff actually documented?).  However, only one of my established trade
routes appear there.

If, for some reason, the route is not profitable, I would suggest making this
obvious by listing "+0 : Trade route with (city name)" (and also fix the
inconsistency here -- everything else seems to use the term "traderoute")

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14106] civserver should use --bind= address when connecting to the metaserver, too

2009-11-11 Thread pepeto 

Update of bug #14106 (project freeciv):

  Status:Wont Fix => None   
 Assigned to:  pepeto => None   
 Open/Closed:  Closed => Open   

___

Follow-up Comment #10:

> Could Wont Fix be dropped then?

Done.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14745] UI for management of trade routes non-obvious or non-existant

2009-11-11 Thread pepeto 

Follow-up Comment #1, bug #14745 (project freeciv):

Currently it appears in the overview city page, when you click on the trade
surplus.  A window appears to explain how this value is calculated, including
the traderoutes.

However, I never liked the removal of the trade page of the city dialog. 
Maybe it would be reimplemented later, notably like warclient trade page if
we decide to use warclient style traderoutes.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14745] UI for management of trade routes non-obvious or non-existant

2009-11-11 Thread anonymous 

URL:
  

 Summary: UI for management of trade routes non-obvious or
non-existant
 Project: Freeciv
Submitted by: None
Submitted on: Thursday 11/12/2009 at 05:24 CET
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: free...@tech.geek.nz
 Open/Closed: Open
 Release: 2.1.9
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: None

___

Details:

After using a canavan to establish a trade route between two of my cities, I
was unable to find UI to show me how much (per-turn) trade is generated by
it, despite searching both help and Google.

I did find the "View | City Traderoutes" command, which is great for visually
showing established routes, but this does not show how much trade is being
generated, and has the potential to become crowded over time (maybe it could
be toggled on a per-city basis, like the city worker map grid?).

IMO, UI to show and manage trade routes should appear in one or both of these
places:

* In the "Overview" tab, or a separate "Trade" tab, of both city's
information report.

* In a new "Trade" report, accessible from the "Reports" menu.

If the per-city "Trade" tab idea is implemented, that would also give
opportunity to break down the trade generated by the city, separately listing
the effects of modifiers such as terrain specials, roads, railroads,
government, improvements, wonders, corruption, etc.

If the "Trade" report idea is implemented, that would give an excellent
opportunity to visualise trade routes on a city-by-city or even
route-by-route basis, as suggested above.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1362] Drop S_S_GENERATING_WAITING state

2009-11-11 Thread pepeto 

Update of patch #1362 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => pepeto 
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14708] ATK warnings at start

2009-11-11 Thread pepeto 

Update of bug #14708 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => pepeto 
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

2009-11-11 Thread pepeto 

Follow-up Comment #15, bug #13869 (project freeciv):

> The other patches are changes 'nice to have'.

I really think it's clearer to keep different validation callback for every
type of settings supported.  Any, it doesn't change the space of the memory
since it's in an union now.

I suggest to don't apply this patch.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

2009-11-11 Thread Matthias Pfafferodt 

Follow-up Comment #14, bug #13869 (project freeciv):

> > it seems now that it doesn't work at all. 
>
> My mistake. I committed it without properly testing it myself.

It was my error to send the patch without really thinking about the logic
used in the code.

> I don't think this is a fundamental patch for the setting
> series. 

>From the following patches only 

bug #13873 - save game settings in game.ruleset

and

patch #1200 - game settings can be locked by the ruleset 

are really changing the working of the game settings. The other patches are
changes 'nice to have'.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

2009-11-11 Thread pepeto 

Follow-up Comment #13, bug #13869 (project freeciv):

> My mistake. I committed it without properly testing it myself.

Someone who don't make mistake is not human! The greatest quality of man is
to recognize to make mistakes. ;)

> I'm a bit undecided whether this patch makes code simpler or
> less simple. It has both pros and cons. Conclusion: Committing
> it would only cause diff noise.

I agree with you.

> Do latter patches of the series depend on some fundamental way
> on this one? Or can we skip this one?

I don't think this is a fundamental patch for the setting series.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

2009-11-11 Thread Marko Lindqvist 

Update of bug #13869 (project freeciv):

  Status:   Fixed => None   
 Open/Closed:  Closed => Open   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

2009-11-11 Thread Marko Lindqvist 

Follow-up Comment #11, bug #13869 (project freeciv):

> it seems now that it doesn't work at all.

My mistake. I committed it without properly testing it myself.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14710] Beta version build fails, gtk-client

2009-11-11 Thread Marko Lindqvist 

Update of bug #14710 (project freeciv):

  Status:None => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14710] Beta version build fails, gtk-client

2009-11-11 Thread Marko Lindqvist 

Update of bug #14710 (project freeciv):

 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14306] save all settings in the savegame

2009-11-11 Thread Marko Lindqvist 

Follow-up Comment #4, bug #14306 (project freeciv):

Updated S2_2 / TRUNK version against svn.

(file #7283)
___

Additional Item Attachment:

File name: ServerSettingsToSavegame_14306.diff Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1352] save event cache in savegame

2009-11-11 Thread pepeto 

Update of patch #1352 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #14661] wish: raise max map size to 30 from 29

2009-11-11 Thread pepeto 

Update of bug #14661 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => pepeto 
 Planned Release:None => 2.2.0  

___

Additional Item Attachment:

File name: trunk_expand_some_max_settings.diff Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

2009-11-11 Thread pepeto 

Follow-up Comment #10, bug #13869 (project freeciv):

Hm, this is crazy, I didn't look at this patch, but it seems now that it
doesn't work at all.  I didn't understand this was to replace the validation
function, I thought it was about the action callback.  I am strongly
against.

It is normal to pass a string to a string validation function, a boolean to a
boolean validation function and an integer to a validation function!  This
patch just check if the current value is normal, not the value we want to
set.

I guess this would have to be reverted.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #13869] [patch 03/07] simplify validation functions

2009-11-11 Thread Marko Lindqvist 

Update of bug #13869 (project freeciv):

  Status: In Progress => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1352] save event cache in savegame

2009-11-11 Thread pepeto 

Follow-up Comment #9, patch #1352 (project freeciv):

Attached new version:
* Updated against current svn.
* Move the load and save functions in the notify module.
* More registry call with default values.
* Move the send_pending_events at the right place.
* Add _warn_unused_result_ attribute to event_cache_player_add().


(file #7280)
___

Additional Item Attachment:

File name: trunk_S2_2_save_event_cache.diff Size:14 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1266] add option to restrict the use of road and rails for enemies

2009-11-11 Thread Marko Lindqvist 

Update of patch #1266 (project freeciv):

  Status:None => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1363] Use tile index instead of city coordinates for packets

2009-11-11 Thread pepeto 

URL:
  

 Summary: Use tile index instead of city coordinates for
packets
 Project: Freeciv
Submitted by: pepeto
Submitted on: mercredi 11.11.2009 à 12:15
Category: general
Priority: 1 - Later
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

This simplify a bit some functions which need to send a NULL tile (here tile
index == -1) and always unsure the tile is valid.  It would also be a bit
faster, but I don't think it would be noticeable.




___

File Attachments:


---
Date: mercredi 11.11.2009 à 12:15  Name: trunk_tile_index_packets.diff 
Size: 39 ko   By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev