[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #10, bug #15377 (project freeciv): Actually I came to the exact same conclusion Ulrik: we should simply rewrite the character functions to work only on ascii (range 0 to 127) characters, and leave others alone. Using the system-provided functions (such as tolower) which work in the current locale makes no sense and never will make sense. This means some UTF8 characters wont get properly converted which will cause minor bugs (for instance it wont do proper case comparison on non-ascii letters in player/ruler names), but will remove a much larger set of bugs (for instance it may currently do wrong case comparison on those same non-ascii letters). As for making or using a UTF-8 variant for these, it's a bit more complicated than that. You can't have isspace() or tolower() or isalpha() functions in utf8 that go byte-by-byte. This means the same job you were doing via byte iteration over the string has to be done entirely differently, in every case. Additionally, some of the places these functions are called they are given utf-8, some they are given ascii, and in some they may be given latin1 or a different character set - so again it all requires careful auditing of the users in that case, of which there are a lot. If we go that route I'd rather rewrite all freeciv core to use ucs2 or ucs4 (fixed-width unicode) strings and impose that on these functions, and then we get type-checking out of it as well. This wouldn't be that hard but then we have to convert all data files (in utf-8) and all GUI strings (also in utf-8, for gtk2) on both input and output, everywhere, which is a lot of lines of change. It's probably overkill. ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #11, bug #15377 (project freeciv): And, unfortunately limiting the functions to ascii-only is not going to work very well either for the is_ functions. is_alnum is most likely used for instance to check for valid ruler/city names and will fail on any non-ascii names now. Even if we add exceptions for any ruler/city names in the ruleset (probably already done) it's not desirable for any non-latin-alphabet players. Nonetheless here's the patch for it (very simple patch; someone might want to actually rewrite the functions to do the work directly for ascii). Out of curiosity, if I made a patch to switch freeciv's internal encoding (client, server, and network encoding) to UCS2/UCS4, would the change be supported by the current developers? Also as a side note, libc does include support for wide characters. However it's not defined what character set this actually is so we still have the current locale issues which is no good since we want to use the same character set at both client and server. -jason (file #8662) ___ Additional Item Attachment: File name: char.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #12, bug #15377 (project freeciv): Turning these functions into ASCII only is the only sane thing, but it might only be the first step. I don't think we check ruler names or anything against character classes, that would already today fail often! Likewise, we don't add new bugs by this change, for example matching player names with non-ASCII names already now requires exact case for the non-ascii part. (For example /ai RÖDSKÄGGE won't match player Rödskägge, but /ai RöDSKäGGE will. This behavior is preserved with this change.) About the patch: Why not document more exactly how we now define the functions more or less work with UTF-8 will leave people wondering. Here's my contribution: These functions are wrappers for the libc character class functions, without any locale-dependent behavior. The character functions work as documented for ASCII. Bytes outside of the ASCII set will not be reported to belong to any character class, and will only be transformed to themselves. This behavior is safe but not strictly correct forsingle-byte 8-bit- or UTF-8 encoded text; in UTF-8, any byte that is part of a multibyte sequence is non-ASCII. ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1230] save worked tiles from main map
Follow-up Comment #8, patch #1230 (project freeciv): Don't care of old trunk servers, there shouldn't be really played as they are the development branch. OK; here is a updated version including the changes in patch #1480 Be careful, the new savegame format will crash old trunk servers! An update of the network capabilities is needed (removal of type CITY_AMP definition) (file #8663) ___ Additional Item Attachment: File name: 20100327-trunk--savegame-format-remove-pcity-city_map-and-save-wor.diff Size:59 KB ___ Reply to this item at: http://gna.org/patch/?1230 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1480] remove pcity-city_map
Update of patch #1480 (project freeciv): Status:None = Duplicate Open/Closed:Open = Closed ___ Follow-up Comment #1: included in patch #1230 ___ Reply to this item at: http://gna.org/patch/?1480 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #13, bug #15377 (project freeciv): We could look eagerly at GLib's support for Unicode/UTF-8, they have every function we would ever need: http://library.gnome.org/devel/glib/unstable/glib-Unicode-Manipulation.html That should already be available to the GTK+ client of course. But there must be some more lighter-weight library for Unicode + UTF-8 available. If I can amend the text in the previous message, say and will be left unchanged by transformations. instead of and will only be transformed to themselves. ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1236] experimental ruleset
Update of patch #1236 (project freeciv): Assigned to:None = syntron ___ Follow-up Comment #4: update to current ruleset (svn 16977) (file #8664) ___ Additional Item Attachment: File name: 20100327-experimental.diff Size:236 KB ___ Reply to this item at: http://gna.org/patch/?1236 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1565] do not scale units with the tileset
URL: http://gna.org/patch/?1565 Summary: do not scale units with the tileset Project: Freeciv Submitted by: syntron Submitted on: Samstag 27.03.2010 um 12:07 Category: client-gtk-2.0 Priority: 3 - Low Status: None Privacy: Public Assigned to: syntron Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: with the variable city radii patch the city map in the city dialog is scaled, thus also the unit size is adapted. This is not needed ___ File Attachments: --- Date: Samstag 27.03.2010 um 12:07 Name: 0001-do-not-scale-units-with-the-tileset.diff Size: 2kB By: syntron http://gna.org/patch/download.php?file_id=8665 ___ Reply to this item at: http://gna.org/patch/?1565 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1234] more than one build slot for units
Update of patch #1234 (project freeciv): Status:None = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1234 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1552] Load script state last in loading savegame
Follow-up Comment #1, patch #1552 (project freeciv): Is it ok to check this in to 2.2 as a bug fix? ___ Reply to this item at: http://gna.org/patch/?1552 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1553] Fix tile lookup by index (id in the API)
Update of patch #1553 (project freeciv): Status:None = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1553 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15705] API: find.player() returns uninitalized players
URL: http://gna.org/bugs/?15705 Summary: API: find.player() returns uninitalized players Project: Freeciv Submitted by: englabenny Submitted on: lördag 2010-03-27 den 12:07 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: englabenny Originator Email: Open/Closed: Open Release: 2.2 Discussion Lock: Any Operating System: None Planned Release: 2.2.1, 2.3.0 ___ Details: find.player() always returns something for 0-31, but uninitialized players are problematic when used back in api functions (for example give_technology). ___ File Attachments: --- Date: lördag 2010-03-27 den 12:07 Name: 0002-API-Return-only-valid-players-for-find.player.patch Size: 956 B By: englabenny http://gna.org/bugs/download.php?file_id=8667 ___ Reply to this item at: http://gna.org/bugs/?15705 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15706] Scripting: Safer stack value handling
URL: http://gna.org/bugs/?15706 Summary: Scripting: Safer stack value handling Project: Freeciv Submitted by: englabenny Submitted on: lördag 2010-03-27 den 12:10 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: Ready For Test Assigned to: englabenny Originator Email: Open/Closed: Open Release: 2.2 Discussion Lock: Any Operating System: None Planned Release: 2.2.1, 2.3.0 ___ Details: In some places we take return values but we don't handle them. In callback invocations, we take only one return value, but clear everything on the stack.. Here is a cleanup patch to be a bit more stringent with the lua stack. ___ File Attachments: --- Date: lördag 2010-03-27 den 12:10 Name: 0003-Scripting-Cleanup-Lua-stack-handling.patch Size: 2 kB By: englabenny http://gna.org/bugs/download.php?file_id=8668 ___ Reply to this item at: http://gna.org/bugs/?15706 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15707] Scripting: Handle missing debug.traceback gracefully
URL: http://gna.org/bugs/?15707 Summary: Scripting: Handle missing debug.traceback gracefully Project: Freeciv Submitted by: englabenny Submitted on: lördag 2010-03-27 den 12:13 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: englabenny Originator Email: Open/Closed: Open Release: 2.2 Discussion Lock: Any Operating System: None Planned Release: 2.2.1, 2.3.0 ___ Details: the debug module is writable from ruleset scripts, so we should be tolerant. Right now, 'debug = nil' will cause a Lua Panic (server crash). ___ File Attachments: --- Date: lördag 2010-03-27 den 12:13 Name: 0004-Scripting-Handle-missing-debug.traceback-gracefully.patch Size: 2 kB By: englabenny http://gna.org/bugs/download.php?file_id=8669 ___ Reply to this item at: http://gna.org/bugs/?15707 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15707] Scripting: Handle missing debug.traceback gracefully
Update of bug #15707 (project freeciv): Status:None = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?15707 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15705] API: find.player() returns uninitalized players
Update of bug #15705 (project freeciv): Status:None = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?15705 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15644] Add server command to run freeciv script
Follow-up Comment #7, bug #15644 (project freeciv): Thanks for the comments. Here is an updated patch. ___ Reply to this item at: http://gna.org/bugs/?15644 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15644] Add server command to run freeciv script
Additional Item Attachment, bug #15644 (project freeciv): File name: 0001-Add-lua-server-command-to-evaluate-a-line-of-freeciv.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?15644 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15708] API: Fix typo in deprecated method
URL: http://gna.org/bugs/?15708 Summary: API: Fix typo in deprecated method Project: Freeciv Submitted by: englabenny Submitted on: lördag 2010-03-27 den 12:27 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: englabenny Originator Email: Open/Closed: Open Release: 2.3 Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: Typo, method calls use a colon in lua: self:method() ___ File Attachments: --- Date: lördag 2010-03-27 den 12:27 Name: 0001-API-Fix-typo-in-deprecated-method.patch Size: 768 B By: englabenny http://gna.org/bugs/download.php?file_id=8671 ___ Reply to this item at: http://gna.org/bugs/?15708 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1561] Make API objects' fields immutable
Update of patch #1561 (project freeciv): Status:None = Ready For Test Planned Release: = 2.3 ___ Reply to this item at: http://gna.org/patch/?1561 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15709] cleanup savegame generating
URL: http://gna.org/bugs/?15709 Summary: cleanup savegame generating Project: Freeciv Submitted by: syntron Submitted on: Samstag 27.03.2010 um 13:30 Category: None Severity: 2 - Minor Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Release: trunk (svn 16977) Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: the current code will create savenames as 'civgame-T0100-Y+001AD-auto.sav.bz2'. This patch cleans it up. The results are names like 'civgame-T0100-Y+0001-auto.sav.bz2'. * no year suffix (a sign for the years is used) * sign and 4 numbers for the positive and negative years ___ File Attachments: --- Date: Samstag 27.03.2010 um 13:30 Name: 20100327-trunk-fix-savegame-naming.diff Size: 2kB By: syntron http://gna.org/bugs/download.php?file_id=8672 ___ Reply to this item at: http://gna.org/bugs/?15709 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1562] API: Define convenience functionality for Types
Update of patch #1562 (project freeciv):
Planned Release: = 2.3.0
Summary: Scripting: Define the equality comparison for API
Types = API: Define convenience functionality for Types
___
Follow-up Comment #1:
Updated patch. Define equality comparison and string representation.
Define the == equality operator for all API datatypes, so you can
compare objects directly (instead of comparing the id field, which is
of course what the equality operation does).
Define a string representation, so that when printed, userdata types
output something like the following (instead of userdata: 0x0x1080ac48):
Government #2 Monarchy
Unit #114
Player #0 Agamemnon
City #137 Agadir
A single quote (') is removed in a comment, it disturbs syntax
highlighting if you want to view api.pkg in Lua syntax colors.
(file #8673)
___
Additional Item Attachment:
File name: 0001-API-Define-convenience-functionality-for-Types.patch Size:2
KB
___
Reply to this item at:
http://gna.org/patch/?1562
___
Meddelandet skickades via/av Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1230] save worked tiles from main map
Follow-up Comment #9, patch #1230 (project freeciv): An update of the network capabilities is needed (removal of type CITY_AMP definition) As you didn't change anything linked with network, only removing a unused type definition, this is really not needed. ___ Reply to this item at: http://gna.org/patch/?1230 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1552] Load script state last in loading savegame
Follow-up Comment #2, patch #1552 (project freeciv): Is it ok to check this in to 2.2 as a bug fix? Yes, this is a bug. ___ Reply to this item at: http://gna.org/patch/?1552 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1487] Merge client and server options GUI
Update of patch #1487 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1487 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15710] Lack of generality for specialists in city report / citizen governor display
URL: http://gna.org/bugs/?15710 Summary: Lack of generality for specialists in city report / citizen governor display Project: Freeciv Submitted by: jtn Submitted on: Saturday 03/27/10 at 13:37 Category: client Severity: 2 - Minor Priority: 5 - Normal Status: Ready For Test Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: While the number and type of specialists is nominally set by the ruleset, there are still a couple of places where the assumption that there are exactly three types, E/S/T, is hardcoded: * In the city report, there's a column E/S/T = Entertainers, Scientists, Taxmen (although the column actually displays the ruleset specialist types, and there are individual columns for the ruleset-defined specialist types). * In the citizen governor, there's a heading People (W/E/S/T): (again, the actual specialists are displayed even if different in number). The attached patch addresses this. Side-effects: * The explanation of the combined specialists column changes from Entertainers, Scientists, Taxmen to Specialists: elvis, scientist, taxman, which is a bit ugly. ** This could be fixed by defining a plural name in rulesets, and probably decoupling the rule name (elvis) from the display name (Entertainer). I haven't done this. * The initial position of the combined specialists column moves left. The issue applies to S2_1, S2_2, and trunk, but the patch touches strings hence only patched for trunk. ___ File Attachments: --- Date: Saturday 03/27/10 at 13:37 Name: trunk-specialist-generality.diff Size: 6kB By: jtn trunk r17166: generalise specialists in city report and citizen governor http://gna.org/bugs/download.php?file_id=8674 ___ Reply to this item at: http://gna.org/bugs/?15710 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15695] Script section truncated in savegame
Update of bug #15695 (project freeciv): Category:None = general Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.3.0 ___ Follow-up Comment #2: Fix attached. (file #8676) ___ Additional Item Attachment: File name: trunk_registry_escapes.diffSize:5 KB ___ Reply to this item at: http://gna.org/bugs/?15695 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15603] Tooltips for columns in city report
Update of bug #15603 (project freeciv): Status: Ready For Test = In Progress ___ Reply to this item at: http://gna.org/bugs/?15603 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15694] Aifill in Scenarios broken
Update of bug #15694 (project freeciv): Category:None = general Assigned to:None = pepeto ___ Reply to this item at: http://gna.org/bugs/?15694 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15694] Aifill in Scenarios broken
Update of bug #15694 (project freeciv): Planned Release: = 2.3.0 ___ Reply to this item at: http://gna.org/bugs/?15694 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15684] ownership of tiles not stable via save / load cycle
Follow-up Comment #3, bug #15684 (project freeciv): 2. load it (do not start the game!) Could you attach the diff just after starting it? ___ Reply to this item at: http://gna.org/bugs/?15684 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15603] Tooltips for columns in city report
Update of bug #15603 (project freeciv): Status: In Progress = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15603 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15643] unknown vote_no ignored
Update of bug #15643 (project freeciv): Category:None = general Status:None = Ready For Test Assigned to:None = pepeto Planned Release: = 2.2.1, 2.3.0 ___ Follow-up Comment #3: Still no answer, assuming my analysis was right, this is the fix. (file #8677, file #8678) ___ Additional Item Attachment: File name: trunk_handle_vote_submit.diff Size:0 KB File name: S2_2_handle_vote_submit.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?15643 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #14, bug #15377 (project freeciv): It is not a real big deal. It just mean having 2 sets of functions for ASCII and UTF-8 (maybe with different prefixes). Without big changes, it can be improved a lot. e.g., fc_snprintf() just need to cut the string after the last complete character if returning -1. We could look eagerly at GLib's support for Unicode/UTF-8 The Glib support could also be a solution. Such code is already in use in the gtk2 client. Out of curiosity, if I made a patch to switch freeciv's internal encoding (client, server, and network encoding) to UCS2/UCS4, would the change be supported by the current developers? I am not sure to know how this work, but if someone explain to me. ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15684] ownership of tiles not stable via save / load cycle
Follow-up Comment #4, bug #15684 (project freeciv): Could you attach the diff just after starting it? I think you mean the original savegame files. Both are attached. I do not have a savefile from the gamestart (turn 0) as this was a autogame running with 'saveturn 50'. But you can try your own game. I did observe similar differences in the savefiles for most of my tests. (file #8679, file #8680) ___ Additional Item Attachment: File name: civgame-T0050-Y-1500BC-auto.sav.bz2 Size:26 KB File name: civgame-T0050-Y-1500BC-manual.sav.bz2 Size:26 KB ___ Reply to this item at: http://gna.org/bugs/?15684 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15695] Script section truncated in savegame
Follow-up Comment #3, bug #15695 (project freeciv): Thanks, fix works when tested. It looks like insert_escapes will be much slower than the old version, looking at the unescaped character case: fz_fprintf(fp, %c, *str); instead of a *dest++ = *str++; This particular case with script.code does not go through insert_escapes (but all other values in a savefile do). I noticed a different change when comparing to 2.2, it is not from this patch: -code=$ +code = $ Savefiles now use spaces around = everywhere. I guess it was intentionally changed before. ___ Reply to this item at: http://gna.org/bugs/?15695 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15684] ownership of tiles not stable via save / load cycle
Follow-up Comment #5, bug #15684 (project freeciv): I meant a diff between 2 the auto save and a manual save after the game started again). ___ Reply to this item at: http://gna.org/bugs/?15684 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15695] Script section truncated in savegame
Additional Item Attachment, bug #15695 (project freeciv): File name: trunk_registry_escapes2.diff Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?15695 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15402] Make default leader names translateable
Update of bug #15402 (project freeciv): Status:None = Duplicate Assigned to:None = pepeto Open/Closed:Open = Closed Depends on: = bugs #14204 ___ Follow-up Comment #1: Duplicate of bug #14204. ___ Reply to this item at: http://gna.org/bugs/?15402 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14204] Enable ability to translate cities' and governors' names
Update of bug #14204 (project freeciv): Priority: 5 - Normal = 1 - Later ___ Follow-up Comment #1: See also #15402. ___ Reply to this item at: http://gna.org/bugs/?14204 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1349] Rework (+fix) auto-settler code
Follow-up Comment #3, patch #1349 (project freeciv): See also bug #14054. ___ Reply to this item at: http://gna.org/patch/?1349 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14054] Autosettler behaviour makes engineers move far too far and take too long
Follow-up Comment #1, bug #14054 (project freeciv): See also patch #1349. ___ Reply to this item at: http://gna.org/bugs/?14054 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15695] Script section truncated in savegame
Follow-up Comment #4, bug #15695 (project freeciv): Version 3. (file #8682) ___ Additional Item Attachment: File name: trunk_registry_escapes3.diff Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?15695 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13701] game_remove_unit(), homecity invalid
Update of bug #13701 (project freeciv): Status:None = Need Info ___ Reply to this item at: http://gna.org/bugs/?13701 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14082] civclient crashes or hangs when caravan/freight enters city
Update of bug #14082 (project freeciv): Status:None = Need Info ___ Follow-up Comment #1: Do you still get this problem? Do you have a savegame? ___ Reply to this item at: http://gna.org/bugs/?14082 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15695] Script section truncated in savegame
Additional Item Attachment, bug #15695 (project freeciv): File name: trunk_registry_escapes4.diff Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?15695 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14168] unable to create a new game
Update of bug #14168 (project freeciv): Status:None = Need Info ___ Reply to this item at: http://gna.org/bugs/?14168 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14549] Crash - unknown cause
Update of bug #14549 (project freeciv): Category:None = client-gtk-2.0 Status:None = Need Info ___ Reply to this item at: http://gna.org/bugs/?14549 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #15, bug #15377 (project freeciv): See also bug #14205. ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14212] game hangs when research dialog open and next turn button is pressed.
Update of bug #14212 (project freeciv): Status:None = Need Info ___ Reply to this item at: http://gna.org/bugs/?14212 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14702] Building a city with multiple settlers on single tile
Update of bug #14702 (project freeciv): Category: client-gtk-2.0 = client ___ Follow-up Comment #1: See also bug #14582. ___ Reply to this item at: http://gna.org/bugs/?14702 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14650] blank rectangle on screen
Update of bug #14650 (project freeciv): Status:None = Need Info ___ Follow-up Comment #1: Do you still get this problem? What is your version of GTK? ___ Reply to this item at: http://gna.org/bugs/?14650 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15684] ownership of tiles not stable via save / load cycle
Follow-up Comment #6, bug #15684 (project freeciv): I started a new game for this due to changes in the savegame format (variable city radii): 1. ./ser -r test.ser will save 'civgame-T0050-Y-1500BC-auto.sav.bz2' 2. ./ser -f civgame-T0050-Y-1500BC-auto.sav.bz2 save this file (civgame-T0050-Y-1500BC-manual.sav.bz2) 3. set timeout 0; save civgame-T0050-Y-1500BC-restart creates the third file Besides the first savefiles the script test.serv and the diffs are attached (file #8685, file #8686, file #8687, file #8688) ___ Additional Item Attachment: File name: test.serv Size:0 KB File name: civgame-T0050-Y-1500BC-auto.sav.bz2 Size:16 KB File name: civgame-auto-manual.diff Size:21 KB File name: civgame-auto-restart.diff Size:22 KB ___ Reply to this item at: http://gna.org/bugs/?15684 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15684] ownership of tiles not stable via save / load cycle
Follow-up Comment #7, bug #15684 (project freeciv): and the diff between the manual save and the save after the game was started again (restart). No changes besides the event cache and the timeout setting are found. So this seems to depend on the timing of the call to the autosave function? (file #8689) ___ Additional Item Attachment: File name: civgame-manual-restart.diffSize:0 KB ___ Reply to this item at: http://gna.org/bugs/?15684 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15695] Script section truncated in savegame
Follow-up Comment #5, bug #15695 (project freeciv): Improved comments. Thanks to englabenny for his comments. (file #8690) ___ Additional Item Attachment: File name: trunk_registry_escapes5.diff Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?15695 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14923] Wrong permission 0700 on /etc
Update of bug #14923 (project freeciv): Status:None = Need Info ___ Reply to this item at: http://gna.org/bugs/?14923 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15021] unable to resize the window to fit my screen
Update of bug #15021 (project freeciv): Status:None = Need Info ___ Reply to this item at: http://gna.org/bugs/?15021 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14205] Bug with utf-8
Update of bug #14205 (project freeciv): Category: general = client ___ Follow-up Comment #1: The problem seems to be truncation of an UTF-8 string, splitting it inside a multibyte sequence. ___ Reply to this item at: http://gna.org/bugs/?14205 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15714] Cient-side connect-with-rail doesn't take into account railroad length
URL:
http://gna.org/bugs/?15714
Summary: Cient-side connect-with-rail doesn't take into
account railroad length
Project: Freeciv
Submitted by: jtn
Submitted on: Saturday 03/27/10 at 17:41
Category: client
Severity: 2 - Minor
Priority: 5 - Normal
Status: Ready For Test
Assigned to: jtn
Originator Email:
Open/Closed: Open
Release: 2.1.11, 2.2.0
Discussion Lock: Any
Operating System: None
Planned Release: 2.1.12, 2.2.1
___
Details:
While reading the client-side goto code for railroad (in
client/goto.c:get_connect_road()) I found this:
if (total_cost *dest_cost
|| (total_cost == *dest_cost total_cost = *dest_cost)) {
There are clearly redundant terms; compare the clause just above. I think it
should be the obvious lexicographic comparison:
if (total_cost *dest_cost
|| (total_cost == *dest_cost total_extra = *dest_extra)) {
Looks like it's been this way since client-side connect was implemented in
2004 (RT #7282).
I think the effect is that for two candidate paths whose construction cost is
equal, the length of the resulting railroad is not taken into account as a
tie-breaker, contrary to the comments in the function which suggest that it
will be minimised. I think this is a pretty minor bug (if it manifests at
all) as the length of a railroad is usually not interesting; I haven't been
able to contrive a case where it makes a difference.
It also means that the return of the function is not consistent with the
comparison within the function (as the return takes into account
total_extra), but looking at the path-finding code I don't think that'll
break anything.
___
File Attachments:
---
Date: Saturday 03/27/10 at 17:41 Name:
S2_1-S2_2-trunk-connect-railroad-calc.diff Size: 447B By: jtn
S2_1/S2_2/trunk r17172: connect-with-rail takes into account length of
railroad
http://gna.org/bugs/download.php?file_id=8694
___
Reply to this item at:
http://gna.org/bugs/?15714
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15714] Client-side connect-with-rail doesn't take into account railroad length
Update of bug #15714 (project freeciv): Summary: Cient-side connect-with-rail doesn't take into account railroad length = Client-side connect-with-rail doesn't take into account railroad length ___ Reply to this item at: http://gna.org/bugs/?15714 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15377] freeciv-gtk2.exe hangs
Follow-up Comment #16, bug #15377 (project freeciv): Having 2 sets of functions is trickier than it sounds. For one, you have to be extremely careful which you use where. For a second, neither one should really be using the libc character functions. And for a third, the functions we're talking about _cant_ be written for variable-width character sets like utf-8 so they all have to be replaced with string variants. I took a look at doing this but it's just way too many places and too wide a spectrum of the codebase affected to do so without upping the bug rate. Glib or libutf8 can provide some help on some of these functions, I do believe. We dont have glib as a requirement for server compilation however, though it wouldnt be a big deal to add it. To change the internal encoding to ucs4 I would introduce a new typedef, typedef uint32 fc_char into fciconv.h. The majority of internal strings then get changed from char[] to fc_char[]. String conversion is mostly done already via the fciconv or gettext functions, but what would have to be added is conversion of all data files read (from utf8/ascii into ucs4) and to all gui strings (again between ucs4 and utf8, both ways and in a lot of places). Perhaps the biggest challenge though would be server-generated strings, which can't use sprintf but instead will need a ucs4 version of the same (probably available through an external library). -jason ___ Reply to this item at: http://gna.org/bugs/?15377 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14205] Bug with utf-8
Follow-up Comment #2, bug #14205 (project freeciv): How can I reproduce this? ___ Reply to this item at: http://gna.org/bugs/?14205 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14205] Bug with utf-8
Follow-up Comment #3, bug #14205 (project freeciv): Pepeto pointed this out in the code for me. You need a long Ai name in UTF-8 (like Easy, Hard, Cheating). Here's a diff where we replace that by a string of just €-signs, and it breaks the same way. IMO the truncation is the bug, that it with misfortune makes UTF-8 strings ugly is just an effect. (file #8698) ___ Additional Item Attachment: File name: truncated_user_name.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?14205 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14205] Bug with utf-8
Follow-up Comment #4, bug #14205 (project freeciv): Ah, well that's simple. It's a simple bug in update_conn_dialog that doesn't check the width of the AI name, probably a remnant from before when they were given artificial player names. Attached patch will fix this. It is likely to occur in many other places as long as we try to snprintf translated strings into fixed-width buffers; g_strdup_printf is the easy alternative for use in the gtk2 client. However it's also the case that the translation should probably be made shorter (in characters, not bytes) so that it doesn't make the dialog expand to fit it; the updated TRANS comment reflects this. -jason (file #8699) ___ Additional Item Attachment: File name: ai_name.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?14205 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
URL: http://gna.org/bugs/?15721 Summary: S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented. Project: Freeciv Submitted by: jtn Submitted on: Sunday 03/28/10 at 02:42 Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.1.11 Discussion Lock: Any Operating System: None Planned Release: ___ Details: Just tried using Engineers to connect two locations with road, rail, and irrigation on the head of S2_1 (r17172) and got the message: 1: jumbo callbacks for danger maps are not yet implemented. The resulting goto paths looked wrong (diagonal moves for irrigation) and the turns-to-completion too short (which is what I'd expect from that message -- in this case it'll completely ignore the special get_connect_road()/irrig() path-finding routines). Same issue applies to 2.1.11 (haven't checked earlier versions). Doesn't happen with S2_2. ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15722] Client-side goto turn estimation inaccurate with waypoints
URL: http://gna.org/bugs/?15722 Summary: Client-side goto turn estimation inaccurate with waypoints Project: Freeciv Submitted by: jtn Submitted on: Sunday 03/28/10 at 02:51 Category: client Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: The client-side goto code shows a couple of issues with turn estimation when setting waypoints: * Long-standing (since 2.1 at least): when connecting (e.g., with road), I've noticed that if I set waypoints along the route it would take anyway, the number of turns displayed is different. * Recent (regression on S2_2 since 2.2.0, also on S2_1, haven't traced its arrival): ordinary [G]oto now adds a spurious turn every time you set a waypoint if you're travelling along a railroad. I've been noodling with this today and found a couple of contributory causes: * Silly mistake: connect was adding the connect_initial cost for every part (waypoint) when it should only add it for the first. * More seriously, the parts in the goto code deal in number of turns, which means that fractional movement points cannot be carried from one part to the next (as they are in the path-finding code), so adding waypoints introduced rounding errors. (These explain the connect error at least. I never tracked down where the recent goto error was coming from, precisely.) The attached patch: * Changes the goto code's length calculations to be in terms of movement points (scaled by SINGLE_MOVE) rather than turns, allowing fractional MP to be carried between parts; the whole route is then converted into turns for display. * Also works scaled by ACTIVITY_FACTOR; this should give correct results for units with fractional get_activity_rate() (possible with veteran settlers, although I've not tested this). I think this mostly affects just the reported turns and not the computed route (except in the fractional get_activity_rate() case). I've tested it with a variety of cases (engineers connecting, soldiers moving, and planes moving) and I think I've solved the problems I noted above and haven't obviously broken anything. However, the code could stand further review and test. (Testing with S2_1 limited due to bug #15721.) (I think this could equally be done by changing the path-finding code so that it doesn't discount the initial movement points, and possibly takes an optional initial cost as input so it can accumulate cost; this would simplify the goto code since the PF code is already doing a lot of the same work. However, that's a rather more invasive change and I haven't checked what knock-on effects it might have.) ___ File Attachments: --- Date: Sunday 03/28/10 at 02:51 Name: S2_1-waypoint-accuracy.diff Size: 6kB By: jtn S2_1/S2_2/trunk r17172: rework turn calculation in client-side goto http://gna.org/bugs/download.php?file_id=8700 --- Date: Sunday 03/28/10 at 02:51 Name: S2_2-waypoint-accuracy.diff Size: 6kB By: jtn S2_1/S2_2/trunk r17172: rework turn calculation in client-side goto http://gna.org/bugs/download.php?file_id=8701 --- Date: Sunday 03/28/10 at 02:51 Name: trunk-waypoint-accuracy.diff Size: 6kB By: jtn S2_1/S2_2/trunk r17172: rework turn calculation in client-side goto http://gna.org/bugs/download.php?file_id=8702 ___ Reply to this item at: http://gna.org/bugs/?15722 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15723] Server help options response mangled
URL: http://gna.org/bugs/?15723 Summary: Server help options response mangled Project: Freeciv Submitted by: jtn Submitted on: Sunday 03/28/10 at 03:01 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: jtn Originator Email: Open/Closed: Open Release: 2.2.0 Discussion Lock: Any Operating System: None Planned Release: 2.2.1 ___ Details: On S2_2 and trunk. Outputs a single long unwrapped truncated line, rather than 4 options per line. ___ File Attachments: --- Date: Sunday 03/28/10 at 03:01 Name: S2_2-trunk-server-help-options.diff Size: 507B By: jtn S2_2/trunk r17172: fix server quot;help optionsquot; output http://gna.org/bugs/download.php?file_id=8703 ___ Reply to this item at: http://gna.org/bugs/?15723 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15721] S2_1 connect (road, irrigation etc) broken: jumbo callbacks for danger maps are not yet implemented.
Follow-up Comment #1, bug #15721 (project freeciv): I wonder if it's trying to use a danger map because of base_unsafe_terrain_loss_pct() (in pft_fill_unit_parameter()). That would explain why it doesn't apply to S2_2. Not proven though. ___ Reply to this item at: http://gna.org/bugs/?15721 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
