[Freeciv-Dev] [bug #17647] adv_data_get() called after adv_data_phase_done()

[Marko Lindqvist]

Update of bug #17647 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17665] Missing README.ruleset_* in 2.3.0 beta3

[Angelo Locritani]

URL:
  

 Summary: Missing README.ruleset_* in 2.3.0 beta3
 Project: Freeciv
Submitted by: alocritani
Submitted on: lun 07 feb 2011 12:01:08 GMT
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.3.0 beta3
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Missing README.ruleset_experimental and README.ruleset_multiplayer in 2.3.0
beta3's tarball




___

Reply to this item at:

  

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2374] Move default ai diplomacy data from adv_data to ai data

[Marko Lindqvist]

Follow-up Comment #2, patch #2374 (project freeciv):

- Updated against current svn

This patch has passed autogame testing

(file #12311)
___

Additional Item Attachment:

File name: AiDiplData_2374-3.diff.bz2 Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2377] Mitanni nation

[J.M. Maalderink]

Update of patch #2377 (project freeciv):

  Status:None => In Progress
 Assigned to:None => mixcoatl   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2401] Werewolf nation

[J.M. Maalderink]

Update of patch #2401 (project freeciv):

  Status:None => In Progress

___

Follow-up Comment #1:

Added a couple of wolf-related locations

(file #12312)
___

Additional Item Attachment:

File name: werewolf.ruleset   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2403] Scanian nation

[J.M. Maalderink]

Update of patch #2403 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2428] Sabinian nation

[J.M. Maalderink]

Update of patch #2428 (project freeciv):

  Status:None => In Progress
 Assigned to:None => mixcoatl   

___

Follow-up Comment #1:

I made some edits, most notably changing the nation's name to Sabine.

Would it be possible to add some more cities?

In any case, I definitely like the idea of having more ancient Italic
nations!

(file #12313)
___

Additional Item Attachment:

File name: sabine.ruleset Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2428] Sabinian nation

[J.M. Maalderink]

Follow-up Comment #2, patch #2428 (project freeciv):

Oh, and we still need a flag.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2432] Swedish Leader Update

[J.M. Maalderink]

Update of patch #2432 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2438] Alternative Thracian flag

[J.M. Maalderink]

Update of patch #2438 (project freeciv):

  Status:None => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2492] New Iraqi flag

[J.M. Maalderink]

URL:
  

 Summary: New Iraqi flag
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Mon 07 Feb 2011 02:32:04 PM GMT
Category: art
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: mixcoatl
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Iraqi flag has changed a couple of years ago, but the game still includes
the old one.

PD. By Militaryace and Hoshie, Wikimedia Commons:
http://commons.wikimedia.org/wiki/File:Flag_of_Iraq.svg



___

File Attachments:


---
Date: Mon 07 Feb 2011 02:32:04 PM GMT  Name: iraq.svg  Size: 5kB   By:
mixcoatl



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2485] Karen nation

[J.M. Maalderink]

Update of patch #2485 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2486] Alternative Mon flag

[J.M. Maalderink]

Update of patch #2486 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2490] Jaffna nation

[J.M. Maalderink]

Update of patch #2490 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2327] Sinhalese nation

[J.M. Maalderink]

Update of patch #2327 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2353] Vistulan nation

[J.M. Maalderink]

Update of patch #2353 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2371] Zambian nation

[J.M. Maalderink]

Update of patch #2371 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2356] Abyssinian nation

[J.M. Maalderink]

Update of patch #2356 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2400] Pictish nation

[J.M. Maalderink]

Update of patch #2400 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2372] Chadian nation

[J.M. Maalderink]

Update of patch #2372 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2377] Mitanni nation

[J.M. Maalderink]

Update of patch #2377 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2389] AI player data saving and loading through AI interface

[Marko Lindqvist]

Follow-up Comment #1, patch #2389 (project freeciv):

- Updated against current svn

(file #12315)
___

Additional Item Attachment:

File name: AIIPlayerSave_2389-2.diff  Size:12 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17665] Missing README.ruleset_* in 2.3.0 beta3

[Marko Lindqvist]

Update of bug #17665 (project freeciv):

Category: general => docs   
  Status:None => Ready For Test 
 Planned Release: => 2.3.0, 2.4.0   

___

Follow-up Comment #1:

Untested fix attached

(file #12316)
___

Additional Item Attachment:

File name: DistRMrs_17665.diffSize:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2412] Support to write reply to file to netfile_send_post()

[Marko Lindqvist]

Follow-up Comment #1, patch #2412 (project freeciv):

- Updated against current svn

(file #12317)
___

Additional Item Attachment:

File name: CurlPostReply_2412-2.diff  Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2417] Stub of threaded ai module

[Marko Lindqvist]

Follow-up Comment #1, patch #2417 (project freeciv):

- Updated against current svn

(file #12318)
___

Additional Item Attachment:

File name: ThreadedAi_2417-2.diff Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2453] player_capital()

[Marko Lindqvist]

Update of patch #2453 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2484] Choose irrigation sprite ver 2

[Marko Lindqvist]

Follow-up Comment #1, patch #2484 (project freeciv):

> +  tm = find_terrain_by_rule_name("plains");

You cannot assume that all rulesets have terrain named "plains". In fact, my
aliens ruleset does not.



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17413] build fails if default python version is python3

[Vijay Kiran Kamuju]

Update of bug #17413 (project freeciv):

  Status:None => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17667] ferry_map allocated by find_something_to_kill() sometimes not freed

[Marko Lindqvist]

URL:
  

 Summary: ferry_map allocated by find_something_to_kill()
sometimes not freed
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 07 Feb 2011 10:03:36 PM EET
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: cazfi
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

Biggest leak found in S2_3 server valgrind run was:

==7824== 37,488,128 (154,752 direct, 37,333,376 indirect) bytes in 744 blocks
are definitely lost in loss record 1,190 of 1,190
==7824==at 0x4C244E8: malloc (vg_replace_malloc.c:236)
==7824==by 0x584181: fc_real_malloc (mem.c:83)
==7824==by 0x5977B0: pf_map_new (path_finding.c:774)
==7824==by 0x4B04EF: find_something_to_kill (aiunit.c:1281)
==7824==by 0x435CE7: kill_something_with (advmilitary.c:)
==7824==by 0x43671B: military_advisor_choose_build (advmilitary.c:1473)
==7824==by 0x4B7883: ai_manage_cities (aicity.c:674)
==7824==by 0x4BE0D2: ai_do_last_activities (aihand.c:508)
==7824==by 0x4072E4: end_phase (srv_main.c:994)
==7824==by 0x40C704: srv_main (srv_main.c:2166)
==7824==by 0x403F36: main (civserver.c:375)





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17667] ferry_map allocated by find_something_to_kill() sometimes not freed

[Marko Lindqvist]

Update of bug #17667 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Fix

(file #12319)
___

Additional Item Attachment:

File name: MacbMemFree_17667.diff Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17665] Missing README.ruleset_* in 2.3.0 beta3

[Jacob Nevins]

Update of bug #17665 (project freeciv):

 Assigned to:None => jtn

___

Follow-up Comment #2:

Oops, mea culpa, to some extent.
Attached patch works for me (on trunk and S2_3), in that the tarball we end
up with after "make dist" now has those two files in it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17669] assert(adv->phase_is_initialized) fails on savegame load

[Marko Lindqvist]

URL:
  

 Summary: assert(adv->phase_is_initialized) fails on savegame
load
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 08 Feb 2011 12:18:35 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0, 2.4.0

___

Details:

$subject fixed by removing completely useless adv_data_get() call. It only
caused data phase to get initialized using other uninitialized data and then
blocked data from being recalculated with correct data.

Only TRUNK version of the patch at the moment. S2_3 version will follow.



___

File Attachments:


---
Date: Tue 08 Feb 2011 12:18:35 AM EET  Name: SaveLoadGADRm.diff  Size: 600B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17669] assert(adv->phase_is_initialized) fails on savegame load

[Marko Lindqvist]

Update of bug #17669 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

S2_3 version

(file #12321)
___

Additional Item Attachment:

File name: SaveLoadGADRm-S2_3_17669.diff  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2450] Effect "Irrig_Possible"

[Marko Lindqvist]

Update of patch #2450 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2493] Function headers to files in client/ main

[Marko Lindqvist]

URL:
  

 Summary: Function headers to files in client/ main
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 08 Feb 2011 01:18:07 AM EET
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

This patch adds all missing function headers to client/ main directory files.
Also some other comment cleanup.



___

File Attachments:


---
Date: Tue 08 Feb 2011 01:18:07 AM EET  Name: FuncHdrsClient.diff.bz2  Size:
7kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2427] [metaticket] Add missing function headers

[Marko Lindqvist]

Update of patch #2427 (project freeciv):

  Depends on: => patch #2493


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2451] Function headers to files in server/ main

[Marko Lindqvist]

Update of patch #2451 (project freeciv):

  Dependency Removed: => patch #2427


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2427] [metaticket] Add missing function headers

[Marko Lindqvist]

Update of patch #2427 (project freeciv):

  Depends on: => patch #2451


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2451] Function headers to files in server/ main

[Marko Lindqvist]

Follow-up Comment #1, patch #2451 (project freeciv):

- Updated against current svn

(file #12323)
___

Additional Item Attachment:

File name: FuncHdrsServer_2451-2.diff.bz2 Size:10 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2494] Kuna nation

[J.M. Maalderink]

URL:
  

 Summary: Kuna nation
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Mon 07 Feb 2011 11:58:41 PM GMT
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: mixcoatl
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Kuna, indigenous people in Panama and Colombia
flag by myself

I don't know if the swastika might cause problems, but as in this case it's
clearly not a Nazi symbol I guess it isn't.



___

File Attachments:


---
Date: Mon 07 Feb 2011 11:58:41 PM GMT  Name: kuna.ruleset  Size: 2kB   By:
mixcoatl


---
Date: Mon 07 Feb 2011 11:58:41 PM GMT  Name: kuna_yala.svg  Size: 801B   By:
mixcoatl



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2495] Thuringians

[J.M. Maalderink]

URL:
  

 Summary: Thuringians
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Tue 08 Feb 2011 12:04:12 AM GMT
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: mixcoatl
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Thuringia. Basically a container nation for the hotchpotch of Thuringian
statelets. Unless somebody wants to make Anhaltians and Braunschweigians,
Germany is pretty much complete by now.

Flag based on official logo for Thuringia, PD by David Liuzzo on Wikicommons:
http://de.wikipedia.org/w/index.php?title=Datei:Th%C3%BCringen_Signet.svg&filetimestamp=20061223024256



___

File Attachments:


---
Date: Tue 08 Feb 2011 12:04:12 AM GMT  Name: thuringian.ruleset  Size: 3kB  
By: mixcoatl


---
Date: Tue 08 Feb 2011 12:04:12 AM GMT  Name: thuringia.svg  Size: 16kB   By:
mixcoatl



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2495] Thuringian nation

[J.M. Maalderink]

Update of patch #2495 (project freeciv):

 Summary: Thuringians => Thuringian nation  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17670] Data phase not initialized for unleashed barbarians

[Marko Lindqvist]

URL:
  

 Summary: Data phase not initialized for unleashed barbarians
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 08 Feb 2011 02:35:35 AM EET
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0, 2.4.0

___

Details:

Data phase handling has been set up correctly for barbarians summoned between
turns, but there is also another kind of barbarians; those who unleash from
hut middle of the turn. Their data phase is not initialized on turn they
appear.
Fix attached.



___

File Attachments:


---
Date: Tue 08 Feb 2011 02:35:35 AM EET  Name: UnleashedDataPhase.diff  Size:
467B   By: cazfi


---
Date: Tue 08 Feb 2011 02:35:35 AM EET  Name: UnleashedDataPhase-S2_3.diff 
Size: 402B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2496] Ai is not afraid of sea attack from irrigation

[Marko Lindqvist]

URL:
  

 Summary: Ai is not afraid of sea attack from irrigation
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 08 Feb 2011 02:55:42 AM EET
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0, 2.4.0

___

Details:

Currently AI prepares against attack where ferries bring land units over any
wet tile. Wet tiles include rivers and irrigated tiles. Attached patch fixes
this so that only oceanic tiles are considered.



___

File Attachments:


---
Date: Tue 08 Feb 2011 02:55:42 AM EET  Name: ExpectNoInvasionFromIrrig.diff 
Size: 770B   By: cazfi


---
Date: Tue 08 Feb 2011 02:55:42 AM EET  Name:
ExpectNoInvasionFromIrrig-S2_3.diff  Size: 623B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2495] Thuringian nation

[Daniel Markstedt]

Follow-up Comment #1, patch #2495 (project freeciv):

Shouldn't the singular nation name be "Thuringian"?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2455] Qt-client: Copying menu item

[Marko Lindqvist]

Follow-up Comment #1, patch #2455 (project freeciv):

Updated patch so it doesn't depend on any other patch. This can be committed
as next Qt-client patch.

(file #12334)
___

Additional Item Attachment:

File name: QtCopying_2455-2.diff  Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2455] Qt-client: Copying menu item

[Marko Lindqvist]

Update of patch #2455 (project freeciv):

  Dependency Removed: => patch #2454


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2496] Ai is not afraid of sea attack from irrigation

[Jacob Nevins]

Follow-up Comment #1, patch #2496 (project freeciv):

(Without having looked at the code) In rulesets with riverboats (e.g.,
Triremes in experimental ruleset), shouldn't the AI fear attacks from rivers
at least?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2496] AI should not fear sea attack from irrigation

[Jacob Nevins]

Update of patch #2496 (project freeciv):

 Summary: Ai is not afraid of sea attack from irrigation =>
AI should not fear sea attack from irrigation


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17672] "/set rare X", "/set situational X" etc crash server

[Jacob Nevins]

URL:
  

 Summary: "/set rare X", "/set situational X" etc crash
server
 Project: Freeciv
Submitted by: jtn
Submitted on: Tue Feb  8 01:27:59 2011
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.2.4,2.3.0-beta3
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Noticed while reading code:

server/stdinhand.c:set_command() calls lookup_option().

lookup_option() checks the names of option groups before checking individual
option names, and if it finds a match, returns the magic number -3.

Unfortunately, the caller (set_command()) doesn't check for -3 (only -1 and
-2). On S2_2 this causes an assertion failure in setting_by_number(). On
S2_3/trunk, the assertion has been removed, so the server segfaults a bit
later on. (I think S2_1 also does the wrong thing.)

Additionally, on S2_3/trunk only, lookup_option() checks for the specific
string 'rulesetdir', and returns -4 (again unhandled) if it finds it, so "/set
rulesetdir X" kills the server too.

I think these special behaviours in lookup_option() are primarily for the use
of '/show', and their bad effects on '/set' are a side effect.

These crashes can be provoked by anyone with 'basic' or higher access to the
server.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2496] AI should not fear sea attack from irrigation

[Marko Lindqvist]

Follow-up Comment #2, patch #2496 (project freeciv):

> In rulesets with riverboats (e.g., Triremes in experimental
> ruleset), shouldn't the AI fear attacks from rivers at least?

In theory, yes. But to implement all the required checks for that (ruleset
analyzing code, checks for current situation when game actually runs) would
require quite a lot of work.
So, we have choice of either being afraid of rivers with any ruleset (and
when ever enemy has any kind of ferries) or never being afraid of them. As
latter would provide better result only in rare situations, I choose former.
Note that custom ruleset could in fact have amphibious or air transports, so
there should be no limit to certain terrains at all.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2496] AI should not fear sea attack from irrigation

[Jacob Nevins]

Follow-up Comment #3, patch #2496 (project freeciv):

Fair enough...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17673] Bitwise server option syntax not documented

[Jacob Nevins]

URL:
  

 Summary: Bitwise server option syntax not documented
 Project: Freeciv
Submitted by: jtn
Submitted on: Tue Feb  8 02:07:50 2011
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.3.0-beta3
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0,2.4.0

___

Details:

The new concept of a set ("bitwise") server option added in patch #1955
requires new syntax at the server prompt ("/set topology wrapx|iso"), but
there's no reliable way for a server prompt user unfamiliar with the syntax to
discover/remember it (so they might be guessing plus, comma, etc as the
delimiter). The attached patch tries to address this (1 new string, 1
changed).




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17673] Bitwise server option syntax not documented

[Jacob Nevins]

Follow-up Comment #1, bug #17673 (project freeciv):

(Sorry, that's 2 new strings, 0 changed.)

(file #12335)
___

Additional Item Attachment:

File name: trunk-S2_3-server-bitwise-opt-doc.diff Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17658] Translate msgid "freeciv 2.3.0"

[Jacob Nevins]

Follow-up Comment #1, bug #17658 (project freeciv):

This is one of the values for the server setting "saveversion", setting the
savefile format to be used. It looks like most translators will want to keep
the string as-is.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2402] Retry map generation with different seed if one fails

[Marko Lindqvist]

Update of patch #2402 (project freeciv):

 Planned Release:2.3.0, 2.4.0 => 2.4.0  

___

Follow-up Comment #5:

After long consideration I'm dropping 2.3 target. Were we certain that there
would be another beta round, I could commit this to S2_3, but this is too high
risk patch to go to actual release without being tested in beta.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17658] Translate msgid "freeciv 2.3.0"

[Marko Lindqvist]

Follow-up Comment #2, bug #17658 (project freeciv):

Without looking the code I wonder if this should be translatable at all. Does
the setting really work if string is translated, or does it depend of it being
exactly "freeciv 2.3.0"?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17658] Translate msgid "freeciv 2.3.0"

[Marko Lindqvist]

Follow-up Comment #3, bug #17658 (project freeciv):

And why there is three parts in number? Any 2.3.a is supposed to be
compatible with any 2.3.b, so last zero is at least misleading (you have to
use 2.3.*0* format to save for 2.3.*7*)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17658] Translate msgid "freeciv 2.3.0"

[Jacob Nevins]

Follow-up Comment #4, bug #17658 (project freeciv):

> Without looking the code I wonder if this should be 
> translatable at all. Does the setting really work if 
> string is translated, or does it depend of it being 
> exactly "freeciv 2.3.0"?
"freeciv 2.3.0" is the 'pretty' name of the value, and is not entered by
users or saved anywhere. The corresponding 'machine'/'rule' name (which must
not be translated or ever change) is "2.3.0".

This pretty/rule name pattern is common to all enumerated/bitwise options.
While we could avoid this string appearing in .po files by removing the N_()
markup, the pretty name will still be passed through _() anyway (and there's
not a lot we can do about that), so it's more honest to keep the N_() markup.
We can of course add a TRANS comment that tells translators not to worry about
it.

> Any 2.3.a is supposed to be compatible with any 2.3.b, 
> so last zero is at least misleading (you have to use 
> 2.3.0 format to save for 2.3.7)
Well. From looking at the new save format stuff, I think part of the intended
point of it is to make future new servers able to save "old"-format games
(compatible with "old" servers back to 2.3.0, but not before). Given that,
this allows us to be more relaxed about savefile format changes; we could, if
we _really_ wanted to, make some change to the savefile format within the
2.3.x cycle, while still allowing server operators the choice to make
backward-compatible savefiles. It looks like a range of versions have been
reserved for this purpose. (I'm not sure what would drive us to this in a
stable release series; perhaps an undiscovered design flaw requiring a format
change.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2497] Scenario downloading support for freeciv-modpack

[Marko Lindqvist]

URL:
  

 Summary: Scenario downloading support for freeciv-modpack
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 08 Feb 2011 05:11:42 AM EET
Category: module installer
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

No patch yet, just proposal. Won't write patches if my plan is not accepted.

As we now have separate FREECIV_DATA_DIR and FREECIV_SCENARIO_DIR, original
freeciv-modpack design of downloading all files to same directory (and its
subdirs) does not work. Currently freeciv-modpack cannot be used for
scenarios. This will never be fixed in S2_3 as datafile format freeze makes it
impossible.
Datafiles, such as rulesets and tilesets, in FREECIV_DATA_DIR are usually
compatible with just one version of freeciv. This is why version specific
subdir is used ( ~/.freeciv// ). Scenario files (.sav) on the other
hand should be compatible with almost any Freeciv version.
So, you should need to download scenario files only once ever and all Freeciv
versions would use that same file. Data files you have to download separately
for each Freeciv version.

First of all I would add basic scenario downloading support to
freeciv-modpack. This would consist of adding new modpack_type "Scenario" and
downloading files of such packages to ~/.freeciv/scenario instead of
~/.freeciv/.

Then we come to more complicated situation. What about more complex scenarios
that use their own ruleset instead of default (or some other ruleset shipped
with freeciv)? At this point we can assume that both rulesets and .sav file
are in same package. There would be .sav that is basically compatible with any
Freeciv version, but it uses datafiles that are specific to one Freeciv
version.
I think such scenarios should be techically handled as modpacks.
freeciv-modpack would download all their files under version specific subdir.
Package should take care that .sav file gets installed to subdir "scenario"
there ( ~/.freeciv//scenario ). Only change to freeciv codebase we
would do to support such modpacks is adding version specific subdir to default
FREECIV_SCENARIO_PATH, probably so that version specific directory comes
before common scenario directory.

In more distant future we can add modpack dependency handling to
freeciv-modpack (scenario depends on ruleset depends on tileset, all get
automatically installed)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev