[Freeciv-Dev] [patch #2683] City worth from def ai city data to advisors city data
Update of patch #2683 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2683 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16471] Info displayed on Happiness tab
Follow-up Comment #10, bug #16471 (project freeciv): My patch has been committed, but syntron's linebreak patch is not. I haven't checked it, but does it insert linebreak at exactly 80 characters even if that's in the middle of a word? ___ Reply to this item at: http://gna.org/bugs/?16471 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2688] Insert linebreaks to long happiness effect provider lists in happiness tab
URL: http://gna.org/patch/?2688 Summary: Insert linebreaks to long happiness effect provider lists in happiness tab Project: Freeciv Submitted by: cazfi Submitted on: Mon 06 Jun 2011 12:47:28 PM EEST Category: client Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: There is patch attached to bug #16471 Let's continue handling it in this separate ticket. ___ Reply to this item at: http://gna.org/patch/?2688 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16471] Info displayed on Happiness tab
Update of bug #16471 (project freeciv): Status:None = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #11: Linebreak patch now handled in patch #2688, closing this one. ___ Reply to this item at: http://gna.org/bugs/?16471 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2431] Update and typo fix for doc/README.effects
Update of patch #2431 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2431 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2572] Use GtkFileChooserDialog instead of deprecated GtkFileSelection
Update of patch #2572 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2572 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2609] Polish localization for S2_3
Additional Item Attachment, patch #2609 (project freeciv): File name: pl.po.zip Size:444 KB ___ Reply to this item at: http://gna.org/patch/?2609 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2689] Enable building gui-gtk-3-0 code as gtk2-program
URL: http://gna.org/patch/?2689 Summary: Enable building gui-gtk-3-0 code as gtk2-program Project: Freeciv Submitted by: cazfi Submitted on: Mon 06 Jun 2011 01:42:31 PM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: As said in task #7334 next step in gtk3-client development is to replace all uses of gtk features deprecated before 2.24.x with modern ones. That is, so called gtk3-client would still be gtk2-program but with as gtk3 compatible codebase as possible. For that step we need means to build gtk3-client as gtk2-program. This patch adds such a hack. If one requests both gtk2- and gtk3-clients to be compiled, they will be configured same way (gtk3-client configuration copied from gtk2-client configuration). You cannot enable gtk3-client without enabling gtk2-client. I have not mentioned gtk3-client in any documentation (including configures client lists) on purpose. Mention of gtk3-client would only confuse people who don't know that it's still in development as gtk2-program. ___ File Attachments: --- Date: Mon 06 Jun 2011 01:42:31 PM EEST Name: Gtk3ConfHack.diff Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=13110 ___ Reply to this item at: http://gna.org/patch/?2689 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7334] Make copy of gtk2-client as base for gtk3-client development
Update of task #7334 (project freeciv): Status:None = Done Percent Complete: 0% = 100% Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/task/?7334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2690] Move city building_turn from default ai to advisors data
URL: http://gna.org/patch/?2690 Summary: Move city building_turn from default ai to advisors data Project: Freeciv Submitted by: cazfi Submitted on: Mon 06 Jun 2011 02:25:14 PM EEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: ___ File Attachments: --- Date: Mon 06 Jun 2011 02:25:14 PM EEST Name: AdvBuildTurn.diff Size: 9kB By: cazfi http://gna.org/patch/download.php?file_id=13111 ___ Reply to this item at: http://gna.org/patch/?2690 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2690] Move city building_turn from default ai to advisors data
Follow-up Comment #1, patch #2690 (project freeciv): More critical checking of usages of building_want and friends show that this patch went completely wrong direction. Advisors should not rely that data at all, all the related code should be moved to default ai instead. ___ Reply to this item at: http://gna.org/patch/?2690 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2690] Move city building_turn from default ai to advisors data
Update of patch #2690 (project freeciv): Status: Ready For Test = None ___ Reply to this item at: http://gna.org/patch/?2690 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2690] Move default ai specific building selection code from building advisor to def ai
Update of patch #2690 (project freeciv): Status:None = Ready For Test Summary: Move city building_turn from default ai to advisors data = Move default ai specific building selection code from building advisor to def ai ___ Follow-up Comment #2: This patch is huge step to right direction now that I found out how human advisor doesn't really use that complicated building selection code at all. A bit frustratingly this reverts a number of previous patches which, while improving situation a bit at their time, were fundamentally going to wrong direction. I wish I had seen this coming earlier so I could have avoided work that went to those patches. (file #13112) ___ Additional Item Attachment: File name: DefAiBuildWant.diff.bz2Size:14 KB ___ Reply to this item at: http://gna.org/patch/?2690 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2691] consider_wonder_city-callback to AI interface
URL: http://gna.org/patch/?2691 Summary: consider_wonder_city-callback to AI interface Project: Freeciv Submitted by: cazfi Submitted on: Mon 06 Jun 2011 04:34:01 PM EEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: This patch adds consider_wonder_city-callback to AI interface. It's used instead of directly accessing default ai specific data from advisors code. ___ File Attachments: --- Date: Mon 06 Jun 2011 04:34:01 PM EEST Name: ConsiderWonderCity.diff Size: 3kB By: cazfi http://gna.org/patch/download.php?file_id=13113 ___ Reply to this item at: http://gna.org/patch/?2691 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2692] build_advisor_prepare-callback to AI interface
URL: http://gna.org/patch/?2692 Summary: build_advisor_prepare-callback to AI interface Project: Freeciv Submitted by: cazfi Submitted on: Mon 06 Jun 2011 05:20:05 PM EEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: This patch adds new build_advisor_prepare-callback to AI interface. It's used in advisors code instead of directly accessing default ai specific distance_to_wonder_city. This is last patch required to make common server code not to depend on default ai. ___ File Attachments: --- Date: Mon 06 Jun 2011 05:20:05 PM EEST Name: BuildAdvPrepare.diff Size: 8kB By: cazfi http://gna.org/patch/download.php?file_id=13114 ___ Reply to this item at: http://gna.org/patch/?2692 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2693] ai_choice - adv_choice
URL: http://gna.org/patch/?2693 Summary: ai_choice - adv_choice Project: Freeciv Submitted by: cazfi Submitted on: Mon 06 Jun 2011 05:44:53 PM EEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: This patch moves ai_choice definition from default ai headers to advisors headers and renames it as adv_choice. ___ File Attachments: --- Date: Mon 06 Jun 2011 05:44:53 PM EEST Name: AdvChoice.diff Size: 23kB By: cazfi http://gna.org/patch/download.php?file_id=13115 ___ Reply to this item at: http://gna.org/patch/?2693 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2694] Remove all default ai includes from advisors code
URL: http://gna.org/patch/?2694 Summary: Remove all default ai includes from advisors code Project: Freeciv Submitted by: cazfi Submitted on: Mon 06 Jun 2011 06:06:42 PM EEST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: This patch removes remaining default ai header includes from advisors code. ___ File Attachments: --- Date: Mon 06 Jun 2011 06:06:42 PM EEST Name: AdvNoAiHdrs.diff Size: 3kB By: cazfi http://gna.org/patch/download.php?file_id=13116 ___ Reply to this item at: http://gna.org/patch/?2694 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2286] AI module directory structure
Update of patch #2286 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #5: One has to svn mv all .c and .h files from ai/ to ai/default/ and then apply attached patch to build default ai from those moved sources. (file #13117) ___ Additional Item Attachment: File name: DefAiInOwnDir.diff Size:3 KB ___ Reply to this item at: http://gna.org/patch/?2286 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17808] Start Scenario Game is unresponsive if scenario dir contains many savefiles
Update of bug #17808 (project freeciv): Planned Release:2.3.0, 2.4.0 = ___ Reply to this item at: http://gna.org/bugs/?17808 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17102] Restrictions on where settlers can build cities could be made clearer
Update of bug #17102 (project freeciv): Planned Release: 2.3.0 = 2.4.0 ___ Reply to this item at: http://gna.org/bugs/?17102 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16457] Bug using enum pointers as int pointers
Update of bug #16457 (project freeciv): Planned Release: 2.3.0 = 2.3.0, 2.4.0 ___ Follow-up Comment #6: Attached patches take care of the easy parts, removing FC_ENUM_PTR macro. settings.c remains broken and problematic. (file #13118, file #13119) ___ Additional Item Attachment: File name: FcEnumPtrRm_16457-TRUNK.diff Size:7 KB File name: FcEnumPtrRm_16457.diff Size:7 KB ___ Reply to this item at: http://gna.org/bugs/?16457 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17461] Document FREECIV_PATH, FREECIV_DATA_PATH etc.
Update of bug #17461 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #5: Attached patch does what I now consider right solution. - Direct freeciv-server usage is unchanged. - If FREECIV_DATA_PATH is not set and FREECIV_PATH is set, ./ser ./civ use FREECIV_PATH as default FREECIV_DATA_PATH. This is consistent with direct freeciv-server usage and also most backward compatible thing to do. - If also FREECIV_PATH is unset, both FREECIV_DATA_PATH gets hardcoded default value. This is consistent with how FREECIV_PATH is handled in these scripts. This default value is different for FREECIV_DATA_PATH than for FREECIV_DATA_PATH. (file #13120) ___ Additional Item Attachment: File name: SerFcDataPathDefault_17461.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?17461 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18005] in dbv_isset() [bitvector.c::120]: assertion 'pdbv-vec != ((void *)0)' failed.
Update of bug #18005 (project freeciv): Release:2.3.0.b4 = 2.3.0-beta4 Planned Release: = 2.3.0 ___ Reply to this item at: http://gna.org/bugs/?18005 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18163] Cancelling city name request makes it impossible to do build city command anymore
Update of bug #18163 (project freeciv): Release: 2.3.0-beta4 = 2.2.5,2.3.0-beta4 Planned Release: 2.3.0 = 2.2.6,2.3.0 ___ Follow-up Comment #15: It backports to S2_2 cleanly, and S2_2's minimum Gtk version is 2.6.0, same as S2_3. So I've committed it there. ___ Reply to this item at: http://gna.org/bugs/?18163 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17919] Spurious migration lines in Government help
Follow-up Comment #5, bug #17919 (project freeciv): Backported to S2_2 in case we ever make a 2.2.x release. ___ Reply to this item at: http://gna.org/bugs/?17919 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7334] Make copy of gtk2-client as base for gtk3-client development
Follow-up Comment #7, task #7334 (project freeciv): Debian unstable seems to have package named libgtk-3-0 now. As does Ubuntu from natty (11.04) onwards. I assume that building instructions for gtk3 itself are not needed now? I don't think they'll be necessary -- just your reassurance that I'm not likely to end up in dependency hell is probably sufficient. Although to be honest, I'd probably just go for installing a more modern distro in a virtual machine for any Gtk3 work I have to do (since I don't intend to move my main machine on from Ubuntu Lucid any time soon). In the beginning so-called gtk3-client tree will be actually gtk2-client prepared to switch to gtk3. (per patch #2689) That may make things easier, but I may still have problems on Lucid, since that only has 2.20 and this code will target 2.24-ish. (This is all about my personal circumstances, but I think it's worth leaving these breadcrumbs in case any other developer finds themself in a similar situation.) ___ Reply to this item at: http://gna.org/task/?7334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7334] Make copy of gtk2-client as base for gtk3-client development
Follow-up Comment #8, task #7334 (project freeciv): On another subject: Cairo was mentioned. There are a couple of very old Cairo patches in RT: RT#15055 http://bugs.freeciv.org/Ticket/Display.html?id=15055, RT#16431 http://bugs.freeciv.org/Ticket/Display.html?id=16431 (2005-6). Dunno if anything can be rescued from them. (At least one of them was about making Cairo an option for all clients, not just Gtk. I don't know if that's still worth pursuing.) ___ Reply to this item at: http://gna.org/task/?7334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17760] Zoom
Follow-up Comment #2, bug #17760 (project freeciv): Historical note: there was apparently a prototype zooming implementation (that depended on the old Cairo patch). Dunno if anything can be rescued from that. RT#16592 http://bugs.freeciv.org/Ticket/Display.html?id=16592 (circa 2006). ___ Reply to this item at: http://gna.org/bugs/?17760 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18185] gtk client crashes after civil war
Update of bug #18185 (project freeciv): Status:None = Duplicate Open/Closed:Open = Closed ___ Follow-up Comment #2: Yes, I agree -- the backtrace looks identical. ___ Reply to this item at: http://gna.org/bugs/?18185 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault
Follow-up Comment #11, bug #17439 (project freeciv): The backtrace in bug #18185 has a bit more debug info than the one in comment #6, but I'm not sure it helps narrow it down. ___ Reply to this item at: http://gna.org/bugs/?17439 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16623] netintf.c gcc warnings in net_lookup_service
Update of bug #16623 (project freeciv): Severity: 2 - Minor = 3 - Normal Status:None = Ready For Test Planned Release: 2.3.0 = 2.3.0, 2.4.0 ___ Follow-up Comment #5: Well, even if nobody has tested the patch on Windows, it cannot not fix the exact bug reported. :-) When you have no reference to gethostbyname2() in code, references to it cannot cause any problems. Attached is trunk version of the patch updated against latest svn. Earlier trunk version still applies cleanly to S2_3. (file #13121) ___ Additional Item Attachment: File name: GetAddrInfo_16623-TRUNK.diff Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?16623 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2609] Polish localization for S2_3
Follow-up Comment #5, patch #2609 (project freeciv): Committed file #13109. 6297 translated messages :) ___ Reply to this item at: http://gna.org/patch/?2609 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17020] IPv6: Improve connecting to dual-stack system
Follow-up Comment #3, bug #17020 (project freeciv): While our current code (with several patches gone in since this ticket was first opened) does not provide full functionality of what this patch gets by unconditionally using getaddrinfo(), original problem reported should be handled. Current code tries to connect to both IPv6 and IPv4 address if both are available. For the time being I prefer our current code to this patch for backward compatibility reasons. This patch would make getaddrinfo() and friends hard requirement for Freeciv. For now we still want to support at least IPv4 in systems lacking those. Of course this patch can be improved too. I wait a couple of days for comments. If none is given, I'll close the ticket. ___ Reply to this item at: http://gna.org/bugs/?17020 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16566] Duplicate base building actions on combat menu for workers
Update of bug #16566 (project freeciv): Planned Release: 2.3.0 = 2.3.0, 2.4.0 ___ Follow-up Comment #6: Could we reveal the fact that division of bases to these two types model nothing in their properties to the UI? Can we just refer to them as Type A / Type B? - Base quick select 1 / Base quick select 2 - Base 1 / Base 2 - Type A base / Type B base Then we have to open another ticket about how client should display somewhere what category (A/B or 1/2) each base belongs to. It's not that obvious that one should press 'f', and not 'e', to build Buoy. ___ Reply to this item at: http://gna.org/bugs/?16566 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault
Update of bug #17439 (project freeciv): Status: Need Info = Ready For Test Planned Release: 2.3.0 = 2.3.0, 2.4.0 ___ Follow-up Comment #12: I tried to find out where that queued real_players_dialog_update() might come from. And I think I know the server side problem. in plrhand.c:split_player():1739 info about new player (newly used slot) is sent first time. Nation for that nation is set only after that at line 1742. It's the nature of the client side gui update being queued by gtk_idle_add() that this bug is not always reproducible. Often client handles updated player info packet with nation in it before going to that idle handling. Untested fix attached. (file #13122) ___ Additional Item Attachment: File name: NationSetBeforeSend_17439.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?17439 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18005] in dbv_isset() [bitvector.c::120]: assertion 'pdbv-vec != ((void *)0)' failed.
Follow-up Comment #7, bug #18005 (project freeciv): I think there must be several bugs. First of all I believe it to be a bug that find_city_or_settler_near_tile() tries to use knowledge of the city owner, and not that of player running the client. Patch for that attached. Still, that usage of wrong player's knowledge should not suddenly start to fail. I'm not entirely sure if it's a bug that it's not always failing (memory has been allocated for tile knowledge information of all players even though client never receives actual information) or that it fails in some situations. I also have to note that this is based entirely on backtrace on comment #4. I'm not sure if all cases listed in this ticket really are the same bug. (file #13123) ___ Additional Item Attachment: File name: SeeYourself_18005.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?18005 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18005] in dbv_isset() [bitvector.c::120]: assertion 'pdbv-vec != ((void *)0)' failed.
Follow-up Comment #8, bug #18005 (project freeciv): The other problem is in client_player_maps_reset() initializing player map information. It is only ever called when map_info packet is received. Problem is either that there is no similar player map information initialization / allocation for players appearing mid-game, or client_player_maps_reset() is buggy in that it initializes / allocates for players other than client user. ___ Reply to this item at: http://gna.org/bugs/?18005 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18005] in dbv_isset() [bitvector.c::120]: assertion 'pdbv-vec != ((void *)0)' failed.
Follow-up Comment #9, bug #18005 (project freeciv): Looking back, i *think* this always manifested after conquering several cities. Thus, it seems logical that it is tied in with setting up a civil war nation. ___ Reply to this item at: http://gna.org/bugs/?18005 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2695] Update filename references in README.sound
URL: http://gna.org/patch/?2695 Summary: Update filename references in README.sound Project: Freeciv Submitted by: doctorjlowe Submitted on: Tue 07 Jun 2011 03:55:46 AM GMT Category: docs Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: correct civclient to freeciv-gtk2, etc. ___ File Attachments: --- Date: Tue 07 Jun 2011 03:55:46 AM GMT Name: README.sound-patch Size: 983B By: doctorjlowe http://gna.org/patch/download.php?file_id=13124 ___ Reply to this item at: http://gna.org/patch/?2695 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2696] Update filename references in README.cma
URL: http://gna.org/patch/?2696 Summary: Update filename references in README.cma Project: Freeciv Submitted by: doctorjlowe Submitted on: Tue 07 Jun 2011 04:01:17 AM GMT Category: docs Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: correct .civclientrc to .freeciv-client-rc-X.Y, etc. ___ File Attachments: --- Date: Tue 07 Jun 2011 04:01:17 AM GMT Name: README.cma-patch Size: 3kB By: doctorjlowe http://gna.org/patch/download.php?file_id=13125 ___ Reply to this item at: http://gna.org/patch/?2696 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2697] Update filename references in README.graphics
URL: http://gna.org/patch/?2697 Summary: Update filename references in README.graphics Project: Freeciv Submitted by: doctorjlowe Submitted on: Tue 07 Jun 2011 04:03:30 AM GMT Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: correct civclient to freeciv-gtk2, etc. ___ File Attachments: --- Date: Tue 07 Jun 2011 04:03:30 AM GMT Name: README.graphics-patch Size: 1kB By: doctorjlowe http://gna.org/patch/download.php?file_id=13126 ___ Reply to this item at: http://gna.org/patch/?2697 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2698] Update filename references in README
URL: http://gna.org/patch/?2698 Summary: Update filename references in README Project: Freeciv Submitted by: doctorjlowe Submitted on: Tue 07 Jun 2011 04:28:09 AM GMT Category: docs Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: correct civclient to freeciv-gtk2, etc. *note that the section on logs has two references to 'civserver' that i didn't know what to do with: lines 458 and 463. ___ File Attachments: --- Date: Tue 07 Jun 2011 04:28:09 AM GMT Name: README.diff Size: 6kB By: doctorjlowe http://gna.org/patch/download.php?file_id=13127 ___ Reply to this item at: http://gna.org/patch/?2698 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16079] Update docs to reflect file name changes
Follow-up Comment #6, bug #16079 (project freeciv): patch #2695 for README.sound patch #2696 for README.cma patch #2697 for README.graphics patch #2698 for README I didn't see any other glaring problems in /doc, other than 1) README.delta could use a good introduction [what is it for, and who would benefit from it?] 2) I'm not sure, but i have a hunch that HACKING contains a lot of obsolete material. ___ Reply to this item at: http://gna.org/bugs/?16079 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
