[Freeciv-Dev] [bug #18081] warning: null format string
Follow-up Comment #14, bug #18081 (project freeciv): No, I still had the problem after r20241 (that's where I first noticed it) -- I just mentioned r20238 to narrow down which of the two changes introduced the problem for me. ___ Reply to this item at: http://gna.org/bugs/?18081 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18081] warning: null format string
Update of bug #18081 (project freeciv): Status: Fixed = In Progress Open/Closed: Closed = Open ___ Follow-up Comment #15: I do not have the problem but it happend before; for the usage of printf like functions a format string is needed ... Could you test the attached patch? It uses a string NOLOGMSG = nologmsg:%s as format as well as argument for these functions. Do you know which option(s) have to be added to gcc to activate these checks? I would include it in --enable-debug=yes or at least --enable-debug=checks configure options. (file #14086) ___ Additional Item Attachment: File name: 0018-fix-assert-if-there-is-no-log-message.patch Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?18081 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18081] warning: null format string
Follow-up Comment #16, bug #18081 (project freeciv): Do you know which option(s) have to be added to gcc to activate these checks This is probably related to so called hardened gcc, though I would expect every major distribution to use such configuration already. Anyway, maybe googling that helps. ___ Reply to this item at: http://gna.org/bugs/?18081 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2960] additional compile checks
URL: http://gna.org/patch/?2960 Summary: additional compile checks Project: Freeciv Submitted by: syntron Submitted on: Do 15 Sep 2011 20:12:43 CEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: add additional compiling time checks if --enable-debug=checks is set - Force '-Wformat -Wformat-security' to be active (see also gna bug #18081) - fix flags for c++ ___ File Attachments: --- Date: Do 15 Sep 2011 20:12:43 CEST Name: 0019-add-additional-compiling-time-checks-if-enable-debug.patch Size: 1kB By: syntron http://gna.org/patch/download.php?file_id=14089 ___ Reply to this item at: http://gna.org/patch/?2960 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18081] warning: null format string
Follow-up Comment #17, bug #18081 (project freeciv): I did found the option. It is -Wformat; see gna patch #2960. Did the patch help in your case? In my tests with I could reproduce the compile error with the new options. It seems to be fixed by the patch in comment #15. ___ Reply to this item at: http://gna.org/bugs/?18081 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18612] more LUA accessors for terrain
Follow-up Comment #9, bug #18612 (project freeciv): I've begun writing the code for accessors. There are three functions I want to implement will each require a simple declaration in three separate files. Specifically, api_methods.h, api_methods.c, tolua_game.pkg. The three functions I plan to implement are tile_terrain(*ptile) and tile_change_terrain(*ptile, *pterrain) in tile.h, and from terrain.h, transform_result(*pterrain). For tile_change_terrain I will have to define a macro in the header. Should have code for review in a day or so. ___ Reply to this item at: http://gna.org/bugs/?18612 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18612] more LUA accessors for terrain
Follow-up Comment #10, bug #18612 (project freeciv): How should I organize the patches for this? As 10 separate patches or three for each set of functions? ___ Reply to this item at: http://gna.org/bugs/?18612 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18612] more LUA accessors for terrain
Follow-up Comment #11, bug #18612 (project freeciv): How should I organize the patches for this? As 10 separate patches or three for each set of functions? As 3 patches for the 3 functions would be OK. Each of them is a change to the interface; or - if you think they belong together - only one patch. ___ Reply to this item at: http://gna.org/bugs/?18612 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2960] additional compile checks
Follow-up Comment #1, patch #2960 (project freeciv): updated patch; it now includes a cleanup of the debug settings: - move debug flags into debug.m4 - remove duplicated flags - Add/force '-Wformat -Wformat-security' to be active (see also gna bug #18081) - Fix flags for c++ (file #14090) ___ Additional Item Attachment: File name: 0019-add-additional-compiling-time-checks-if-enable-debug.patch Size:6 KB ___ Reply to this item at: http://gna.org/patch/?2960 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2960] additional compile checks
Follow-up Comment #2, patch #2960 (project freeciv): Why you have in several places two calls to FC_C_FLAGS for setting flags to same variable after each other? It would be more efficient to combine these to one call. ___ Reply to this item at: http://gna.org/patch/?2960 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18613] Boats can be left landlocked in cities by terrain transformation = assertion failures
Follow-up Comment #3, bug #18613 (project freeciv): Forgot the editor, as usual, so I'll need to update my patch. ___ Reply to this item at: http://gna.org/bugs/?18613 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18081] warning: null format string
Follow-up Comment #18, bug #18081 (project freeciv): File #14086 does help for me, yes. (And notwithstanding my previous comment about fragility, it's hard to see how a toolchain could find this objectionable.) Evidence for Ubuntu tweaking to enable these warnings here https://wiki.ubuntu.com/CompilerFlags#A-Wformat_-Wformat-security. But I don't know what the mechanism they use to do so (it's not ended up on my command line). ___ Reply to this item at: http://gna.org/bugs/?18081 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
