[Freeciv-Dev] [bug #19959] Mon nation PNG flags don't match SVG

2012-07-20 Thread Jacob Nevins
Update of bug #19959 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = jtn

___

Follow-up Comment #2:

I am completely dozy -- it says it right there in the patch, doesn't it?

Well, better get it (file #12297) committed before release, in the spirit of
GPL compliance.

___

Reply to this item at:

  http://gna.org/bugs/?19959

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19959] Mon nation PNG flags don't match SVG

2012-07-20 Thread Jacob Nevins
Follow-up Comment #3, bug #19959 (project freeciv):

Oh, right, that's a different patch. Not so dozy after all.

___

Reply to this item at:

  http://gna.org/bugs/?19959

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18440] IP_ADD_MEMBERSHIP (225.1.1.1) failed on Windows

2012-07-20 Thread Jacob Nevins
Follow-up Comment #2, bug #18440 (project freeciv):

The whole message is there, but you have to select the text and drag right to
see it (dodgy CSS?)

An unknown, invalid, or unsupported option or level was specified in a
getsockopt or setsockopt call.

I think I get something like this on Linux when starting Freeciv with no
Internet connection; it's quite possible that Windows didn't have access to
the Internet this time (it often doesn't).

___

Reply to this item at:

  http://gna.org/bugs/?18440

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19959] Mon nation PNG flags don't match SVG

2012-07-20 Thread Jacob Nevins
Additional Item Attachment, bug #19959 (project freeciv):

File name: trunk-S2_4-flag-mon-new-svg.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?19959

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19955] gtk_menus.xml not installed if only Gtk3 client built

2012-07-20 Thread Jacob Nevins
Update of bug #19955 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19955

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3434] Qt revolution menu and message box

2012-07-20 Thread mir3x
URL:
  http://gna.org/patch/?3434

 Summary: Qt revolution menu and message box
 Project: Freeciv
Submitted by: mir3x
Submitted on: Fri 20 Jul 2012 08:19:05 PM GMT
Category: client-qt
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Added MessageBox confirming revolution.
+ menus with available governments, sensitive.



___

File Attachments:


---
Date: Fri 20 Jul 2012 08:19:05 PM GMT  Name: QtRevol.patch  Size: 9kB   By:
mir3x

http://gna.org/patch/download.php?file_id=16139

___

Reply to this item at:

  http://gna.org/patch/?3434

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19960] ./confiure

2012-07-20 Thread mir3x
URL:
  http://gna.org/bugs/?19960

 Summary: ./confiure
 Project: Freeciv
Submitted by: mir3x
Submitted on: Fri 20 Jul 2012 08:50:30 PM GMT
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:






___

Reply to this item at:

  http://gna.org/bugs/?19960

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19960] ./confiure

2012-07-20 Thread mir3x
Follow-up Comment #1, bug #19960 (project freeciv):

Can I remove it somehow ? I pressed enter in browser accidently.

___

Reply to this item at:

  http://gna.org/bugs/?19960

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19960] ./confiure

2012-07-20 Thread Jacob Nevins
Update of bug #19960 (project freeciv):

  Status:None = Invalid
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19960

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail

2012-07-20 Thread Jacob Nevins
Follow-up Comment #1, bug #19961 (project freeciv):

Hm. I haven't tested it thoroughly, but looking at package contents, on Ubuntu
(Lucid / Precise) and Debian (stable and testing), the pkgconfig file is
called lua5.1.pc, not lua.pc.

What's your operating system / distribution?

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail

2012-07-20 Thread mir3x
Follow-up Comment #2, bug #19961 (project freeciv):

gentoo

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail

2012-07-20 Thread mir3x
Follow-up Comment #3, bug #19961 (project freeciv):

http://lua-users.org/lists/lua-l/2008-09/msg00184.html


___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail

2012-07-20 Thread Marko Lindqvist
Follow-up Comment #4, bug #19961 (project freeciv):

 but pkgconfig file is called lua.pc instead lua51.pc

That's tricky setup. Even ignoring other distributions that would be affected
with checking lua.pc, presumably lua.pc always refers to *current* lua version
in your distribution. 5.0, 5.1, and 5.2 are incompatible in ways that make us
currently require exactly 5.1.

Anyway, lua project itself seems to produce lua.pc. lua51.pc is just debian
modification.

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail

2012-07-20 Thread mir3x
Follow-up Comment #5, bug #19961 (project freeciv):

lua -e 'print(_VERSION)' 21 | cut -d' ' -f2

will post correct version but Im not good in putting it in configure

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail

2012-07-20 Thread Marko Lindqvist
Follow-up Comment #6, bug #19961 (project freeciv):

 lua -e 'print(_VERSION)' 21 | cut -d' ' -f2

You cannot run target system lua on build system when cross-compiling.

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail

2012-07-20 Thread mir3x
Follow-up Comment #7, bug #19961 (project freeciv):

so maybe one of these macros will be useful ?
http://www.gnu.org/software/autoconf-archive/ax_lua.html


___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3424] City dialog created for Qt Version

2012-07-20 Thread Marko Lindqvist
Update of patch #3424 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3424

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail on Gentoo

2012-07-20 Thread Jacob Nevins
Update of bug #19961 (project freeciv):

 Summary: ./configure --enable-sys-lua fail = ./configure
--enable-sys-lua fail on Gentoo

___

Follow-up Comment #8:

Looks like Lua upstream made good on their threat to drop lua.pc from 5.2.

I'm not an autoconf expert, but how about the attached patch? Not extensively
tested but it still works for me on Ubuntu.

(file #16140)
___

Additional Item Attachment:

File name: trunk-S2_4-enable-sys-lua-portability.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail on Gentoo

2012-07-20 Thread Jacob Nevins
Follow-up Comment #9, bug #19961 (project freeciv):

(It's a bit ugly because it can produce output like this:

checking for LUA... no
checking for LUA... no
checking for LUA... yes)

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail on Gentoo

2012-07-20 Thread Jacob Nevins
Update of bug #19961 (project freeciv):

Operating System:None = GNU/Linux  


___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail on Gentoo

2012-07-20 Thread mir3x
Follow-up Comment #10, bug #19961 (project freeciv):

doesnt work anyway
configure:32327: $? = 1
Requested 'lua = 5.1' but version of Lua is 5.1.4
configure:32355: result: no
configure:32358: error: Use of included lua disabled, and no lua found from
system


___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3424] City dialog created for Qt Version

2012-07-20 Thread Jacob Nevins
Follow-up Comment #5, patch #3424 (project freeciv):

I think citydlg.h was missed from the commit to svn (r21586), although it's in
the attached patches.

With citydlg.h from file #16129, it builds and runs for me.

___

Reply to this item at:

  http://gna.org/patch/?3424

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail on Gentoo

2012-07-20 Thread Jacob Nevins
Follow-up Comment #11, bug #19961 (project freeciv):

Darn, overly fussy. Can you try changing lua = 5.1 to lua =5.1 lua  5.2?

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3433] Remove Gtk2-specific code from Gtk3 client

2012-07-20 Thread Marko Lindqvist
Update of patch #3433 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.5.0  

___

Follow-up Comment #1:

Patch

(file #16141)
___

Additional Item Attachment:

File name: Gtk3Gtk3Only.patch.bz2 Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?3433

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail on Gentoo

2012-07-20 Thread mir3x
Follow-up Comment #12, bug #19961 (project freeciv):

Doesnt work:

Unknown version comparison operator '=5.1' after package name 'lua' in file
'(command line arguments)'

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3433] Remove Gtk2-specific code from Gtk3 client

2012-07-20 Thread Jacob Nevins
Follow-up Comment #2, patch #3433 (project freeciv):

If this is a prerequisite for further patches to the Gtk3 client, I think
it'll need to go to 2.4.0 as well.

How about removing the freeciv.rc-2.0 related stuff from the Gtk3 Makefile,
and fallback_resources[] while removing Gtk2 things? As noted in bug #19955,
it's not used.

___

Reply to this item at:

  http://gna.org/patch/?3433

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail on Gentoo

2012-07-20 Thread Jacob Nevins
Follow-up Comment #13, bug #19961 (project freeciv):

Argh. Missing space.
lua = 5.1 lua  5.2
(I've tested it this time.)

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3431] Call bitwise setting with no bits set empty value

2012-07-20 Thread Marko Lindqvist
Update of patch #3431 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3431

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3417] Configure check for Qt version

2012-07-20 Thread Jacob Nevins
Follow-up Comment #5, patch #3417 (project freeciv):

As of patch #3424, Qt 4.7 is no longer a requirement -- it now builds fine on
my 4.6.2 system.

___

Reply to this item at:

  http://gna.org/patch/?3417

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail on Gentoo

2012-07-20 Thread mir3x
Follow-up Comment #14, bug #19961 (project freeciv):

it works

configure:32306: $PKG_CONFIG --exists --print-errors lua = 5.1 lua  5.2
configure:32309: $? = 0
configure:32324: $PKG_CONFIG --exists --print-errors lua = 5.1 lua  5.2
configure:32327: $? = 0
configure:32369: result: yes

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail on Gentoo

2012-07-20 Thread Jacob Nevins
Additional Item Attachment, bug #19961 (project freeciv):

File name: trunk-S2_4-enable-sys-lua-portability-bis.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19921] Intermediate animation steps in map update not visible

2012-07-20 Thread Marko Lindqvist
Update of bug #19921 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19921

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3433] Remove Gtk2-specific code from Gtk3 client

2012-07-20 Thread Marko Lindqvist
Update of patch #3433 (project freeciv):

 Planned Release:   2.5.0 = 2.4.0, 2.5.0   

___

Follow-up Comment #3:

New version for TRUNK (S2_4 version coming later)

- Remove freeciv.rc-2.0 stuff, including resources

In addition to applying this patch, files rc2c and resources.[ch] should be
completely removed.

(file #16143)
___

Additional Item Attachment:

File name: Gtk3Gtk3Only-2.patch.bz2   Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?3433

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19961] ./configure --enable-sys-lua fail on Gentoo

2012-07-20 Thread Jacob Nevins
Update of bug #19961 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = jtn

___

Follow-up Comment #15:

 it works
Good news.
I plan to commit the modified patch, unless anyone says it's a terrible idea.

___

Reply to this item at:

  http://gna.org/bugs/?19961

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19957] Move Lua tile:set_label() from tolua_game to tolua_server

2012-07-20 Thread Jacob Nevins
Follow-up Comment #1, bug #19957 (project freeciv):

It's easy enough to fix this, but can I first check that the intent wasn't to
make this available on the client?

Entering something like find.tile(0,0):set_label(Hello) in the client Lua
console does actually work at the moment, in that the label appears on the
map, but it tends not to show up until you've scrolled the map around about,
and of course it doesn't go to other players, and is likely to be obliterated
at some point by a server update.

Just wanted to check there wasn't some plan for client-side private labels.

___

Reply to this item at:

  http://gna.org/bugs/?19957

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19957] Move Lua tile:set_label() from tolua_game to tolua_server

2012-07-20 Thread Marko Lindqvist
Follow-up Comment #2, bug #19957 (project freeciv):

 Just wanted to check there wasn't some plan for client-side
 private labels.

While per-player labels would make sense, they too, if ever implemented, must
go to server side to be added in savegames.

___

Reply to this item at:

  http://gna.org/bugs/?19957

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3435] New civilization - Mormons

2012-07-20 Thread anonymous
URL:
  http://gna.org/patch/?3435

 Summary: New civilization - Mormons
 Project: Freeciv
Submitted by: None
Submitted on: Sat 21 Jul 2012 12:03:05 AM UTC
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: wi...@vandals.uidaho.edu
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Enclosed is a .zip file containing a  Mormon civilization. This is based on
the quasi-independence of the state of Deseret in the 1840s and 1850s. Leaders
are LDS church officials and Mormon politicians. The flag is purely
hypothetical. Please consider this civilization for inclusion in the next
release of Freeciv.

Sincerely,

Michael Witry



___

File Attachments:


---
Date: Sat 21 Jul 2012 12:03:05 AM UTC  Name: mormons.zip  Size: 25kB   By:
None

http://gna.org/patch/download.php?file_id=16145

___

Reply to this item at:

  http://gna.org/patch/?3435

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3435] New civilization - Mormons

2012-07-20 Thread Jacob Nevins
Update of patch #3435 (project freeciv):

Category: general = rulesets   
 Assigned to:None = mixcoatl   

___

Follow-up Comment #1:

The flag would need an SVG version for consideration -- see guidance
http://freeciv.wikia.com/wiki/Nations#The_nation_flag_image_file.

___

Reply to this item at:

  http://gna.org/patch/?3435

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19962] Lua Tile:set_label() does not update clients

2012-07-20 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?19962

 Summary: Lua Tile:set_label() does not update clients
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Jul 21 01:28:29 2012
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r21593
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

The tile_label() function added in patch #3136 and modified in bug #19957
doesn't do anything to push the updated tile to clients, so it's left until
the next time the tile gets updated for another reason.

However, the obvious code fix causes trouble in the form of assertion failures
when the script that assigns labels on the map_generated signal runs.




___

Reply to this item at:

  http://gna.org/bugs/?19962

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19957] Move Lua tile:set_label() from tolua_game to tolua_server

2012-07-20 Thread Jacob Nevins
Update of bug #19957 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = jtn

___

Follow-up Comment #3:

* Invent edit.tile_set_label().
* Remove bool return value from Tile:set_label() (which indicates whether the
tile was changed, not much use to a script)
** This highlights that the script function doesn't push updates to the
client. Not completely trivial to fix, so punted to bug #19962.

(file #16147)
___

Additional Item Attachment:

File name: trunk-lua-tile-set-label-server.patch Size:4 KB


___

Reply to this item at:

  http://gna.org/bugs/?19957

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3434] Qt revolution menu and message box

2012-07-20 Thread Marko Lindqvist
Follow-up Comment #1, patch #3434 (project freeciv):

 // common
 #include game.h
+#include packhand.h
 #include government.h

packhand.h is not in common but in client, and includes should be in
alphabetical order within category.

 for (int i = 1; i  gov_count; i++) { /** skip anarchy ( == 0 ) */

You should not blindly skip government in index 0 - order of governments is
ruleset author's decision. You are probably after
game.government_during_revolution here.

Some extra spaces between function, macro, or macrolike (SLOT, SIGNAL) names
and (.

___

Reply to this item at:

  http://gna.org/patch/?3434

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3436] Improve server console readline completion

2012-07-20 Thread Jacob Nevins
URL:
  http://gna.org/patch/?3436

 Summary: Improve server console readline completion
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Jul 21 04:33:43 2012
Category: None
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.3,2.4.0,2.5.0

___

Details:

This patch improves tab completion at the server command prompt:
* Enumerated and bitwise option values are now completed.
* Add basic completion for reset, vote, delegate, mapimg, fcdb, lua, kick, and
playercolor commands (on appropriate branches).

There is still plenty of room for improvement.




___

Reply to this item at:

  http://gna.org/patch/?3436

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev