[Freeciv-Dev] [patch #3556] DefenseDivider combat bonus

[Marko Lindqvist]

URL:
  

 Summary: DefenseDivider combat bonus
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 12 Nov 2012 04:02:00 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Add DefenseDivider combat bonus. Replace hardcoded rule that Helicopter
defense is divided by 2 when attacked by Fighter by proper bonus definition.

"Fighter" and "Helicopter" flags are not yet removed, since they have more
properties than this one now removed from them.

Civ1 had "Fighter" unit, but no "Helicopter", so former had no gameplay effect
at all. I removed it.



___

File Attachments:


---
Date: Mon 12 Nov 2012 04:02:00 AM EET  Name: DefenseDivider.patch  Size: 7kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3555] Pikemen bonus vs Horses as combat bonus

[Marko Lindqvist]

URL:
  

 Summary: Pikemen bonus vs Horses as combat bonus
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 12 Nov 2012 03:22:00 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Remove hardcoded "Horse" and "Pikemen" unit type flags. Add user flag "Horse"
and combat bonus against them for Pikemen units in rulesets that need it.

The AI code that evaluated Pikemen usability has been rewritten completely - I
didn't even attempt to get anything near the old behavior restored. Most
notably tech want for any tech that provides better defense against potential
attackers gets a bump where only techs providing "Pikemen" unit got it, and
only when attacker was "Horse" unit.



___

File Attachments:


---
Date: Mon 12 Nov 2012 03:22:00 AM EET  Name: HorsePikemen.patch  Size: 23kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

[RafałMużyło]

Follow-up Comment #6, patch #3550 (project freeciv):

As noted, I've decided if there's no good way to do it, I'll stick with a
model that sort of works.

I've still merged the active content of update_rect_at_mouse_pos into the
calbacks that used it, but updated the old code in regard of deprecation
warnings.

That meant touching up the code in gui_main.c, so that it works in the same
way mapctrl.c does.

(file #16747, file #16748)
___

Additional Item Attachment:

File name: 0001-modify-selection-rectangle-drawing.patch Size:2 KB
File name: 0002-remove-deprecation-warnings-from-create_line_at_mous.patch
Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

[RafałMużyło]

Follow-up Comment #5, patch #3550 (project freeciv):

Well, it seems we don't quite understand each other, but OK.
I went with the extreme duplication instead.
You'll see what I mean once I'll attach updated version of both patches.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3548] Combat bonuses framework

[Marko Lindqvist]

Follow-up Comment #1, patch #3548 (project freeciv):

- Updated agains current SVN

(file #16746)
___

Additional Item Attachment:

File name: CombatBonuses-2.patch.bz2  Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3545] Max_Trade_Routes for civ2civ3 ruleset

[David Fernandez]

Follow-up Comment #1, patch #3545 (project freeciv):

Thank you for keep updating the civ2civ3 ruleset.

I'm sort of time now to play freeciv, but I plan to come back before the next
release, to check the latest changes and test this ruleset again.

Send me a mail if you think I can help with something.

___

Reply to this item at:

  

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

[Marko Lindqvist]

Follow-up Comment #4, patch #3550 (project freeciv):

> the problem comes down to a simple thing - the function
> signature is 'void update_rect_at_mouse_pos(void)'.

That's why I proposed new helper function with proper signature ("taking
coordinates as parameters")

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3550] Merge update_rect_at_mouse_pos into move_mapcanvas (patch 11/60)

[RafałMużyło]

Follow-up Comment #3, patch #3550 (project freeciv):

In case of update_rect_at_mouse_pos, the problem comes down to a simple thing
- the function signature is 'void update_rect_at_mouse_pos(*void*)'.
The already stated reason comes into play, the same one I was against
gdk_display_get_device_manager 'solution' in the patch in bug #20097 - the
event *knows* exactly where mouse is when the event happened,
gdk_display_get_device_manager says only where the mouse is while the
*function* runs.

While usually those positions (due to human reaction speed vs cpu power) are
very close, that still means the code would be wrong.
So, with such signature, there's no reasonable way to pass the coordinates
from the event handler to this function.

create_line_at_mouse_pos is a different case: as I said in the comment of that
patch, the only reasonable usecase is already handled elsewhere in the code,
that is the lines are effectively drawn twice now - once by
create_line_at_mouse_pos, the second time by move_{map,overview}canvas -
therefore non-empty create_line_at_mouse_pos is redundant...well, at least
AFAICT. 

Well, perhaps cur_x/cur_y could be used here instead of trying to query the
pointer, but all those global vars make me cringe.
I need to think about it.

On a surprisingly related note: that cpu usage jump when a *selected* unit is
on screen (due to that animated circle) is quite annoying.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20256] Can't buy units when city is in disorder

[David Christensen]

Follow-up Comment #2, bug #20256 (project freeciv):

It is irritating/ confusing when a city run by the governor is in peace at the
end of a turn, turn processing causes disorder, the governor restores peace,
and the player's actions w.r.t. that city are impaired.  Perhaps it would be
less irritating/ confusing if disorder caused by turn processing disengaged
the governor, and provided an explanation in the message pane for the cause of
disorder and a statement that the governor has been disengaged.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20291] Cannot finish compiling latest freeciv code

[Roland Haeder]

URL:
  

 Summary: Cannot finish compiling latest freeciv code
 Project: Freeciv
Submitted by: quix0r
Submitted on: Sun 11 Nov 2012 03:42:32 PM GMT
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

The compilation files here:

distcc[25552] ERROR: compile ../../../freeciv/client/cityrepdata.c on
192.168.2.3 failed
distcc[25552] (dcc_build_somewhere) Warning: remote compilation of
'../../../freeciv/client/cityrepdata.c' failed, retrying locally
distcc[25552] Warning: failed to distribute
../../../freeciv/client/cityrepdata.c to 192.168.2.3, running locally instead
In file included from ../../../freeciv/client/cityrepdata.c:843:0:
../../../freeciv/client/cityrepdata.c: In function 'split_string':
../../../freeciv/utility/specvec.h:129:29: error: 'd.string_value' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
../../../freeciv/client/cityrepdata.c:956:20: note: 'd.string_value' was
declared here
cc1: all warnings being treated as errors
distcc[25552] ERROR: compile ../../../freeciv/client/cityrepdata.c on
localhost failed
make[3]: *** [cityrepdata.lo] Error 1
make[3]: *** Waiting for unfinished jobs
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20256] Can't buy units when city is in disorder

[Roland Haeder]

Follow-up Comment #1, bug #20256 (project freeciv):

As I have heard this is a feature, not a bug. If a city is in disorder nothing
works until the order is restored.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2195] New Early Germanic nations

[Jacob Nevins]

Follow-up Comment #22, patch #2195 (project freeciv):

Should government type "Tribal" in gepid.ruleset be "Despotism"?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19977] Range of trademindist 1-999 is too big for network packet format (UINT8)

[Jacob Nevins]

Follow-up Comment #12, bug #19977 (project freeciv):

Trivial patch for S2_3 typo. No attempt to handle binaries built off S2_3 in
the last month or so specially.

(file #16745)
___

Additional Item Attachment:

File name: S2_3-trademindist-capability-typo.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev