[Freeciv-Dev] [patch #4451] AI handling of !present requirements
URL: http://gna.org/patch/?4451 Summary: AI handling of !present requirements Project: Freeciv Submitted by: cazfi Submitted on: Sat 25 Jan 2014 11:11:16 AM EET Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.3, 2.5.0, 2.6.0 ___ Details: This patch fixes !present (or negated) requirement handling in AI. For effect requirements reggression testing between nreg vector and !present requirements there's bad news: implementation differs in such a fundamental level, that it makes no sense to make !present results identical to nreqs. Effects for which building is nreq, are not even in buildings effects cache, so AI code never even sees them. !present OTOH is handled (after this patch) inside AI code, and only when it's time to check the req. !present requirement now work against the value of the requirement building. ___ File Attachments: --- Date: Sat 25 Jan 2014 11:11:16 AM EET Name: AiNotPresent.patch Size: 9kB By: cazfi http://gna.org/patch/download.php?file_id=19850 --- Date: Sat 25 Jan 2014 11:11:16 AM EET Name: AiNotPresent-S2_5.patch Size: 8kB By: cazfi http://gna.org/patch/download.php?file_id=19851 --- Date: Sat 25 Jan 2014 11:11:16 AM EET Name: AiNotPresent-S2_4.patch Size: 8kB By: cazfi http://gna.org/patch/download.php?file_id=19852 ___ Reply to this item at: http://gna.org/patch/?4451 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21527] Server tries to use announcement socket even if one is not created
Update of bug #21527 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21527 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21441] Gained achievements not visible to client
Update of bug #21441 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #3: Wider requirement ranges discussion to continue in bug #21536 ___ Reply to this item at: http://gna.org/bugs/?21441 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21536] Client fails to see requirement Achievement ... Allied fulfilled
URL: http://gna.org/bugs/?21536 Summary: Client fails to see requirement Achievement ... Allied fulfilled Project: Freeciv Submitted by: cazfi Submitted on: Sat 25 Jan 2014 11:34:50 AM EET Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: Discussion to continue from bug #21441 that made it so that player's own achievement are sent to the client. That made client to know when requirements of type Achievement ... Player are fulfilled. What should we do about wider range requirements? Just document the limitation that client cannot handle them (I'd rather not make them completely illegal in server side just because use with *some* effect types would not work well) ___ Reply to this item at: http://gna.org/bugs/?21536 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4452] freeciv-ruledit script.lua
URL: http://gna.org/patch/?4452 Summary: freeciv-ruledit script.lua Project: Freeciv Submitted by: cazfi Submitted on: Sat 25 Jan 2014 11:47:37 AM EET Category: freeciv-ruledit Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Opening a ticket just to document this last missing piece from saving usable ruleset. script.lua is mandatory part of the ruleset directory, so freeciv-ruledit should save it even though freeciv-ruledit never makes changes to it. Also, script saved cannot be some template, so that editing a ruleset with freeciv-ruledit does not lose earlier changes to script.lua. ___ Reply to this item at: http://gna.org/patch/?4452 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4441] Editing tech requirements
Update of patch #4441 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4441 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21537] freeciv-ruledit ruleset loading failure error message shows wrong ruleset name
URL: http://gna.org/bugs/?21537 Summary: freeciv-ruledit ruleset loading failure error message shows wrong ruleset name Project: Freeciv Submitted by: cazfi Submitted on: Sat 25 Jan 2014 12:01:00 PM EET Category: freeciv-ruledit Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: When ruleset loading fails, freeciv-ruledit always claims failing ruleset to be classic. This is due to ruleset loading code falling back to default (i.e., classic) when loading the original ruleset fails. Attached fix makes freeciv-ruledit to print name of the requested ruleset in the error message, not what actually got loaded. ___ File Attachments: --- Date: Sat 25 Jan 2014 12:01:00 PM EET Name: LoadFailureRulesetName.patch Size: 471B By: cazfi http://gna.org/bugs/download.php?file_id=19853 ___ Reply to this item at: http://gna.org/bugs/?21537 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21538] Unrecognized options silently ignored by tools
URL: http://gna.org/bugs/?21538 Summary: Unrecognized options silently ignored by tools Project: Freeciv Submitted by: cazfi Submitted on: Sat 25 Jan 2014 12:17:42 PM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.5, 2.4.2, 2.5.0, 2.6.0 ___ Details: Found out when I accidentally gave wrong option to freeciv-ruledit and spent some time investigating why it didn't do what I meant. It had just ignored that option instead of giving an error. Also freeciv-manual and modpack installers have the same problem (all actually have code originally copy-pasted from freeciv-manual that was our first tool) Fix attached. Does not add a new strings, but just uses existing one in more places. ___ File Attachments: --- Date: Sat 25 Jan 2014 12:17:42 PM EET Name: UnrecognizedOptions.patch Size: 2kB By: cazfi http://gna.org/bugs/download.php?file_id=19854 --- Date: Sat 25 Jan 2014 12:17:42 PM EET Name: UnrecognizedOptions-S2_5.patch Size: 1kB By: cazfi http://gna.org/bugs/download.php?file_id=19855 --- Date: Sat 25 Jan 2014 12:17:42 PM EET Name: UnrecognizedOptions-S2_4.patch Size: 1kB By: cazfi http://gna.org/bugs/download.php?file_id=19856 ___ Reply to this item at: http://gna.org/bugs/?21538 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21524] Failing asserts from player removal when quitting scenario in pregame.
Update of bug #21524 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21524 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [Freeciv-commits] r24236 - in /branches/S2_5: configure.ac m4/qt-client.m4
On 25 January 2014 13:56, Jacob Nevins 0jacobnk@chiark.greenend.org.uk wrote: (local change accidentally committed, again) Maybe you need to do some coding on your local workflow scripts to prevent these ;-) Sorry I can't help, my workflow is still based on using svn (but incidentally I have been just today been writing first freeciv patch to be categorized as git support, --enable-gitrev, equivalent of --enable-svnrev) - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20521] Government Upkeep_Factor help wrong
Follow-up Comment #7, bug #20521 (project freeciv): Patches for older branches, plus output diffs. Testing ancients ruleset (on S2_5) threw up a couple more changes, but again I'm happy that the result is more accurate. (file #19857, file #19858, file #19859) ___ Additional Item Attachment: File name: S2_5-gov-help-worldbonus-ter.patch Size:31 KB File name: S2_4-gov-help-worldbonus-ter.patch Size:31 KB File name: S2_3-gov-help-worldbonus-ter.patch Size:34 KB ___ Reply to this item at: http://gna.org/bugs/?20521 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20521] Government Upkeep_Factor help wrong
Additional Item Attachment, bug #20521 (project freeciv): File name: S2_5-gov-help-worldbonus-ter-output.diff Size:62 KB File name: S2_4-gov-help-worldbonus-ter-output.diff Size:52 KB File name: S2_3-gov-help-worldbonus-ter-output.diff Size:50 KB ___ Reply to this item at: http://gna.org/bugs/?20521 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4450] Improve some government help strings
Follow-up Comment #2, patch #4450 (project freeciv): Versions for stable branches (file #19863, file #19864) ___ Additional Item Attachment: File name: S2_5-gov-help-text-tweaks.patch Size:11 KB File name: S2_4-gov-help-text-tweaks.patch Size:11 KB ___ Reply to this item at: http://gna.org/patch/?4450 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4445] Specify reason for You can't attack there
Follow-up Comment #2, patch #4445 (project freeciv): Adds several strings, so not going to commit before 2.4.2 unless jtn gives explicit ok. No, let's put this off until after 2.4.2. Other nitpicks: I think this patch is mistakenly using AR_OK (airlift enum) instead of ATT_OK in some places. (No bug because they happen to have the same value.) String polish: You can't attack there since there's unreachable unit.: suggest ... there's *an* unreachable unit. ___ Reply to this item at: http://gna.org/patch/?4445 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4125] Help-About Freeciv should mention mailing lists as point of contact
Follow-up Comment #1, patch #4125 (project freeciv): Currently targeted at 2.4.2, but will likely break string chill. Can you suggest some text? I assume we want to direct people to -maintainers only for things that need to remain vaguely confidential, like security issues? (I'm not getting any direct mail of this kind, so it looks like people really do pick the top address on the list. I'm inclined to make that -dev.) ___ Reply to this item at: http://gna.org/patch/?4125 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2863] AI fails to account for building expenses with gold_upkeep_style=2
Update of patch #2863 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/patch/?2863 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21027] ImageMagick postscript delegate failures
Update of bug #21027 (project freeciv): Planned Release: 2.4.1, 2.5.0, 2.6.0 = 2.5.0, 2.6.0 ___ Follow-up Comment #1: Removing 2.4.x target (it missed 2.4.1, and no patch in sight). ___ Reply to this item at: http://gna.org/bugs/?21027 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20886] Fortresses can be used to take over territory within peaceful neighbour's city radius
Update of bug #20886 (project freeciv): Status: In Progress = None Assigned to: jtn = None Planned Release: 2.3.5,2.4.1,2.5.0,2.6.0 = ___ Follow-up Comment #11: Since this turned out to be a can of worms, removing targets for now, and relinquishing ticket -- someone else feel free to grab it. ___ Reply to this item at: http://gna.org/bugs/?20886 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20872] mapimg font dependency not documented
Update of bug #20872 (project freeciv): Status: Ready For Test = In Progress ___ Reply to this item at: http://gna.org/bugs/?20872 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20772] City dialog unit lists too short vertically if unpopulated, don't grow if a unit is added
Update of bug #20772 (project freeciv): Planned Release:2.4.1, 2.5.0 = ___ Reply to this item at: http://gna.org/bugs/?20772 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7760] Make Gtk3 client usable as default client
URL: http://gna.org/task/?7760 Summary: Make Gtk3 client usable as default client Project: Freeciv Submitted by: jtn Submitted on: Sat Jan 25 13:40:49 2014 Should Start On: Sat Jan 25 00:00:00 2014 Should be Finished on: Sat Jan 25 00:00:00 2014 Category: None Priority: 5 - Normal Status: None Privacy: Public Percent Complete: 0% Assigned to: None Open/Closed: Open Discussion Lock: Any Effort: 0.00 Planned Release: 2.5.0 ___ Details: Metaticket for all issues that might block us making the Gtk3 client the default (in place of Gtk2). Anything from major functionality issues to minor polish -- we should at least consider any regression from the Gtk2 client. ___ Reply to this item at: http://gna.org/task/?7760 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7668] Tracking release 2.5.0
Update of task #7668 (project freeciv): Depends on: = task #7760 ___ Reply to this item at: http://gna.org/task/?7668 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20772] City dialog unit lists too short vertically if unpopulated, don't grow if a unit is added
Update of bug #20772 (project freeciv): Planned Release: = 2.5.0 ___ Reply to this item at: http://gna.org/bugs/?20772 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20598] Something funny with Ready checkboxes in pregame screen
Update of bug #20598 (project freeciv): Planned Release: 2.4.1, 2.5.0, 2.6.0 = 2.5.0, 2.6.0 ___ Reply to this item at: http://gna.org/bugs/?20598 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20624] Goto/Airlift dialog sometimes focuses all cities in turn
Update of bug #20624 (project freeciv): Planned Release:2.4.1, 2.5.0 = 2.5.0 ___ Reply to this item at: http://gna.org/bugs/?20624 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17096] Freeland: assertion 'v1 count v2 count v3 count' failed.
Update of bug #17096 (project freeciv): Planned Release: 2.4.0 = ___ Reply to this item at: http://gna.org/bugs/?17096 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17824] in fill_grid_sprite_array() [tilespec.c::4211]: assertion 't-sprites.player[plrid].grid_borders [pedge-type][1] != NUL
Update of bug #17824 (project freeciv): Planned Release: 2.4.0 = ___ Follow-up Comment #6: Is it possible that this had the same root cause as bug #21384? For that to bite, I think a player would have had to be removed (which is an easy thing to do in the editor). ___ Reply to this item at: http://gna.org/bugs/?17824 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19882] Help browser opening on turn change if help checkbox checked in research dialog
Update of bug #19882 (project freeciv): Category: client-gtk-3.0 = client-gtk-2.0 ___ Reply to this item at: http://gna.org/bugs/?19882 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7760] Make Gtk3 client usable as default client
Update of task #7760 (project freeciv): Depends on: = patch #3379 ___ Reply to this item at: http://gna.org/task/?7760 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20109] Compilation fails with stdinhand on OSX (‘rl_completion_suppress_append’ undeclared)
Update of bug #20109 (project freeciv): Planned Release: 2.3.4,2.4.0,2.5.0 = ___ Follow-up Comment #9: Clearing release targets since I don't think we know how to reproduce or fix. ___ Reply to this item at: http://gna.org/bugs/?20109 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19429] Assertion failures at start with 350x350 isometric map
Update of bug #19429 (project freeciv): Planned Release: 2.3.5,2.4.1,2.5.0,2.6.0 = ___ Follow-up Comment #4: Doubt we're going to get around to untangling this for 2.3.5. ___ Reply to this item at: http://gna.org/bugs/?19429 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7760] Make Gtk3 client usable as default client
Update of task #7760 (project freeciv): Depends on: = task #7681 ___ Reply to this item at: http://gna.org/task/?7760 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21385] gameloss_style=Civil gives new nation two kings
Update of bug #21385 (project freeciv): Status: Fixed = In Progress Open/Closed: Closed = Open Planned Release: 2.6.0 = 2.5.0,2.6.0 ___ Follow-up Comment #2: Wait, why haven't I applied this patch to S2_5? ___ Reply to this item at: http://gna.org/bugs/?21385 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21126] assertion 'prgbcolor != ((void *)0)' failed.
Follow-up Comment #6, bug #21126 (project freeciv): Digging into how I managed to make so many mistakes: I think I made this much worse on S2_5+ in patch #3443 (nation colours); before that (and hence on current S2_4), server_create_player() assigns a colour if passed NULL outside of pregame (so the comment referred to in comment #2 used to be more correct); afterward, it became the caller's responsibility. My mistakes were (a) not updating the comment (b) not checking all callers thoroughly enough (particularly savegame loading). * (Loading many S2_3 games into say S2_5 causes no obvious difficulty, which surprised me. Turns out the colorlessness of players persists indefinitely in the server, but with the default plrcolormode, the client gets the 'virtual' colors from player_get_preferred_color(), so all seems to be well until a save is attempted. Perhaps adding an assertion in package_player_info() based on server state would be a good idea.) Since S2_4 has different invariants, I think any patch for that branch probably needs to be a different shape. I think the bug is less severe there, too -- loading 2.3 savegames is fine, so I think the only issue is in loading then saving a pregame savegame (which is somewhat theoretical)? If so, perhaps we should put this cleanup back to 2.4.3? Also: in the current patch, in sg_save_player_main(), the sense of the Colorless player outside pregame test is wrong (generates errors when saving a valid game). ___ Reply to this item at: http://gna.org/bugs/?21126 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21385] gameloss_style=Civil gives new nation two kings
Update of bug #21385 (project freeciv): Status: In Progress = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21385 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4421] Ignore tautological-compare compiler errors with --enable-debug
Follow-up Comment #4, patch #4421 (project freeciv): Was this option meant to be conditionalised on use of the clang compiler somehow? I've noticed that whenever I get a -Werror build failure from my (GCC 4.6.3) toolchain, I get an additional complaint about this warning option: helpdata.c: In function 'free_help_texts': helpdata.c:120:7: error: unused variable 'x' [-Werror=unused-variable] helpdata.c: At top level: cc1: error: unrecognized command line option -Wno-tautological-compare [-Werror] cc1: all warnings being treated as errors make[3]: *** [helpdata.lo] Error 1 It seems fairly harmless -- it only happens if the build was going to fail anyway -- but slightly confusing. ___ Reply to this item at: http://gna.org/patch/?4421 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21126] assertion 'prgbcolor != ((void *)0)' failed.
Update of bug #21126 (project freeciv): Planned Release: 2.4.2, 2.5.0, 2.6.0 = 2.4.3, 2.5.0, 2.6.0 ___ Follow-up Comment #7: perhaps we should put this cleanup back to 2.4.3 Since you made it clear that it's not obviously correct, we shouldn't risk 2.4.2 with it, true. Even if we deem it more than cleanup (sse below), it's not reggression nor high severity either. I think the only issue is in loading then saving a pregame savegame (which is somewhat theoretical)? Does it really require loading old game first? Isn't there a problem even if one /create a player (maybe even having aifill != 0 suffice?) and then saves in pregame? Use-case for that would be creation of new scenario, one where is no map but all the other settings, including players, set. Updating such a scenario would be use-case for load + save, of course. ___ Reply to this item at: http://gna.org/bugs/?21126 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20533] Missing building gfx for experimental ruleset: Hospital, Genetic Lab
Follow-up Comment #1, bug #20533 (project freeciv): Hospital building from nextended ruleset: http://forum.freeciv.org/f/viewtopic.php?f=14t=196hilit=hospital#p1205 ___ Reply to this item at: http://gna.org/bugs/?20533 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21526] 'make dist' failing due to missing MOCCMD
Follow-up Comment #6, bug #21526 (project freeciv): Could jtn test that this works also in his system as expected (at least with S2_5) I'm guessing slightly at what I'm looking for here... * If configured without any Qt program enabled, build shouldn't fall over just because MOCCMD isn't set ** I reproduced the original problem of this bug in a clean 2.5 checkout and default configure options without this patch ** After applying this patch (file #19844) and retrying the experiment, make dist completed and produced a plausible tarball * If configured with Qt, resulting make dist tarball shouldn't contain any meta_*.cpp? ** With this patch + my current wobbly pile of local Qt4 patches + ./configure --enable-client=qt --enable-fcmp=qt, the resulting tarball didn't contain any meta_* files (it had the same files as the tarball from the previous test) (Only tested S2_5.) ___ Reply to this item at: http://gna.org/bugs/?21526 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4374] Avoid accidentally using Qt 4's moc
Follow-up Comment #11, patch #4374 (project freeciv): My offer to add a version parameter for Qt 4 if needed still stands. I guess that this involves changing m4/qt.m4? I think this will help me at least as long as I'm carrying local patches to build with Qt4, We still have qt.m4 in svn, but currently I think it's not usable -- after this patch my S2_5 Qt4 build (with local patch) fell over looking for a literal @MOCCMD@. Arguably we should either fix qt.m4 or remove it from svn (in which case I'll keep a local copy). FWIW, attached my local Qt4 version of this patch to restore my own ability to build with Qt4; don't know if this is the best way to do it. (file #19865) ___ Additional Item Attachment: File name: qt4-1.patchSize:1 KB ___ Reply to this item at: http://gna.org/patch/?4374 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21539] hex2t mountains/forest/etc poke through darkness
URL: http://gna.org/bugs/?21539 Summary: hex2t mountains/forest/etc poke through darkness Project: Freeciv Submitted by: jtn Submitted on: Sat Jan 25 20:20:41 2014 Category: art Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_4 r24241 Discussion Lock: Any Operating System: Any Planned Release: ___ Details: After the fix for bug #21312, hex2t mountains/forests/jungle have started poking through the darkness at the edge of known territory. See screenshot. Would it be possible to add a solid black wedge to the hex2t darkness sprites outside of the subject tile's hex boundary, so that such protuberances are hidden in darkness? ___ File Attachments: --- Date: Sat Jan 25 20:20:41 2014 Name: hex2t_post_21312_protuberances.png Size: 84kB By: jtn S2_4 r24241, hex2t tileset http://gna.org/bugs/download.php?file_id=19866 ___ Reply to this item at: http://gna.org/bugs/?21539 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21540] debug options do not work as expected
URL: http://gna.org/bugs/?21540 Summary: debug options do not work as expected Project: Freeciv Submitted by: chrisk Submitted on: Sa 25 Jan 2014 21:22:38 CET Category: client-gtk-2.0 Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.4.1 Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Running 2.4.1 release on i386 Debian Squeeze I have compiled with ./configure --enable-debug=yes Now when I % freeciv-gtk2 -d 1 -l gtk2.log and start a new game from there I get a huge logfile with a lot 3: messages. OTOH when I start the server seperately % freeciv-server -d 1 -l server.log % freeciv-gtk2 -d 1 -l client.log and make a very short game I get no logs at all (no files) Christian ___ Reply to this item at: http://gna.org/bugs/?21540 ___ Nachricht gesendet von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21539] hex2t mountains/forest/etc poke through darkness
Follow-up Comment #1, bug #21539 (project freeciv): (Haven't checked if other tilesets are affected.) ___ Reply to this item at: http://gna.org/bugs/?21539 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21540] debug options do not work as expected
Follow-up Comment #1, bug #21540 (project freeciv): Hmm, yes, the debug level of the spawned server is hardcoded at 3 in client_start_server(). ___ Reply to this item at: http://gna.org/bugs/?21540 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21539] hex2t mountains/forest/etc poke through darkness
Follow-up Comment #2, bug #21539 (project freeciv): Ah, that explains the amplio2hexbig problem I have been encountering: http://forum.freeciv.org/f/viewtopic.php?f=12t=205#p1245 To make it clear: it's not that parts of forests have started appearing on unknown tiles (that has always been the case), but that now the darkness edge is drawn on top of it, cutting it to pieces. ___ Reply to this item at: http://gna.org/bugs/?21539 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4453] --enable-gitrev
URL: http://gna.org/patch/?4453 Summary: --enable-gitrev Project: Freeciv Submitted by: cazfi Submitted on: Sun 26 Jan 2014 12:40:51 AM EET Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: Add configure option --enable-gitrev, equivalent to --enable-svnrev. If freeciv sources to be built happen to be in git repository, enabling this option adds commit id to version numbers. This initial version is straightforward copy of --enable-svnrev implementation. As git commit id is rather long string, there's certainly need to adjust this feature in future tickets, not to print full string where it doesn't fit. There's no plan to switch freeciv project to git (freeciv-web part is already in github). This patch exist for two reasons: 1) It opens the option to switch to git in the future. This feature should be in all branches active at the time of the switch to mimimize feature reggression 2) More importantly, many people already use git-svn for freeciv development (not limited to freeciv project itself, but to external projects too). --enable-gitrev feature will be available for them already. It seems to me that there's not much risk in including this to S2_5, but rather makes sure it's not later found out to be needed but not present there. ___ File Attachments: --- Date: Sun 26 Jan 2014 12:40:51 AM EET Name: GitRev.patch Size: 7kB By: cazfi http://gna.org/patch/download.php?file_id=19868 ___ Reply to this item at: http://gna.org/patch/?4453 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4445] Specify reason for You can't attack there
Follow-up Comment #3, patch #4445 (project freeciv): - Fixed the issues jtn found. I originally wrote this using namespace AR_ only to find out that it was already used for airlift and conflict (redefinition) of the very AR_OK. (file #19869) ___ Additional Item Attachment: File name: FailedAttackReason-2.patch Size:11 KB ___ Reply to this item at: http://gna.org/patch/?4445 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19720] Client fails to fork server in next free port when 5556 in use
Follow-up Comment #4, bug #19720 (project freeciv): This was also reported in bug #21530. ___ Reply to this item at: http://gna.org/bugs/?19720 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21530] client cannot start server when a server is still running
Update of bug #21530 (project freeciv): Status:None = Duplicate Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21530 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19720] Client fails to fork server in next free port when 5556 in use
Update of bug #19720 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19720 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21126] assertion 'prgbcolor != ((void *)0)' failed.
Update of bug #21126 (project freeciv): Status: Ready For Test = None Assigned to:None = jtn ___ Follow-up Comment #8: Giving to one who knows the code in question. ___ Reply to this item at: http://gna.org/bugs/?21126 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21534] Unfreed pixbufs from sprite_get_pixbuf()
Update of bug #21534 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21534 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21526] 'make dist' failing due to missing MOCCMD
Update of bug #21526 (project freeciv): Planned Release: 2.5.0-beta1, 2.6.0 = 2.4.2, 2.5.0-beta1, 2.6.0 ___ Follow-up Comment #7: I'm guessing slightly at what I'm looking for here Those seem like satisfactory tests to me. Committing in less than 24h. If not part of your regular release-week procedure, it might be a good idea to test also S2_4 before actual 2.4.2 release. ___ Reply to this item at: http://gna.org/bugs/?21526 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Upcoming releases: 2.3.5 and 2.4.2 -- S2_4 strings frozen
I wrote (22 Jan): We've had a couple of important bug fixes recently, which means it's about time for a new stable release, 2.4.2. [...] S2_4 is not yet in string freeze, and there are still string changes to come. I've not found any urgent pending fixes requiring string changes, and cazfi and I are already acting as if we're in string freeze, so I'm declaring strings frozen on S2_4 until 2.4.2 is released. (Shout if I've missed something.) The translations at http://www.cazfi.net/freeciv/translations/S2_4/ right now look to be up-to-date except for one unimportant string (and lack the latest es/de updates). I don't have a date yet, but it should be soonish. Still no firm release date, but perhaps next weekend or the weekend after? Draft release notes at http://www.freeciv.org/wiki/NEWS-2.4.2. At the same time, I'm minded to do the oldstable 2.3.5 release we've talked about, and then finally close the S2_3 branch. Draft release notes for this are now at http://www.freeciv.org/wiki/NEWS-2.3.5. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21521] Gettext unterminated character constant warnings from nation rulesets
Update of bug #21521 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21521 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21389] Gold looted when conquering city may exceed victim's treasury
Follow-up Comment #6, bug #21389 (project freeciv): as fc_rand(1) always returns zero. Oh right, I just keep on remembering that fc_rand() has unusual interface that it returns from range (1 - max). Maybe I'm just remembering some ancient version? ___ Reply to this item at: http://gna.org/bugs/?21389 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Upcoming releases: 2.3.5 and 2.4.2 -- S2_4 strings frozen
On 26 January 2014 02:26, Jacob Nevins 0jacobnk@chiark.greenend.org.uk wrote: The translations at http://www.cazfi.net/freeciv/translations/S2_4/ right now look to be up-to-date except for one unimportant string (and lack the latest es/de updates). Now updated. I don't have a date yet, but it should be soonish. Still no firm release date, but perhaps next weekend or the weekend after? When you need to know which weekend to reserve for the releasing? At the moment I'd say next weekend is preferred, but that assumes we can get some testing done in time, and without finding any issues. In theory we could get Windows installer fixes tested and, depending on the result, committed, if we waited one more week, but they are not important enough to alone postpone the release. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
