[Freeciv-Dev] [bug #21738] Updated information not sent to clients when lua adds base or road
URL: http://gna.org/bugs/?21738 Summary: Updated information not sent to clients when lua adds base or road Project: Freeciv Submitted by: cazfi Submitted on: Sun 02 Mar 2014 10:43:52 AM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.4.3, 2.5.0, 2.6.0 ___ Details: The only supplied use of tile:create_base() and tile:create_road(), the creation of Ruins when city gets destroyed, has not been affected simply because tile information gets sent later anyway, but usually client does not receive information about bases or roads added with those lua functions. Fix attached ___ File Attachments: --- Date: Sun 02 Mar 2014 10:43:52 AM EET Name: UpdateTileBaseRoadCreation.patch Size: 517B By: cazfi http://gna.org/bugs/download.php?file_id=20231 --- Date: Sun 02 Mar 2014 10:43:52 AM EET Name: UpdateTileBaseRoadCreation-S2_5.patch Size: 519B By: cazfi http://gna.org/bugs/download.php?file_id=20232 --- Date: Sun 02 Mar 2014 10:43:52 AM EET Name: UpdateTileBaseRoadCreation-S2_4.patch Size: 402B By: cazfi http://gna.org/bugs/download.php?file_id=20233 ___ Reply to this item at: http://gna.org/bugs/?21738 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4568] sdl2-client theme
URL: http://gna.org/patch/?4568 Summary: sdl2-client theme Project: Freeciv Submitted by: cazfi Submitted on: Sun 02 Mar 2014 11:04:23 AM EET Category: client-sdl2 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Make copy of sdl-client theme (human) as sdl2-client specific theme. Previously sdl2-client had no themes directory of its own, but was using sdl-client one. As a side effect of this patch, bug that no theme is installed for sdl2-client if sdl-client is not being built too, gets resolved. Before applying the patch itself, one needs to copy data/themes/gui-sdl as data/themese/gui-sdl2. ___ File Attachments: --- Date: Sun 02 Mar 2014 11:04:23 AM EET Name: Sdl2Theme.patch Size: 3kB By: cazfi http://gna.org/patch/download.php?file_id=20234 ___ Reply to this item at: http://gna.org/patch/?4568 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4569] Remove qt.m4
URL: http://gna.org/patch/?4569 Summary: Remove qt.m4 Project: Freeciv Submitted by: cazfi Submitted on: Sun 02 Mar 2014 11:32:35 AM EET Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: Attached patch removes obsolete qt.m4 from tarball. In case of TRUNK I'm about to remove it from version control too. ___ File Attachments: --- Date: Sun 02 Mar 2014 11:32:35 AM EET Name: QtM4Rm.patch Size: 343B By: cazfi http://gna.org/patch/download.php?file_id=20236 ___ Reply to this item at: http://gna.org/patch/?4569 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4570] Link sdl2-client against external libsdl2-gfx
URL: http://gna.org/patch/?4570 Summary: Link sdl2-client against external libsdl2-gfx Project: Freeciv Submitted by: cazfi Submitted on: Sun 02 Mar 2014 12:39:22 PM EET Category: client-sdl2 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Replace having copy of libsdl2-gfx sources in freeciv tree, link sdl2-client against external library. This was not done before as even Debian testing (which I use) had no libsdl2-gfx available, and I saw no point in compiling it myself just so it would be external to freeciv. Now there's suitable package in Debian testing. Is there someone else, who *has all the other sdl2-client requirements* but lack libsdl2-gfx, so that this would prevent the build? (Building it yourself is straightforward, though, so even if we postpone this patch now, I'm not going through any extra trouble to keep it out if there later is some problems with the included sources, which were originally taken from alpha version of libsdl2-gfx) In addition to applying the patch, libsdl2-gfx related source files should be removed from client/gui-sdl2/ (see change of Makefile.am for list of files) ___ File Attachments: --- Date: Sun 02 Mar 2014 12:39:22 PM EET Name: Sdl2Gfx.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=20237 ___ Reply to this item at: http://gna.org/patch/?4570 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4570] Link sdl2-client against external libsdl2-gfx
Follow-up Comment #1, patch #4570 (project freeciv): Is there someone else, who *has all the other sdl2-client equirements* but lack libsdl2-gfx [...]? Data point: it looks like the next Ubuntu LTS, 14.10 (Trusty), will have a version of libsdl2-gfx. So this change should be OK wrt that. (I expect to upgrade to that and stay on it for a while.) ___ Reply to this item at: http://gna.org/patch/?4570 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21741] Temporary client hands when sound enabled
URL: http://gna.org/bugs/?21741 Summary: Temporary client hands when sound enabled Project: Freeciv Submitted by: cazfi Submitted on: Sun 02 Mar 2014 01:32:49 PM EET Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Microsoft Windows Planned Release: ___ Details: As long as I have had sound enabled crosser builds, I've got reports that client occasionally does not accept input for a couple of seconds. This only happens when sound plugin sdl is selected, changing client options to use None plugin prevents it. Now I found this comment in audio_sdl.c: /* Sounds don't sound good on Windows unless the buffer size is 4k, * but this seems to cause strange behaviour on other systems, * such as a delay before playing the sound. */ #ifdef WIN32_NATIVE const size_t buf_size = 4096; #else const size_t buf_size = 1024; #endif Maybe the strange behavior ... delay before playing the sound. applies to Windows too (at least crosser based builds). At worst this is choice between two bugs, at best crosser based builds could use 1k buffer size like most systems. ___ Reply to this item at: http://gna.org/bugs/?21741 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21741] Temporary client hangs when sound enabled
Update of bug #21741 (project freeciv): Summary: Temporary client hands when sound enabled = Temporary client hangs when sound enabled ___ Reply to this item at: http://gna.org/bugs/?21741 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [Freeciv-i18n] Speculation about renaming the freeciv project
Main project name will not be changed, but Paths will be assumed as secondary name for Freeciv version 3: Freeciv-3: Paths - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4181] Clean up: Make player_spaceship-structure a bitvector
Update of patch #4181 (project freeciv): Status:Done = Ready For Test Open/Closed: Closed = Open Planned Release: 2.6.0 = 2.6.0, 2.5.0 ___ Follow-up Comment #5: 2.5 version. AI won spaceship victory in auto game. (file #20238) ___ Additional Item Attachment: File name: 2.5_space_bitvector.patch Size:19 KB ___ Reply to this item at: http://gna.org/patch/?4181 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4562] Soundtrack 0.1
Follow-up Comment #2, patch #4562 (project freeciv): I can't attach the ogg files. They are too big :( If you can't make them otherwise available anywhere, could you sent them to me via email and I'll make them available somehow. ___ Reply to this item at: http://gna.org/patch/?4562 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4181] Clean up: Make player_spaceship-structure a bitvector
Follow-up Comment #6, patch #4181 (project freeciv): I consider back porting this to 2.5 before the network protocol freeze. Please update relevant tasks to depend on this kind of tickets in the future. ___ Reply to this item at: http://gna.org/patch/?4181 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7670] S2_5 network protocol freeze
Follow-up Comment #5, task #7670 (project freeciv): In IRQ bobody had anything to say about my comment: I don't see any pressing need to freeze S2_5 network protocol long before first beta. So maybe we should set date for beta1 first, and then set network protocol freeze date based on that, something like two weeks earlier. I'm the one doing protocol freeze, but jtn is the one making beta1 release, so now it's mostly his business to tell when beta1 could be expected (unless he wants bureaucracy to go so that he does not commit to anything before I've handed branch to him after protocol freeze) ___ Reply to this item at: http://gna.org/task/?7670 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4571] Mention what actions a government makes you immune to in its auto generated help text
Update of patch #4571 (project freeciv): Depends on: = patch #4558 ___ Reply to this item at: http://gna.org/patch/?4571 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4572] Replace Unbribable_Units and No_Incite in the experimental ruleset
URL: http://gna.org/patch/?4572 Summary: Replace Unbribable_Units and No_Incite in the experimental ruleset Project: Freeciv Submitted by: sveinung Submitted on: Sun 02 Mar 2014 07:32:49 PM UTC Category: rulesets Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Some code that get information from the Unbribable_Units and No_Incite effects still can't get the same information from the corresponding action enablers. Having a rule set that use action enablers in stead of the above mentioned effects makes it easier to test action enablers gaining the same support as the effects has. Adding the requirements of the effects to the action enablers without deleting the effects will cause a double consequence in code that support both. The experimental rule set is meant for situations like this. Make the experimental rule set use not present action target requirements in stead of the effects Unbribable_Units and No_Incite. ___ File Attachments: --- Date: Sun 02 Mar 2014 07:32:49 PM UTC Name: 0004-Use-not-present-action-target-requirements-in-stead-.patch Size: 2kB By: sveinung http://gna.org/patch/download.php?file_id=20240 ___ Reply to this item at: http://gna.org/patch/?4572 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4572] Replace Unbribable_Units and No_Incite in the experimental ruleset
Follow-up Comment #1, patch #4572 (project freeciv): Are the effect types going to be completely removed as obsolete at some point, or will there always be some case where ruleset needs to use them instead of action enablers? ___ Reply to this item at: http://gna.org/patch/?4572 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4562] Soundtrack 0.1
Follow-up Comment #3, patch #4562 (project freeciv): Alright, I managed to upload them in my webspace but these are only temporary links: http://4mq.org/mqtx/mqtx-freeciv-music_all_game01.ogg http://4mq.org/mqtx/mqtx-freeciv-music_start-menu.ogg (when I upload new tracks, I will delete these) ___ Reply to this item at: http://gna.org/patch/?4562 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4542] Music Style
Update of patch #4542 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4545] Music Styles to supplied rulesets
Update of patch #4545 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #1: Attached patch implements musicstyles equivalent to citystyles to all supplied rulesets. If nothing better gets proposed, we have to go with this. (file #20241) ___ Additional Item Attachment: File name: MusicStyleSetup-2.patchSize:15 KB ___ Reply to this item at: http://gna.org/patch/?4545 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4573] Music by mood
URL: http://gna.org/patch/?4573 Summary: Music by mood Project: Freeciv Submitted by: cazfi Submitted on: Sun 02 Mar 2014 10:48:24 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Play music specific to nation mood. ___ File Attachments: --- Date: Sun 02 Mar 2014 10:48:24 PM EET Name: MoodPlay.patch Size: 3kB By: cazfi http://gna.org/patch/download.php?file_id=20242 ___ Reply to this item at: http://gna.org/patch/?4573 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4572] Replace Unbribable_Units and No_Incite in the experimental ruleset
Follow-up Comment #2, patch #4572 (project freeciv): Are the effect types going to be completely removed as obsolete at some point, or will there always be some case where ruleset needs to use them instead of action enablers? I hope to remove them completely. Benefits of removing them includes that the Freeciv C code becomes simpler and that the rule set format avoids surprises for rule set authors that don't have the effects in mind. The costs of removing them includes that many action enablers must be used to express rules that today can be expressed in a single effect. (Example: Democracy AND Radio = Unbribable) I don't know any rule set with something like that. The bundled rule sets will go in the opposite direction: One action enabler can replace more than one effect. If the effects can't be removed it still makes sense to replace the effects with action enablers in the bundled rule sets when all functionality of the effects also exist for the action enablers. That will let them benefit from the action enabler work. ___ Reply to this item at: http://gna.org/patch/?4572 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4574] Modpack type Musicset
URL: http://gna.org/patch/?4574 Summary: Modpack type Musicset Project: Freeciv Submitted by: cazfi Submitted on: Sun 02 Mar 2014 10:54:02 PM EET Category: module installer Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Add modpack type Musicset ___ File Attachments: --- Date: Sun 02 Mar 2014 10:54:02 PM EET Name: fcmpMusicset.patch Size: 514B By: cazfi http://gna.org/patch/download.php?file_id=20243 ___ Reply to this item at: http://gna.org/patch/?4574 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4487] [Metaticket] Music switching system
Update of patch #4487 (project freeciv): Depends on: = patch #4574 ___ Reply to this item at: http://gna.org/patch/?4487 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4487] [Metaticket] Music switching system
Update of patch #4487 (project freeciv): Depends on: = patch #4573 ___ Reply to this item at: http://gna.org/patch/?4487 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4487] [Metaticket] Music switching system
Update of patch #4487 (project freeciv): Depends on: = patch #4575 ___ Reply to this item at: http://gna.org/patch/?4487 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4575] Rename music_start as music_menu
URL: http://gna.org/patch/?4575 Summary: Rename music_start as music_menu Project: Freeciv Submitted by: cazfi Submitted on: Sun 02 Mar 2014 10:57:28 PM EET Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: ___ File Attachments: --- Date: Sun 02 Mar 2014 10:57:29 PM EET Name: MusicMenu.patch Size: 1013B By: cazfi http://gna.org/patch/download.php?file_id=20244 ___ Reply to this item at: http://gna.org/patch/?4575 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21742] advdata: Governments gets the bonus from all the governments above it
URL: http://gna.org/bugs/?21742 Summary: advdata: Governments gets the bonus from all the governments above it Project: Freeciv Submitted by: sveinung Submitted on: Sun 02 Mar 2014 09:31:31 PM UTC Category: ai Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: sveinung Originator Email: Open/Closed: Open Release: 2.6.0, 2.5.0, 2.4.2 Discussion Lock: Any Operating System: None Planned Release: 2.6.0, 2.5.0, 2.4.3 ___ Details: When done evaluating what bonus a government gets it isn't reset. This makes governments inherit the bonus of all the governments above it in the list. ___ File Attachments: --- Date: Sun 02 Mar 2014 09:31:31 PM UTC Name: 0005-advdata-Reset-bonus-when-checking-the-next-governmen.patch Size: 1kB By: sveinung http://gna.org/bugs/download.php?file_id=20245 ___ Reply to this item at: http://gna.org/bugs/?21742 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21743] Typing ^D at server prompt prevents all input
URL: http://gna.org/bugs/?21743 Summary: Typing ^D at server prompt prevents all input Project: Freeciv Submitted by: jtn Submitted on: Sun 02 Mar 2014 23:43:43 UTC Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Press Ctrl-D at a server prompt and you get Server cannot read standard input. Ignoring input. and can no longer enter anything. This does not seem like a useful thing to do. This has just wedged a Longturn game, which is now stuck waiting for a timed save before the situation can be rectified. (This is distinct from bug #18254, which alleges the same thing can happen even without ^D.) ___ Reply to this item at: http://gna.org/bugs/?21743 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4571] Mention what actions a government makes you immune to in its auto generated help text
Follow-up Comment #1, patch #4571 (project freeciv): New version: * Add a function that test if a government makes a player immune to an action to common/government.[c|h] since it is needed elsewhere. * Use it in stead of patch #4558 to make sure the above mention function is tested. Should a test if a government type fulfills a requirement vector be needed later it can be extracted from version 1 of this patch. (file #20246) ___ Additional Item Attachment: File name: 0005-Mention-what-actions-a-government-makes-you-immune-t.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?4571 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4571] Mention what actions a government makes you immune to in its auto generated help text
Update of patch #4571 (project freeciv): Dependency Removed: = patch #4558 ___ Reply to this item at: http://gna.org/patch/?4571 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18254] Server ignores input when run in screen
Follow-up Comment #5, bug #18254 (project freeciv): I've only been able to provoke this message by typing Ctrl-D at the server prompt. ...on reflection, we should fix that. Bug #21743. Maybe a fix will also fix some of the stuff reported here. ___ Reply to this item at: http://gna.org/bugs/?18254 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4576] advdata: Government bonus for not present target req on the actions bribe and incite
URL: http://gna.org/patch/?4576 Summary: advdata: Government bonus for not present target req on the actions bribe and incite Project: Freeciv Submitted by: sveinung Submitted on: Sun 02 Mar 2014 11:59:45 PM UTC Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Give the same bonus to governments for not present target requirement on the actions bribe and incite as the effects doing the same gets. ___ Reply to this item at: http://gna.org/patch/?4576 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4576] advdata: Government bonus for not present target req on the actions bribe and incite
Additional Item Attachment, patch #4576 (project freeciv): File name: 0006-advdata-Government-bonus-for-not-present-target-req-.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?4576 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4576] advdata: Government bonus for not present target req on the actions bribe and incite
Update of patch #4576 (project freeciv): Depends on: = patch #4571 ___ Reply to this item at: http://gna.org/patch/?4576 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3743] /delegate tidy-up
Follow-up Comment #9, patch #3743 (project freeciv):
The current implementation of delegations is case-sensitive with regard to
usernames. That is, if user A delegates his nation to user B, b wouldn't
be able to take the delegation from A.
In Greatturn, games last for months and usernames can be somewhat long and
complicated; sometimes users log-in typing their nicks w/o paying attention to
case, and then they wonder why delegations stop working.
AFAIK, the whole structure of Freeciv is built to be case insensitive for
usernames, so this patch, which comes from Longturn, is somewhat inconsistent.
Moreover, Longturn solves this issue - for its sole benefit - by using the
following custom code to internally handle delegations in interactions with
DB:
SELECT delegation FROM auth_user AS u
JOIN game_joined j ON (u.id = j.user_id)
JOIN player_player p ON p.id = j.user_id
WHERE lower(username) = lower('$USER') AND game_id = '$GAMENAME';
I think this patch should be made consistent with the rest of Freeciv, by
treating usernames case-insensitively.
___
Reply to this item at:
http://gna.org/patch/?3743
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3743] /delegate tidy-up
Follow-up Comment #10, patch #3743 (project freeciv): Sounds reasonable without looking in detail; please raise a new ticket for it (this one has been closed for a year, so we'll just lose the comment otherwise). ___ Reply to this item at: http://gna.org/patch/?3743 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21744] Delegation is case-sensitive for username
URL:
http://gna.org/bugs/?21744
Summary: Delegation is case-sensitive for username
Project: Freeciv
Submitted by: davide_at_debian
Submitted on: Mon 03 Mar 2014 12:51:22 AM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.4.2
Discussion Lock: Any
Operating System: Any
Planned Release:
___
Details:
The current implementation of delegations is case-sensitive with regard to
usernames. That is, if user A delegates his nation to user B, b wouldn't
be able to take the delegation from A.
In Greatturn, games last for months and usernames can be somewhat long and
complicated; sometimes users log-in typing their nicks w/o paying attention to
case, and then they wonder why delegations stop working.
AFAIK, the whole structure of Freeciv is built to be case insensitive for
usernames, so this patch, which comes from Longturn, is somewhat inconsistent.
Moreover, Longturn solves this issue - for its sole benefit - by using the
following custom code to internally handle delegations in interactions with
DB:
SELECT delegation FROM auth_user AS u
JOIN game_joined j ON (u.id = j.user_id)
JOIN player_player p ON p.id = j.user_id
WHERE lower(username) = lower('$USER') AND game_id = '$GAMENAME';
I think this patch should be made consistent with the rest of Freeciv, by
treating usernames case-insensitively.
___
Reply to this item at:
http://gna.org/bugs/?21744
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3743] /delegate tidy-up
Follow-up Comment #11, patch #3743 (project freeciv): For reference, the new ticket is here: https://gna.org/bugs/index.php?21744 ___ Reply to this item at: http://gna.org/patch/?3743 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4571] Mention what actions a government makes you immune to in its auto generated help text
Follow-up Comment #2, patch #4571 (project freeciv): New version: * Make the function live in common/actions in stead of common/government (file #20248) ___ Additional Item Attachment: File name: 0005-Mention-what-actions-a-government-makes-you-immune-t.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?4571 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18254] Server ignores input when run in screen
Follow-up Comment #6, bug #18254 (project freeciv): This message always appears to me anytime I enter a blank line in console. I first noticed this with 2.3.0, progressively up to the current 2.4.2. I don't know for releases before 2.3.0. I never got in touch with a build not affected by this bug. Debian 5 and 6; no Screen, only bg Bash process or nohup. ___ Reply to this item at: http://gna.org/bugs/?18254 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4576] advdata: Government bonus for not present target req on the actions bribe and incite
Follow-up Comment #1, patch #4576 (project freeciv): Update patch to apply on top of the new version of patch #4571 (file #20249) ___ Additional Item Attachment: File name: 0006-advdata-Government-bonus-for-not-present-target-req-.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?4576 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4557] Help generator: optimize unit_type_fulfills_requirement()
Follow-up Comment #1, patch #4557 (project freeciv): The patch I believed I had uploaded when I filed this. (file #20250) ___ Additional Item Attachment: File name: 0001-Optimalize-unit_type_fulfills_requirement.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?4557 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
