[Freeciv-Dev] [patch #6945] Fracture map generator (2.91) + Resource Clustering

2016-02-09 Thread mir3x 
Follow-up Comment #1, patch #6945 (project freeciv):

Hi.
You need format code properly.
Everyhting is descibed here:
http://freeciv.wikia.com/wiki/Coding_Style

Shortly what u missed:
- tabs to spaces
- max line length - 77
- always add brackets to if {} else {}, for{} .. etc ..

Overall you can quickly make such code by setting formatting to:
- Indention - spaces - 2 
- Indent - labels
- Brackets type - Linux
- Pad parenthesis - unpad
- Add spaces after parenthesis headers
- Add spaces around operators
- Pointer alignment - name

After applying such format you will need fix only xxx_iterate_end line.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6947] Log level by name

2016-02-09 Thread Marko Lindqvist 
URL:
  

 Summary: Log level by name
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 10 Feb 2016 08:05:31 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Log level can be given by name to '--debug'. Any (over zero) length
abbreviation is accepted.

--debug normal
--debug err




___

File Attachments:


---
Date: Wed 10 Feb 2016 08:05:32 AM EET  Name: LogLevelNames.patch  Size: 4kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6946] Keep action decision data until taken

2016-02-09 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Keep action decision data until taken
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 10 Feb 2016 03:15:48 AM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

The fact that an action decision dialog is open doesn't guarantee that the
player will have a chance to respond. His network connection may go down. An
admin may save the game and later restart it from that save game.

Changes network protocol.



___

File Attachments:


---
Date: Wed 10 Feb 2016 03:15:48 AM UTC  Name:
3.0-Keep-action-decision-data-until-taken.patch  Size: 5kB   By: sveinung


---
Date: Wed 10 Feb 2016 03:15:48 AM UTC  Name:
2.6-Keep-action-decision-data-until-taken.patch  Size: 4kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24389] Climate moderation at coasts not working as intended

2016-02-09 Thread Jacob Nevins 
Follow-up Comment #3, bug #24389 (project freeciv):

(patch now available at patch #6944)

1. Sure, but the reason I hesitated is that this code has never been in use,
so should be treated like new code; i.e. we should check if it gives a
sensible result before fixing the bug. (I haven't tried it and seen what the
resulting maps look like.)
Also I wasn't sure how it would interact with my sea ice stuff (now taking
shape in patch #6921).

2. (procedural) It's OK (indeed, preferred) to submit patches for bugs under
the bug ticket (this one); you don't need to create a separate patch ticket
for the fix. We use Gna's "bug" and "patch" tickets approximately for "bugs"
and "features", and .patch files go under both. All revisions of a patch go
under the same ticket until it's finally committed.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6920] Add terrain flag "Frozen", and use it to colour minimap

2016-02-09 Thread Jacob Nevins 
Update of patch #6920 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6918] Map generator: use multiple lake terrains more sensibly

2016-02-09 Thread Jacob Nevins 
Update of patch #6918 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6917] Make near_singularity() have less fierce effects on map generation

2016-02-09 Thread Jacob Nevins 
Update of patch #6917 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6945] Fracture map generator (2.91) + Resource Clustering

2016-02-09 Thread Robert Finch 
URL:
  

 Summary: Fracture map generator (2.91) + Resource Clustering
 Project: Freeciv
Submitted by: robfinch
Submitted on: Tue 09 Feb 2016 11:08:15 PM UTC
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Slightly improved map generation to back the hills / mountains off the shore.
Resource clustering similar to Civ3 is in progress. This patch adds a field to
the extra packet to contain the clustering chance. This chance may be added to
the terrain ruleset. Both the client and server need to be made compatible for
this patch.



___

File Attachments:


---
Date: Tue 09 Feb 2016 11:08:15 PM UTC  Name: fc_rfinch_02.patch  Size: 27kB  
By: robfinch



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6944] Moderating Temperature fix re: issue 24389

2016-02-09 Thread Robert Finch 
URL:
  

 Summary: Moderating Temperature fix re: issue 24389
 Project: Freeciv
Submitted by: robfinch
Submitted on: Tue 09 Feb 2016 10:49:43 PM UTC
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

This is a patch that affects the temperature moderation near oceans.
Previously the temperature moderation was returning 0 or 1 rather than degrees
as a fraction.



___

File Attachments:


---
Date: Tue 09 Feb 2016 10:49:43 PM UTC  Name: fc_rfinch_10.patch  Size: 733B  
By: robfinch



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6943] Explicitle enable ruledit in Ruledit Installer configure

2016-02-09 Thread Marko Lindqvist 
URL:
  

 Summary: Explicitle enable ruledit in Ruledit Installer
configure
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 11:52:26 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Explicitly --enable-ruledit when running configure for Ruledit Installer
package build. That way failure to find dependencies or any other failure to
enable ruledit build causes hard failure in configure step already, and not
only packaging problems when trying to put ruledit to the installer.

Patch makes this to both msys1 and msys2 Installer environments.



___

File Attachments:


---
Date: Tue 09 Feb 2016 11:52:26 PM EET  Name: ExplicitRuleditEnablement.patch 
Size: 1kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6916] Method for internal lua code to signal use of deprecated signals

2016-02-09 Thread Marko Lindqvist 
Update of patch #6916 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #2:

Should be ported to use deprecations module from patch #6942.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6730] [Metaticket] Optional deprecation warnings

2016-02-09 Thread Marko Lindqvist 
Update of patch #6730 (project freeciv):

  Depends on: => patch #6942


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6730] [Metaticket] Optional deprecation warnings

2016-02-09 Thread Marko Lindqvist 
Update of patch #6730 (project freeciv):

 Summary: [Metaticket] Optional (lua) deprecation warnings =>
[Metaticket] Optional deprecation warnings


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6942] deprecations.[ch]

2016-02-09 Thread Marko Lindqvist 
URL:
  

 Summary: deprecations.[ch]
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 11:10:21 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

This is initial patch to add deprecations.[ch] module.

- Add deprecations.[ch] module
- Add command-line option "--warnings" on server (only) to enable reporting of
deprecated modpack constructs
- Ruleset use of effetct.name instead of effect.type is warned about
- Also registry's "unused entry" warnings are now warned as deprecation
warnings if those are enabled. The logic here is that most of such unused
entries are leftovers from format so old that it's all the way obsolete, not
only deprecated




___

File Attachments:


---
Date: Tue 09 Feb 2016 11:10:21 PM EET  Name: DeprecationsModule.patch  Size:
8kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] S2_6 Datafileformat freeze (d3f) 09-Mar-16

2016-02-09 Thread Marko Lindqvist 
 We are one month from the date S2_6 d3f is finally supposed to
happen. Please keep that in mind when considering any new changes to
file formats. I still would take in changes fixing problems in current
formats, something that would otherwise be likely to cause us headache
during S2_6 lifetime, which is expected to be exceptionally long.

  Ticket about d3f, with planned changes as dependencies:
http://gna.org/task/?7814

 This freeze is only about file formats, its goal being that people
can start working on custom content knowing that what they create for
then-current revision will be compatible with future 2.6.x releases.
 Network protocol freeze is a separate milestone later on.


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6939] Prefer pkg-config method for finding ImageMagick

2016-02-09 Thread Marko Lindqvist 
Follow-up Comment #2, patch #6939 (project freeciv):

Mapimg is typically saved on server side (no need to have client attached)

> /help mapimg

 Cairo would be a bit heavy requirement (with all the dependencies) to have on
servers just for this, but I wouldn't mind someone implementing saving as png
by using libpng directly.



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6939] Prefer pkg-config method for finding ImageMagick

2016-02-09 Thread mir3x 
Follow-up Comment #1, patch #6939 (project freeciv):

Is ImageMagick used only for saving minimap only?
If yes, I would remove it, cairo or qt can do the same,
also saving minimap is not useful at all.
Better would be to save whole map -
Eg client could stop updating screen, resize map to maximum, then scale and
save it with desired resolution, restore map size, start updating screen
again, the same could be done with minimap. 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6941] Qt client - add default font

2016-02-09 Thread mir3x 
URL:
  

 Summary: Qt client - add default font
 Project: Freeciv
Submitted by: mir3x
Submitted on: Tue 09 Feb 2016 08:07:24 PM CET
Category: client-qt
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6, 3.0

___

Details:

Added default font to qt options, 
which will be used as QApplication::font().
Its added because qt default font is not windows/gnome default font.




___

File Attachments:


---
Date: Tue 09 Feb 2016 08:07:24 PM CET  Name: qt_default_font.patch  Size: 3kB 
 By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [patch #6938] [Metaticket] Get rid of gtkpixcomm

2016-02-09 Thread Vasco Alexandre da Silva Costa 
GtkPixcomm is a widget I ported over from the Xaw client to GTK+. At the
time GTK+'s GtkImage widget had memory leaks and did not include rectangle
drawing routines. Without GtkPixcomm the Freeciv client would increase its
memory resource usage quickly over the course of 30 minutes because of the
memory leaks. You could test this easily by opening a city dialog and
running a game with AIs on auto and took at the memory consumption of the
client with 'top'.

I hope GTK+ upstream fixed those memory leaks. But then again I don't know
which widgets you are using atm.

On Tue, Feb 9, 2016 at 3:08 PM, Marko Lindqvist <
no-reply.invalid-addr...@gna.org> wrote:

> URL:
>   
>
>  Summary: [Metaticket] Get rid of gtkpixcomm
>  Project: Freeciv
> Submitted by: cazfi
> Submitted on: Tue 09 Feb 2016 05:08:45 PM EET
> Category: client-gtk-3.0
> Priority: 5 - Normal
>   Status: None
>  Privacy: Public
>  Assigned to: None
> Originator Email:
>  Open/Closed: Open
>  Discussion Lock: Any
>  Planned Release: 2.6.0, 3.0.0
>
> ___
>
> Details:
>
> This has been in my TODO for some time, but with very slow progress.
> Gtkpixcomm is remnant from gtk+-1.2 time. It seems that gtk+ dropped it,
> but
> we kept internal copy and carried it over to gtk+-2, and then to gtk+-3.
> gtk2-client can probably keep on using it to the end (already coming near)
> but
> gtk3- and especially gtk3x-client should switch to supported solutions.
>
> There's know breakaga at the moment: msys2 mingw64 version of gtk3-client
> does
> not build because of problems in gtkpixcomm. For a quick resolution (to get
> something working on msys2 win64) for that one we probably still need to
> make
> fix to gtkpixcomm, though we should get rid of gtkpixcomm soon anyway.
>
>
>
>
> ___
>
> Reply to this item at:
>
>   
>
> ___
>   Message sent via/by Gna!
>   http://gna.org/
>
>
> ___
> Freeciv-dev mailing list
> Freeciv-dev@gna.org
> https://mail.gna.org/listinfo/freeciv-dev
>



-- 
Vasco Alexandre da Silva Costa
PhD in Computer Engineering (Computer Graphics)
Instituto Superior Técnico/University of Lisbon, Portugal
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24393] civ1 and civ2 doesn't document action required utype fields

2016-02-09 Thread Sveinung Kvilhaugsvik 
Update of bug #24393 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24392] No paradrop while transporting isn't enforeced

2016-02-09 Thread Sveinung Kvilhaugsvik 
Update of bug #24392 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24391] C-formated string haven't enough following parameters

2016-02-09 Thread Marko Lindqvist 
Update of bug #24391 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6924] rulesets: remove blank line inside Paratroopers

2016-02-09 Thread Sveinung Kvilhaugsvik 
Update of patch #6924 (project freeciv):

 Planned Release:   3.0.0 => 3.0.0, 2.6.0, 2.5.4

___

Follow-up Comment #2:

I forgot to target 2.6 and 2.5. Patch already attached.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6923] Hard action reqs: improve sees tile readability

2016-02-09 Thread Sveinung Kvilhaugsvik 
Update of patch #6923 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6926] Long range actions don't work in orders

2016-02-09 Thread Sveinung Kvilhaugsvik 
Update of patch #6926 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24391] C-formated string haven't enough following parameters

2016-02-09 Thread Konstantin Vedeneev 
Follow-up Comment #2, bug #24391 (project freeciv):

Ok, I see the logic.

Trying to be more informative:

(file #26673)
___

Additional Item Attachment:

File name: SrvEdit2.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24396] Qt client - some menu issues

2016-02-09 Thread mir3x 
URL:
  

 Summary: Qt client - some menu issues
 Project: Freeciv
Submitted by: mir3x
Submitted on: Tue 09 Feb 2016 04:48:13 PM CET
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.4, 2.6, 3.0

___

Details:

Renamed Auto Settler to Auto Worker - for non settlers units.
Fixed "go and build city" enabled for workers.
Fixed "revolution" enabled  for observers.
Fixed "tax rates" enabled  for observers.






___

File Attachments:


---
Date: Tue 09 Feb 2016 04:48:13 PM CET  Name: qt_menu_issues.patch  Size: 3kB  
By: mir3x


---
Date: Tue 09 Feb 2016 04:48:13 PM CET  Name: qt_menu_issues-ftrunk.patch 
Size: 3kB   By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6940] Merge ai.love to rest of ai table in europe_1901 scenario

2016-02-09 Thread Marko Lindqvist 
URL:
  

 Summary: Merge ai.love to rest of ai table in europe_1901
scenario
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 05:34:40 PM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

europe_1901 scenario has ai.love column (for each player) separate from rest
of the ai table. This is property of savegames created from 2.5, but it's just
formatting issue and not requirement of the format. S2_6 writes ai.love column
merged to rest of the table.

Attached patch merges the column (keeping everything in 2.5 format). This is
mainly meant for reducing the delta when comparing scenario in 2.5 format and
one converted to 2.6 format.



___

File Attachments:


---
Date: Tue 09 Feb 2016 05:34:40 PM EET  Name: Europe1901Love.patch.bz2  Size:
906B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7963] Tracking release 2.6.0-beta1

2016-02-09 Thread Marko Lindqvist 
Update of task #7963 (project freeciv):

  Depends on: => patch #6939


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6939] Prefer pkg-config method for finding ImageMagick

2016-02-09 Thread Marko Lindqvist 
URL:
  

 Summary: Prefer pkg-config method for finding ImageMagick
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 05:22:22 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

During S2_5 lifetime we have added search for ImageMagick to fallback to using
pkg-config if it can't be found otherwise. In a branch that had already
released it made sense to have it that way to avoid regressions in any system
where the Wand-config method should be used.
Project specific scripts like Wand-config cause all kind of problems on
building cross-compiling setups. With pkg-config most of them have been
resolved to some extend, and at least it creates just one point where to
resolve the problem for all packages. Thus I'd prefer pkg-config over
Wand-config for getting ImageMagick flags in S2_6.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6938] [Metaticket] Get rid of gtkpixcomm

2016-02-09 Thread Marko Lindqvist 
URL:
  

 Summary: [Metaticket] Get rid of gtkpixcomm
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 05:08:45 PM EET
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

This has been in my TODO for some time, but with very slow progress.
Gtkpixcomm is remnant from gtk+-1.2 time. It seems that gtk+ dropped it, but
we kept internal copy and carried it over to gtk+-2, and then to gtk+-3.
gtk2-client can probably keep on using it to the end (already coming near) but
gtk3- and especially gtk3x-client should switch to supported solutions.

There's know breakaga at the moment: msys2 mingw64 version of gtk3-client does
not build because of problems in gtkpixcomm. For a quick resolution (to get
something working on msys2 win64) for that one we probably still need to make
fix to gtkpixcomm, though we should get rid of gtkpixcomm soon anyway.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24380] Qt client - menu shortcuts active when in chat window.

2016-02-09 Thread mir3x 
Update of bug #24380 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7963] Tracking release 2.6.0-beta1

2016-02-09 Thread Marko Lindqvist 
Update of task #7963 (project freeciv):

  Depends on: => patch #6422


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6422] AI Module capstr for S2_6

2016-02-09 Thread Marko Lindqvist 
Update of patch #6422 (project freeciv):

  Status:  Ready For Test => In Progress
  Depends on: => patch #6937


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6937] Reserved AI callback slots

2016-02-09 Thread Marko Lindqvist 
URL:
  

 Summary: Reserved AI callback slots
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 04:14:30 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Reserve some AI callback slots so optional callbacks can later be added
without need to break module compatibility.



___

File Attachments:


---
Date: Tue 09 Feb 2016 04:14:30 PM EET  Name: ReservedAiCallbacks.patch  Size:
2kB   By: cazfi


---
Date: Tue 09 Feb 2016 04:14:30 PM EET  Name: ReservedAiCallbacks-S2_6.patch 
Size: 2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6936] Search jansson with pkg-config

2016-02-09 Thread Marko Lindqvist 
URL:
  

 Summary: Search jansson with pkg-config
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 09 Feb 2016 04:07:13 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Search jansson with pkg-config. Old search method is still used as fallback.



___

File Attachments:


---
Date: Tue 09 Feb 2016 04:07:13 PM EET  Name: JanssonPkgConfig.patch  Size: 2kB
  By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5650] Clean up rulesets protecting against multiple Barracks

2016-02-09 Thread Marko Lindqvist 
Update of patch #5650 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6914] Radiobutton to automate the usual rule_name -> display name update

2016-02-09 Thread Marko Lindqvist 
Update of patch #6914 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6931] Configure check for pathless SDL includes

2016-02-09 Thread Marko Lindqvist 
Follow-up Comment #1, patch #6931 (project freeciv):

- Name the macro as SDL2_PLAIN_INCLUDES to better prepare for the future
possibility that one version of SDL requires pathless includes and another
version accepts path.

(file #2)
___

Additional Item Attachment:

File name: SdlPlainInclude-2.patchSize:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6922] Shadow warning fixes (from OpenBSD build)

2016-02-09 Thread Marko Lindqvist 
Update of patch #6922 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6329] pf_normal_map_iterate() optimization

2016-02-09 Thread pepeto 
Follow-up Comment #2, patch #6329 (project freeciv):

This is due to patch #5201. Using right values for AI calculations is slow...
I never could find a better solution for reversed (a real one). If someone
does, I would be interested to know how it works!


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6913] Caravan destination search to not iterate cities of no-go players at all

2016-02-09 Thread Marko Lindqvist 
Update of patch #6913 (project freeciv):

 Planned Release: 2.5.4, 2.6.0, 3.0.0 => 2.6.0, 3.0.0   

___

Follow-up Comment #2:

> I'm going to run some performance tests on this to see if there's enough
benefit to justify risks of regressions

No measurable (too much noise, from the fact that not everything on the used
computer was identical between runs, compared to signal) gains.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24391] C-formated string haven't enough following parameters

2016-02-09 Thread Marko Lindqvist 
Update of bug #24391 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #1:

It shouldn't be research_name (you should already know what team you are part
of) but name of the player who got the tech for the team.

Will you make an updated patch?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev