[Freeciv-Dev] [patch #6960] Save player sex by name to savegame3 saves

2016-02-18 Thread Marko Lindqvist 
Update of patch #6960 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6978] Add log.deprecation_warning() calls

2016-02-18 Thread Marko Lindqvist 
URL:
  

 Summary: Add log.deprecation_warning() calls
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 19 Feb 2016 09:05:17 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:





___

File Attachments:


---
Date: Fri 19 Feb 2016 09:05:17 AM EET  Name: LuaDeprWarns.patch  Size: 5kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6977] Create Ruins with Tile:create_extra()

2016-02-18 Thread Marko Lindqvist 
URL:
  

 Summary: Create Ruins with Tile:create_extra()
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 19 Feb 2016 08:46:04 AM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Many supplied rulesets create Ruins with deprecated Tile:create_base(). Make
them to use Tile:create_extra() instead.



___

File Attachments:


---
Date: Fri 19 Feb 2016 08:46:04 AM EET  Name: CreateRuinsAsExtra.patch  Size:
2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6916] Method for internal lua code to signal use of deprecated signals

2016-02-18 Thread Marko Lindqvist 
Update of patch #6916 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24409] Ruledit not handling string-from-a-file secfile format well

2016-02-18 Thread Marko Lindqvist 
Update of bug #24409 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6976] 'buildable-win32' and 'buildable-win64' make targets to msys2 Installer makefile

2016-02-18 Thread Marko Lindqvist 
URL:
  

 Summary: 'buildable-win32' and 'buildable-win64' make targets
to msys2 Installer makefile
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 18 Feb 2016 09:37:11 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Most of the the msys2 installer packets have not yet reached buildable state,
making target 'all' to fail. Consequtively, target 'snaphost' using 'all'
fails. Running the individual working targets work, but there's some
functionality in 'make snapshot' (svn revision in version number) that would
be nice to have without too much setup work in the terminal.
Attached patch adds targets 'buildable-win32' and 'buildable-win64' that
depend on installer targets already building without failure (we're only
worried about build aborting due to failure here, so those installers that
fail on lauch but do build are included). 'make snapshot' is changed to use
those targets instead of 'all'



___

File Attachments:


---
Date: Thu 18 Feb 2016 09:37:11 PM EET  Name: BuildableTargets.patch  Size:
836B   By: cazfi


---
Date: Thu 18 Feb 2016 09:37:11 PM EET  Name: BuildableTargets-S2_6.patch 
Size: 832B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6975] Add new UnitState test "Transporting"

2016-02-18 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Add new UnitState test "Transporting"
 Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 18 Feb 2016 04:55:22 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

It checks if the unit has cargo.

Remember to update the network capstring.



___

File Attachments:


---
Date: Thu 18 Feb 2016 04:55:22 PM UTC  Name:
0002-Add-new-UnitState-test-Transporting.patch  Size: 7kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24430] freeciv-web uses civ2civ3 tutorial scenario with fcweb ruleset

2016-02-18 Thread Andreas Røsdal 
Follow-up Comment #1, bug #24430 (project freeciv):

Good observation. How do you suggest we fix this? 

At some point it would be nice if Freeciv-web supported the same rulesets as
Freeciv. 

Perhaps in the short-term, then both Freeciv-web and Freeciv should use
civ2civ3 as default?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24430] freeciv-web uses civ2civ3 tutorial scenario with fcweb ruleset

2016-02-18 Thread Marko Lindqvist 
URL:
  

 Summary: freeciv-web uses civ2civ3 tutorial scenario with
fcweb ruleset
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 18 Feb 2016 05:51:07 PM EET
Category: freeciv-web
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Tutorial scenario is about behavior of default (civ2civ3 in TRUNK) ruleset. As
freeciv-web just forces it to use fcweb (based on classic) ruleset, tutorial
messages are telling a whole different story from what the rules in ues
actually are.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6957] Unit class user flags

2016-02-18 Thread Sveinung Kvilhaugsvik 
Update of patch #6957 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Assigned to:None => sveinung   
 Planned Release: => 3.0.0  

___

Additional Item Attachment:

File name: 0001-Introduce-unit-type-class-user-flags-support.patch Size:18 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6956] SDL2: dialog closed -> action decision taken

2016-02-18 Thread Sveinung Kvilhaugsvik 
Additional Item Attachment, patch #6956 (project freeciv):

File name: 2.6-SDL-dialog-closed-action-decision-taken.patch Size:26 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6945] Fracture map generator (2.91) + Resource Clustering

2016-02-18 Thread Marko Lindqvist 
Follow-up Comment #5, patch #6945 (project freeciv):

> struct terrain *pick_terrain(enum mapgen_terrain_property target,
> + enum mapgen_terrain_property prefer,
> + enum mapgen_terrain_property avoid);

> How about terrain.h for the above ?

Assuming the naming of 'enum mapgen_...' is not misleading (and should be
changed too), I rather not add dependency to it outside mapgenerator.
generator/utilities.[ch] seems like proper home for these (no matter that the
module should be renamed to something more mapgenerator-specific in the
future; '#include "utilities.h"' does not look like obvious source of
generator definitions, one is more likely to assume it to have stuff similar
to uitlity/support.h)


> Regarding the macros, I will change it, but a decent compiler
> will optimize the extra instances away via common
> subexpression elimination.

As I said, that was more about static analysis of the macro calls. It also had
something that at least seemed like a function call -> cannot be optimized
away unless there's some guarantee that both calls will give same return value
and that there's no side-effects.

> What about map generators as a shared library? (or separate
> executable) that can be dumped from memory once map generation > is
complete?

We have support for dynamic AI modules. Though that currently has only the
module loading functionality, not unloading side, a lot of the low-level stuff
is there already (I've never even tried to use it on any kind of Windows
builds, though. That's likely to have some challenges)
The relative size of the generators is so small that "custom generator plugin"
support would be much more interesting side of the feature than unloading
supplied generators.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6945] Fracture map generator (2.91) + Resource Clustering

2016-02-18 Thread Robert Finch 
Follow-up Comment #4, patch #6945 (project freeciv):

bool terrain_is_too_flat(struct tile *ptile, 
 + int thill, int my_height); 

This probably belongs in the tile.h file since it takes a tile parameter.
(tile_is_too_flat ?)

struct terrain *pick_terrain(enum mapgen_terrain_property target, 
 + enum mapgen_terrain_property prefer, 
 + enum mapgen_terrain_property avoid); 

How about terrain.h for the above ?

Regarding the macros, I will change it, but a decent compiler will optimize
the extra instances away via common subexpression elimination.

I added a check for <150 players to have clustering enabled, in case the
default isn't reset. It's possible in CivIII to corner the market on a
resource with one or two carefully placed cities and force other players to
negotiate.

Does it use more server resources if the max number of players is left at 150
?

I added a check to bypass the clustering iterations if there aren't any
specified.

What about map generators as a shared library ?(or separate executable) that
can be dumped from memory once map generation is complete ?


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6953] Gtk3x-client msys2 based Installer

2016-02-18 Thread Marko Lindqvist 
Update of patch #6953 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev