[Freeciv-Dev] [bug #24921] After sinking a Transport, a Riflemen unit is left behind in the sea

[Marko Lindqvist]

Update of bug #24921 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7571] universal_value_from_str()

[Marko Lindqvist]

Update of patch #7571 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7588] 'struct timeval' to 'fc_timeval'

[Marko Lindqvist]

URL:
  

 Summary: 'struct timeval' to 'fc_timeval'
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 10 Aug 2016 03:10:21 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.6, 2.6.0, 3.0.0
 Contains string changes: None

___

Details:

Replace couple of fc_select() parameters to be 'fc_timeval' instead of 'struct
timeval'



___

File Attachments:


---
Date: Wed 10 Aug 2016 03:10:21 PM EEST  Name: FcTimevalMore.patch  Size: 594B 
 By: cazfi


---
Date: Wed 10 Aug 2016 03:10:21 PM EEST  Name: FcTimevalMore-S2_6.patch  Size:
582B   By: cazfi


---
Date: Wed 10 Aug 2016 03:10:21 PM EEST  Name: FcTimevalMore-S2_5.patch  Size:
555B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

[mir3x]

Update of bug #24935 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.5.6, 2.6, 3.0
 Contains string changes:None => No 

___

Follow-up Comment #1:

Patch attached

(file #28235, file #28236)
___

Additional Item Attachment:

File name: qt_meta_msg-ftrunk.patch   Size:2 KB
File name: qt_meta_msg.patch  Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24944] Qt client - crash when metaserver is down

[mir3x]

Update of bug #24944 (project freeciv):

  Status:  Ready For Test => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

Fixed in bug #24935

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7570] Reduce want of pile of caravans

[Marko Lindqvist]

Update of patch #7570 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7576] SDL client: act sel dlg paradrop and airlift

[Sveinung Kvilhaugsvik]

Update of patch #7576 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7575] SDL client(s): ask for target for "Do..."

[Sveinung Kvilhaugsvik]

Update of patch #7575 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7572] Support user specified target tile for "Do..."

[Sveinung Kvilhaugsvik]

Update of patch #7572 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

[Louis Moureaux]

Follow-up Comment #3, bug #24942 (project freeciv):

Attached patch uses pkg-config to discover Qt and sets --std=c++11 if needed.
Besides MSVC, I don't know of compilers using other flags. I didn't use
--std=c++0x because it enabled *experimental* C++11 support and is deprecated
in recent GCC.

The moc discovery is left unchanged (there is no pkg-config for it).

For now, only tested with TRUNK on Arch Linux.


(file #28239)
___

Additional Item Attachment:

File name: qt-use-pkg-config.patch.bz2Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7589] Share unithand's action not enabled reason

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Share unithand's action not enabled reason
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 10 Aug 2016 04:07:44 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: No

___

Details:

Make it possible for server code outside unithand.c to get the kind of reason
that prevents a unit from doing an action. Having the ane_kind it self rather
than an explanation text can be useful in places like the AI.



___

File Attachments:


---
Date: Wed 10 Aug 2016 04:07:44 PM UTC  Name:
0003-Share-unithand-s-action-not-enabled-reason.patch  Size: 8kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7589] Share unithand's action not enabled reason

[Sveinung Kvilhaugsvik]

Update of patch #7589 (project freeciv):

  Depends on: => patch #7582

___

Follow-up Comment #1:

Textual dependence on patch #7582. (It adds two action not enabled explanation
kinds)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

[Marko Lindqvist]

Follow-up Comment #4, bug #24942 (project freeciv):

Didn't check the patch yet, but couple of general notes before I forget:
1) pkg-config for Qt should set --std=c++11 if it needs it, so it's bug there
if we need to set it separately
2) We have macros to set flags only when used compiler supports them.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

[Louis Moureaux]

Follow-up Comment #5, bug #24942 (project freeciv):

Devil is in the details. Really works now...

(file #28240)
___

Additional Item Attachment:

File name: qt-use-pkg-config-2.patch.bz2  Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

[Marko Lindqvist]

Follow-up Comment #6, bug #24942 (project freeciv):

> A pc file is provided by Qt itself

It didn't back then when we added .m4 files. It's possible that all Qt5
versions have provided them, though. Anyway, compatibility issues with oldest
supported (by us) versions need to be checked.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7574] Gtk clients: act sel dlg paradrop and airlift

[Sveinung Kvilhaugsvik]

Update of patch #7574 (project freeciv):

 Summary: Gtk 3 clients: act sel dlg paradrop and airlift =>
Gtk clients: act sel dlg paradrop and airlift

___

Follow-up Comment #3:

Do so for the Gtk 2.0 client too.

(file #28244)
___

Additional Item Attachment:

File name: 3.0-Gtk-clients-act-sel-dlg-paradrop-and-airlift.patch Size:8 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7573] Gtk clients: ask for target for "Do..."

[Sveinung Kvilhaugsvik]

Update of patch #7573 (project freeciv):

 Summary: Gtk 3 clients: add "Do To..." => Gtk clients: ask
for target for "Do..."

___

Follow-up Comment #2:

> This was chosen rather than having "Do..." start asking for the target tile
since an extra click may be confusing and annoying to old players.
Solved by patch #7578.

Have "Do..." start asking for the target tile. Do it for the Gtk 2 client too.
Both 3.0 and 2.6 version are ready for test.

(file #28242, file #28243)
___

Additional Item Attachment:

File name: 3.0-Gtk-clients-ask-for-target-for-Do.patch Size:3 KB
File name: 2.6-Gtk-clients-ask-for-target-for-Do.patch Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7577] Tileset "for_ruleset"

[Marko Lindqvist]

Update of patch #7577 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

[Marko Lindqvist]

URL:
  

 Summary: Old base "Diplomat_Defense" not recreatable
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 10 Aug 2016 10:17:36 PM EEST
Category: general
Severity: 5 - Blocker
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:

This counts as *regression* after patch #7081: Base "Diplomat_Defense" was
obsoleted in favor of using "Spy_Resistant" effect also for those cases, but
"Spy_Resistant" is not exactly same as "Diplomat_Defense" was. At least,
unlike "Diplomat_Defense", it also directly affects sabotaging buildings.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24957] Segmentation faul in is_action_enabled.constprop

[Andreas Røsdal]

URL:
  

 Summary: Segmentation faul in is_action_enabled.constprop 
 Project: Freeciv
Submitted by: andreasr
Submitted on: Wed 10 Aug 2016 07:44:41 PM UTC
Category: freeciv-web
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 
 Contains string changes: None

___

Details:

Freeciv-web is now has slightly more segmentation faults than normal (about 1%
of games now, it used to be about 0,1%). 
This is Freeciv server svn r33476.

This is a backtrace from a core-dump which was created on the most recent
segmentation fault:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0055be84 in is_action_enabled.constprop ()
(gdb) bt full
#0  0x0055be84 in is_action_enabled.constprop ()
No symbol table info available.
#1  0x0055e3cc in is_action_enabled_unit_on_city ()
No symbol table info available.
#2  0x004f26e1 in handle_unit_do_action ()
No symbol table info available.
#3  0x0048a8d8 in server_handle_packet ()
No symbol table info available.
#4  0x0040e96d in server_packet_input ()
No symbol table info available.
#5  0x004e2c5e in server_sniff_all_input ()
No symbol table info available.
#6  0x00411935 in srv_main ()
No symbol table info available.
#7  0x004084ce in main ()
No symbol table info available.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

[Sveinung Kvilhaugsvik]

Follow-up Comment #1, bug #24956 (project freeciv):

Base Diplomat_Defense didn't work in cities. Spy_Resistant's impact on
building sabotage is therefore irrelevant.

Real bug (source of the confusion?): A third party ruleset may contain a
Diplomat_Defense base that can be built inside a city. The upgrade in rscompat
should therefore have added a !CityTile requirement. (The bundled rulesets'
DiplomatDefense bases can't be built in cities) Fix attached.



(file #28245)
___

Additional Item Attachment:

File name: 0006-rscompat-DiplomatDefense-is-outside-cities.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24957] Segmentation faul in is_action_enabled.constprop

[Marko Lindqvist]

Update of bug #24957 (project freeciv):

Category: freeciv-web => general
  Status:None => Ready For Test 
 Planned Release: => 3.0.0  

___

Follow-up Comment #1:

Recent changes on that area is passing homecity as parameter... and looking
where that might be unchecked... does attached patch help?

(file #28246)
___

Additional Item Attachment:

File name: HomecityFromNULL.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

[Marko Lindqvist]

Follow-up Comment #2, bug #24956 (project freeciv):

> Base Diplomat_Defense didn't work in cities.

It didn't? (Note that since this change is only in TRUNK, also the S2_6
ruleset formats should be considered - not what already existing S2_5 rulesets
do)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

[Sveinung Kvilhaugsvik]

Follow-up Comment #3, bug #24956 (project freeciv):

> It didn't?
  if (tile_city(pdefender_tile)) {
/* Reduce the chance of an attack by EFT_SPY_RESISTANT percent. */
chance -= chance * get_city_bonus(tile_city(pdefender_tile),
  EFT_SPY_RESISTANT) / 100;
  } else {
/* Reduce the chance of an attack if BF_DIPLOMAT_DEFENSE is active. */
if (tile_has_base_flag_for_unit(pdefender_tile, unit_type_get(pdefender),
BF_DIPLOMAT_DEFENSE)) {
  chance -= chance * 25 / 100; /* 25% penalty */
}
  }

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7566] Output_Waste_By_Rel_Distance

[Marko Lindqvist]

Update of patch #7566 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

[Marko Lindqvist]

Follow-up Comment #4, bug #24956 (project freeciv):

Right. But that in turn then seems like a bug in S2_6 where bases should work
inside cities too.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

[Sveinung Kvilhaugsvik]

Update of bug #24956 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => sveinung   
 Release: => TRUNK  
Operating System:None => Any
 Contains string changes:None => No 

___

Follow-up Comment #5:

Just to be clear: DiplomatDefence doesn't work on city tiles in 2.6.

I should have mentioned this in the commit message and added the !Center rule
to rscompat. I guess I forgot.

Patch v2:
 * document why the !Center requirement is added.

(file #28248)
___

Additional Item Attachment:

File name: 0006-rscompat-DiplomatDefense-is-outside-cities.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

[Sveinung Kvilhaugsvik]

Follow-up Comment #6, bug #24956 (project freeciv):

> Seems like a bug in S2_6 where bases should work inside cities too.
They should?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

[Marko Lindqvist]

Follow-up Comment #7, bug #24956 (project freeciv):

Before S2_6 it was a hardcoded rule that bases cannot exist inside cities.
S2_6 allow bases (like any extras) inside cities unless ruleset says
otherwise. When they exist inside cities, they should also work as they
usually do.

For this particular ticket I would propose splitting "Spy_Resistant" effect to
two separate effects, of which old "Diplomat_Defense" gets updated to just
one. Old "Spy_Resistant" effects get updated to two (both) effects.

New ticket is needed for S2_6 bug.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

[Sveinung Kvilhaugsvik]

Update of bug #24956 (project freeciv):

  Status:  Ready For Test => None   
 Assigned to:sveinung => None   

___

Follow-up Comment #8:

If 2.6 starts supporting DiplomatDefence in cities the attached patch won't
fix the problem.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24094] ai/default/aisettler.c::1251]: Tekun Umam: Failed to build city at (48, 28)

[Sveinung Kvilhaugsvik]

Follow-up Comment #12, bug #24094 (project freeciv):

updated of trunk version:
 * moved sharing of action not enabled reason to patch #7589

(file #28250)
___

Additional Item Attachment:

File name: 0001-AI-near-city-blocking-Found-City-not-an-error.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

[Louis Moureaux]

Follow-up Comment #7, bug #24942 (project freeciv):

I checked Kde Neon Developer Edition, which ships Qt 5.7 on a Ubuntu
14.04-based system. The default compiler there is GCC 5.4, which defaults to
C++98. With my patch, freeciv configures fine but build fails (in Qt) as if
std::nullptr_t == int. It works fine if I set CXXFLAGS=--std=c++11, I'll need
to investigate further.

*pkg-config*

Ubuntu's packages of Qt 4.8 has .pc files
(http://packages.ubuntu.com/precise/amd64/libqt4-dev/filelist), so I'm
confident about it being distributed on Linux.

Reading
http://code.qt.io/cgit/qt/qtbase.git/tree/mkspecs/features/qt_module.prf?h=old/5.0,
it looks like the .pc files are built for "unix" and "win32-g++" systems
(which means Linux, *BSD and Windows if Qt was compiled with g++). I don't
know the precise requirement for building on Windows.

> pkg-config for Qt should set --std=c++11 if it needs it, so it's bug there
if we need to set it separately
Qt doesn't know the compiler we use, so it can't guess the required flag. This
is where limitations of autotools and pkg-config show up, and other tools such
as cmake shine. But let's not start a flame war...

> We have macros to set flags only when used compiler supports them.
I saw libtool sets variables for C++11 and PIC, but they're not part of the
public API (as far as I can tell). As PIC didn't use a macro beforehand, there
is no regression.

*Potential problems*

- Qt >= 5.7 will be picked even if Qt < 5.7 is found earlier in pkgconfig's
path.
- QtWidgets < 5.7 and eg QtCore >= 5.7 installed. C++11 won't be used, even
though QtCore requires it. idk if Qt supports such a setup, however.
- If Qt >= 5.7 is found but the compiler doesn't support C++11, the error
message still won't be very useful.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

[Marko Lindqvist]

Follow-up Comment #8, bug #24942 (project freeciv):

For the C++11 problem, would something as simple as attached patch work? That
would be something I would be ready accept even to S2_5. Preferring pkg-config
is probably a good idea (we've headed towards it in general, and we probably
have many bugs hidden in our Qt m4 mess that it would avoid) in trunk, maybe
S2_6.

(file #28251)
___

Additional Item Attachment:

File name: C++11Qt5.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24945] Dead player's client has Turn Done button enabled

[Marko Lindqvist]

Update of bug #24945 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7591] Merge ruledit_qt_setup(), ruledit_qt_run(), and ruledit_qt_close()

[Marko Lindqvist]

URL:
  

 Summary: Merge ruledit_qt_setup(), ruledit_qt_run(), and
ruledit_qt_close()
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 11 Aug 2016 02:38:12 AM EEST
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0
 Contains string changes: None

___

Details:





___

File Attachments:


---
Date: Thu 11 Aug 2016 02:38:12 AM EEST  Name: RuleditQtRunOnce.patch  Size:
3kB   By: cazfi


---
Date: Thu 11 Aug 2016 02:38:12 AM EEST  Name: RuleditQtRunOnce-S2_6.patch 
Size: 3kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

[Louis Moureaux]

Follow-up Comment #9, bug #24942 (project freeciv):

> For the C++11 problem, would something as simple as attached patch work?
Such a patch would work. On the other hand, one would need Debian Wheezy or
Ubuntu 12.04 to compile Freeciv without C++11 support. This would make it more
difficult to check the Freeciv codebase being C++11-free.

I've been thinking of something along these lines:
++
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include 
#if QT_VERSION >= #0x050700
#error ""
#endif]], [[]], [ (enable C++11) ])
--
It's much simpler, but relies on  not depending on C++11 (which
is the case but not guaranteed).


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

[Louis Moureaux]

Follow-up Comment #10, bug #24942 (project freeciv):

(In the code below, #0x050700 should read 0x050700. Habit from CSS: every hex
number begins with #... Sorry)

___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24960] req_edit::select_req() crash when adding new requirement

[Marko Lindqvist]

URL:
  

 Summary: req_edit::select_req() crash when adding new
requirement
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 11 Aug 2016 03:07:55 AM EEST
Category: freeciv-ruledit
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:

Fix attached



___

File Attachments:


---
Date: Thu 11 Aug 2016 03:07:55 AM EEST  Name: SelectReqCrash.patch  Size: 541B
  By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7592] Support editing requirement value, as long as kind is "tech"

[Marko Lindqvist]

URL:
  

 Summary: Support editing requirement value, as long as kind
is "tech"
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 11 Aug 2016 03:12:24 AM EEST
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:

Add code needed for editing ANY textual requirement values, implement "tech"
requirement kind as an example of usage.



___

File Attachments:


---
Date: Thu 11 Aug 2016 03:12:24 AM EEST  Name: ReqValueEdit.patch  Size: 6kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7490] Qt client: Add class to ease wrapping the C API

[Louis Moureaux]

Follow-up Comment #3, patch #7490 (project freeciv):

Same class without C++11, and renamed to "listener", which is more specific.
The API has changed a bit and now requires the listener to register once it's
ready.

Please reopen.

(file #28256)
___

Additional Item Attachment:

File name: listener.h Size:5 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7582] Action not enabled explain actor tgt distance

[Sveinung Kvilhaugsvik]

Update of patch #7582 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7580] Qt client: act sel dlg paradrop and airlift

[Sveinung Kvilhaugsvik]

Update of patch #7580 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7584] webperimental: set default citymindist to 3

[Sveinung Kvilhaugsvik]

Update of patch #7584 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7578] 2nd targeted "Do..." means target own tile

[Sveinung Kvilhaugsvik]

Update of patch #7578 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7579] Qt client: ask for target for "Do..."

[Sveinung Kvilhaugsvik]

Update of patch #7579 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7581] Forbid paradropping to same tile unit already is

[Sveinung Kvilhaugsvik]

Update of patch #7581 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 
 Contains string changes:  No => Yes

___

Follow-up Comment #3:

(2.6 version added a String)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24961] Client freezes when connecting to local server

[Louis Moureaux]

URL:
  

 Summary: Client freezes when connecting to local server
 Project: Freeciv
Submitted by: louis94
Submitted on: jeu. 11 août 2016 01:26:10 UTC
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5, trunk
 Discussion Lock: Any
Operating System: Any
 Planned Release: 
 Contains string changes: None

___

Details:

Reported by GriffonSpade on the forum
(http://forum.freeciv.org/f/viewtopic.php?f=8&t=859&p=8101#p8101)

I found two ways to reproduce:

* Start a local server
* Open the client
* On the start page, choose "Connect to network game"
** Click on the local server in the list
** In the "host" box, replace "localhost" with your computer's name
* Hit "Connect"
* Client is frozen

Affects at least Gtk3 and Qt clients, in versions 2.5.5, S2_5 and trunk. Looks
like it's related to the computer name not being "localhost".

Common stack trace:
++
#0  0x776e540d in connect () from /usr/lib/libpthread.so.0
#1  0x0049e394 in try_to_connect (username=,
errbuf=, errbufsize=) at clinet.c:228
#2  0x0049e200 in connect_to_server (username=0x90ac20 
"me", hostname=, port=, errbuf=0x7fffd040
"", 
errbufsize=512) at clinet.c:270
--




___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23992] Client page change in queue mess

[Marko Lindqvist]

Update of bug #23992 (project freeciv):

  Status:None => Ready For Test 
 Planned Release:2.6.0, 3.0.0 => 2.5.6, 2.6.0, 3.0.0

___

Follow-up Comment #1:

Fix.

I first considered checking that page is PAGE_GAME also in the future
(get_client_page() does that) but then it would probably break some case where
page is first being brought up and not yet initialized. Attached patch should
work for both coming *to* and leaving *from* PAGE_GAME.

(file #28257, file #28258, file #28259)
___

Additional Item Attachment:

File name: UpdateQueuePageCheck.patch Size:2 KB
File name: UpdateQueuePageCheck-S2_6.patch Size:4 KB
File name: UpdateQueuePageCheck-S2_5.patch Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24084] citizen_base_mood: comparison is always true due to limited range of data type

[Marko Lindqvist]

Update of bug #24084 (project freeciv):

  Status: In Progress => Duplicate  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

Now part of bug #24948

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7593] Delete unused act vs own tile functions

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Delete unused act vs own tile functions
 Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 11 Aug 2016 01:53:35 AM UTC
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: No

___

Details:

"Do..." can now act against any target tile the user selects, not only the
tile the actor is located at. It is therefore enabled for any actor unit. This
makes the functions can_units_act_against_own_tile() and
can_unit_act_against_own_tile() redundant. Remove them. (The xaw client still
use them in 2.6)



___

File Attachments:


---
Date: Thu 11 Aug 2016 01:53:35 AM UTC  Name:
0001-Delete-unused-act-vs-own-tile-functions.patch  Size: 3kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23988] Feature request: all units on a tile are shown in the bar on the right side

[Marko Lindqvist]

Update of bug #23988 (project freeciv):

Category:  client-gtk-2.0 => client-gtk-3.0 
  Status:None => Ready For Test 
 Planned Release: => 2.6.0, 3.0.0   

___

Follow-up Comment #3:

Patch to adjust default in gtk3-clients.

(file #28261, file #28262)
___

Additional Item Attachment:

File name: BigDisplayLayout.patch Size:1 KB
File name: BigDisplayLayout-S2_6.patchSize:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Marko Lindqvist]

Follow-up Comment #1, bug #23911 (project freeciv):

Disband gives only 50% of the shields, so it's not same as Help Wonder. So
it's only correct that restrictions to Help Wonder do not apply to a caravan
(and only caravan?) doing disband.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24948] Comparisons against negative 'citizens' values

[Marko Lindqvist]

Update of bug #24948 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24947] Caravans can't plan over 1-tile long routes

[Marko Lindqvist]

Update of bug #24947 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24957] Segmentation faul in is_action_enabled.constprop

[Andreas Røsdal]

Follow-up Comment #2, bug #24957 (project freeciv):

Yes, the patch has fixed this, based on 0 crashes in 614 games.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24961] Client freezes when connecting to local server

[mir3x]

Follow-up Comment #1, bug #24961 (project freeciv):

Have u checked if it related to internet servers too?

Maybe your computer tries to resolve your computer name by doing
 and cannot do it.

Its other bug than Griffon, he specified that he cannot connect even when
using localhost as hostname. And server reports him as connected.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

[Marko Lindqvist]

Follow-up Comment #11, bug #24942 (project freeciv):

> one would need Debian Wheezy or Ubuntu 12.04 to compile Freeciv without
C++11 support.

User can still override the std version in CXXFLAGS. I'm more concerned about
those users who see their standard version going to older one because of this.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23911] Disband can bypass non domestic help wonder restrictions

[Sveinung Kvilhaugsvik]

Follow-up Comment #2, bug #23911 (project freeciv):

> Disband gives only 50% of the shields,
Not if you follow the procedure below. It will give you 100% of the shields.
(Unless it has changed since I filed this bug)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7490] Qt client: Add class to ease wrapping the C API

[mir3x]

Update of patch #7490 (project freeciv):

  Status: Wont Do => None   
 Open/Closed:  Closed => Open   

___

Follow-up Comment #4:

Pls use gcc-config to switch to gcc 5.x

listener.h

listener.h:108:9: error: expected nested-name-specifier before ‘type_t’
   using type_t = _type_;
 ^
listener.h:112:19: error: ‘type_t’ was not declared in this scope
   static std::set instances;

and more

cpputils.h:
from cpputils.h:22,
/usr/lib/gcc/x86_64-pc-linux-gnu/5.3.0/include/g++-v5/bits/c++0x_warning.h:32:2:
error: #error This file requires compiler and library support for the ISO C++
2011 standard. This support is currently experimental, and must be enabled
with the -std=c++11 or -std=gnu++11 compiler options


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

[mir3x]

Update of patch #7491 (project freeciv):

  Status: Wont Do => None   
 Open/Closed:  Closed => Open   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev