[Freeciv-Dev] (PR#39358) vote in pregame

2008-06-24 Thread Pepeto _

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39358 

 [jdorje - Tue Jun 24 03:30:07 2008]:

 This is actually a rather serious bug.  The only solutions are to
 disable the vote code or to reset all votes when a player leaves.
 
 -jason
 

We have fixed it differently in warserver. The votes are based on
connection ids, and all their vote are canceled when the connection
detach or leave.


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#39358) vote in pregame

2008-06-23 Thread Jason Short

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39358 

A 5-minute fix for this is to stick the votes into the player structure.
 This is easy enough but as the vote records are still in an array
inside the vote structures themselves player reordering will change
everyone's vote around.  Which basically means voting is useless since
anyone leaving the game will change all votes around at complete random.

This is actually a rather serious bug.  The only solutions are to
disable the vote code or to reset all votes when a player leaves.

-jason


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#39358) vote in pregame

2007-05-12 Thread Per I. Mathisen

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39358 

This will be rather hard to fix in 2.0, but will work in 2.1 and trunk
because we redesigned voting there so that it only is available while
the game is running. Unless someone volunteers to backport the 2.1
voting system, we should leave this as is. Closing ticket.

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#39358) vote in pregame

2007-04-25 Thread Pepeto _

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39358 

When there is a vote while the pregame, and a player leaves or is lost, the 
players are renumbered. But votes are based on player_no, so the vote are 
messed up.

For exemple:
* A (player 0), B (player 1), C (player 2) are connected on the same server
* B ask for cut C.
* A leaves. The players are renumbered: B (player 0), C (player 1). Vote are 
not changed so C voted yes, instead of B.
* B can vote a second time, and cut this poor C user Sad. He can ask a 
second vote too, without canceling the first.

I don't see any easy solution, just some hack... So i prefer don't give you 
bad code lines :)

_
Découvrez le Blog heroic Fantaisy d'Eragon! 
http://eragon-heroic-fantasy.spaces.live.com/



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#39358) vote in pregame

2007-04-25 Thread Guest

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39358 

 [EMAIL PROTECTED] - Wed Apr 25 07:18:33 2007]:
 
 When there is a vote while the pregame, and a player leaves or is
 lost, the
 players are renumbered. But votes are based on player_no, so the vote
 are
 messed up.
 
 For exemple:
 * A (player 0), B (player 1), C (player 2) are connected on the same
 server
 * B ask for cut C.
 * A leaves. The players are renumbered: B (player 0), C (player 1).
 Vote are
 not changed so C voted yes, instead of B.
 * B can vote a second time, and cut this poor C user Sad. He can ask a
 second vote too, without canceling the first.
 
 I don't see any easy solution, just some hack... So i prefer don't
 give you
 bad code lines :)
 
 _
 Découvrez le Blog heroic Fantaisy d'Eragon!
 http://eragon-heroic-fantasy.spaces.live.com/
 
 
 
I wanted to clarify this cause I think I can fix it just need some more
information.  You are referring to a pregame vote only correct?  If this
is occuring during the game itself I will need some more information as
the server doesn't actually reorder the player list during a disconnect
if not in pregame.

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#39358) vote in pregame

2007-04-25 Thread Guest

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39358 


 I wanted to clarify this cause I think I can fix it just need some more
 information.  You are referring to a pregame vote only correct?  If this
 is occuring during the game itself I will need some more information as
 the server doesn't actually reorder the player list during a disconnect
 if not in pregame.
 

The players are not renumbered while the other game state (like
running). While the pregame, players are removed when they leaves (or
lose connection). But if a player is removed while the game is running,
the player lose all his cities and units and he is marked as 'dead', but
he isn't removed completely of the game.

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev