[Freeciv-Dev] [bug #13586] [patch] economic report (was PR#40763) - help needed
Update of bug #13586 (project freeciv): Status: In Progress = Confirmed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13586 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13586] [patch] economic report (was PR#40763) - help needed
Follow-up Comment #5, bug #13586 (project freeciv): The extra 'upkeep_info' field is needed for homeless units because even for the player who owns them they have no upkeep. ___ Reply to this item at: http://gna.org/bugs/?13586 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13586] [patch] economic report (was PR#40763) - help needed
Follow-up Comment #6, bug #13586 (project freeciv): The extra 'upkeep_info' field is needed for homeless units because even for the player who owns them they have no upkeep. Would it be so bad just to show zero upkeep for those units? Are there any other circumstances when the extra boolean field would be needed? if the editor is used the changes are visible in the next turn. I'm not sure, how to force an update. Possibly there should be some more city refreshes after editor actions. Could you give more details about what editor actions you used that caused the upkeep values to not show correctly? 援助すればいいだろう。 ___ Reply to this item at: http://gna.org/bugs/?13586 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13586] [patch] economic report (was PR#40763) - help needed
Follow-up Comment #7, bug #13586 (project freeciv): Would it be so bad just to show zero upkeep for those units? Are there any other circumstances when the extra boolean field would be needed? I know only of the case of homeless unit. So the upkeep_info field can be removed. Please try it especially with homeless units and investigating cities of other players. Could you give more details about what editor actions you used that caused the upkeep values to not show correctly? If I use Shield2Gold the upkeep is changed if I research (or add using the editor) the corresponding tech or build the improvement with this effect. changes in version 3: - remove upkeep_info (file #5903) ___ Additional Item Attachment: File name: version3-13586-gold5.patch.diff Size:37 KB ___ Reply to this item at: http://gna.org/bugs/?13586 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13586] [patch] economic report (was PR#40763) - help needed
Follow-up Comment #4, bug #13586 (project freeciv): I think we can safely adopt the convention that upkeep information will only be available for the player's own units. So we do not need the extra 'upkeep_info' boolean field; just check that the owner is the same the client's player. if the editor is used the changes are visible in the next turn. I'm not sure, how to force an update. Possibly there should be some more city refreshes after editor actions. もう少しだ。 ___ Reply to this item at: http://gna.org/bugs/?13586 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13586] [patch] economic report (was PR#40763) - help needed
Follow-up Comment #2, bug #13586 (project freeciv): Ok, after some (a lot of!) searching I found my error. The upkeep information has to be processed two times in packhand.c - in unpackage_unit() and handle_unit_packet_common()! changes in version 2: - it's working! - move city_units_upkeep() to citytools.c - upkeep information are only send for own units (a flag upkeep_info is used) - upkeep information are only send if there are changes - reduce the number of places there this function is called (not on every loop!; but within city_refresh()) (file #5843) ___ Additional Item Attachment: File name: version2-gold5.patch.diff Size:37 KB ___ Reply to this item at: http://gna.org/bugs/?13586 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13586] [patch] economic report (was PR#40763) - help needed
Follow-up Comment #3, bug #13586 (project freeciv): one remark: if the editor is used the changes are visible in the next turn. I'm not sure, how to force an update. ___ Reply to this item at: http://gna.org/bugs/?13586 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13586] [patch] economic report (was PR#40763) - help needed
Update of bug #13586 (project freeciv): Assigned to:None = mbook ___ Reply to this item at: http://gna.org/bugs/?13586 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13586] [patch] economic report (was PR#40763) - help needed
URL: http://gna.org/bugs/?13586 Summary: [patch] economic report (was PR#40763) - help needed Project: Freeciv Submitted by: syntron Submitted on: Donnerstag 28.05.2009 um 12:13 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: If the upkeep for all units is save in the units struct. This information can be used on the client side. - the function ./common/city.c:city_unit_upkeep is removed - the unit upkeep information is send to the clients in packet_unit and packet_unit_short_info (needed?) - at the moment the packet information do not reach the client. why? - HELP NEEDED With the patch gold-check.patch.diff the default upkeep is multiplied by 3 and the sserver and client packet information are printed in the log. The values at the server side are correct while at the client side only the default values are shown. Therefore in the city dialog as well as in the economic dialog the default values are used. depends on 13580, 13581 ___ File Attachments: --- Date: Donnerstag 28.05.2009 um 12:13 Name: gold5.patch.diff Size: 28kB By: syntron http://gna.org/bugs/download.php?file_id=5827 --- Date: Donnerstag 28.05.2009 um 12:13 Name: gold-check.patch.diff Size: 5kB By: syntron http://gna.org/bugs/download.php?file_id=5828 ___ Reply to this item at: http://gna.org/bugs/?13586 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13586] [patch] economic report (was PR#40763) - help needed
Update of bug #13586 (project freeciv): Category:None = general Status:None = In Progress ___ Follow-up Comment #1: - the unit upkeep information is send to the clients in packet_unit and packet_unit_short_info (needed?) As far as I know, the short version of the unit info packet is for enemy units, or special circumstances (e.g. the unit goes out of sight hack). Probably upkeep information should not be included in those packets, or is not needed. at the moment the packet information do not reach the client. why? - HELP NEEDED This is probably because you do not call send_unit _info() when the upkeep values change at the server side. This should happen at least everytime you call city_units_upkeep() for all of the supported units. I would add that since city_units_upkeep() is never called from the client, it should probably have stayed in the server code (cityturn or tools). My own feeling is that putting things in common/ is not such a great idea, since it makes it easy to introduce hard-to-work-around constraints and dependencies. Ideally only very simple very modular code should be kept there. But that is a discussion for another ticket... 制約とか依存とかそんなものは嫌だ。 ___ Reply to this item at: http://gna.org/bugs/?13586 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
