[Freeciv-Dev] [bug #22787] Changing the theme does not work

[Marko Lindqvist]

Follow-up Comment #14, bug #22787 (project freeciv):

> Sorry, I had assumed it was the gtk behavior on Windows that we
> were trying to fix.

Not at the cost of breaking all the other systems, nor has anybody else
considered this a bug before you. Also, it's not related to problems in theme
refresh this ticket is about -> open a new ticket if you want to pursue it
further.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[anonymous]

Follow-up Comment #13, bug #22787 (project freeciv):

Sorry, I had assumed it was the gtk behavior on Windows that we were trying to
fix. see http://freeciv.wikia.com/wiki/Gtk_minefield

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[Marko Lindqvist]

Follow-up Comment #12, bug #22787 (project freeciv):

I'm quite close to start ignoring you as a troll.

For the last time: My point are all *other* environments than Windows, Windows
being special case. You keep on telling how it works on your Windows. We know
how it works on Windows, thank you, no need to keep repeating that to us.

> different folders with with different versions of gtk

As a developer, I've done that in environments other than Windows, but normal
users just install gtk to their system by what ever package manager it has,
and there will be no multiple copies of it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[anonymous]

Follow-up Comment #11, bug #22787 (project freeciv):

A strange argument. I continue it to add a useful link to a portable gtk theme
switcher for windows.

> The file settings.ini in the freeciv folder is not system-wide.

>All the programs using gtk you have in that directory hierarchy, use that
settings.ini, not just freeciv.  

Yes this is true. Both the freeciv client and the freeciv modpack in the same
freeciv folder use the same gtk. The one that is in that folder. There are no
other programs using gtk in the freeciv folder. Until now. But it is a fact
that another gtk program installed in that folder will use the same
settings.ini not just freeciv.

I have added an additional program into the freeciv folder 
gtk2_prefs.exe  from
http://sourceforge.net/projects/tumagcc/files/gtk2_prefs.exe/download.

So now there are 3 programs using gtk in this directory hierarchy. If you look
at the attached screenshot you will see a list of themes I can choose from in
this directory. These themes are all installed in this folder tree.

I have other versions of freeciv installed in different folders with different
versions of gtk and different themes. There is no overlap.



(file #22646)
___

Additional Item Attachment:

File name: gtk-theme-selector.PNG Size:187 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[Marko Lindqvist]

Follow-up Comment #10, bug #22787 (project freeciv):

You still fail to read what I say.

"Outside the pecularities of the Windows packaging ..."

When you say that this is not true, you are claiming that 1) You are not using
Windows & 2) You still have /etc/gtk-3.0/settings.ini as part of freeciv, not
gtk.

The thing about Freeciv Windows Installer packaging is that in addition to
freeciv itself, it contains entire system of third party libraries and stuff
that freeciv depends on. That's like a miniature filesystem hierarchy from
linux contained in one Windows folder.

Crosser based installation would give you better picture of what is freeciv,
and what are the third party components. Crosser installation, that can be
used with multiple installations of freeciv, contains the third party system
parts, freeciv builds are just freeciv. gtk is part of crosser, and so is
/etc/gtk-3.0/settings.ini in the upcoming release. Previous one didn't have
one. (Hint about it being gtk3 configuration and not freeciv one: It's not
/etc/freeciv/settings.ini but /etc/gtk-3.0/settings.ini)

> The file settings.ini in the freeciv folder is not system-wide.

All the programs using gtk you have in that directory hierarchy, use that
settings.ini, not just freeciv. It's not system-wide on your Windows, but it
represents entire system on its own, and in any other OS equivalent hierarchy
is the root-hierarchy (there's no dozens of copies of gtk installed for each
gnome program to use its own)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[anonymous]

Follow-up Comment #9, bug #22787 (project freeciv):

>Our windows packaging includes more than freeciv itself, it contains entire
system with things like gtk and its system-wide configuration file.

This is not correct. The file settings.ini in the freeciv folder is not
system-wide.

I also have gtk installed at C:MinGWmsys1.0optbin
In that folder is a test program called gtk-demo.exe which I am using to test
the gtk2 themes.

The freeciv settings have no impact on the settings in the optbin folder. The
settings for that folder are set at C:MinGWmsys1.0optetcgtk-2.0settings.ini

I did not develop this system this is how the gtk build on mingw compiles and
installs.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[Marko Lindqvist]

Follow-up Comment #8, bug #22787 (project freeciv):

You're still referring to Windows builds, though I said:
> Outside the pecularities of the Windows packaging

Our windows packaging includes more than freeciv itself, it contains entire
system with things like gtk and its system-wide configuration file.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[anonymous]

Follow-up Comment #7, bug #22787 (project freeciv):

It seems I have to be more pedantic.

When I refer to sharethemes  for a particular version of freeciv the folder is
C:Program FilesFreeciv-xxxsharethemes. It is not a system wide folder. 

When I refer to /etc/gtk-3.0/settings.ini  for a particular version of freeciv
the folder is C:Program FilesFreeciv-xxxetcgtk-3.0. It is not a system wide
folder. Each freeciv folder will have its own version of settings.ini

client-rc-2.5 is stored in the user profile and effects all the versions of
2.5 that are installed. Hence only options that are common to all versions
should be included here. Theming is not one of them.

IF there is more than one version of freeciv 2.5 installed with different
versions of the gtk3 binaries then each will be in its own folder. Each will
have its own settings.ini. It is important that this file is not unique
because different versions of gtk have different requirements.

Also different versions of the same theme exist for different versions of gtk.
For example
http://gnome-look.org/content/show.php/Clearlooks-Phenix?content=145210
Hence the need for different settings.ini


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[Marko Lindqvist]

Follow-up Comment #6, bug #22787 (project freeciv):

> The use of gui_gtk3_default_theme_name="Freeciv" in .freeciv
> client-rc-2.5 is a mistake and should be removed. A default
> theme choice should be saved in settings.ini.

Definitely not.

Outside the pecularities of the Windows packaging, /etc/gtk-3.0/settings.ini
is not part of Freeciv but configuration file defining system-wide (for all
programs, and even all users) defaults. Even if freeciv could change that
file, we wouldn't want to make all the programs in the system to use Freeciv
theme simply because freeciv is installed there.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[anonymous]

Follow-up Comment #5, bug #22787 (project freeciv):

Here are the correct placings for themes to work on my windows version of
freeciv. (Using settings.ini)

The settings.ini file needs to be in etcgtk-3.0

The themes need to be in sharethemes

The Freeciv theme for gtk3 should be at sharethemesFreecivgtk-3.0

Another example is sharethemesclearlooks-phenixgtk-3.0

To change theme put the line
gtk-theme-name =  into settings.ini
for example gtk-theme-name = clearlooks-phenix

The use of gui_gtk3_default_theme_name="Freeciv" in .freeciv-client-rc-2.5 is
a mistake and should be removed. A default theme choice should be saved in
settings.ini.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[anonymous]

Follow-up Comment #4, bug #22787 (project freeciv):

I have managed to make this work for the first time.

I started freeciv in the Raleigh theme by adding the line gtk-theme-name =
Raleigh into settings.ini

Again freeciv wrongly claims that we are in the freeciv theme. But I have
added a copy of the freeciv theme to sharethemesxFreecivgtk-3.0

I called it xfreeciv to distinguish it from the same folder in
datathemesgui-gtk-3.0Freecivgtk-3.0

Now the freeciv gui gives me the option to swap from freeciv theme to
xfreeciv. This works and I actually swapped from Raleigh to freeciv.

It seems the only thing wrong with the freeciv code (apart from not knowing
which theme it is actually in) is that it is looking in the wrong place for
the themes.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[Marko Lindqvist]

Follow-up Comment #3, bug #22787 (project freeciv):

> on windows.
...
> menu will at least show the theme actually being used.

I too am working on this for crosser builds at least, but it's an separate
issue -> to a new ticket.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[anonymous]

Follow-up Comment #2, bug #22787 (project freeciv):

I have a self-compiled version of freeciv on windows. The default theme used
by freeciv is the Adwaita theme.

I would like to change the theme back to the freeciv theme. It would be nice
if the theme selector in the local options tab could do this. But at present
freeciv does not seem to recognise what theme is actually being used.

The screenshot shows in Adwaita that the one and only theme selectable is
freeciv. This cannot be selected as an option. 

I will try to adapt the code so this menu will at least show the theme
actually being used.

(file #22608)
___

Additional Item Attachment:

File name: wrong-theme.JPGSize:37 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[Marko Lindqvist]

Follow-up Comment #1, bug #22787 (project freeciv):

With another theme it partly works - seems like the problem is our lack of
complete theme reset - if the new theme does not define something, that part
remains from the old theme instead of changing to global default.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22787] Changing the theme does not work

[Marko Lindqvist]

URL:
  

 Summary: Changing the theme does not work
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 12 Oct 2014 11:20:45 AM EEST
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Nothing happens when one tries to apply new theme from settings.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev