[Freeciv-Dev] [bug #23888] explorer_goto() can mess goto_tile for AI task using it

[Marko Lindqvist]

URL:
  

 Summary: explorer_goto() can mess goto_tile for AI task using
it
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 20 Sep 2015 01:19:53 PM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

explorer_goto() is called based on unit ACTIVITY, and there's no direct
linkage between ACTIVITY and AITASK. So it's possible (or at least not
prevented by design. It might be hard to find a special case code path where
this happens) that unit has a AITASK that requires goto_tile set correctly,
but then unit does exploring and the goto_tile gets mangled.

Proper fix is not as easy as restoring the old goto_tile after exploring. As
the comment says, if exploring is going to continue next turn, we may want to
send destination currently considered final to the client.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23888] explorer_goto() can mess goto_tile for AI task using it

[Marko Lindqvist]

Update of bug #23888 (project freeciv):

Category:None => ai 
 Planned Release: => 2.5.2, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23888] explorer_goto() can mess goto_tile for AI task using it

[Marko Lindqvist]

Update of bug #23888 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #1:

For TRUNK and S2_6 my proposed fix is to add AI callback want_to_explore,
called before messing the goto_tile.

In case of S2_6 default AI implementation of that callback simply clears AI
task unit might already have, so it won't end with a task and goto_tile
pointing to wrong target for it.

In case if TRUNK default AI implementation of that callback denies
autoexplorer from proceeding if the unit has existing task.

Patches for S2_6 and TRUNK attached, and they enter 36h inspection period now.
I need to think a bit more what to do with S2_5.

(file #25304, file #25305)
___

Additional Item Attachment:

File name: WantToExplore.patchSize:7 KB
File name: WantToExplore-S2_6.patch   Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23888] explorer_goto() can mess goto_tile for AI task using it

[Marko Lindqvist]

Follow-up Comment #2, bug #23888 (project freeciv):

- Updated S2_6 and TRUNK patches against svn

Still no plans about S2_5.

(file #25365, file #25366)
___

Additional Item Attachment:

File name: WantToExplore-2.patch  Size:7 KB
File name: WantToExplore-S2_6-2.patch Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23888] explorer_goto() can mess goto_tile for AI task using it

[Marko Lindqvist]

Follow-up Comment #3, bug #23888 (project freeciv):

- Updated S2_6 and TRUNK patches against svn

(file #25476, file #25477)
___

Additional Item Attachment:

File name: WantToExplore-3.patch  Size:7 KB
File name: WantToExplore-S2_6-3.patch Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23888] explorer_goto() can mess goto_tile for AI task using it

[Marko Lindqvist]

Follow-up Comment #4, bug #23888 (project freeciv):

- S2_5 fix that simply removes goto_tile changing form the autoexplorer. It's
not like the information would be accurate and/or relevant any more by the
time client may see it.

(file #25488)
___

Additional Item Attachment:

File name: ExplorerGotoTileNot.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23888] explorer_goto() can mess goto_tile for AI task using it

[Marko Lindqvist]

Update of bug #23888 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev