[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Marko Lindqvist]

Update of bug #24072 (project freeciv):

  Status:None => Duplicate  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[mir3x]

Follow-up Comment #13, bug #24072 (project freeciv):

Ok, pls close.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Marko Lindqvist]

Follow-up Comment #12, bug #24072 (project freeciv):

As explained in comment #11, this could be duplicate of bug #23708 after all.
Ok to close?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Marko Lindqvist]

Follow-up Comment #11, bug #24072 (project freeciv):

> I see nothing sending city info about trade partner cities, only textual
events, before city gets removed.

This seems like explanation for bug #23708, at least, since that bug took
place when server is removing players and cities.
The NULL pointer there is due to the fact that game_city_by_number(id) can
return NULL even if 'id' is a sane value. That happens when city with that id
has been removed.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Marko Lindqvist]

Follow-up Comment #10, bug #24072 (project freeciv):

It could be that the other end of the traderoute has just been destroyed
(removed from the game) but the traderoute has not yet been removed from the
client end. I see nothing sending city info about trade partner cities, only
textual events, before city gets removed.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Marko Lindqvist]

Follow-up Comment #9, bug #24072 (project freeciv):

> PACKET_PROCESSING_FINISHED

That's actually only last one of the packets received, and could even be
garbage value. The 'type' is relevant only inside the loop going through all
the packets in queue, and the agents thawing is outside (after) that loop.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Jacob Nevins]

Update of bug #24072 (project freeciv):

 Planned Release: 2.5.2, 2.6.0, 3.0.0 => 2.5.x, 2.6.0, 3.0.0

___

Follow-up Comment #8:

No lead on how to reproduce this => reluctantly remove 2.5.2 target.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Jacob Nevins]

Follow-up Comment #7, bug #24072 (project freeciv):

I tried to provoke trouble using my random guessed situation in comment #5
(see file #26096), but didn't see any. Tried with valgrind, with head (r31099)
and r30578 (13 Nov), and with Gtk2 and Qt clients.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Jacob Nevins]

Additional Item Attachment, bug #24072 (project freeciv):

File name: tradeunknown25.sav.bz2 Size:13 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Jacob Nevins]

Follow-up Comment #3, bug #24072 (project freeciv):

> Since this is from agents code triggered by a packet (maybe 
> city info?)
Yes, I think that's right -- city_info or city_short_info can lead to
city_changed() being called, as can putting a city under governor control
(cma_put_city_under_agent()).

Depending on network conditions, it is possible for agents not to run until a
burst of network activity is over; clinet.c:input_from_server() freezes agents
until there's a pause in the packets. I think this means this bug could be
hard to reproduce in situations where the server/network is able to keep up
with the client (local games?).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Jacob Nevins]

Follow-up Comment #5, bug #24072 (project freeciv):

A way to have a valid city pointer for which city_tile() returns NULL is
"ghost" or "invisible" cities, which are created on the client when it sees a
tile_info containing an unknown city ID in 'worked'.

Not sure in what circumstance you could be trading with a city you only know
about this way.
mir3x, is it possible that someone else just established a trade route with
one of your cities?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Jacob Nevins]

Follow-up Comment #4, bug #24072 (project freeciv):

...but the backtrace shows that the packet that actually triggered this was
PACKET_PROCESSING_FINISHED, which also triggers agents to run; and this
happens at the start of the turn or on connect. So I don't think my comment
about network conditions is relevant.

It does imply that it's something the client (possibly an agent) did that
triggered it, I think?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[mir3x]

Follow-up Comment #6, bug #24072 (project freeciv):

Yes, there were some enemy traderoutes, I dont know if someone had also
caravans on goto to my city, but possible.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Jacob Nevins]

Follow-up Comment #2, bug #24072 (project freeciv):

> Both city pointers for can_cities_trade() seem sensible
Hence this doesn't look similar to bug #23708.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Jacob Nevins]

Update of bug #24072 (project freeciv):

 Planned Release: => 2.5.2, 2.6.0, 3.0.0
 Summary: Segmenation fault with traderoutes => Segmentation
fault with traderoutes


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

[Marko Lindqvist]

Follow-up Comment #1, bug #24072 (project freeciv):

Both city pointers for can_cities_trade() seem sensible, so it seems that the
only possibly invalid pointer is city_tile() of either. Since this is from
agents code triggered by a packet (maybe city info?), packet sequence might be
relevant thing here (client has not yet handled some packet providing
necessary information)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev