[Freeciv-Dev] [patch #2418] Add impr_want and impr_keep_want to AI interface

2011-02-15 Thread Marko Lindqvist 

Update of patch #2418 (project freeciv):

 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

Continuing problem solving in its own ticket, bug #17744, as it is not really
error in this patch but wider problem.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2418] Add impr_want and impr_keep_want to AI interface

2011-02-15 Thread Marko Lindqvist 

Update of patch #2418 (project freeciv):

 Open/Closed:  Closed => Open   

___

Follow-up Comment #3:

Reopening ticket so it appears in search results...

> it's to do with the different struct/typedef namespace rules in
> C and C++ --

C rules sure are confusing sometimes. Trying to fix this I'm currently in
situation where compiler complains: "expected ‘const struct tech_vector *’
but argument is of type ‘const struct tech_vector *’"
I don't know if I still somehow have two different struct tech_vector
definitions which C-compiler doesn't consider error in itself, or what is
going on...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2418] Add impr_want and impr_keep_want to AI interface

2011-02-15 Thread Jacob Nevins 

Follow-up Comment #2, patch #2418 (project freeciv):

This change appears to have broken compilation of the Qt client on my system.
If I either disable that client or revert the change, everything builds fine.

I'm guessing that it's to do with the different struct/typedef namespace
rules in C and C++ -- we now have the typedef "tech_vector" (tech.h) and the
struct "tech_vector" (ai.h) -- but I confess I don't know the rules in detail
here.


make[3]: Entering directory `/home/jtn/src/freeciv/git/client/gui-qt'
  CXXchatline.lo
In file included from ../../common/requirements.h:23,
 from ../../common/base.h:25,
 from ../../common/unit.h:25,
 from ../../common/unitlist.h:22,
 from ./../climisc.h:25,
 from chatline.cpp:19:
../../common/tech.h:145: error: conflicting declaration ‘typedef struct
tech_vector tech_vector’
../../common/ai.h:38: error: ‘struct tech_vector’ has a previous
declaration as ‘struct tech_vector’
make[3]: *** [chatline.lo] Error 1
make[3]: Leaving directory `/home/jtn/src/freeciv/git/client/gui-qt'


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2418] Add impr_want and impr_keep_want to AI interface

2011-02-15 Thread Marko Lindqvist 

Update of patch #2418 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2418] Add impr_want and impr_keep_want to AI interface

2011-01-30 Thread Marko Lindqvist 

Update of patch #2418 (project freeciv):

  Depends on: => patch #2391


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2418] Add impr_want and impr_keep_want to AI interface

2011-01-26 Thread Marko Lindqvist 

Update of patch #2418 (project freeciv):

  Depends on: => patch #2399


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2418] Add impr_want and impr_keep_want to AI interface

2011-01-26 Thread Marko Lindqvist 

URL:
  

 Summary: Add impr_want and impr_keep_want to AI interface
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 27 Jan 2011 03:18:04 AM EET
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

This patch replaces direct want_tech_for_improvement_effect() calls from
server common code with calls to new "impr_want" and "impr_keep_want"
functions in AI interface.



___

File Attachments:


---
Date: Thu 27 Jan 2011 03:18:04 AM EET  Name: AIIImprWant.diff  Size: 10kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev