[Freeciv-Dev] [patch #3434] Qt revolution menu and message box

2012-07-29 Thread Marko Lindqvist 
Update of patch #3434 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

Committed though noticed in final testing that there's no confirmation dialog
when selecting target government directly. I guess that's not intentional?
Leaving to future tickets.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3434] Qt revolution menu and message box

2012-07-27 Thread Marko Lindqvist 
Update of patch #3434 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => cazfi  
 Planned Release: => 2.5.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3434] Qt revolution menu and message box

2012-07-27 Thread mir3x 
Follow-up Comment #2, patch #3434 (project freeciv):

Ok, updated.

( meanwhile I found some bugs in qt science report, I'll patch it soon)

(file #16209)
___

Additional Item Attachment:

File name: QtRevol.patch  Size:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3434] Qt revolution menu and message box

2012-07-20 Thread Marko Lindqvist 
Follow-up Comment #1, patch #3434 (project freeciv):

> // common
> #include "game.h"
>+#include "packhand.h"
> #include "government.h"

packhand.h is not in common but in client, and includes should be in
alphabetical order within category.

> for (int i = 1; i < gov_count; i++) { /** skip anarchy ( == 0 ) */

You should not blindly skip government in index 0 - order of governments is
ruleset author's decision. You are probably after
game.government_during_revolution here.

Some extra spaces between function, macro, or macrolike (SLOT, SIGNAL) names
and "(".

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3434] Qt revolution menu and message box

2012-07-20 Thread mir3x 
URL:
  

 Summary: Qt revolution menu and message box
 Project: Freeciv
Submitted by: mir3x
Submitted on: Fri 20 Jul 2012 08:19:05 PM GMT
Category: client-qt
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Added MessageBox confirming revolution.
+ menus with available governments, sensitive.



___

File Attachments:


---
Date: Fri 20 Jul 2012 08:19:05 PM GMT  Name: QtRevol.patch  Size: 9kB   By:
mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev