[Freeciv-Dev] [patch #4016] Qt::global code style fixup

[mir3x]

Update of patch #4016 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => mir3x  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4016] Qt::global code style fixup

[Marko Lindqvist]

Follow-up Comment #3, patch #4016 (project freeciv):

It seems patch #4005 needs some work in any case (it didn't pass my autogame
testing) so feel free to go forward with this meanwhile.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4016] Qt::global code style fixup

[mir3x]

Follow-up Comment #2, patch #4016 (project freeciv):

I'll wait until both will be committed and I'll modify that one before
committing.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4016] Qt::global code style fixup

[Marko Lindqvist]

Follow-up Comment #1, patch #4016 (project freeciv):

For such patch touching a bit every place in Qt-client we need to synchronize
a bit to avoid patch conflicts. I just committed patch #4002 that touched
Qt-client code. I also just updated patch #4005 that will touch Qt-client, but
decided not to make it to apply on top of this one - either one needs to be
changed to apply on top of the other. I'd like #4005 to go in first, as it's
so important step in extras implementation on top of which to build further
development. It's also huge patch that would easily suffer bitrot from almost
any part of the code, not just Qt-client. Any further patches I'd make so that
they apply on top of this one.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4016] Qt::global code style fixup

[mir3x]

URL:
  

 Summary: Qt::global code style fixup
 Project: Freeciv
Submitted by: mir3x
Submitted on: Wed 17 Jul 2013 08:43:30 PM CEST
Category: client-qt
Priority: 3 - Low
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0 2.6.0

___

Details:

Fixed some code style in all files:
mostly:
-brackets and  xxx_itereate_end macro
-empty lines after variables 
-moved variables to the beggining of block



___

File Attachments:


---
Date: Wed 17 Jul 2013 08:43:30 PM CEST  Name:
Qt-global-codestyle-fixup-S25.patch.bz2  Size: 14B   By: mir3x


---
Date: Wed 17 Jul 2013 08:43:30 PM CEST  Name:
Qt-global-codestyle-fixup-S26.patch.bz2  Size: 16kB   By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev