[Freeciv-Dev] [patch #4795] Rename automake cariables xxx_CAPITAL to xxx_capital
Follow-up Comment #2, patch #4795 (project freeciv): I'm a bit worried about the amount of variable renames in build system where some code-paths are really rarely taken and could remain untested for a long time, and language being one where typoed variable names do not cause clear error messages but variable would be just wrong one and cause whatever subtle problems. Still, there's no 2.5.0-beta1 date announced yet, so I assume we have time to fix problems arising, so boldly going where no commit has gone before. ___ Reply to this item at: http://gna.org/patch/?4795 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4795] Rename automake cariables xxx_CAPITAL to xxx_capital
Update of patch #4795 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4795 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4795] Rename automake cariables xxx_CAPITAL to xxx_capital
Follow-up Comment #1, patch #4795 (project freeciv): New S2_5 version - Updated against current svn (file #21008) ___ Additional Item Attachment: File name: amng-illegalvariables-S2_5-2.patch.bz2 Size:5 KB ___ Reply to this item at: http://gna.org/patch/?4795 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4795] Rename automake cariables xxx_CAPITAL to xxx_capital
URL: http://gna.org/patch/?4795 Summary: Rename automake cariables xxx_CAPITAL to xxx_capital Project: Freeciv Submitted by: cazfi Submitted on: Fri 13 Jun 2014 12:13:13 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: automake-ng considers various target_XXXFLAGS variable namess reserved to the extend that it checks all variables fitting that pattern (having such suffix) against typos and giving an error if there is no equivalent target. We have been using such variables to store temporary/partial values, not referring to actual targets. Attached patches renames the offending variables, usually just making them lower-case. ___ File Attachments: --- Date: Fri 13 Jun 2014 12:13:13 AM EEST Name: amng-illegalvariables.patch.bz2 Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=20986 --- Date: Fri 13 Jun 2014 12:13:13 AM EEST Name: amng-illegalvariables-S2_5.patch.bz2 Size: 5kB By: cazfi http://gna.org/patch/download.php?file_id=20987 ___ Reply to this item at: http://gna.org/patch/?4795 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
