[Freeciv-Dev] [patch #5736] Dynamically get supported file formats
Update of patch #5736 (project freeciv): Planned Release: 2.5.1, 2.6.0, 3.0.0 = 2.6.0, 3.0.0 ___ Follow-up Comment #8: This is too controversial for S2_5 at least. ___ Reply to this item at: http://gna.org/patch/?5736 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5736] Dynamically get supported file formats
Follow-up Comment #6, patch #5736 (project freeciv): S2_5 version that touches gtk2-client only. gtk3-client uses cairo's png loading API so it supports png only. something in Gtk thinks it knows about .svg The problem is probably the opposite - why does it not know about .svg while loading the file? Does your /usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders.cache have an entry for svg? (file #24114) ___ Additional Item Attachment: File name: GtkGfxFileExtensions-S2_5.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?5736 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5736] Dynamically get supported file formats
Follow-up Comment #7, patch #5736 (project freeciv): Does your /usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders.cache have an entry for svg? It does: /usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-svg.so svg 6 gdk-pixbuf Scalable Vector Graphics LGPL image/svg+xml image/svg image/svg-xml image/vnd.adobe.svg+xml text/xml- svg image/svg+xml-compressed svg svgz svg.gz svg * 100 !DOCTYPE svg * 100 The referenced .so file exists. But do we want the client to pick up on .svg files that are lying around, given that we don't install them? That'd give different behaviour when running out of a build tree (and only for small tilesets). ___ Reply to this item at: http://gna.org/patch/?5736 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5736] Dynamically get supported file formats
Follow-up Comment #5, patch #5736 (project freeciv): Since this change on S2_6, if I run the client in my build tree with -t trident, the client dies on Start New Game: 0: Failed reading graphics file /home/jtn/src/freeciv/git/bS2_6/../data/flags/usa.svg: Couldn't recognise the image file format for file '/home/jtn/src/freeciv/git/bS2_6/../data/flags/usa.svg' 2: Backtrace: 2: 0: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(backtrace_print+0x30) [0x610de0] 2: 1: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(vdo_log+0x8b) [0x615e5b] 2: 2: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(do_log+0x7d) [0x615f0d] 2: 3: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(load_gfxfile+0x61) [0x4687e1] 2: 4: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2() [0x4be8b8] 2: 5: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2() [0x4c0272] 2: 6: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(tileset_setup_nation_flag+0xb5) [0x4c5fa5] 2: 7: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(client_handle_packet+0x399) [0x4adcb9] 2: 8: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(client_packet_input+0x1f) [0x47238f] 2: 9: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(input_from_server+0x6c) [0x478f4c] ... I suspect that the data/flags/foo.svg files that live alongside the .pngs in svn are now causing trouble because something in Gtk thinks it knows about .svg; and that this only affects tilesets using the small flags because foo-large.svg doesn't exist. ___ Reply to this item at: http://gna.org/patch/?5736 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5736] Dynamically get supported file formats
Follow-up Comment #4, patch #5736 (project freeciv): Ah, actually the assumption about gdk-pixbuf deciding what we support is not true with gtk3-client. It's not using gdk-pixbuf but reads pngs directly with cairo_image_surface_create_from_png(). This should be changed, of course. (cairo_image_surface_create_from_png() is also called a toy API) ___ Reply to this item at: http://gna.org/patch/?5736 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5736] Dynamically get supported file formats
Follow-up Comment #1, patch #5736 (project freeciv): - Introduce macro MAX_FILE_EXTENSIONS instead of using plain '50' everywhere - Guard also the inner loop against going over array boundaries (file #23914) ___ Additional Item Attachment: File name: GtkGfxFileExtensions-2.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?5736 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5736] Dynamically get supported file formats
Update of patch #5736 (project freeciv): Status: Ready For Test = In Progress Planned Release: 2.5.0, 2.6.0, 3.0.0 = 2.5.1, 2.6.0, 3.0.0 ___ Reply to this item at: http://gna.org/patch/?5736 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5736] Dynamically get supported file formats
URL: http://gna.org/patch/?5736 Summary: Dynamically get supported file formats Project: Freeciv Submitted by: cazfi Submitted on: Wed 21 Jan 2015 05:20:39 AM EET Category: client-gtk-2.0 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0, 3.0.0 ___ Details: Instead of assuming that gtk2-client supports xpm and png, and gtk3-client png, check the support runtime. ___ File Attachments: --- Date: Wed 21 Jan 2015 05:20:39 AM EET Name: GtkGfxFileExtensions.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=23567 ___ Reply to this item at: http://gna.org/patch/?5736 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
