[Freeciv-Dev] [patch #6833] Max paratroopers_range is 255

[Marko Lindqvist]

Update of patch #6833 (project freeciv):

 Planned Release: 3.0.0, 2.6.0, 2.5.3 => 3.0.0, 2.6.0, 2.5.4


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6833] Max paratroopers_range is 255

[Sveinung Kvilhaugsvik]

Follow-up Comment #10, patch #6833 (project freeciv):

> Is there some complication in that?
1) I hadn't checked that it would be enough to cover the full map. (I now
believe that I understand map.h well enough to say that it does)
2) I was thinking about adding a "no range limit". (Would anyone be interested
in 254 but not 255?) A bit close to 2.6 for my taste. Could be communicated
with a special value. In that case the limit should have room for it. (I
reserved the top value for that use)

> No ticket about this is set as dependency of task #7814.
I forgot. Thank you for the reminder.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6833] Max paratroopers_range is 255

[Marko Lindqvist]

Follow-up Comment #9, patch #6833 (project freeciv):

> I considered to increase the limit to 65536 (UNIT16) in a follow up patch.

Is there some complication in that? If it would have been one-liner in
packets.def, I don't understand why you want to first document current limit
everywhere and then revert all that in a patch that does the one-liner to lift
the limit.

No ticket about this is set as dependency of task #7814. Is the limit of 255
now forced in rssanity.c meant to be part of final S2_6 ruleset format?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6833] Max paratroopers_range is 255

[Sveinung Kvilhaugsvik]

Update of patch #6833 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6833] Max paratroopers_range is 255

[Sveinung Kvilhaugsvik]

Follow-up Comment #5, patch #6833 (project freeciv):

> All it does is documenting the limit. (Refusing to load could cause
currently loading rulesets to stop loading) 
New 2.5 version. It warns but doesn't refuse to load a ruleset with an out of
range unit.

(file #26477)
___

Additional Item Attachment:

File name: 2.5-Max-paradrop-range-is-255.patch Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6833] Max paratroopers_range is 255

[Sveinung Kvilhaugsvik]

Update of patch #6833 (project freeciv):

 Planned Release:3.0.0, 2.6.0 => 3.0.0, 2.6.0, 2.5.3

___

Follow-up Comment #4:

> just document the situation in S2_5.
I agree. 2.5 patch attached. All it does is documenting the limit. (Refusing
to load could cause currently loading rulesets to stop loading)

> I considered to increase the limit
Now bug #24349

(file #26476)
___

Additional Item Attachment:

File name: 2.5-Max-paradrop-range-is-255.patch Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6833] Max paratroopers_range is 255

[Marko Lindqvist]

Follow-up Comment #3, patch #6833 (project freeciv):

I'm thinking what to do with S2_5. If we consider this undocumented limitation
(paratrooper range can't be big enough for enabling world-range paradropping
on larger maps) a bug, we may even want to change network protocol there, with
an optional capability.

Since the limitation is not a regression from older versions, I think that
changing the protocol to support it would be more like protocol freeze
breakage (new ruleset relying on the change would not work on freeciv 2.5.0 -
2.5.2) than a bugfix -> just document the situation in S2_5.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6833] Max paratroopers_range is 255

[Sveinung Kvilhaugsvik]

Follow-up Comment #2, patch #6833 (project freeciv):

> Wouldn't it be better just to lift the limit by changing it to UINT16 in
network protocol?
I considered to increase the limit to 65536 (UNIT16) in a follow up patch.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6833] Max paratroopers_range is 255

[Marko Lindqvist]

Follow-up Comment #1, patch #6833 (project freeciv):

Wouldn't it be better just to lift the limit by changing it to UINT16 in
network protocol?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6833] Max paratroopers_range is 255

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Max paratroopers_range is 255
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 20 Jan 2016 11:47:45 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

The network protocol transfers paratroopers_range in an UINT8. This limits its
value to 255.

Add a sanity check that paratroopers_range is in range. Document the maximum
value in ruleset comments.



___

File Attachments:


---
Date: Wed 20 Jan 2016 11:47:45 PM UTC  Name:
3.0-Max-paradrop-range-is-255.patch  Size: 9kB   By: sveinung


---
Date: Wed 20 Jan 2016 11:47:45 PM UTC  Name:
2.6-Max-paradrop-range-is-255.patch  Size: 8kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev