Re: [Freecol-developers] Coronado / PF83

[Michael T. Pope]

On Wed, 22 Dec 2021 17:53:59 +0100 (CET)
Stefan Fellner  wrote:
> > I think that might be overkill.  I might be misunderstanding here.  What
> > is currently wrong?
> >
> Col1 (v3) would grant you the 11x11 sight radius for all colonies, also newly 
> founded, also your own colonies. Also with the ability seeAllColonies this is 
> not what Coronado would grant you in freecol (at least not in my tests).

Did you test classic or freecol rules?  classic has a hack to reveal the
full 11x11, as required for Col1 compatibility. freecol-rules does
not.  I do not remember what I did at the time, but judging by
reaction on PF83 I probably decided it was excessive for freecol.  Is the
classic-rules hack not working?

FreeCol (the program, not the ruleset:-) (should) distinguish visibility
from exploration.  Exploration just reveals the terrain and improvements.
Visibility is exploration plus units.  Here is what I think we have ATM:

classic-rules:
- 11x11 exploration for all colonies when Coronado joins
- ongoing 5x5 visibility of your own colonies only

freecol-rules:
- 5x5 exploration for all colonies when Coronado joins
- ongoing 5x5 visibility of all colonies (provided by seeAllColonies)

So if I understand aright, the problem is that classic-rules should
also provide 11x11 exploration for new colonies?

If so, IMHO the best way to do this is in the update sent to
players from the build-colony code.

Cheers,
Mike Pope


pgpyvYJ8j_UDC.pgp
Description: OpenPGP digital signature
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Re: [Freecol-developers] Coronado / PF83

[Michael T. Pope]

On Tue, 21 Dec 2021 19:26:35 +0100 (CET)
Stefan Fellner  wrote:
> I added to your ServerPlayer#csEndTurn (you added for laSalle), also the 
> coronado-reveal territory call, for in col1 that also applies for all newly 
> founded colonies.

I think that might be overkill.  I might be misunderstanding here.  What
is currently wrong?  If it is that Col1-Coronado grants display of new
colonies, then AFAICT that is what we do in the freecol-ruleset, so the
easy way to fix that is just to add the:
   
  

from .../rules/freecol/specification.xml to
.../rules/classic/specification.xml.  See Player.getVisibleTileSet.  That

> -> created branch therefore, 
> 
> jazzrexl/add-coronado-seeallcolonies-end-of-turn

Nitpicks.
1. Please do not create new functions without javadoc.
2. cs*() routines have the convention that the ChangeSet argument is last.

Cheers,
Mike Pope


pgpUSIuSqOPTx.pgp
Description: OpenPGP digital signature
___
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers