Re: [Freedos-devel] package contains an invalid filename

2022-09-03 Thread Paul Dufresne via Freedos-devel
First, fdnpkg contains zlib to handle zip files.

It's version is the 2013 version (1.2.8) while most recent is 1.2.12 (2022).



Maybe the invalid zip sig is linked to that... unsure.





Also, pkginst.c have:

/* validate a filename (8+3, no weird characters, etc). returns 0 on success,

 * nonzero otherwise. */

static int validfilename(char *fname) {

  int i, i2;

  char *validchars = "!#$%&'()-@^_`{}~";

  int elemlen = 0;

  int elemmaxlen = 8; /* switches from 8 to 3 depending wheter I am analyzing

 a filename or an extension */

  /* look for invalid chars in the entire string, and check the length of the

   * element at the same time */



So yeah... I guess this is linked to the fact that Gitlab insert a directory 
name with the name of the project-name of branch at the top of zip file.

This make it invalid... too long.

But also it is unclear it would know that it must look for source not in top, 
but in the single directory in top of the archive.



So... maybe should begin to update to latest zlib... then find a way to ignore 
first part of paths.



Of course... if I wait one month... the OS installer thing would do a valid 
archive ... hopefully (I wanted to early test).

Sent using https://www.zoho.com/mail/








 Le sam., 03 sept. 2022 16:28:01 -0400 Paul Dufresne via Freedos-devel 
 a écrit 



unzip djgpp.zip in FreeDOS was happy to execute without errors.

funny... the whatin.sh file was the last one inflated.






___ 
Freedos-devel mailing list 
Freedos-devel@lists.sourceforge.net 
https://lists.sourceforge.net/lists/listinfo/freedos-devel___
Freedos-devel mailing list
Freedos-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-devel


Re: [Freedos-devel] package contains an invalid filename

2022-09-03 Thread Paul Dufresne via Freedos-devel
unzip djgpp.zip in FreeDOS was happy to execute without errors.

funny... the whatin.sh file was the last one inflated.___
Freedos-devel mailing list
Freedos-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-devel


Re: [Freedos-devel] package contains an invalid filename

2022-09-03 Thread Paul Dufresne via Freedos-devel
hum... maybe... but it' always on .md file, .ver file (or this time .sh) files.



I just tried to extract in Linux, rename the djgpp_unstable to just djgpp, 
rezip...



But then in FreeDOS on the fdnpkg command I got:

unknow zip sig: 0x92cb9dd5

Error: Invalid zip archive! Package not installed.



Tried to search that ID... did not found something.___
Freedos-devel mailing list
Freedos-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-devel


Re: [Freedos-devel] package contains an invalid filename

2022-09-03 Thread Jim Hall
On Sat, Sep 3, 2022 at 2:55 PM Paul Dufresne via Freedos-devel
 wrote:
>
> Like the guy that wrote a small program... and come to the compiler and 
> naively expect it to compile it without errors...
> I have come to "fdnpkg install-nosrc djgpp_uns~1.zip" and was replied with:
> Error: Package contains an invalid filename:
>   djpp_unstable\source\djgpp\utils\whatin.sh
>
> Is it the .sh (Unix shell ) ...
> does it handle correctly LongFileNames? (I did not remember to have called 
> doslfn.exe...) but djgpp_unstable seems ok... and not 8.3.
>
> Well... do I need to be strict like this in my source directory?
> Frankly... I did just unzip upstream in it... without thinking much more.
>


"djpp_unstable" is 13 characters - that's more than the "8.3" limit in
DOS. So I think that's the problem.


___
Freedos-devel mailing list
Freedos-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-devel