Re: [Freeipa-devel] [PATCH] 632 webui: simplify self-service menu
On 12.6.2014 14:53, Endi Sukma Dewata wrote: On 6/11/2014 10:17 AM, Endi Sukma Dewata wrote: On 6/11/2014 6:06 AM, Petr Vobornik wrote: 1. If I recall correctly, a new user is required to change the password upon the initial login. This can be done with kinit, but can this be done via UI too? Right now a new user will get a login error without any message or link to reset the password. It works for me. There was a ticket https://fedorahosted.org/freeipa/ticket/4339 which corresponds to the description. Or it could be related to: https://git.fedorahosted.org/cgit/freeipa.git/commit/?id=c41b782bc59cd0cb70cbd62d543f9c538109d410 (if you use an IPA version before the revert) I just built the master yesterday. Let me see if I can reproduce it with a newer build. I'm still seeing the problem in the new build. Here are the steps to reproduce: 1. Login as admin. 2. Add a new user with a password. 3. Logout. 4. Login as the new user. It will say The password or username you entered is incorrect. There's no message about expiration or link to change the password. So far the only way to change the password is via kinit. Found the culprit. It was caused by utc vs local time comparison. Patch #676 should fix it. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 632 webui: simplify self-service menu
On 5/15/2014 8:58 AM, Petr Vobornik wrote: Just an idea: there is only one top level item in self service menu - no point of having this level. This patch replaces top level with second menu level original: * http://pvoborni.fedorapeople.org/images/self-service-menu-2levels.png new: * http://pvoborni.fedorapeople.org/images/self-service-menu-1level.png ACK. Some unrelated issues: 1. If I recall correctly, a new user is required to change the password upon the initial login. This can be done with kinit, but can this be done via UI too? Right now a new user will get a login error without any message or link to reset the password. 2. When I logged in to the self-service mode, I got the following error: http://edewata.fedorapeople.org/ipa/images/snapshot7.png 3. In the login screen if the page is shorter than a certain height, there will be a blank area appearing at the bottom. The background doesn't extend all the way to the bottom: http://edewata.fedorapeople.org/ipa/images/snapshot8.png -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 632 webui: simplify self-service menu
Hey Petr, I would actually say the inverse here. Your second option creates unnecessary nesting which we should avoid if possible. We would only want to go to multiple levels in the nav if the number of items in the nav got unwieldy, we then should categorize. Since there are only two items the simplest and clearest way to display them is as they are in the original screenshot. Kyle - Original Message - Just an idea: there is only one top level item in self service menu - no point of having this level. This patch replaces top level with second menu level original: * http://pvoborni.fedorapeople.org/images/self-service-menu-2levels.png new: * http://pvoborni.fedorapeople.org/images/self-service-menu-1level.png -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 632 webui: simplify self-service menu
On 16.5.2014 15:19, Kyle Baker wrote: Hey Petr, I would actually say the inverse here. Your second option creates unnecessary nesting which we should avoid if possible. We would only want to go to multiple levels in the nav if the number of items in the nav got unwieldy, we then should categorize. Since there are only two items the simplest and clearest way to display them is as they are in the original screenshot. Kyle I'm not sure if I understand you correctly. This patch is *removing* one level of nesting, not creating a new one. From: - Identity -- Users -- OTP Tokens To: - Users - OTP Tokens - Original Message - Just an idea: there is only one top level item in self service menu - no point of having this level. This patch replaces top level with second menu level original: * http://pvoborni.fedorapeople.org/images/self-service-menu-2levels.png new: * http://pvoborni.fedorapeople.org/images/self-service-menu-1level.png -- Petr Vobornik -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 632 webui: simplify self-service menu
- Original Message - On 16.5.2014 15:19, Kyle Baker wrote: Hey Petr, I would actually say the inverse here. Your second option creates unnecessary nesting which we should avoid if possible. We would only want to go to multiple levels in the nav if the number of items in the nav got unwieldy, we then should categorize. Since there are only two items the simplest and clearest way to display them is as they are in the original screenshot. Kyle I'm not sure if I understand you correctly. This patch is *removing* one level of nesting, not creating a new one. From: - Identity -- Users -- OTP Tokens To: - Users - OTP Tokens Ah, sorry about that I got the images switched. This is much better, ACK - Original Message - Just an idea: there is only one top level item in self service menu - no point of having this level. This patch replaces top level with second menu level original: * http://pvoborni.fedorapeople.org/images/self-service-menu-2levels.png new: * http://pvoborni.fedorapeople.org/images/self-service-menu-1level.png -- Petr Vobornik -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 632 webui: simplify self-service menu
Just an idea:
there is only one top level item in self service menu - no point of
having this level.
This patch replaces top level with second menu level
original:
* http://pvoborni.fedorapeople.org/images/self-service-menu-2levels.png
new:
* http://pvoborni.fedorapeople.org/images/self-service-menu-1level.png
--
Petr Vobornik
From a7fd9c19b8414f6264d9b325e362f1a1f12158cd Mon Sep 17 00:00:00 2001
From: Petr Vobornik pvobo...@redhat.com
Date: Thu, 15 May 2014 15:44:29 +0200
Subject: [PATCH] webui: simplify self-service menu
there is only one top level item - no point of having this level.
This patch replaces top level with second menu level
---
install/ui/src/freeipa/navigation/menu_spec.js | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/install/ui/src/freeipa/navigation/menu_spec.js b/install/ui/src/freeipa/navigation/menu_spec.js
index 0e206b828f68dffc7fe7753033344ed74cffe6a4..a613805148744a2629d3f771272ec67ff43194d6 100644
--- a/install/ui/src/freeipa/navigation/menu_spec.js
+++ b/install/ui/src/freeipa/navigation/menu_spec.js
@@ -146,14 +146,8 @@ var nav = {};
nav.self_service = {
name: 'self-service',
items: [
-{
-name: 'identity',
-label: '@i18n:tabs.identity',
-children: [
-{ entity: 'user' },
-{ entity: 'otptoken' }
-]
-}
+{ entity: 'user' },
+{ entity: 'otptoken' }
]
};
--
1.9.0
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
