Re: module failure with multiple accounting methods

2003-09-16 Thread Alan DeKok
Dave Mason <[EMAIL PROTECTED]> wrote:
> I have a Freeradius server (v0.8.1) where I may configure multiple 
> accounting methods in radiusd.conf.  These could be any of the ones 
> supplied with Freeradius, like detail, radutmp, etc, or a new one that I 
> wrote.  My new one may succeed or fail in writing the accounting 
> record.  Currently, I return RLM_MODULE_FAIL if it fails and 
> RLM_MODULE_OK if it succeeds.  The problem is, if I run another method 
> like detail first and it succeeds, then I run mine and it fails, the 
> accounting group returns failure and no Accounting-Response is sent.  Is 
> that the correct behavior?

  That depends on what you mean by "correct".  It's the way it
currently works...

>  If not, should my accounting method return RLM_MODULE_NOOP or some
> other code in the failure case?  I looked at rlm_detail..c and it
> returns RLM_MODULE_FAIL in its failure cases.  I thought we should
> send Accounting-Response if any succeed, so the remaining
> Accounting-Requests will be sent.

  I think that's a good idea.  The accounting modules can generally
return "NOOP", which is better in some cases.

  However, the SQL modules should return *something* useful when the
database is down.  This will allow configurable fail-over for SQL
back-ends.

  Alan DeKok.

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


module failure with multiple accounting methods

2003-09-12 Thread Dave Mason
Hi,
I have a Freeradius server (v0.8.1) where I may configure multiple 
accounting methods in radiusd.conf.  These could be any of the ones 
supplied with Freeradius, like detail, radutmp, etc, or a new one that I 
wrote.  My new one may succeed or fail in writing the accounting 
record.  Currently, I return RLM_MODULE_FAIL if it fails and 
RLM_MODULE_OK if it succeeds.  The problem is, if I run another method 
like detail first and it succeeds, then I run mine and it fails, the 
accounting group returns failure and no Accounting-Response is sent.  Is 
that the correct behavior?  If not, should my accounting  method return 
RLM_MODULE_NOOP or some other code in the failure case?  I looked at 
rlm_detail..c and it returns RLM_MODULE_FAIL in its failure cases.  I 
thought we should send Accounting-Response if any succeed, so the 
remaining Accounting-Requests will be sent.

Dave



- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html