Re: rlm_perl %RAD_REQUEST re-write (snapshot-20030310)

2003-03-24 Thread Boian Jordanov
On _ 2003-03-23 at 16:41, Latte wrote:
> Hi folks,
> 
> I'm using freeradius-snapshot-20030310
> with rlm_perl feature.
> 
> I want to re-write (modify) values in RAD_REQUEST 
> in 'authorize' phase by some reason.
> In my case here, that is 'User-Name'
> and I want to let other modules (like rlm_realm, rlm_pap/chap)
> process 're-writed' User-Name.
> 
perl hashes are not ordered so if you don't know what are you doing it
is not correct way to do this.
But you can always use rlm_rewrite. 

> In src/modules/rlm_perl/rlm_perl.c functiuon "rlmperl_call"
> I added 
> > PERL_SET_CONTEXT(my_perl);
> > if ((get_hv_content(inst->rad_check_hv, &vp)) == 1 ) {
> > pairmove(&request->packet->vps, &vp);
> > pairfree(&vp);
> > }
> at the bottom of it (though before return of course),
> but it seems not suffice at all. (Erk, sorry for such dummy guess).
> 
> 3 questions:-
>  1. How I modify rlm_perl.c to have it allow me to 
> modify RAD_REQUEST?
> 
>  2. 'experimental.conf' perl module config part says
> > #  Only the %RAD_REPLY hash can be modified.
> > #  All of the other are read only.
> But, I can modify att/value pair for %RAD_CHECK 
> on this version, (and that works for me ;-)).
> Could I understand the status 
> that '%RAD_CHECK' can be also modified (not %RAD_REPLY only) 
> is 'correct'?

Probably i missed this.

> 
>  3. Could it be considerable to modify the rlm_perl module
> in the freeradius distribution
> to allow users to modify RAD_REQUEST, RAD_CHECK and RAD_REPLY
> all in next (or whenever appropriate) version?
> It might be helpful when pre-proxy, post-proxy are implemented 
> in this module as well, no?
> 

From my point of view this can be fixed if %RAD_XXX will be replaced
with some Array of hashes and every element of array will be the single
hash that contains AV pair

> 
> Any comments are welcome.
> Thanks a lot in advance.
> 
> Best regards, 
> Latte
> 
> - 
> List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
-- 
Best Regards,

Boian Jordanov
SNE
Orbitel - the Internet Company
tel. +359 2 937 07 23



signature.asc
Description: This is a digitally signed message part


Re: rlm_perl %RAD_REQUEST re-write (snapshot-20030310)

2003-03-23 Thread Latte

Hi, 

sorry, one correction to avoid confusion.
> > PERL_SET_CONTEXT(my_perl);
> > if ((get_hv_content(inst->rad_check_hv, &vp)) == 1 ) {

Correctly I added
if ((get_hv_content(inst->rad_request_hv, &vp)) == 1 ) {
...

Anyways it does not work.

Thanks a lot.

Best regards, 
Latte


On Sun, 23 Mar 2003 14:41:37 +
Latte <[EMAIL PROTECTED]> wrote:

> 
> Hi folks,
> 
> I'm using freeradius-snapshot-20030310
> with rlm_perl feature.
> 
> I want to re-write (modify) values in RAD_REQUEST 
> in 'authorize' phase by some reason.
> In my case here, that is 'User-Name'
> and I want to let other modules (like rlm_realm, rlm_pap/chap)
> process 're-writed' User-Name.
> 
> In src/modules/rlm_perl/rlm_perl.c functiuon "rlmperl_call"
> I added 
> > PERL_SET_CONTEXT(my_perl);
> > if ((get_hv_content(inst->rad_check_hv, &vp)) == 1 ) {
> > pairmove(&request->packet->vps, &vp);
> > pairfree(&vp);
> > }
> at the bottom of it (though before return of course),
> but it seems not suffice at all. (Erk, sorry for such dummy guess).
> 
> 3 questions:-
>  1. How I modify rlm_perl.c to have it allow me to 
> modify RAD_REQUEST?
> 
>  2. 'experimental.conf' perl module config part says
> > #  Only the %RAD_REPLY hash can be modified.
> > #  All of the other are read only.
> But, I can modify att/value pair for %RAD_CHECK 
> on this version, (and that works for me ;-)).
> Could I understand the status 
> that '%RAD_CHECK' can be also modified (not %RAD_REPLY only) 
> is 'correct'?
> 
>  3. Could it be considerable to modify the rlm_perl module
> in the freeradius distribution
> to allow users to modify RAD_REQUEST, RAD_CHECK and RAD_REPLY
> all in next (or whenever appropriate) version?
> It might be helpful when pre-proxy, post-proxy are implemented 
> in this module as well, no?
> 
> 
> Any comments are welcome.
> Thanks a lot in advance.
> 
> Best regards, 
> Latte
> 
> - 
> List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


rlm_perl %RAD_REQUEST re-write (snapshot-20030310)

2003-03-23 Thread Latte

Hi folks,

I'm using freeradius-snapshot-20030310
with rlm_perl feature.

I want to re-write (modify) values in RAD_REQUEST 
in 'authorize' phase by some reason.
In my case here, that is 'User-Name'
and I want to let other modules (like rlm_realm, rlm_pap/chap)
process 're-writed' User-Name.

In src/modules/rlm_perl/rlm_perl.c functiuon "rlmperl_call"
I added 
> PERL_SET_CONTEXT(my_perl);
> if ((get_hv_content(inst->rad_check_hv, &vp)) == 1 ) {
> pairmove(&request->packet->vps, &vp);
> pairfree(&vp);
> }
at the bottom of it (though before return of course),
but it seems not suffice at all. (Erk, sorry for such dummy guess).

3 questions:-
 1. How I modify rlm_perl.c to have it allow me to 
modify RAD_REQUEST?

 2. 'experimental.conf' perl module config part says
> #  Only the %RAD_REPLY hash can be modified.
> #  All of the other are read only.
But, I can modify att/value pair for %RAD_CHECK 
on this version, (and that works for me ;-)).
Could I understand the status 
that '%RAD_CHECK' can be also modified (not %RAD_REPLY only) 
is 'correct'?

 3. Could it be considerable to modify the rlm_perl module
in the freeradius distribution
to allow users to modify RAD_REQUEST, RAD_CHECK and RAD_REPLY
all in next (or whenever appropriate) version?
It might be helpful when pre-proxy, post-proxy are implemented 
in this module as well, no?


Any comments are welcome.
Thanks a lot in advance.

Best regards, 
Latte

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html