Re: Window geometry differences
On Sun, May 23, 2010 at 12:24:18PM -0500, Adam Croft wrote: > Now that I'm checking all the apps I use, it seems Firefox is really the > only one exhibiting the problem. I swear I've seen it happen with other > applications, but can't reproduce it now. No idea then -- works fine here after my fix. -- Thomas Adam -- "It was the cruelest game I've ever played and it's played inside my head." -- "Hush The Warmth", Gorky's Zygotic Mynci.
Re: FVWM: Can't open new windows?
On Wed, May 19, 2010 at 10:00:50AM -0700, Omar Zakaria wrote:
> Thanks again for looking at this. I really appreciate it. Let me know if
> I can help in any way.
Can you please checkout the CVS version of FVWM and apply the patch
attached? See if it "fixes" your problem?
-- Thomas Adam
--
"It was the cruelest game I've ever played and it's played inside my head."
-- "Hush The Warmth", Gorky's Zygotic Mynci.
Index: fvwm/add_window.c
===
RCS file: /home/cvs/fvwm/fvwm/fvwm/add_window.c,v
retrieving revision 1.401
diff -u -p -r1.401 add_window.c
--- fvwm/add_window.c 2 Aug 2009 15:04:08 - 1.401
+++ fvwm/add_window.c 23 May 2010 18:33:50 -
@@ -2378,10 +2378,14 @@ FvwmWindow *AddWindow(
}
else
{
- attributes.event_mask = XEVMASK_CLIENTW;
+ /* TA: Temporarily assign Substructure masks here, and
+ * consider adding them to XEVMASK_CLIENTW if proven to work.
+ */
+ attributes.event_mask = XEVMASK_CLIENTW | \
+ SubstructureRedirectMask | SubstructureNotifyMask;
}
attributes.do_not_propagate_mask = ButtonPressMask | ButtonReleaseMask;
- XChangeWindowAttributes(dpy, FW_W(fw), valuemask, &attributes);
+ XChangeWindowAttributes(dpy, FW_W_PARENT(fw), valuemask, &attributes);
/** make sure the window is not destroyed when fvwm dies **/
if (!IS_TEAR_OFF_MENU(fw))
{
Re: Window geometry differences
Yeah, I'm fairly sure it's CVS. I completely removed the existing fvwm package and reinstalled CVS. This is the output from fvwm -V: ~$ fvwm -V fvwm 2.5.31 (from cvs) compiled on May 22 2010 at 23:44:58 with support for: ReadLine, RPlay, XPM, PNG, SVG, Shape, XShm, SM, Bidi text, Xinerama, XRender, XCursor, XFT, NLS Now that I'm checking all the apps I use, it seems Firefox is really the only one exhibiting the problem. I swear I've seen it happen with other applications, but can't reproduce it now. Adam On Sun, May 23, 2010 at 5:31 AM, Thomas Adam wrote: > On Sun, May 23, 2010 at 12:06:57AM -0500, Adam Croft wrote: > > Thanks for getting back so quickly. I'm not using ResizeHintOverride. > > OK, well it was still a bug which would have reported a width/height of: > > 80x24 > > to always be 80x24, even though the window was 79x23, due to ignoring > resize > increments. That's the only bug it could have been, given the way you > described it originally. > > > Perhaps I have something else in my config which is causing the issue. I > did > > try CVS as you asked and still have the issue. My config file is attached > in > > case you want to see where the problem might be. > > Are you sure you were using the CVS version (/usr/local/bin/fvwm versus > /usr/bin/fvwm)? Given your config, can you tell me what applications I > need > to load to exhibit this problem? > > -- Thomas Adam > > -- > "It was the cruelest game I've ever played and it's played inside my head." > -- "Hush The Warmth", Gorky's Zygotic Mynci. >
CVS tadam: Fix WindowList to use resize increments correctly.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: tadam 10/05/22 11:56:04 Modified files: . : ChangeLog NEWS fvwm : windowlist.c Log message: Fix WindowList to use resize increments correctly. When reporting on a window's width and height ensure we use the orig_hints XSizeHints struct for calculating resize increment geometries.
Re: Window geometry differences
On Fri, May 21, 2010 at 03:23:24PM -0500, Adam Croft wrote: > Configuration Information [Automatically generated, do not change]: > uname: Linux redwood 2.6.27.7-smp #2 SMP Thu Nov 20 22:32:43 CST 2008 i686 > Intel > (R) Core(TM)2 Quad CPUQ9550 @ 2.83GHz GenuineIntel GNU/Linux > compiler flags: gcc -Wall -Wno-implicit-int -g -O2 > > FVWM Version: 2.5.28 > FVWM_MODULEDIR: /usr/libexec/fvwm/2.5.28 > FVWM_DATADIR: /usr/share/fvwm > FVWM_USERDIR: /home/adam/.fvwm Sorry for the delay -- just pushed a fix for this, if you'd be so kind as to try FVWM CVS, please? -- Thomas Adam -- "It was the cruelest game I've ever played and it's played inside my head." -- "Hush The Warmth", Gorky's Zygotic Mynci.
Re: Window geometry differences
On Sun, May 23, 2010 at 12:06:57AM -0500, Adam Croft wrote: > Thanks for getting back so quickly. I'm not using ResizeHintOverride. OK, well it was still a bug which would have reported a width/height of: 80x24 to always be 80x24, even though the window was 79x23, due to ignoring resize increments. That's the only bug it could have been, given the way you described it originally. > Perhaps I have something else in my config which is causing the issue. I did > try CVS as you asked and still have the issue. My config file is attached in > case you want to see where the problem might be. Are you sure you were using the CVS version (/usr/local/bin/fvwm versus /usr/bin/fvwm)? Given your config, can you tell me what applications I need to load to exhibit this problem? -- Thomas Adam -- "It was the cruelest game I've ever played and it's played inside my head." -- "Hush The Warmth", Gorky's Zygotic Mynci.
