Re: Patch proposal for FvwmButtons with two new options
Hi, Thanks for your patch. Please apply locally. I shan't be accepting it in mainline. Kindly, Thomas On Mon, 29 Apr 2019, 08:23 Hegel3DReloaded, wrote: > On Monday, 29. April 2019 7:10, Thomas Adam wrote: > > > > Where's your patch? > > I have never achieved to remember attaching what I refer to. > Sorry. :-( > > Here it is. > > > I can't say I see the need for what you're describing as 'WindowName'. > But I > > might be persuaded otherwise with an example of what you're trying to do. > > Simply put, if I have FvwmButtons popup subpanel with title "Applications" > everything is ok: I can refer to it with "*Applications:" in configuration, > but if I want title "My Applications" then this doesn't work obviously. > > > That said, FVWM2 is in maintenance mode, and as such, I'd be extremely > > reluctant to shoehorn in more features like this. > > :-\ > > > -- > ... one of the main causes of the fall of the Roman Empire > was that, lacking zero, they had no way to indicate > successful termination of their C programs. > -- Robert Firth > >
Re: Patch proposal for FvwmButtons with two new options
On Monday, 29. April 2019 7:10, Thomas Adam wrote: > Where's your patch? I have never achieved to remember attaching what I refer to. Sorry. :-( Here it is. > I can't say I see the need for what you're describing as 'WindowName'. But I > might be persuaded otherwise with an example of what you're trying to do. Simply put, if I have FvwmButtons popup subpanel with title "Applications" everything is ok: I can refer to it with "*Applications:" in configuration, but if I want title "My Applications" then this doesn't work obviously. > That said, FVWM2 is in maintenance mode, and as such, I'd be extremely > reluctant to shoehorn in more features like this. :-\ -- ... one of the main causes of the fall of the Roman Empire was that, lacking zero, they had no way to indicate successful termination of their C programs. -- Robert Firth FvwmButtons_sunkraise_windowname_unified.patch Description: Binary data
Re: Patch proposal for FvwmButtons with two new options
On Mon, Apr 29, 2019 at 06:09:22AM +, Hegel3DReloaded wrote: > I have added two options: WindowName and second argument for arrow > indicator on triangle which says if triangle will look pressed or depressed > (indicator 12 in|out). Default is out and it can be ommited for backward > config > compatibility. WindowName is when I want transient FvwmButtons panel to > have title bar with title that contains spaces and symbols which cannot be > part of the alias to FvwmButtons module in configuration. I'm not much a > programmer. Specially not for C, but I have a text editor and a good will. I'm > attaching a patch proposal in the hope it will be considered and eventualy > merged if it is not really bad. Edited also manpage. Where's your patch? I can't say I see the need for what you're describing as 'WindowName'. But I might be persuaded otherwise with an example of what you're trying to do. That said, FVWM2 is in maintenance mode, and as such, I'd be extremely reluctant to shoehorn in more features like this. -- Thomas
Patch proposal for FvwmButtons with two new options
Hello all, I have been using and abusing FVWM for a 14-15 year now. I have made it long ago to look like CDE, and recently had a chance to rewrite this all as some kind of heavyweight theme and wrapper around fvwm. Called it NsCDE (Not so Common Desktop Environment). ( https://github.com/NsCDE/NsCDE.git ) Yes, many say this is sick, but I like it and I have discovered there are much more lunatics like me in wild, so I'm not alone. :-) But for some things to look smooth and more like original I had to alter code of the FvwmButtons. I have added two options: WindowName and second argument for arrow indicator on triangle which says if triangle will look pressed or depressed (indicator 12 in|out). Default is out and it can be ommited for backward config compatibility. WindowName is when I want transient FvwmButtons panel to have title bar with title that contains spaces and symbols which cannot be part of the alias to FvwmButtons module in configuration. I'm not much a programmer. Specially not for C, but I have a text editor and a good will. I'm attaching a patch proposal in the hope it will be considered and eventualy merged if it is not really bad. Edited also manpage. Sorry for my horrible english ... ... one of the main causes of the fall of the Roman Empire was that, lacking zero, they had no way to indicate successful termination of their C programs. -- Robert Firth
