Re: FVWM: Small localization patch
On 4/17/07, Jesús Guerrero <[EMAIL PROTECTED]> wrote: El Tue, 17 Apr 2007 09:30:57 +0100 "seventh guardian" <[EMAIL PROTECTED]> escribió: > On 4/17/07, seventh guardian <[EMAIL PROTECTED]> wrote: > > On 4/14/07, Jesús Guerrero <[EMAIL PROTECTED]> wrote: > > > Localization for the "More&..." string in the menus. > > > > > > http://jesgue.homelinux.org/fvwm-files/gtMore.patch > > > > Seems ok, can you provide a ChangeLog entry? > > Can you also provide an entry to the pot file? > > I supose everyone is wellcome to translate it to other languages. > > Cheers, > Renato > Sure, I can also provide a diff for the man page, if you think it would be an interesting feature. For example, the man page says: [snip] Menu Anatomy Menus consist of any number of titles which are inactive menu items that usually appear at the top of the menu, normal items triggering various actions when selected,separator lines between the items, tear off bars (a horizontal broken line) that tear off the menu when selected, and sub menu items indicated with a triangle pointing left or right, depending on the direction in which the sub menu appears. All the above menu items are optional. Additionally, if the menu is too long to fit on the screen, the excess menu items are put in a continuation menu and a sub menu with the string "More..." is placed at the bottom of the menu. Finally, there may be a picture running up either side of the menu (a "side bar"). [/snip] May I add something like: [snip] This string ("More...") honours the locale, though the msgid "More&..." [/snip] ??? If you have a better suggestion, let me know. I think that documenting the feature would be nice, but maybe I am wrong, and it is enough to include the msgids in the po files. I guess so, but I'm not sure.. I'm afraid that these details would make our huge man page even more unreadable :P Opinions from the senior devs? I can make a single patch for all the po files is anyone can provide translations for the word "More", I don't trust google translator :P If that is not the case, may I patch only the english locale? Or may I patch all of them using english, so anyone will remember to translate it later? I would just add the translated ones for now.. If you could provide patches for other languages it would be great. Cheers, Renato
Re: FVWM: Small localization patch
El Tue, 17 Apr 2007 15:55:44 +0100 "seventh guardian" <[EMAIL PROTECTED]> escribió: > > Oh!! Sorry for the mess, I was the one who didn't check! [embarassed] > Anyway, it's probably better to keep this discussion on the workers > list... > > > > Sorry, I forgot to include the Changelog entry, new patch > > > attached. > > > > Ok, I'll check it as soon as I have some time.. Maybe tonight. > > Cheers, > Renato > Nah, I am the one that posted wrongly, and the one to be sorry. The discussion started at fvwm-workers, but I got someone confused in the middle and started posting at [EMAIL PROTECTED] at some point. Don't hesitate to correct me if I do something wrong, and forgive me, please, for any inconvenience caused by my incompetence. -- Jesús Guerrero
Re: FVWM: Small localization patch
On 4/17/07, Jesús Guerrero <[EMAIL PROTECTED]> wrote: El Tue, 17 Apr 2007 14:22:27 +0200 Jesús Guerrero <[EMAIL PROTECTED]> escribió: > The patch has been attached to this mail. We were on the Workers-list, not on the General-list. Please pay attention to that to avoid cross messages.. They get difficult to track. Sorry, I forgot to include the Changelog entry, new patch attached. Ok, I'll check it as soon as I have some time.. Maybe tonight. Cheers, Renato
Re: FVWM: Small localization patch
On 4/17/07, seventh guardian <[EMAIL PROTECTED]> wrote: On 4/17/07, Jesús Guerrero <[EMAIL PROTECTED]> wrote: > El Tue, 17 Apr 2007 14:22:27 +0200 > Jesús Guerrero <[EMAIL PROTECTED]> escribió: > > > The patch has been attached to this mail. We were on the Workers-list, not on the General-list. Please pay attention to that to avoid cross messages.. They get difficult to track. Oh!! Sorry for the mess, I was the one who didn't check! [embarassed] Anyway, it's probably better to keep this discussion on the workers list... > Sorry, I forgot to include the Changelog entry, new patch attached. Ok, I'll check it as soon as I have some time.. Maybe tonight. Cheers, Renato
Re: FVWM: Small localization patch
On 4/17/07, Jesús Guerrero <[EMAIL PROTECTED]> wrote: El Tue, 17 Apr 2007 14:22:27 +0200 Jesús Guerrero <[EMAIL PROTECTED]> escribió: > The patch has been attached to this mail. Sorry, I forgot to include the Changelog entry, new patch attached. Ok, I've reviewed the patch and will submit it soon. I've made some small corrections though: * First of all, the ChangeLog for the localization files is on the po/ subdir. * The translation entries have a description on top of them that help locating the code to which they apply, so I've added that. * Finally I've "compacted" a bit the manual page entry and the main ChangeLog entry: usually you don't need a throughly explanation of the changes, a simple note suffices (and usually is more readable). You can check the reviewed patch (on annex), which should help you next time. Other than that, good work :) Cheers, Renato gtMore_v3.patch Description: Binary data
Re: FVWM: Small localization patch
El Wed, 18 Apr 2007 16:12:57 +0100 "seventh guardian" <[EMAIL PROTECTED]> escribió: Hello, > * First of all, the ChangeLog for the localization files is on the > po/ subdir. > * The translation entries have a description on top of them that help > locating the code to which they apply, so I've added that. > * Finally I've "compacted" a bit the manual page entry and the main > ChangeLog entry: usually you don't need a throughly explanation of the > changes, a simple note suffices (and usually is more readable). > > You can check the reviewed patch (on annex), which should help you > next time. Other than that, good work :) > Thanks for all the notes and corrections. They are much appreciated. In the future I will try to make it better. Thanks for all the attention and your patience. I am glad to be helpful even if it is just a very small piece of the puzzle. -- Jesús Guerrero