FvwmButtons core dump

2001-08-16 Thread Olivier Chapuis
I get a FvwmButtons core dump when I change colorsets and the buttons
contains swallowed shaped app.

FvwmButtons-WMakerApplets: Cause of next X Error.
   Error: 4 (BadPixmap)
   Major opcode of failed request:  54 (FreePixmap)
   Minor opcode of failed request:  0 
   Resource id of failed request:  0x2a2 
 Leaving a core dump now

[EMAIL PROTECTED] bin]$ gdb /usr/local/libexec/fvwm/2.4.1-beta1/FvwmButtons 
~/core
GNU gdb 4.18
Core was generated by `/usr/local/libexec/fvwm/2.4.1-beta1/FvwmButtons 19 4 
none 0 8 FvwmButtons-WMake'.
Program terminated with signal 6, Abandon.
Reading symbols from /usr/X11R6/lib/libXpm.so.4...done.
Reading symbols from /usr/X11R6/lib/libSM.so.6...done.
Reading symbols from /usr/X11R6/lib/libICE.so.6...done.
Reading symbols from /usr/X11R6/lib/libXext.so.6...done.
Reading symbols from /usr/X11R6/lib/libX11.so.6...done.
Reading symbols from /lib/libm.so.6...done.
Reading symbols from /lib/libc.so.6...done.
Reading symbols from /lib/ld-linux.so.2...done.
Reading symbols from /usr/lib/gconv/ISO8859-1.so...done.
#0  0x40149091 in kill () from /lib/libc.so.6
(gdb) where
#0  0x40149091 in kill () from /lib/libc.so.6
#1  0x40148d79 in raise () from /lib/libc.so.6
#2  0x4014a4f0 in abort () from /lib/libc.so.6
#3  0x805b97c in error_name (code=134620072) at XError.c:59
#4  0x804b4cd in myErrorHandler (dpy=0x80623a8, event=0xb20c)
at FvwmButtons.c:675
#5  0x4008f66d in _XError () from /usr/X11R6/lib/libX11.so.6
#6  0x4008e16b in _XReply () from /usr/X11R6/lib/libX11.so.6
#7  0x400784c7 in XGetWindowAttributes () from /usr/X11R6/lib/libX11.so.6
#8  0x8059f8f in GetEqualSizeChildren (dpy=0x80623a8, parent=100663299, 
depth=16, visualid=34, colormap=35, ret_children=0xb458)
at WinMagic.c:268
#9  0x804e04f in change_swallowed_window_colorset (b=0x8077278, do_clear=0)
at FvwmButtons.c:2325
#10 0x8050a78 in RedrawButton (b=0x8077278, clean=1) at draw.c:350
#11 0x804bdce in Loop () at FvwmButtons.c:1014
#12 0x804bccb in main (argc=7, argv=0xb7f4) at FvwmButtons.c:961
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: FvwmButtons core dump

2001-08-16 Thread Dominik Vogt
On Wed, Aug 15, 2001 at 08:06:42AM +0200, Olivier Chapuis wrote:
 I get a FvwmButtons core dump when I change colorsets and the buttons
 contains swallowed shaped app.
 
 FvwmButtons-WMakerApplets: Cause of next X Error.
Error: 4 (BadPixmap)
Major opcode of failed request:  54 (FreePixmap)
Minor opcode of failed request:  0 
Resource id of failed request:  0x2a2 
  Leaving a core dump now
 
 [EMAIL PROTECTED] bin]$ gdb /usr/local/libexec/fvwm/2.4.1-beta1/FvwmButtons 
 ~/core
 GNU gdb 4.18
 Core was generated by `/usr/local/libexec/fvwm/2.4.1-beta1/FvwmButtons 19 4 
 none 0 8 FvwmButtons-WMake'.
 Program terminated with signal 6, Abandon.
 Reading symbols from /usr/X11R6/lib/libXpm.so.4...done.
 Reading symbols from /usr/X11R6/lib/libSM.so.6...done.
 Reading symbols from /usr/X11R6/lib/libICE.so.6...done.
 Reading symbols from /usr/X11R6/lib/libXext.so.6...done.
 Reading symbols from /usr/X11R6/lib/libX11.so.6...done.
 Reading symbols from /lib/libm.so.6...done.
 Reading symbols from /lib/libc.so.6...done.
 Reading symbols from /lib/ld-linux.so.2...done.
 Reading symbols from /usr/lib/gconv/ISO8859-1.so...done.
 #0  0x40149091 in kill () from /lib/libc.so.6
 (gdb) where
 #0  0x40149091 in kill () from /lib/libc.so.6
 #1  0x40148d79 in raise () from /lib/libc.so.6
 #2  0x4014a4f0 in abort () from /lib/libc.so.6
 #3  0x805b97c in error_name (code=134620072) at XError.c:59
 #4  0x804b4cd in myErrorHandler (dpy=0x80623a8, event=0xb20c)
 at FvwmButtons.c:675
 #5  0x4008f66d in _XError () from /usr/X11R6/lib/libX11.so.6
 #6  0x4008e16b in _XReply () from /usr/X11R6/lib/libX11.so.6
 #7  0x400784c7 in XGetWindowAttributes () from /usr/X11R6/lib/libX11.so.6
 #8  0x8059f8f in GetEqualSizeChildren (dpy=0x80623a8, parent=100663299, 
 depth=16, visualid=34, colormap=35, ret_children=0xb458)
 at WinMagic.c:268
 #9  0x804e04f in change_swallowed_window_colorset (b=0x8077278, do_clear=0)
 at FvwmButtons.c:2325
 #10 0x8050a78 in RedrawButton (b=0x8077278, clean=1) at draw.c:350
 #11 0x804bdce in Loop () at FvwmButtons.c:1014
 #12 0x804bccb in main (argc=7, argv=0xb7f4) at FvwmButtons.c:961

Thiss core dump isn't very helpful.  Obviously an X error occured
that was not handled and then the routine that should generate the
core dump crashed (probably by accessing an array index of
(unsigned char)-1 ).

T'll submit a fix for the crash in XError.c.  Please try to make
that happen again then.  Also, I tried to reproduce this, but
could not.  If the problem does not become obvious with a proper
core dump, can you please provide more information on the bug?

Bye

Dominik ^_^  ^_^

-- 
Dominik Vogt, email: [EMAIL PROTECTED]
LifeBits Aktiengesellschaft, Albrechtstr. 9, D-72072 Tuebingen
fon: ++49 (0) 7071/7965-0, fax: ++49 (0) 7071/7965-20
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


CVS domivogt: * Fixed core dump in error handling routine.

2001-08-16 Thread FVWM CVS
CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by: domivogt01/08/16 04:53:04

Modified files:
.  : ChangeLog 
libs   : XError.c 

Log message:
* Fixed core dump in error handling routine.

--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: FvwmButtons core dump

2001-08-16 Thread Tim Phipps
fvwm-workers@fvwm.org wrote:
 
 On Wed, Aug 15, 2001 at 08:06:42AM +0200, Olivier Chapuis wrote:
  I get a FvwmButtons core dump when I change colorsets and the buttons
  contains swallowed shaped app.
 
  FvwmButtons-WMakerApplets: Cause of next X Error.
 Error: 4 (BadPixmap)
 Major opcode of failed request:  54 (FreePixmap)
 Minor opcode of failed request:  0
 Resource id of failed request:  0x2a2
   Leaving a core dump now

 This core dump isn't very helpful.  Obviously an X error occured
 that was not handled and then the routine that should generate the
 core dump crashed (probably by accessing an array index of
 (unsigned char)-1 ).

I think the routine worked correctly i.e. it called abort(). The X-error
is included above. Where it originates is another matter, you have to
run in synchronous mode or guess. From the description it sounds like
FvwmButtons is trying to free the shape mask (which belongs to the
swallowed app)

Cheers,
Tim.
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: Xinerama patch for Maximize

2001-08-16 Thread Dominik Vogt
On Wed, Aug 15, 2001 at 08:30:20PM +0700, Dmitry Yu. Bolkhovityanov wrote:
   Hi!
 
   This patch touches solely the move_resize.c.  I've tried to modify
 fvwm2.1, but my roff skills seem to be below what required to keep
 Maximize description in the same style (the latter seems a bit wrong BTW
 -- too many spaces).
 
   I've added an optional global switch, which means that
 maximization should be made on a global screen, otherwise it is made on 
 the screen where the center of a window is.  grow* are also adjusted
 (that turned to be the easiest part of the task).

I have been thinking about an entirely different approach that
uses XGeometry specs:

  Maximize on [EMAIL PROTECTED]

The problem here is to specify the resize unit (screen % or
pixels) and where to place the grow option.  The same syntax
could be used for the Move, Resize and ResizeMove commands.

   There are some problems with maximizing windows that aren't on the
 current page when the page itself doesn't start on a page boundary, but
 that effect existed before anyway.  

I see.  Consider it fixed :)

   And there is a comment maximize on visible page after
 IsRectangleOnThisPage() check, which doesn't seem to be correct -- somehow
 it happens that windows are maximized on visible page even if they are by
 some part (not entirely) on it. 

The comment should better read:

  maximize on the page where the center of the window is, but if
  any part of the window is on the current page, maximize it
  there.

 BTW, Dominik, was it done intentionally that in Xinerama emulation mode
  the vertical separator doesn't separate, but in fact overlaps two
  left pixels of the second pseudo-screen?  The result seems a bit
  confusing ;-)

You would have to ask Olivier.  He wrote that stuff.  Anyway, I
don't really care about this.  It is only meant as visible
feedback for testing and debugging.

Bye

Dominik ^_^  ^_^

-- 
Dominik Vogt, email: [EMAIL PROTECTED]
LifeBits Aktiengesellschaft, Albrechtstr. 9, D-72072 Tuebingen
fon: ++49 (0) 7071/7965-0, fax: ++49 (0) 7071/7965-20
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


CVS domivogt: * Fixed maximizing windows with the vieport not starting on a page boundary.

2001-08-16 Thread FVWM CVS
CVSROOT:/home/cvs/fvwm
Module name:fvwm
Changes by: domivogt01/08/16 05:23:09

Modified files:
.  : ChangeLog NEWS 
fvwm   : move_resize.c 

Log message:
* Fixed maximizing windows with the vieport not starting on a page boundary.

--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]


Re: FvwmButtons doesn't like multiple Actions with whitespace separation

2001-08-16 Thread Tim Phipps
fvwm-workers@fvwm.org wrote:
 I don't think this is a bug.  Omitting the commas between the
 options is not officially supported.  This happens because

OK then can we change the FvwmButtons man page and add a note in NEWS:

 *FvwmButtons: (options) [title icon command]
  Specifies the contents of a button  in  the  buttonbox.
  The  following  options,  separated  by  commas or whi-
  tespace, can be given a button:

Cheers,
Tim.
--
Visit the official FVWM web page at URL:http://www.fvwm.org/.
To unsubscribe from the list, send unsubscribe fvwm-workers in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]