Re: [Ganglia-developers] request to merge some corrective patches (specfile, systemd service files, INSTALL, fixconfig)
Hi Jeff, That was my 1st time doing that, but apparently it has been already merged. Regarding scripts/fixconfig.in it has been merged as well. This is better than nothing, but my comment was, while it fixes the issue, is IMHO a bad solution and I was asking for better solution. If a skilled autoconf developer is reading this, please help as IMHO, it's an easy fix for someone that is used in autotools. To be more precise, I'm using @envdir@ and @runstatedir@ to set correct paths in systemd service files. This support is added in fixconfig.in, and IMHO, I think that it's bad doing everything here. The sed of course is needed, but the runstatedir=@localstatedir@/run and the if -d @sysconfigdir@/sysconfig used to set envdir should be moved to configure.ac IMHO That would permit to set them using --runstatedir and --envdir in the ./configure script. In the fixconfig.in we should only have runstatedir=@runstatedir@ envdir=@envdir@ ... $SED -e ... ... I have absolutely no skills (or almost none) in autotools unfortunately, otherwise I would have fixed that as well for a clean config. Right now, as sysconfigdir is set to points to /etc/ganglia, the env files goes to /etc/ganglia/sysconfig/gmetad which is strange and not FSH compliant I suppose. In configure.ac, we should handle the 2 following parameters: 1/ --runstatedir set to /var/run by default. Note that autoconf = 2.70 handles that by default, so either we required autoconf 2.70 = AC_PREREQ(2.70) (see if it's acceptable: rhel-6 which is an old distro has 2.63 for instance) or we set @runstatedir@ to @localstatedir@/run (making sure that is autoconf =2.60 is used it doesn't conflict. 2/ --envdir set to /etc/sysconfig on a redhat variant or /etc/default on a debian variant. I think that for that, the correct test is to 1st test /etc/sysconfig and use it if present. Indeed, /etc/default is also present on redhat variants due to some bad packaging that do not fix hardcoded debian env directory. In the opposite, on debian variant, I've never seen any /etc/sysconfig directory. That's why I think that the safest way to test is to test for /etc/sysconfig and there after /etc/default. This directory contains files that are sourced before starting a daemon (either using init script or systemd service) to set its environment. Aside that, (IMHO), I think that installing config files in @sysconfdir@ is a bad thing as it forces the installation to use the --syconfdir=/etc/ganglia and also triggers problems when dealing with envdir for exemple. IMHO, config files should be installed in @sysconfdir@/ganglia. this would result in the same installation except that --syconfdir=/etc/ganglia would not be required anymore and could be used to install init scripts using Makefile instead of doing so thru the packaging files. the systemd logic exists (HAVE_SYSTEMD), aand thus, depending on systemd or not, the make install would install the init scripts or the service files accordingly. Thanks a lot for so long reading and help. Best regards, Olivier. - Mail original - De: Jeff Buchbinder rufustfire...@gmail.com À: olivier lahaye1 olivier.laha...@free.fr Cc: Ganglia Developers ganglia-developers@lists.sourceforge.net Envoyé: Jeudi 27 Février 2014 21:31:40 Objet: Re: [Ganglia-developers] request to merge some corrective patches (specfile, systemd service files, INSTALL, fixconfig) On Thu, Feb 27, 2014 at 2:26 PM, olivier.laha...@free.fr wrote: Hi Jeff, I think I committed to my fork and sent a pull request. Can you see my pull request? It isn't showing up here : https://github.com/ganglia/monitor-core/pulls Are you sure that you created a new pull request? Jeff-- Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071iu=/4140/ostg.clktrk___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
Re: [Ganglia-developers] make dist broken: riemann support related?
Pleas ignore my remark, it seems to be fixed in awaiting pull request #134 from satterly - Mail original - De: olivier lahaye1 olivier.laha...@free.fr À: Ganglia Developers ganglia-developers@lists.sourceforge.net Envoyé: Jeudi 27 Février 2014 20:27:23 Objet: [Ganglia-developers] make dist broken: riemann support related? I've noticed that make dist is broken in current git. make -k dist gives the following error: make[1]: Entering directory `/home/ol222822/rpmbuild/BUILD/ganglia.git/gmetad' make[1]: *** No rule to make target `gm_scoreboard.h', needed by `distdir'. make[1]: *** No rule to make target `riemann.pb-c.h', needed by `distdir'. make[1]: *** No rule to make target `riemann.pb-c.c', needed by `distdir'. make[1]: Target `distdir' not remade because of errors. make[1]: Leaving directory `/home/ol222822/rpmbuild/BUILD/ganglia.git/gmetad' Best regards, Olivier. -- Olivier LAHAYE -- Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071iu=/4140/ostg.clktrk ___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers -- Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071iu=/4140/ostg.clktrk___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
[Ganglia-developers] ganglia-web rpm packaging: bug fix (ganglia-web pull request #231)
Hi, I've fixed an easy bug in ganglia-web.spec.in breventing to build the package. https://github.com/ganglia/ganglia-web/pull/231 The spec tries to use Source1 (external source) to retreive apache.conf file while in fact it's already present in the archive. I've tested a rpmbuild -tb ganglia-web-3.5.12.tar.gz on fedora-17 and centos-6.5 and it works fine. Best regards. -- Olivier LAHAYE -- Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071iu=/4140/ostg.clktrk___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
Re: [Ganglia-developers] ganglia-web rpm packaging: bug fix (ganglia-web pull request #231)
Hi, I've finaly reworked the whole makeinstall make dist-gzip rpm packaging and debian packaging so whatever the way you install ganglia-webfrontend it results is the exact same installation Here is what the pull request is about: [build packaging] Reworked the install and packaging so it results in the same installation whatever the build is (manual, deb pkg or rpm pkg) * Use Makefile to make install for deb and rpm as well including config files. * Include specfile in the dist-gzip so a rpmbuild -tb (tarbuild) can be used * Added customization for rpmbuild using --with tags (see spec file for usage and more details). * Use adequate default values for rpm. The apache_user is not www-data. it's apache... * Use /etc/ganglia-webfrontend to store apache.conf what ever the distro is. Make sure that a link is set to apache config dir using triggers or postinstall. * Use /etc/ganglia-webfrontend to store conf.php what ever the distro is. Use a generic conf.php in /usr/share/ganglia-webfrontend to load the file from /etc/ganglia-webfrontend. * Replaced vargwebstatedir with vargwebdir in conf_default.php.in and Makefile. * filters dir was not created under debian pkg or manual make install * Added possibility to have a httpd_group different from user. For instance you can choose to install files under apache.daemon identity. If not specified, a group with the same name as the user is used. * Added comment in the install section of the Makefile so it's clear. * Reworked dist-gzip target so version.php and spec file are generated while other .in files remain so they can be tuned by make or make install. * Make sure that sharedstatedir is not owned by rpm package (conflict on fc-18+), and updated %file section accordingly. * Removed the manual install and specific config files in debian packaging. Using standard make install DESTDIR=... I've tested a rpm -tb ganglia-web-3.5.13.tar.gz on fc-17 and rhel-6 and it works fine. the tarball was generated using make dist-gzip. I'll test tomorrow on debian. Thanks for committing this update so it can be in 2.5.13 release. Best regards. Olivier. - Mail original - De: olivier lahaye1 olivier.laha...@free.fr À: Ganglia Developers ganglia-developers@lists.sourceforge.net Envoyé: Vendredi 28 Février 2014 11:58:22 Objet: [Ganglia-developers] ganglia-web rpm packaging: bug fix (ganglia-web pull request #231) Hi, I've fixed an easy bug in ganglia-web.spec.in breventing to build the package. https://github.com/ganglia/ganglia-web/pull/231 The spec tries to use Source1 (external source) to retreive apache.conf file while in fact it's already present in the archive. I've tested a rpmbuild -tb ganglia-web-3.5.12.tar.gz on fedora-17 and centos-6.5 and it works fine. Best regards. -- Olivier LAHAYE -- Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071iu=/4140/ostg.clktrk ___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers -- Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071iu=/4140/ostg.clktrk___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
[Ganglia-developers] ganglia 3.7.x in the works, errors
I've made a 3.7.0 tag and a release/3.7 branch for creating 3.7.1, 3.7.2 bootstrap was done on Debian wheezy (amd64) with autoconf 2.69, I recommend using the same platform and autoconf version for future 3.7.x series releases, it has caused confusion for people when autoconf versions varied in the past (sometimes people can work around that by re-bootstrapping after they unpack the tarball) libck0 (concurrency kit) is a new dependency, I have uploaded that to Debian, it is in the FTP NEW queue waiting for final approval: https://ftp-master.debian.org/new.html and anybody who wants to can build it from: Vcs-Browser: http://git.debian.org/?p=collab-maint/ck.git Vcs-Git: git://git.debian.org/git/collab-maint/ck.git git clone git://git.debian.org/git/collab-maint/ck.git cd ck dpkg-buildpackage -rfakeroot -i.git ganglia packages will have to wait and will not propagate to Ubuntu until libck0 is accepted in the archives. Can anybody assist with this for Fedora? To release, I bootstrap like so: - edit the version number into configure.ac - tag - branch (as it is .0) - run ./bootstrap.sh - install new dependencies: apt-get install libprotobuf-c0-dev protobuf-c-compiler and things I build locally: dpkg -i libck0.deb libck-dev.deb - configure: ./configure --with-gmetad --enable-perl \ --enable-php --enable-status --with-python \ --with-riemann - and finally: make dist This gives me the tarballs The ganglia-3.7.0.tar.gz checksum (sha224) is dec117ebd2966b1eeb6c3b775d16c606e82ce2c9eb60f36a84805293 and it is uploaded here: https://sourceforge.net/projects/ganglia/files/pre-release/ I tried a build, it looks like a few things are failing - are some of these errors because I am enabling unsupported/deprecated features or is the tarball broken? We can make a 3.7.1 next week if necessary $ ./configure --with-gmetad --enable-perl \ --enable-php --enable-status --with-python \ --with-riemann make -j13 -i make make[4]: Entering directory `/home/daniel/tmp/builds/ganglia-3.7.0/gmond/modules/php' /bin/bash ../../../libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../../.. -D_REENTRANT -D_GNU_SOURCE -I/usr/include/apr-1.0 -I/usr/include/php5 -I/usr/include/php5/main -I/usr/include/php5/TSRM -I/usr/include/php5/Zend -I/usr/include/php5/ext -I/usr/include/php5/ext/date/lib -I/usr/include/php5 -I/usr/include/php5/main -I/usr/include/php5/TSRM -I/usr/include/php5/Zend -I/usr/include/php5/ext -I/usr/include/php5/ext/date/lib -D_LARGEFILE64_SOURCE -I../../../include -I../../../lib -g -O2 -DWITH_RIEMANN -fno-strict-aliasing -Wall -D_REENTRANT -MT mod_php.lo -MD -MP -MF .deps/mod_php.Tpo -c -o mod_php.lo mod_php.c libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../../.. -D_REENTRANT -D_GNU_SOURCE -I/usr/include/apr-1.0 -I/usr/include/php5 -I/usr/include/php5/main -I/usr/include/php5/TSRM -I/usr/include/php5/Zend -I/usr/include/php5/ext -I/usr/include/php5/ext/date/lib -I/usr/include/php5 -I/usr/include/php5/main -I/usr/include/php5/TSRM -I/usr/include/php5/Zend -I/usr/include/php5/ext -I/usr/include/php5/ext/date/lib -D_LARGEFILE64_SOURCE -I../../../include -I../../../lib -g -O2 -DWITH_RIEMANN -fno-strict-aliasing -Wall -D_REENTRANT -MT mod_php.lo -MD -MP -MF .deps/mod_php.Tpo -c mod_php.c -fPIC -DPIC -o .libs/mod_php.o mod_php.c:46:18: fatal error: file.h: No such file or directory compilation terminated. make[4]: [mod_php.lo] Error 1 (ignored) mv -f .deps/mod_php.Tpo .deps/mod_php.Plo mv: cannot stat `.deps/mod_php.Tpo': No such file or directory make[4]: [mod_php.lo] Error 1 (ignored) /bin/bash ../../../libtool --tag=CC --mode=link gcc -std=gnu99 -D_LARGEFILE64_SOURCE -I../../../include -I../../../lib -g -O2 -DWITH_RIEMANN -fno-strict-aliasing -Wall -D_REENTRANT -module -avoid-version -lphp5 -L/usr/lib -lpthread -lapr-1 -o modphp.la -rpath /usr/local/lib64/ganglia mod_php.lo -ldl -lnsl -lnsl -lz -lpcre -lexpat -lconfuse -lprotobuf-c -lpthread libtool: link: `mod_php.lo' is not a valid libtool object make[4]: [modphp.la] Error 1 (ignored) make[3]: Entering directory `/home/daniel/tmp/builds/ganglia-3.7.0/gmond' gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -D_REENTRANT -D_GNU_SOURCE -I/usr/include/apr-1.0-I/usr/include/php5 -I/usr/include/php5/main -I/usr/include/php5/TSRM -I/usr/include/php5/Zend -I/usr/include/php5/ext -I/usr/include/php5/ext/date/lib -I../lib -I../include/ -I../libmetrics -D_LARGEFILE64_SOURCE -DSFLOW -g -O2 -DWITH_RIEMANN -fno-strict-aliasing -Wall -D_REENTRANT -MT gmond.o -MD -MP -MF .deps/gmond.Tpo -c -o gmond.o gmond.c gmond.c: In function ‘socket_send’: gmond.c:267:17: error: ‘struct gengetopt_args_info’ has no member named ‘gzip_output_flag’ gmond.c: In function ‘process_tcp_accept_channel’: gmond.c:2050:7: warning: passing argument 4 of ‘apr_socket_data_set’ from incompatible pointer type [enabled by default] In file included from
