Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-25 Thread Carlo Marcelo Arenas Belon
On Mon, Feb 25, 2008 at 10:56:33AM -0600, Martin Hicks wrote:
> 
> Ah okay.  I don't see those warnings.  Thanks for the update.

Committed revision 1003.

Carlo

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-25 Thread Martin Hicks

On Sat, Feb 23, 2008 at 04:32:20PM -0600, Carlo Marcelo Arenas Belon wrote:
> 
>   gmond.c: In function 'Ganglia_message_save':
>   gmond.c:840: warning: passing argument 1 of 'xdr_free' from incompatible 
> pointer type
>   gmond.c:840: warning: passing argument 2 of 'xdr_free' from incompatible 
> pointer type
> 
> attached patch silences it.

Ah okay.  I don't see those warnings.  Thanks for the update.

mh

> 
> Carlo

> Index: gmond/gmond.c
> ===
> --- gmond/gmond.c (revision 993)
> +++ gmond/gmond.c (working copy)
> @@ -837,7 +837,7 @@
>  
>metric->message.id = metric_user_defined;
>metric->message.Ganglia_message_u.gmetric = 
> message->Ganglia_message_u.spmetric.gmetric;
> -  xdr_free(xdr_Ganglia_spoof_header, 
> &message->Ganglia_message_u.spmetric.spheader);
> +  xdr_free((xdrproc_t)xdr_Ganglia_spoof_header, (char 
> *)&(message->Ganglia_message_u.spmetric.spheader));
>  
>}else{
>memcpy(&(metric->message), message, sizeof(Ganglia_message));

> -
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> ___
> Ganglia-developers mailing list
> Ganglia-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-23 Thread Carlo Marcelo Arenas Belon
On Wed, Feb 20, 2008 at 12:18:41PM -0800, Bernard Li wrote:
> 
> On 2/20/08, Martin Knoblauch <[EMAIL PROTECTED]> wrote:
> 
> >  I just committed the  fix for the spoofing leak from Martin Hicks. Can you 
> > run a [final] snapshot for 3.0.7? I have something brewing to fix the 
> > petabyte/sec spikes that one of our customers is seeing, but that needs 
> > more testing and can wait for 3.0.8.
> 
> The snapshots have been uploaded here:
> 
> http://www.ganglia.info/snapshots/3.0.x/
> 
> It would be good if we can get folks to ACK the fix.

the fix is throwing this warning at compile time :

  gmond.c: In function 'Ganglia_message_save':
  gmond.c:840: warning: passing argument 1 of 'xdr_free' from incompatible 
pointer type
  gmond.c:840: warning: passing argument 2 of 'xdr_free' from incompatible 
pointer type

attached patch silences it.

Carlo
Index: gmond/gmond.c
===
--- gmond/gmond.c   (revision 993)
+++ gmond/gmond.c   (working copy)
@@ -837,7 +837,7 @@
 
   metric->message.id = metric_user_defined;
   metric->message.Ganglia_message_u.gmetric = 
message->Ganglia_message_u.spmetric.gmetric;
-  xdr_free(xdr_Ganglia_spoof_header, 
&message->Ganglia_message_u.spmetric.spheader);
+  xdr_free((xdrproc_t)xdr_Ganglia_spoof_header, (char 
*)&(message->Ganglia_message_u.spmetric.spheader));
 
   }else{
   memcpy(&(metric->message), message, sizeof(Ganglia_message));
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-21 Thread Kumar Vaibhav
Hi All,

Thjumbs up from my side. I don't see any memory leak on my systems. So 
It is ok for my configuration.


Vaibhav
Bernard Li wrote:
> Hi guys:
> 
> On 2/20/08, Martin Knoblauch <[EMAIL PROTECTED]> wrote:
> 
>>  I just committed the  fix for the spoofing leak from Martin Hicks. Can you 
>> run a [final] snapshot for 3.0.7? I have something brewing to fix the 
>> petabyte/sec spikes that one of our customers is seeing, but that needs more 
>> testing and can wait for 3.0.8.
> 
> The snapshots have been uploaded here:
> 
> http://www.ganglia.info/snapshots/3.0.x/
> 
> It would be good if we can get folks to ACK the fix.
> 
> Cheers,
> 
> Bernard
> 
> -
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> ___
> Ganglia-developers mailing list
> Ganglia-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers
> 


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Hicks

On Wed, Feb 20, 2008 at 01:18:33PM -0700, Brad Nicholes wrote:
>   I don't believe that we have the same problem in trunk, however some
>   additional testing couldn't hurt.  The spoof packet handling as well
>   as the way that the XDR data is handled in general, has changed
>   significantly in trunk.  I have gone through the trunk code
>   specifically looking for cases where xdr_free() was not being
>   called.  I checked in a few memory leaks patches a couple of weeks
>   ago that were directly related to xdr_free() not being called.  So I
>   am hoping that these issues have already been nailed in trunk.

I'll try to test-drive ganglia-3.1.x on the Altix ICE stuff soon.

mh


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Bernard Li
Hi guys:

On 2/20/08, Martin Knoblauch <[EMAIL PROTECTED]> wrote:

>  I just committed the  fix for the spoofing leak from Martin Hicks. Can you 
> run a [final] snapshot for 3.0.7? I have something brewing to fix the 
> petabyte/sec spikes that one of our customers is seeing, but that needs more 
> testing and can wait for 3.0.8.

The snapshots have been uploaded here:

http://www.ganglia.info/snapshots/3.0.x/

It would be good if we can get folks to ACK the fix.

Cheers,

Bernard

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Brad Nicholes
  I don't believe that we have the same problem in trunk, however some 
additional testing couldn't hurt.  The spoof packet handling as well as the way 
that the XDR data is handled in general, has changed significantly in trunk.  I 
have gone through the trunk code specifically looking for cases where 
xdr_free() was not being called.  I checked in a few memory leaks patches a 
couple of weeks ago that were directly related to xdr_free() not being called.  
So I am hoping that these issues have already been nailed in trunk.

Brad

>>> On 2/20/2008 at 12:21 PM, in message
<[EMAIL PROTECTED]>, Martin Knoblauch
<[EMAIL PROTECTED]> wrote:
> btw. the fix does not apply to trunk. The code looks quite different there. 
> Someone familiar with the spoofing stuff may want to check whether the leak 
> exists in trunk and needs fixing.
> 
> Cheers
> Martin
> --
> Martin Knoblauch
> email: k n o b i AT knobisoft DOT de
> www:   http://www.knobisoft.de 
> 
> - Original Message 
>> From: Martin Knoblauch <[EMAIL PROTECTED]>
>> To: Martin Hicks <[EMAIL PROTECTED]>; Bernard Li <[EMAIL PROTECTED]>
>> Cc: Ganglia Developers 
>> Sent: Wednesday, February 20, 2008 7:58:20 PM
>> Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix
>> 
>> Bernard, all,
>> 
>>  I just committed the  fix for the spoofing leak from Martin Hicks. Can you 
> run 
>> a [final] snapshot for 3.0.7? I have something brewing to fix the 
> petabyte/sec 
>> spikes that one of our customers is seeing, but that needs more testing and 
> can 
>> wait for 3.0.8.
>>   
>> Cheers
>> Martin
>> 
>> --
>> Martin Knoblauch
>> email: k n o b i AT knobisoft DOT de
>> www:   http://www.knobisoft.de 
>> 
>> - Original Message 
>> > From: Martin Knoblauch 
>> > To: Martin Hicks 
>> > Cc: Ganglia Developers 
>> > Sent: Wednesday, February 20, 2008 7:44:04 PM
>> > Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix
>> > 
>> > - Original Message 
>> > > From: Martin Hicks 
>> > > To: Martin Knoblauch 
>> > > Cc: Ganglia Developers 
>> > > Sent: Wednesday, February 20, 2008 7:33:32 PM
>> > > Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix
>> > > 
>> > > 
>> > > On Wed, Feb 20, 2008 at 10:27:33AM -0800, Martin Knoblauch wrote:
>> > > > Hi,
>> > > > 
>> > > >  if you resend it as an attachment, I would apply the fix.
>> > > 
>> > > You can apply it with my blabbering at the beginning. :)
>> > > patch ignores the stuff before the ---
>> > > 
>> > > The patch is attached for your convenience.
>> > > 
>> > 
>> >  My problem is, that my MUA just garbles the white space. So, I prefer 
> inlined
>> > patches.
>> > 
>> > > > 
>> > > > Cheers
>> > > > Martin
>> > > > PS: How is life at SGI nowadays?
>> > > 
>> > > Seems okay.  I just got here recently. :)
>> > > 
>> > 
>> >  I left about 10 years ago. Different place at that time, I think.
>> > 
>> > 
>> > 
>> > 
>> > -
>> > This SF.net email is sponsored by: Microsoft
>> > Defy all challenges. Microsoft(R) Visual Studio 2008.
>> > http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ 
>> > ___
>> > Ganglia-developers mailing list
>> > Ganglia-developers@lists.sourceforge.net 
>> > https://lists.sourceforge.net/lists/listinfo/ganglia-developers 
>> > 
>> > 
>> 
>> 
>> 
>> -
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ 
>> ___
>> Ganglia-developers mailing list
>> Ganglia-developers@lists.sourceforge.net 
>> https://lists.sourceforge.net/lists/listinfo/ganglia-developers 
>> 
>> 
> 
> 
> 
> -
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ 
> ___
> Ganglia-developers mailing list
> Ganglia-developers@lists.sourceforge.net 
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers 



-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Knoblauch
btw. the fix does not apply to trunk. The code looks quite different there. 
Someone familiar with the spoofing stuff may want to check whether the leak 
exists in trunk and needs fixing.

Cheers
Martin
--
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www:   http://www.knobisoft.de

- Original Message 
> From: Martin Knoblauch <[EMAIL PROTECTED]>
> To: Martin Hicks <[EMAIL PROTECTED]>; Bernard Li <[EMAIL PROTECTED]>
> Cc: Ganglia Developers 
> Sent: Wednesday, February 20, 2008 7:58:20 PM
> Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix
> 
> Bernard, all,
> 
>  I just committed the  fix for the spoofing leak from Martin Hicks. Can you 
> run 
> a [final] snapshot for 3.0.7? I have something brewing to fix the 
> petabyte/sec 
> spikes that one of our customers is seeing, but that needs more testing and 
> can 
> wait for 3.0.8.
>   
> Cheers
> Martin
> 
> --
> Martin Knoblauch
> email: k n o b i AT knobisoft DOT de
> www:   http://www.knobisoft.de
> 
> - Original Message 
> > From: Martin Knoblauch 
> > To: Martin Hicks 
> > Cc: Ganglia Developers 
> > Sent: Wednesday, February 20, 2008 7:44:04 PM
> > Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix
> > 
> > - Original Message 
> > > From: Martin Hicks 
> > > To: Martin Knoblauch 
> > > Cc: Ganglia Developers 
> > > Sent: Wednesday, February 20, 2008 7:33:32 PM
> > > Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix
> > > 
> > > 
> > > On Wed, Feb 20, 2008 at 10:27:33AM -0800, Martin Knoblauch wrote:
> > > > Hi,
> > > > 
> > > >  if you resend it as an attachment, I would apply the fix.
> > > 
> > > You can apply it with my blabbering at the beginning. :)
> > > patch ignores the stuff before the ---
> > > 
> > > The patch is attached for your convenience.
> > > 
> > 
> >  My problem is, that my MUA just garbles the white space. So, I prefer 
> > inlined
> > patches.
> > 
> > > > 
> > > > Cheers
> > > > Martin
> > > > PS: How is life at SGI nowadays?
> > > 
> > > Seems okay.  I just got here recently. :)
> > > 
> > 
> >  I left about 10 years ago. Different place at that time, I think.
> > 
> > 
> > 
> > 
> > -
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> > ___
> > Ganglia-developers mailing list
> > Ganglia-developers@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/ganglia-developers
> > 
> > 
> 
> 
> 
> -
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> ___
> Ganglia-developers mailing list
> Ganglia-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers
> 
> 



-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Knoblauch
Bernard, all,

 I just committed the  fix for the spoofing leak from Martin Hicks. Can you run 
a [final] snapshot for 3.0.7? I have something brewing to fix the petabyte/sec 
spikes that one of our customers is seeing, but that needs more testing and can 
wait for 3.0.8.
  
Cheers
Martin

--
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www:   http://www.knobisoft.de

- Original Message 
> From: Martin Knoblauch <[EMAIL PROTECTED]>
> To: Martin Hicks <[EMAIL PROTECTED]>
> Cc: Ganglia Developers 
> Sent: Wednesday, February 20, 2008 7:44:04 PM
> Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix
> 
> - Original Message 
> > From: Martin Hicks 
> > To: Martin Knoblauch 
> > Cc: Ganglia Developers 
> > Sent: Wednesday, February 20, 2008 7:33:32 PM
> > Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix
> > 
> > 
> > On Wed, Feb 20, 2008 at 10:27:33AM -0800, Martin Knoblauch wrote:
> > > Hi,
> > > 
> > >  if you resend it as an attachment, I would apply the fix.
> > 
> > You can apply it with my blabbering at the beginning. :)
> > patch ignores the stuff before the ---
> > 
> > The patch is attached for your convenience.
> > 
> 
>  My problem is, that my MUA just garbles the white space. So, I prefer inlined
> patches.
> 
> > > 
> > > Cheers
> > > Martin
> > > PS: How is life at SGI nowadays?
> > 
> > Seems okay.  I just got here recently. :)
> > 
> 
>  I left about 10 years ago. Different place at that time, I think.
> 
> 
> 
> 
> -
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> ___
> Ganglia-developers mailing list
> Ganglia-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers
> 
> 



-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Knoblauch
- Original Message 
> From: Martin Hicks <[EMAIL PROTECTED]>
> To: Martin Knoblauch <[EMAIL PROTECTED]>
> Cc: Ganglia Developers 
> Sent: Wednesday, February 20, 2008 7:33:32 PM
> Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix
> 
> 
> On Wed, Feb 20, 2008 at 10:27:33AM -0800, Martin Knoblauch wrote:
> > Hi,
> > 
> >  if you resend it as an attachment, I would apply the fix.
> 
> You can apply it with my blabbering at the beginning. :)
> patch ignores the stuff before the ---
> 
> The patch is attached for your convenience.
> 

 My problem is, that my MUA just garbles the white space. So, I prefer inlined
patches.

> > 
> > Cheers
> > Martin
> > PS: How is life at SGI nowadays?
> 
> Seems okay.  I just got here recently. :)
> 

 I left about 10 years ago. Different place at that time, I think.




-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Hicks

On Wed, Feb 20, 2008 at 10:27:33AM -0800, Martin Knoblauch wrote:
> Hi,
> 
>  if you resend it as an attachment, I would apply the fix.

You can apply it with my blabbering at the beginning. :)
patch ignores the stuff before the ---

The patch is attached for your convenience.

> 
> Cheers
> Martin
> PS: How is life at SGI nowadays?

Seems okay.  I just got here recently. :)

mh

--- ganglia-3.0.6.200802141157/gmond/gmond.c2008-02-14 14:58:58.0 
-0500
+++ ganglia-3.0.6.200802141157.mod/gmond/gmond.c2008-02-20 
11:46:23.0 -0500
@@ -831,11 +831,13 @@ Ganglia_message_save( Ganglia_host *host
   /* Copy in the data */
   // Yemi
   if(message->id == spoof_metric){
-// Store data as regular gmetric in hash table!!
+  /* Store data as regular gmetric in hash table!!
+   * Free the Spoof-related strings.
+   */
 
-  metric->message.id = metric_user_defined;   
+  metric->message.id = metric_user_defined;
   metric->message.Ganglia_message_u.gmetric = 
message->Ganglia_message_u.spmetric.gmetric;
-
+  xdr_free(xdr_Ganglia_spoof_header, 
&message->Ganglia_message_u.spmetric.spheader);
 
   }else{
   memcpy(&(metric->message), message, sizeof(Ganglia_message));
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Knoblauch
Hi,

 if you resend it as an attachment, I would apply the fix.

Cheers
Martin
PS: How is life at SGI nowadays?
--
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www:   http://www.knobisoft.de

- Original Message 
> From: Martin Hicks <[EMAIL PROTECTED]>
> To: Ganglia Developers 
> Sent: Wednesday, February 20, 2008 7:06:41 PM
> Subject: [Ganglia-developers] gmond Spoof memory leak fix
> 
> 
> Hi,
> 
> Here's a patch against ganglia-3.0.6.200802141157 that fixes a memory
> leak when using user defined metrics with spoofing.
> 
> The problem was that the spmetric was being copied out, ignoring the
> spheader.  The strings that were allocated inside the spheader were
> dropped.
> 
> mh
> 
> --- ganglia-3.0.6.200802141157/gmond/gmond.c2008-02-14 14:58:58.0 
> -0500
> +++ ganglia-3.0.6.200802141157.mod/gmond/gmond.c2008-02-20 
> 11:46:23.0 -0500
> @@ -831,11 +831,13 @@ Ganglia_message_save( Ganglia_host *host
>/* Copy in the data */
>// Yemi
>if(message->id == spoof_metric){
> -// Store data as regular gmetric in hash table!!
> +  /* Store data as regular gmetric in hash table!!
> +   * Free the Spoof-related strings.
> +   */
>  
> -  metric->message.id = metric_user_defined;   
> +  metric->message.id = metric_user_defined;
>metric->message.Ganglia_message_u.gmetric = 
> message->Ganglia_message_u.spmetric.gmetric;
> -
> +  xdr_free(xdr_Ganglia_spoof_header, 
> &message->Ganglia_message_u.spmetric.spheader);
>  
>}else{
>memcpy(&(metric->message), message, sizeof(Ganglia_message));
> 
> 
> -
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
> ___
> Ganglia-developers mailing list
> Ganglia-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers
> 
> 



-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers


[Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Hicks

Hi,

Here's a patch against ganglia-3.0.6.200802141157 that fixes a memory
leak when using user defined metrics with spoofing.

The problem was that the spmetric was being copied out, ignoring the
spheader.  The strings that were allocated inside the spheader were
dropped.

mh

--- ganglia-3.0.6.200802141157/gmond/gmond.c2008-02-14 14:58:58.0 
-0500
+++ ganglia-3.0.6.200802141157.mod/gmond/gmond.c2008-02-20 
11:46:23.0 -0500
@@ -831,11 +831,13 @@ Ganglia_message_save( Ganglia_host *host
   /* Copy in the data */
   // Yemi
   if(message->id == spoof_metric){
-// Store data as regular gmetric in hash table!!
+  /* Store data as regular gmetric in hash table!!
+   * Free the Spoof-related strings.
+   */
 
-  metric->message.id = metric_user_defined;   
+  metric->message.id = metric_user_defined;
   metric->message.Ganglia_message_u.gmetric = 
message->Ganglia_message_u.spmetric.gmetric;
-
+  xdr_free(xdr_Ganglia_spoof_header, 
&message->Ganglia_message_u.spmetric.spheader);
 
   }else{
   memcpy(&(metric->message), message, sizeof(Ganglia_message));


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers