Re: gcc-4.2-20060304 is now available
I reproduced this with just gcc-core, I normally also build g++ and
gfortran as well. The problem goes away if I unpack the sources for
objc, which I am not really interested in.
Any takers? How/against what do I report this?
The problem is that now configure is processing config-lang.in files
even for languages that are not active by default.
It is a bit weird that objcp is included in the gcc-core download. It
could be included in the gcc-objc download (or in a separate objcp
download). But we can work around the problem by restricting the
operation of my patch to "allow typing `make cc1plus' on second
thought", to languages that are built by default.
I don't like the attached patch particularly, but if Salvatore confirms
that it works around his issue, I can give the necessary testing to the
patch.
Paolo
Index: configure.ac
===
--- configure.ac(revision 111635)
+++ configure.ac(working copy)
@@ -3328,13 +3328,6 @@ changequote(,)dnl
esac
changequote([,])dnl
- if test -f $srcdir/$subdir/lang.opt; then
- lang_opt_files="$lang_opt_files $srcdir/$subdir/lang.opt"
- fi
- if test -f $srcdir/$subdir/$subdir-tree.def; then
- lang_tree_files="$lang_tree_files $srcdir/$subdir/$subdir-tree.def"
- fi
-
language=
boot_language=
compilers=
@@ -3347,24 +3340,37 @@ changequote([,])dnl
echo "${srcdir}/$subdir/config-lang.in doesn't set \$language."
1>&2
exit 1
fi
- all_lang_makefrags="$all_lang_makefrags \$(srcdir)/$subdir/Make-lang.in"
- if test -f ${srcdir}/$subdir/Makefile.in
- then all_lang_makefiles="$subdir/Makefile"
- fi
- all_languages="$all_languages $language"
- if test "x$boot_language" = xyes
- then
- all_boot_languages="$all_boot_languages $language"
- fi
- all_compilers="$all_compilers $compilers"
- all_stagestuff="$all_stagestuff $stagestuff"
- all_outputs="$all_outputs $outputs"
- all_gtfiles="$all_gtfiles $gtfiles"
-for f in $gtfiles
-do
- all_gtfiles_files_langs="$all_gtfiles_files_langs ${subdir} "
- all_gtfiles_files_files="$all_gtfiles_files_files ${f} "
-done
+
+ # Don't include languages that are not built by default, unless
+ # specified explicitly.
+case "$build_by_default:,$enable_languages," in
+yes:* | no:*,$lang_alias,*)
+ all_lang_makefrags="$all_lang_makefrags
\$(srcdir)/$subdir/Make-lang.in"
+ if test -f $srcdir/$subdir/lang.opt; then
+ lang_opt_files="$lang_opt_files $srcdir/$subdir/lang.opt"
+ fi
+ if test -f $srcdir/$subdir/$subdir-tree.def; then
+ lang_tree_files="$lang_tree_files
$srcdir/$subdir/$subdir-tree.def"
+ fi
+ if test -f ${srcdir}/$subdir/Makefile.in
+ then all_lang_makefiles="$subdir/Makefile"
+ fi
+ all_languages="$all_languages $language"
+ if test "x$boot_language" = xyes
+ then
+ all_boot_languages="$all_boot_languages $language"
+ fi
+ all_compilers="$all_compilers $compilers"
+ all_stagestuff="$all_stagestuff $stagestuff"
+ all_outputs="$all_outputs $outputs"
+ all_gtfiles="$all_gtfiles $gtfiles"
+ for f in $gtfiles
+ do
+ all_gtfiles_files_langs="$all_gtfiles_files_langs
${subdir} "
+ all_gtfiles_files_files="$all_gtfiles_files_files
${f} "
+ done
+ ;;
+ esac
;;
esac
done
Index: configure
===
--- configure (revision 111635)
+++ configure (working copy)
@@ -15845,13 +15748,6 @@ do
;;
esac
- if test -f $srcdir/$subdir/lang.opt; then
- lang_opt_files="$lang_opt_files $srcdir/$subdir/lang.opt"
- fi
- if test -f $srcdir/$subdir/$subdir-tree.def; then
- lang_tree_files="$lang_tree_files $srcdir/$subdir/$subdir-tree.def"
- fi
-
language=
boot_language=
compilers=
@@ -15864,24 +15760,37 @@ do
echo "${srcdir}/$subdir/config-lang.in doesn't set \$language."
1>&2
exit 1
fi
- all_lang_makefrags="$all_lang_makefrags \$(srcdir)/$subdir/Make-lang.in"
- if test -f ${srcdir}/$subdir/Makefile.in
- then all_lang_makefiles="$subdir/Makefile"
- fi
- all_languages="$all_languages $language"
- if test "x$boot_language" = xyes
- then
- all_boot_languages="$all_boot_languages $language"
- fi
- all_compilers="$all_
Re: gcc-4.2-20060304 is now available
On Mon, 6 Mar 2006, Paolo Bonzini wrote: > It is a bit weird that objcp is included in the gcc-core download. It could > be included in the gcc-objc download (or in a separate objcp download). But It should go in an objcp download. sourcebuild.texi includes updating the release script as one of the things to do when contributing a new front end. -- Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/ [EMAIL PROTECTED] (personal mail) [EMAIL PROTECTED] (CodeSourcery mail) [EMAIL PROTECTED] (Bugzilla assignments and CCs)
Re: gcc-4.2-20060304 is now available
Paolo Bonzini's patch appears to work. What the best solution is long term, is not really my province. Regards Salvatore
Re: gcc-4.2-20060304 is now available
On Mon, 6 Mar 2006, Joseph S. Myers wrote: >> It is a bit weird that objcp is included in the gcc-core download. It >> could be included in the gcc-objc download (or in a separate objcp >> download). But > It should go in an objcp download. sourcebuild.texi includes updating > the release script as one of the things to do when contributing a new > front end. Hmm, do we really want to split of another .tar file? Looking at the current sizes gcc-core-4.2-20060304.tar.bz2 = 15703096 gcc-g++-4.2-20060304.tar.bz2 = 3905138 gcc-objc-4.2-20060304.tar.bz2 = 191280 gcc-fortran-4.2-20060304.tar.bz2 = 793478 gcc-testsuite-4.2-20060304.tar.bz2 = 3606941 I'd really suggest to make this part of gcc-objc instead of adding another one. Gerald
Re: gcc-4.2-20060304 is now available
Gerald Pfeifer wrote: > Looking at the current sizes > > gcc-core-4.2-20060304.tar.bz2 = 15703096 > gcc-g++-4.2-20060304.tar.bz2 = 3905138 > gcc-objc-4.2-20060304.tar.bz2 = 191280 > gcc-fortran-4.2-20060304.tar.bz2 = 793478 > gcc-testsuite-4.2-20060304.tar.bz2 = 3606941 > > I'd really suggest to make this part of gcc-objc instead of adding > another one. Definitely. -- Mark Mitchell CodeSourcery [EMAIL PROTECTED] (650) 331-3385 x713
Re: gcc-4.2-20060304 is now available
On Mar 11, 2006, at 1:04 AM, Mark Mitchell wrote: Gerald Pfeifer wrote: Looking at the current sizes gcc-core-4.2-20060304.tar.bz2 = 15703096 gcc-g++-4.2-20060304.tar.bz2 = 3905138 gcc-objc-4.2-20060304.tar.bz2 = 191280 gcc-fortran-4.2-20060304.tar.bz2 = 793478 gcc-testsuite-4.2-20060304.tar.bz2 = 3606941 I'd really suggest to make this part of gcc-objc instead of adding another one. Definitely. Wouldn't that make you dowload gcc-core, gcc-g++ and gcc-objc to just to compile an objective-C compiler as objcp depends on c++ also? -- Pinski
Re: gcc-4.2-20060304 is now available
Andrew Pinski wrote: >>> gcc-core-4.2-20060304.tar.bz2 = 15703096 >>> gcc-g++-4.2-20060304.tar.bz2 = 3905138 >>> gcc-objc-4.2-20060304.tar.bz2 = 191280 >>> gcc-fortran-4.2-20060304.tar.bz2 = 793478 >>> gcc-testsuite-4.2-20060304.tar.bz2 = 3606941 >>> >>> I'd really suggest to make this part of gcc-objc instead of adding >>> another one. >> >> Definitely. > > Wouldn't that make you dowload gcc-core, gcc-g++ and gcc-objc to just > to compile an objective-C compiler as objcp depends on c++ also? Yes, but so what? :-) Creating these separate modules seems somewhat pointless given the core is 80% of the total. Why not simplify things a bit and just package it all up together? -- Mark Mitchell CodeSourcery [EMAIL PROTECTED] (650) 331-3385 x713
Re: gcc-4.2-20060304 is now available
On Mar 11, 2006, at 10:53 AM, Mark Mitchell wrote: Creating these separate modules seems somewhat pointless given the core is 80% of the total. Why not simplify things a bit and just package it all up together? Just to put another idea on the table, we can require they grab the full tar file for Objective-C++ if we want. I don't care enough in any case to argue for or against any particular choice.
Re: gcc-4.2-20060304 is now available
On Sat, 2006-03-11 at 10:53 -0800, Mark Mitchell wrote: > Andrew Pinski wrote: > > >>> gcc-core-4.2-20060304.tar.bz2 = 15703096 > >>> gcc-g++-4.2-20060304.tar.bz2 = 3905138 > >>> gcc-objc-4.2-20060304.tar.bz2 = 191280 > >>> gcc-fortran-4.2-20060304.tar.bz2 = 793478 > >>> gcc-testsuite-4.2-20060304.tar.bz2 = 3606941 > >>> > >>> I'd really suggest to make this part of gcc-objc instead of adding > >>> another one. > >> > >> Definitely. > > > > Wouldn't that make you dowload gcc-core, gcc-g++ and gcc-objc to just > > to compile an objective-C compiler as objcp depends on c++ also? > > Yes, but so what? :-) > > Creating these separate modules seems somewhat pointless given the core > is 80% of the total. Why not simplify things a bit and just package it > all up together? Are statistics for GCC download available somewhere? I suspect in these days of broadband that just about everyone gets the full tarball (especially for releases...). Laurent
Re: gcc-4.2-20060304 is now available
On Sun, 19 Mar 2006, Laurent GUERBY wrote: > Are statistics for GCC download available somewhere? I suspect > in these days of broadband that just about everyone gets the full > tarball (especially for releases...). The FreeSD ports, for example, by default do not build gfortran nor Java at this point and have never built Ada. And I doubt that many are building Ada, regardless of the platform they are using. gfortran weights in less than one megabyte, thus isn't of too much concern. Java with close to 10MB and Adad with some 4.5MB are kind of heavy, though. Keep in mind that depending on the part of the world many may still be using modem lines. Gerald
