[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-10 Thread jv244 at cam dot ac dot uk


--- Comment #1 from jv244 at cam dot ac dot uk  2007-07-11 05:27 ---
Created an attachment (id=13883)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13883&action=view)
testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-10 Thread jv244 at cam dot ac dot uk


--- Comment #2 from jv244 at cam dot ac dot uk  2007-07-11 05:49 ---
FYI, all three modules are needed to trigger the bug. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-10 Thread burnus at gcc dot gnu dot org


--- Comment #3 from burnus at gcc dot gnu dot org  2007-07-11 06:38 ---
Working: 2007-07-09-r126478
Failing: 2007-07-10-r126510

I believe it is due to the patch
 r126509 | pault | 2007-07-10 07:11:00 +0200 (Di, 10 Jul 2007) | 28 lines
PR 32634 [...]
* module.c (write_generic): Write the local name of the
interface.
but I might be wrong and it is one of:
 r126486 | dfranke | 2007-07-09 16:56:49 +0200 (Mon, 09 Jul 2007) | 14 lines
 r126493 | kargl | 2007-07-09 21:41:37 +0200 (Mon, 09 Jul 2007) | 6 lines
 r126496 | fxcoudert | 2007-07-10 00:00:52 +0200 (Tue, 10 Jul 2007) | 6 lines

The error message is:

  USE util,ONLY: sort
   1
Error: Symbol 'sort' referenced at (1) not found in module 'util'


Reduced test case:

MODULE kinds
  INTEGER, PARAMETER :: dp = SELECTED_REAL_KIND ( 14, 200 )
END MODULE kinds

MODULE util
  USE kinds,   ONLY: dp
  INTERFACE sort
 MODULE PROCEDURE sort2
  END INTERFACE
CONTAINS
  SUBROUTINE sort2 ( )
  END SUBROUTINE sort2
END MODULE util

MODULE graphcon
  USE util,ONLY: sort
END MODULE graphcon


-- 

burnus at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||pault at gcc dot gnu dot org
   Target Milestone|--- |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-11 Thread dfranke at gcc dot gnu dot org


--- Comment #4 from dfranke at gcc dot gnu dot org  2007-07-11 08:33 ---
No error up to and including r126496. That leaves only Paul's patch ...


-- 

dfranke at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||dfranke at gcc dot gnu dot
   ||org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-11 Thread pault at gcc dot gnu dot org


--- Comment #5 from pault at gcc dot gnu dot org  2007-07-12 04:58 ---
(In reply to comment #4)
> No error up to and including r126496. That leaves only Paul's patch ...
> 
Daniel,

Could you please revert r126496 and re-open the PR? - I can do nothing about it
for 10 days or more.

Cheers

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-11 Thread pault at gcc dot gnu dot org


--- Comment #6 from pault at gcc dot gnu dot org  2007-07-12 06:22 ---
(In reply to comment #5)

Daniel,

Hmmm!  Cancel that - I'll have a slot this evening where I can either fix it or
revert it myself.  Just leave it to me but, I'll let you know if I am unable to
do the business.

Paul - who is run off his feet but wants to fix those bugs...


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-11 Thread dfranke at gcc dot gnu dot org


--- Comment #7 from dfranke at gcc dot gnu dot org  2007-07-12 06:31 ---
Subject: Bug 32727

Author: dfranke
Date: Thu Jul 12 06:31:12 2007
New Revision: 126572

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126572
Log:
2007-07-12  Daniel Franke  <[EMAIL PROTECTED]>

PR fortran/32634
PR fortran/32727
* module.c: Reverted Paul's patch from 2007-07-10.


Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/module.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-11 Thread dfranke at gcc dot gnu dot org


--- Comment #8 from dfranke at gcc dot gnu dot org  2007-07-12 06:36 ---
Sorry, too late :(


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-11 Thread jv244 at cam dot ac dot uk


--- Comment #9 from jv244 at cam dot ac dot uk  2007-07-12 06:57 ---
(In reply to comment #8)
> Sorry, too late :(

Fine with me :-), I can give gfortran another round of testing today... thanks

BTW, if you revert a patch, you should add the testcase that is the reason it.
To avoid regressing again if the patch gets re-applied. Similarly, you should
xfail the other testcase that now fails.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-12 Thread dfranke at gcc dot gnu dot org


--- Comment #10 from dfranke at gcc dot gnu dot org  2007-07-12 07:27 
---
> BTW, if you revert a patch, you should add the testcase that is the reason
> it. To avoid regressing again if the patch gets re-applied. Similarly, you
> should xfail the other testcase that now fails.

Joost,

good point. I thought about XFAIL, but then again, probably nobody will notice
that there's something wrong since it's expected to fail. Hence I concluded
that it would be preferable to have people asking about a testsuite failure
twice a day then to hide the problem it in an xfail :)

However, if Paul does find the time today, I'm positive that he will set it
right -- otherwise I will implement your suggestion tomorrow.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-12 Thread burnus at gcc dot gnu dot org


--- Comment #11 from burnus at gcc dot gnu dot org  2007-07-12 17:39 ---
*** Bug 32741 has been marked as a duplicate of this bug. ***


-- 

burnus at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||hjl at lucon dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-12 Thread pault at gcc dot gnu dot org


--- Comment #12 from pault at gcc dot gnu dot org  2007-07-12 20:05 ---
Subject: Bug 32727

Author: pault
Date: Thu Jul 12 20:04:59 2007
New Revision: 126600

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126600
Log:
2007-07-12  Paul Thomas  <[EMAIL PROTECTED]>

PR fortran/32634
PR fortran/32727
* module.c (write_generic): Restore patch of 2007-07-10 and use
symbol name if there are no use names. 

2007-07-12  Paul Thomas  <[EMAIL PROTECTED]>

PR fortran/32727
* gfortran.dg/interface_17.f90: New test.

Added:
trunk/gcc/testsuite/gfortran.dg/interface_17.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/module.c
trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-12 Thread pault at gcc dot gnu dot org


--- Comment #13 from pault at gcc dot gnu dot org  2007-07-12 20:26 ---
Thanks for the very prompt report.

I would use your cp2k testcase but it does not compile on Cygwin - it runs out
of memory during compilation. When I have a moment, I'll break itup.

Fixed on trunk

Paul


-- 

pault at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727



[Bug fortran/32727] [4.3 regression] bogus error: Error: Symbol 'sort' referenced at (1) not found in module 'util'

2007-07-13 Thread jv244 at cam dot ac dot uk


--- Comment #14 from jv244 at cam dot ac dot uk  2007-07-13 07:14 ---
(In reply to comment #13)
> I would use your cp2k testcase but it does not compile on Cygwin - it runs out
> of memory during compilation. When I have a moment, I'll break itup.

yes, it can be trivially split after every module, and compiled in that order.
The other option is to check (a fixed version) out from cvs. See 
http://cp2k.berlios.de/download.html. That might initially be a few minutes
more work to setup, but has the advantage that make -j X speeds up testing and
that miscompilations can be more easily found.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32727