Re: [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html
On Wed, Dec 1, 2021 at 10:54 AM Gerald Pfeifer wrote:
>
> Hi Eric,
>
> On Wed, 24 Nov 2021, Eric Gallager wrote:
> > This next patch does more than just removing old stuff: it adds an
> > extra sentence to describe a shell command used to generate a list, so
> > to verify that I've got the shell command right, I'm asking for a
> > review.
>
> -There are several other files in this size range, which I have left
> +There are several other files in this size range, which are left
> out because touching them at all is unwise (reload, the Fortran front
> end). You can try, but I am not responsible for any damage to your
> sanity which may result.
>
> while we are touching this, how about toning the second half of this
> paragraph down and moving away from first person?
>
> How about something like "...breaking them up likely may prove rather
> difficult" (or similar, happy to leave this to you as native spaker)?
>
OK yeah I did remove the first instance of the first person in that
paragraph, but couldn't think of a better wording for the second one,
so that suggestion is helpful; thanks.
>
> +Note that the list of large files in this section is generated with the
> +following shell command, run from the gcc subdirectory:
> +
> +
> + du -sh *.{c,h,cc} */*.{c,h,cc} | sort -hr | grep -v fortran | head -n
> 14
> +
>
> This looks like it does what you want it to do.
>
> (Pulling up the database courses I have given in a previous life, I'd pull
> in the grep before the sort - O(n) filtering before O(n·log n) processing
> - but even on my notebook both are instantenous. ;-) )
>
>
> Please consider the two suggestions above and commit the result; just
> share the final patch here (no review required).
>
> Thanks,
> Gerald
OK thanks, I committed the attached patch as f4b4d0f:
https://gcc.gnu.org/git/?p=gcc-wwwdocs.git;a=commitdiff;h=f4b4d0f783246dd6f58944cdb542446d5e7589d3
patch-beginner-projects-02.diff
Description: Binary data
Re: [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html
Hi Eric,
On Wed, 24 Nov 2021, Eric Gallager wrote:
> This next patch does more than just removing old stuff: it adds an
> extra sentence to describe a shell command used to generate a list, so
> to verify that I've got the shell command right, I'm asking for a
> review.
-There are several other files in this size range, which I have left
+There are several other files in this size range, which are left
out because touching them at all is unwise (reload, the Fortran front
end). You can try, but I am not responsible for any damage to your
sanity which may result.
while we are touching this, how about toning the second half of this
paragraph down and moving away from first person?
How about something like "...breaking them up likely may prove rather
difficult" (or similar, happy to leave this to you as native spaker)?
+Note that the list of large files in this section is generated with the
+following shell command, run from the gcc subdirectory:
+
+
+ du -sh *.{c,h,cc} */*.{c,h,cc} | sort -hr | grep -v fortran | head -n 14
+
This looks like it does what you want it to do.
(Pulling up the database courses I have given in a previous life, I'd pull
in the grep before the sort - O(n) filtering before O(n·log n) processing
- but even on my notebook both are instantenous. ;-) )
Please consider the two suggestions above and commit the result; just
share the final patch here (no review required).
Thanks,
Gerald
PING [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html
Hi, I'd like to ping this patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585294.html On Wed, Nov 24, 2021 at 2:11 AM Eric Gallager wrote: > > On Tue, Nov 23, 2021 at 6:27 PM Eric Gallager wrote: > > > > On Fri, Nov 19, 2021 at 8:14 AM Eric Gallager wrote: > > > > > > On Fri, Nov 19, 2021 at 1:48 AM Gerald Pfeifer wrote: > > > > > > > > Cool, thank you! > > > > > > > > Please feel free to commit patches like this without asking for > > > > approval (though I'm happy to review and approve). > > > > > > > > Gerald > > > > > > > > > > OK thanks; committed as dbaebcd > > > > I've also committed one to remove the section on traditional C now: > > https://gcc.gnu.org/git/?p=gcc-wwwdocs.git;a=commitdiff;h=ca83c13ad6bf0d351220dafa36264ebc7a6b7816 > > This next patch does more than just removing old stuff: it adds an > extra sentence to describe a shell command used to generate a list, so > to verify that I've got the shell command right, I'm asking for a > review. > > Thanks, > Eric Gallager
[PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html
On Tue, Nov 23, 2021 at 6:27 PM Eric Gallager wrote: > > On Fri, Nov 19, 2021 at 8:14 AM Eric Gallager wrote: > > > > On Fri, Nov 19, 2021 at 1:48 AM Gerald Pfeifer wrote: > > > > > > Cool, thank you! > > > > > > Please feel free to commit patches like this without asking for > > > approval (though I'm happy to review and approve). > > > > > > Gerald > > > > > > > OK thanks; committed as dbaebcd > > I've also committed one to remove the section on traditional C now: > https://gcc.gnu.org/git/?p=gcc-wwwdocs.git;a=commitdiff;h=ca83c13ad6bf0d351220dafa36264ebc7a6b7816 This next patch does more than just removing old stuff: it adds an extra sentence to describe a shell command used to generate a list, so to verify that I've got the shell command right, I'm asking for a review. Thanks, Eric Gallager patch-beginner-projects-02.diff Description: Binary data
