Re: v2 [PATCH] Fixes for PR68356, PR81210, and PR81693
On Dec 29, 2018, at 5:13 AM, Dominique d'Humières wrote: > > New patch for taking into account the comments in > https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01003.html > > 2018-12-29 Dominique d'Humieres > >PR tree-optimization/68356 >PR target/81210 >PR target/81693 >* gcc.dg/torture/pr68264.c: Skip on darwin. >* gcc.dg/torture/pr68037-1.c: Likewise. >* gcc.dg/torture/pr68037-2.c: Likewise. >* gcc.dg/torture/pr68037-3.c: Likewise. >* gcc.dg/torture/pr25967-1.c: Likewise. >* gcc.dg/torture/pr25967-2.c: Likewise. > > OK to commit to trunk and the gcc-8 branch? Ok.
Re: v2 [PATCH] Fixes for PR68356, PR81210, and PR81693
> On 29 Dec 2018, at 13:13, Dominique d'Humières wrote: > > New patch for taking into account the comments in > https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01003.html > > 2018-12-29 Dominique d'Humieres > >PR tree-optimization/68356 >PR target/81210 >PR target/81693 >* gcc.dg/torture/pr68264.c: Skip on darwin. >* gcc.dg/torture/pr68037-1.c: Likewise. >* gcc.dg/torture/pr68037-2.c: Likewise. >* gcc.dg/torture/pr68037-3.c: Likewise. >* gcc.dg/torture/pr25967-1.c: Likewise. >* gcc.dg/torture/pr25967-2.c: Likewise. > > OK to commit to trunk and the gcc-8 branch? LGTM, and in line with what was already approved. Iain > > Dominique > >
v2 [PATCH] Fixes for PR68356, PR81210, and PR81693
New patch for taking into account the comments in https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01003.html 2018-12-29 Dominique d'Humieres PR tree-optimization/68356 PR target/81210 PR target/81693 * gcc.dg/torture/pr68264.c: Skip on darwin. * gcc.dg/torture/pr68037-1.c: Likewise. * gcc.dg/torture/pr68037-2.c: Likewise. * gcc.dg/torture/pr68037-3.c: Likewise. * gcc.dg/torture/pr25967-1.c: Likewise. * gcc.dg/torture/pr25967-2.c: Likewise. OK to commit to trunk and the gcc-8 branch? Dominique patch-68356b Description: Binary data
Re: [PATCH] Fixes for PR68356, PR81210, and PR81693
On Nov 14, 2017, at 3:33 AM, Dominique d'Humières <domi...@lps.ens.fr> wrote:
>
>> Le 13 nov. 2017 à 18:40, Mike Stump <mikest...@comcast.net> a écrit :
>> On Nov 12, 2017, at 6:58 AM, H.J. Lu <hjl.to...@gmail.com> wrote:
>>>
>>> On Sun, Nov 12, 2017 at 6:22 AM, Dominique d'Humières
>>> <domi...@lps.ens.fr> wrote:
>>>> The following patch fixes PR68356, PR81210, and PR81693 on darwin.
>>>> ...
>>>
>>> I wrote these tests. These tests don't align stack to 16 bytes and
>>> should be skipped on Darwin.
>>
>> So, sounds like something based on:
>>
>> /* { dg-skip-if "sp not aligned to 16 bytes" { *-*-darwin } } */
>>
>> then. Ok with that change.
>
> Thanks for the review.
>
> Am I correct to understand that this apply to pr25967-*.c only?
>
> I’ld like to keep the PR numbers. Is it OK?
Feel free to keep the PR, but, I'd close the other two as dups of the first,
and then just list the first. The issue is that all of these test cases are 1
problem, so there should only be 1 PR. HJ's comment applies to all test cases
in your patch, and the problem appears to be the single non-16 byte stack on
all of them. Because of that alone, the test cases should be skipped for that
one reason, no matter the existence of other reasons why that test case should
be skipped.
Re: [PATCH] Fixes for PR68356, PR81210, and PR81693
> Le 13 nov. 2017 à 18:40, Mike Stump <mikest...@comcast.net> a écrit :
>
> On Nov 12, 2017, at 6:58 AM, H.J. Lu <hjl.to...@gmail.com> wrote:
>>
>> On Sun, Nov 12, 2017 at 6:22 AM, Dominique d'Humières
>> <domi...@lps.ens.fr> wrote:
>>> The following patch fixes PR68356, PR81210, and PR81693 on darwin.
>>> ...
>>
>> I wrote these tests. These tests don't align stack to 16 bytes and
>> should be skipped on Darwin.
>
> So, sounds like something based on:
>
> /* { dg-skip-if "sp not aligned to 16 bytes" { *-*-darwin } } */
>
> then. Ok with that change.
Thanks for the review.
Am I correct to understand that this apply to pr25967-*.c only?
I’ld like to keep the PR numbers. Is it OK?
TIA
Dominique
Re: [PATCH] Fixes for PR68356, PR81210, and PR81693
On Nov 12, 2017, at 6:58 AM, H.J. Lu <hjl.to...@gmail.com> wrote:
>
> On Sun, Nov 12, 2017 at 6:22 AM, Dominique d'Humières
> <domi...@lps.ens.fr> wrote:
>> The following patch fixes PR68356, PR81210, and PR81693 on darwin.
>>
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68264.c2016-01-28
>> 00:30:03.0 +0100
>> +++ gcc/testsuite/gcc.dg/torture/pr68264.c 2017-11-11
>> 17:16:58.0 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run } */
>> +/* { dg-xfail-run-if "PR68356 no math-errno on darwin" { "*-*-darwin*" } }
>> */
>> /* { dg-add-options ieee } */
>> /* { dg-require-effective-target fenv_exceptions } */
>>
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-1.c 2016-06-10
>> 15:22:50.0 +0200
>> +++ gcc/testsuite/gcc.dg/torture/pr68037-1.c2017-11-11
>> 18:43:16.0 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
>> +/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } } */
>> /* { dg-options "-mgeneral-regs-only" } */
>>
>> extern void exit (int);
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-2.c 2016-06-10
>> 15:22:50.0 +0200
>> +++ gcc/testsuite/gcc.dg/torture/pr68037-2.c2017-11-11
>> 18:44:08.0 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
>> +/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } } */
>> /* { dg-options "-mgeneral-regs-only" } */
>>
>> extern void exit (int);
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-3.c 2016-06-10
>> 15:22:50.0 +0200
>> +++ gcc/testsuite/gcc.dg/torture/pr68037-3.c2017-11-11
>> 18:49:10.0 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
>> +/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } { "-O1" "-O2" "-O3"
>> "-Os" } } */
>> /* { dg-options "-mgeneral-regs-only" } */
>>
>> #include
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr25967-1.c 2017-10-26
>> 07:16:19.0 +0200
>> +++ gcc/testsuite/gcc.dg/torture/pr25967-1.c2017-11-11
>> 19:36:30.0 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
>> +/* { dg-xfail-run-if "PR81693" { "*-*-darwin*" } } */
>> /* { dg-options "-mgeneral-regs-only" } */
>>
>> extern void exit (int);
>> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr25967-2.c 2017-10-26
>> 07:16:19.0 +0200
>> +++ gcc/testsuite/gcc.dg/torture/pr25967-2.c2017-11-11
>> 19:36:02.0 +0100
>> @@ -1,4 +1,5 @@
>> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
>> +/* { dg-xfail-run-if "PR81693" { *-*-darwin* && ilp32 } } */
>> /* { dg-options "-mgeneral-regs-only" } */
>>
>>
>> Is it OK?
>
> I wrote these tests. These tests don't align stack to 16 bytes and
> should be skipped on Darwin.
So, sounds like something based on:
/* { dg-skip-if "sp not aligned to 16 bytes" { *-*-darwin } } */
then. Ok with that change.
Re: [PATCH] Fixes for PR68356, PR81210, and PR81693
On Sun, Nov 12, 2017 at 6:22 AM, Dominique d'Humières
<domi...@lps.ens.fr> wrote:
> The following patch fixes PR68356, PR81210, and PR81693 on darwin.
>
> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68264.c2016-01-28
> 00:30:03.0 +0100
> +++ gcc/testsuite/gcc.dg/torture/pr68264.c 2017-11-11 17:16:58.0
> +0100
> @@ -1,4 +1,5 @@
> /* { dg-do run } */
> +/* { dg-xfail-run-if "PR68356 no math-errno on darwin" { "*-*-darwin*" } } */
> /* { dg-add-options ieee } */
> /* { dg-require-effective-target fenv_exceptions } */
>
> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-1.c 2016-06-10
> 15:22:50.0 +0200
> +++ gcc/testsuite/gcc.dg/torture/pr68037-1.c2017-11-11 18:43:16.0
> +0100
> @@ -1,4 +1,5 @@
> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
> +/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } } */
> /* { dg-options "-mgeneral-regs-only" } */
>
> extern void exit (int);
> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-2.c 2016-06-10
> 15:22:50.0 +0200
> +++ gcc/testsuite/gcc.dg/torture/pr68037-2.c2017-11-11 18:44:08.0
> +0100
> @@ -1,4 +1,5 @@
> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
> +/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } } */
> /* { dg-options "-mgeneral-regs-only" } */
>
> extern void exit (int);
> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-3.c 2016-06-10
> 15:22:50.0 +0200
> +++ gcc/testsuite/gcc.dg/torture/pr68037-3.c2017-11-11 18:49:10.0
> +0100
> @@ -1,4 +1,5 @@
> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
> +/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } { "-O1" "-O2" "-O3"
> "-Os" } } */
> /* { dg-options "-mgeneral-regs-only" } */
>
> #include
> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr25967-1.c 2017-10-26
> 07:16:19.0 +0200
> +++ gcc/testsuite/gcc.dg/torture/pr25967-1.c2017-11-11 19:36:30.0
> +0100
> @@ -1,4 +1,5 @@
> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
> +/* { dg-xfail-run-if "PR81693" { "*-*-darwin*" } } */
> /* { dg-options "-mgeneral-regs-only" } */
>
> extern void exit (int);
> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr25967-2.c 2017-10-26
> 07:16:19.0 +0200
> +++ gcc/testsuite/gcc.dg/torture/pr25967-2.c2017-11-11 19:36:02.0
> +0100
> @@ -1,4 +1,5 @@
> /* { dg-do run { target i?86-*-* x86_64-*-* } } */
> +/* { dg-xfail-run-if "PR81693" { *-*-darwin* && ilp32 } } */
> /* { dg-options "-mgeneral-regs-only" } */
>
>
> Is it OK?
I wrote these tests. These tests don't align stack to 16 bytes and
should be skipped on Darwin.
--
H.J.
[PATCH] Fixes for PR68356, PR81210, and PR81693
The following patch fixes PR68356, PR81210, and PR81693 on darwin.
--- ../_clean/gcc/testsuite/gcc.dg/torture/pr68264.c2016-01-28
00:30:03.0 +0100
+++ gcc/testsuite/gcc.dg/torture/pr68264.c 2017-11-11 17:16:58.0
+0100
@@ -1,4 +1,5 @@
/* { dg-do run } */
+/* { dg-xfail-run-if "PR68356 no math-errno on darwin" { "*-*-darwin*" } } */
/* { dg-add-options ieee } */
/* { dg-require-effective-target fenv_exceptions } */
--- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-1.c 2016-06-10
15:22:50.0 +0200
+++ gcc/testsuite/gcc.dg/torture/pr68037-1.c2017-11-11 18:43:16.0
+0100
@@ -1,4 +1,5 @@
/* { dg-do run { target i?86-*-* x86_64-*-* } } */
+/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } } */
/* { dg-options "-mgeneral-regs-only" } */
extern void exit (int);
--- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-2.c 2016-06-10
15:22:50.0 +0200
+++ gcc/testsuite/gcc.dg/torture/pr68037-2.c2017-11-11 18:44:08.0
+0100
@@ -1,4 +1,5 @@
/* { dg-do run { target i?86-*-* x86_64-*-* } } */
+/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } } */
/* { dg-options "-mgeneral-regs-only" } */
extern void exit (int);
--- ../_clean/gcc/testsuite/gcc.dg/torture/pr68037-3.c 2016-06-10
15:22:50.0 +0200
+++ gcc/testsuite/gcc.dg/torture/pr68037-3.c2017-11-11 18:49:10.0
+0100
@@ -1,4 +1,5 @@
/* { dg-do run { target i?86-*-* x86_64-*-* } } */
+/* { dg-xfail-run-if "PR81210" { *-*-darwin* && lp64 } { "-O1" "-O2" "-O3"
"-Os" } } */
/* { dg-options "-mgeneral-regs-only" } */
#include
--- ../_clean/gcc/testsuite/gcc.dg/torture/pr25967-1.c 2017-10-26
07:16:19.0 +0200
+++ gcc/testsuite/gcc.dg/torture/pr25967-1.c2017-11-11 19:36:30.0
+0100
@@ -1,4 +1,5 @@
/* { dg-do run { target i?86-*-* x86_64-*-* } } */
+/* { dg-xfail-run-if "PR81693" { "*-*-darwin*" } } */
/* { dg-options "-mgeneral-regs-only" } */
extern void exit (int);
--- ../_clean/gcc/testsuite/gcc.dg/torture/pr25967-2.c 2017-10-26
07:16:19.0 +0200
+++ gcc/testsuite/gcc.dg/torture/pr25967-2.c2017-11-11 19:36:02.0
+0100
@@ -1,4 +1,5 @@
/* { dg-do run { target i?86-*-* x86_64-*-* } } */
+/* { dg-xfail-run-if "PR81693" { *-*-darwin* && ilp32 } } */
/* { dg-options "-mgeneral-regs-only" } */
Is it OK?
TIA
Dominique
