Re: [PATCH] hppa-linux: add missing cpp specs
On 27 May 2015 14:20, John David Anglin wrote: On 2015-05-27 1:50 PM, Mike Frysinger wrote: since i'm not looped into gcc development normally, which branches are those currently ? naively reading gcc.gnu.org homepage makes me think none since they're labled regression fixes and afaict, none of these are regressions. they've been broken for as long as the ports have existed :/. The branches are 4.8, 4.9, 5 and trunk as noted on http://gcc.gnu.org. For target fixes, that don't affect primary or secondary targets, nobody cares about the regression criteria. gotcha. i've committed them then to trunk/4.8/4.9/5. hopefully didn't break anything ;). This is probably one of the causes of poor thread behavior of many applications running on parisc hardware. I want to see the patch in Debian and you probably want it for Gentoo. i've already merged the patches in Gentoo for 4.6+ ;) -mike signature.asc Description: Digital signature
Re: [PATCH] hppa-linux: add missing cpp specs
On 27 May 2015 13:05, John David Anglin wrote: On 2015-05-27 11:59 AM, Mike Frysinger wrote: Define CPP_SPEC for parisc linux targets so that -posix -pthread work like on all other linux targets. 2015-05-27 Mike Frysingervap...@gentoo.org * config/pa/pa-linux.h (CPP_SPEC): Define. Okay. I think this should be applied to all active branches. ChangeLog entry should mention _REENTRANT. since i'm not looped into gcc development normally, which branches are those currently ? naively reading gcc.gnu.org homepage makes me think none since they're labled regression fixes and afaict, none of these are regressions. they've been broken for as long as the ports have existed :/. -mike signature.asc Description: Digital signature
Re: [PATCH] hppa-linux: add missing cpp specs
On 2015-05-27 1:50 PM, Mike Frysinger wrote: since i'm not looped into gcc development normally, which branches are those currently ? naively reading gcc.gnu.org homepage makes me think none since they're labled regression fixes and afaict, none of these are regressions. they've been broken for as long as the ports have existed :/. The branches are 4.8, 4.9, 5 and trunk as noted on http://gcc.gnu.org. For target fixes, that don't affect primary or secondary targets, nobody cares about the regression criteria. This is probably one of the causes of poor thread behavior of many applications running on parisc hardware. I want to see the patch in Debian and you probably want it for Gentoo. Dave -- John David Anglin dave.ang...@bell.net
[PATCH] hppa-linux: add missing cpp specs
Define CPP_SPEC for parisc linux targets so that -posix -pthread work
like on all other linux targets.
2015-05-27 Mike Frysinger vap...@gentoo.org
* config/pa/pa-linux.h (CPP_SPEC): Define.
---
gcc/config/pa/pa-linux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/pa/pa-linux.h b/gcc/config/pa/pa-linux.h
index 396d321..f8da185 100644
--- a/gcc/config/pa/pa-linux.h
+++ b/gcc/config/pa/pa-linux.h
@@ -28,7 +28,7 @@ along with GCC; see the file COPYING3. If not see
while (0)
#undef CPP_SPEC
-#define CPP_SPEC %{posix:-D_POSIX_SOURCE}
+#define CPP_SPEC %{posix:-D_POSIX_SOURCE} %{pthread:-D_REENTRANT}
#undef ASM_SPEC
#define ASM_SPEC \
--
2.4.1
Re: [PATCH] hppa-linux: add missing cpp specs
On 2015-05-27 11:59 AM, Mike Frysinger wrote: Define CPP_SPEC for parisc linux targets so that -posix -pthread work like on all other linux targets. 2015-05-27 Mike Frysingervap...@gentoo.org * config/pa/pa-linux.h (CPP_SPEC): Define. Okay. I think this should be applied to all active branches. ChangeLog entry should mention _REENTRANT. Thanks, Dave -- John David Anglin dave.ang...@bell.net
