RE: [PATCH v2][ARM][GCC][2/5x]: MVE load intrinsics.

2020-03-18 Thread Kyrylo Tkachov
Hi Srinath,

> -Original Message-
> From: Srinath Parvathaneni 
> Sent: 18 March 2020 17:18
> To: gcc-patches@gcc.gnu.org
> Cc: Kyrylo Tkachov 
> Subject: [PATCH v2][ARM][GCC][2/5x]: MVE load intrinsics.
> 
> Hello Kyrill,
> 
> Following patch is the rebased version of v1.
> (version v1) https://gcc.gnu.org/pipermail/gcc-patches/2019-
> November/534338.html
> 
> 
> 
> Hello,
> 
> This patch supports the following MVE ACLE load intrinsics.
> 
> vldrbq_gather_offset_u8, vldrbq_gather_offset_s8, vldrbq_s8, vldrbq_u8,
> vldrbq_gather_offset_u16, vldrbq_gather_offset_s16, vldrbq_s16,
> vldrbq_u16, vldrbq_gather_offset_u32, vldrbq_gather_offset_s32,
> vldrbq_s32, vldrbq_u32, vldrwq_gather_base_s32, vldrwq_gather_base_u32.
> 
> Please refer to M-profile Vector Extension (MVE) intrinsics [1]  for more
> details.
> [1]  https://developer.arm.com/architectures/instruction-sets/simd-
> isas/helium/mve-intrinsics
> 
> Regression tested on arm-none-eabi and found no regressions.
> 
> Ok for trunk?

Thanks, I've pushed this patch to master.

Kyrill

> 
> Thanks,
> Srinath.
> 
> gcc/ChangeLog:
> 
> 2019-11-01  Andre Vieira  
>   Mihail Ionescu  
>   Srinath Parvathaneni  
> 
>   * config/arm/arm-builtins.c (LDRGU_QUALIFIERS): Define builtin
>   qualifier.
>   (LDRGS_QUALIFIERS): Likewise.
>   (LDRS_QUALIFIERS): Likewise.
>   (LDRU_QUALIFIERS): Likewise.
>   (LDRGBS_QUALIFIERS): Likewise.
>   (LDRGBU_QUALIFIERS): Likewise.
>   * config/arm/arm_mve.h (vldrbq_gather_offset_u8): Define macro.
>   (vldrbq_gather_offset_s8): Likewise.
>   (vldrbq_s8): Likewise.
>   (vldrbq_u8): Likewise.
>   (vldrbq_gather_offset_u16): Likewise.
>   (vldrbq_gather_offset_s16): Likewise.
>   (vldrbq_s16): Likewise.
>   (vldrbq_u16): Likewise.
>   (vldrbq_gather_offset_u32): Likewise.
>   (vldrbq_gather_offset_s32): Likewise.
>   (vldrbq_s32): Likewise.
>   (vldrbq_u32): Likewise.
>   (vldrwq_gather_base_s32): Likewise.
>   (vldrwq_gather_base_u32): Likewise.
>   (__arm_vldrbq_gather_offset_u8): Define intrinsic.
>   (__arm_vldrbq_gather_offset_s8): Likewise.
>   (__arm_vldrbq_s8): Likewise.
>   (__arm_vldrbq_u8): Likewise.
>   (__arm_vldrbq_gather_offset_u16): Likewise.
>   (__arm_vldrbq_gather_offset_s16): Likewise.
>   (__arm_vldrbq_s16): Likewise.
>   (__arm_vldrbq_u16): Likewise.
>   (__arm_vldrbq_gather_offset_u32): Likewise.
>   (__arm_vldrbq_gather_offset_s32): Likewise.
>   (__arm_vldrbq_s32): Likewise.
>   (__arm_vldrbq_u32): Likewise.
>   (__arm_vldrwq_gather_base_s32): Likewise.
>   (__arm_vldrwq_gather_base_u32): Likewise.
>   (vldrbq_gather_offset): Define polymorphic variant.
>   * config/arm/arm_mve_builtins.def (LDRGU_QUALIFIERS): Use
> builtin
>   qualifier.
> (LDRGS_QUALIFIERS): Likewise.
> (LDRS_QUALIFIERS): Likewise.
> (LDRU_QUALIFIERS): Likewise.
> (LDRGBS_QUALIFIERS): Likewise.
> (LDRGBU_QUALIFIERS): Likewise.
>   * config/arm/mve.md (VLDRBGOQ): Define iterator.
>   (VLDRBQ): Likewise.
>   (VLDRWGBQ): Likewise.
>   (mve_vldrbq_gather_offset_): Define RTL pattern.
>   (mve_vldrbq_): Likewise.
>   (mve_vldrwq_gather_base_v4si): Likewise.
> 
> gcc/testsuite/ChangeLog:
> 
> 2019-11-01  Andre Vieira  
>   Mihail Ionescu  
>   Srinath Parvathaneni  
> 
>   * gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_s16.c: New
> test.
>   * gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_s32.c:
> Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_s8.c: Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_u16.c:
> Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_u32.c:
> Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_u8.c: Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrbq_s16.c: Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrbq_s32.c: Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrbq_s8.c: Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrbq_u16.c: Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrbq_u32.c: Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrbq_u8.c: Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrwq_gather_base_s32.c: Likewise.
>   * gcc.target/arm/mve/intrinsics/vldrwq_gather_base_u32.c: Likewise.
> 
> 
> ### Attachment also inlined for ease of reply
> ###
> 
> 
> diff --git a/gcc/config/arm/arm-builtins.c b/gcc/config/arm/arm-builti

[PATCH v2][ARM][GCC][2/5x]: MVE load intrinsics.

2020-03-18 Thread Srinath Parvathaneni
Hello Kyrill,

Following patch is the rebased version of v1.
(version v1) https://gcc.gnu.org/pipermail/gcc-patches/2019-November/534338.html



Hello,

This patch supports the following MVE ACLE load intrinsics.

vldrbq_gather_offset_u8, vldrbq_gather_offset_s8, vldrbq_s8, vldrbq_u8,
vldrbq_gather_offset_u16, vldrbq_gather_offset_s16, vldrbq_s16, vldrbq_u16,
vldrbq_gather_offset_u32, vldrbq_gather_offset_s32, vldrbq_s32, vldrbq_u32,
vldrwq_gather_base_s32, vldrwq_gather_base_u32.

Please refer to M-profile Vector Extension (MVE) intrinsics [1]  for more 
details.
[1]  
https://developer.arm.com/architectures/instruction-sets/simd-isas/helium/mve-intrinsics

Regression tested on arm-none-eabi and found no regressions.

Ok for trunk?

Thanks,
Srinath.

gcc/ChangeLog:

2019-11-01  Andre Vieira  
Mihail Ionescu  
Srinath Parvathaneni  

* config/arm/arm-builtins.c (LDRGU_QUALIFIERS): Define builtin
qualifier.
(LDRGS_QUALIFIERS): Likewise.
(LDRS_QUALIFIERS): Likewise.
(LDRU_QUALIFIERS): Likewise.
(LDRGBS_QUALIFIERS): Likewise.
(LDRGBU_QUALIFIERS): Likewise.
* config/arm/arm_mve.h (vldrbq_gather_offset_u8): Define macro.
(vldrbq_gather_offset_s8): Likewise.
(vldrbq_s8): Likewise.
(vldrbq_u8): Likewise.
(vldrbq_gather_offset_u16): Likewise.
(vldrbq_gather_offset_s16): Likewise.
(vldrbq_s16): Likewise.
(vldrbq_u16): Likewise.
(vldrbq_gather_offset_u32): Likewise.
(vldrbq_gather_offset_s32): Likewise.
(vldrbq_s32): Likewise.
(vldrbq_u32): Likewise.
(vldrwq_gather_base_s32): Likewise.
(vldrwq_gather_base_u32): Likewise.
(__arm_vldrbq_gather_offset_u8): Define intrinsic.
(__arm_vldrbq_gather_offset_s8): Likewise.
(__arm_vldrbq_s8): Likewise.
(__arm_vldrbq_u8): Likewise.
(__arm_vldrbq_gather_offset_u16): Likewise.
(__arm_vldrbq_gather_offset_s16): Likewise.
(__arm_vldrbq_s16): Likewise.
(__arm_vldrbq_u16): Likewise.
(__arm_vldrbq_gather_offset_u32): Likewise.
(__arm_vldrbq_gather_offset_s32): Likewise.
(__arm_vldrbq_s32): Likewise.
(__arm_vldrbq_u32): Likewise.
(__arm_vldrwq_gather_base_s32): Likewise.
(__arm_vldrwq_gather_base_u32): Likewise.
(vldrbq_gather_offset): Define polymorphic variant.
* config/arm/arm_mve_builtins.def (LDRGU_QUALIFIERS): Use builtin
qualifier.
(LDRGS_QUALIFIERS): Likewise.
(LDRS_QUALIFIERS): Likewise.
(LDRU_QUALIFIERS): Likewise.
(LDRGBS_QUALIFIERS): Likewise.
(LDRGBU_QUALIFIERS): Likewise.
* config/arm/mve.md (VLDRBGOQ): Define iterator.
(VLDRBQ): Likewise. 
(VLDRWGBQ): Likewise.
(mve_vldrbq_gather_offset_): Define RTL pattern.
(mve_vldrbq_): Likewise.
(mve_vldrwq_gather_base_v4si): Likewise.

gcc/testsuite/ChangeLog:

2019-11-01  Andre Vieira  
Mihail Ionescu  
Srinath Parvathaneni  

* gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_s16.c: New test.
* gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_s32.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_s8.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_u16.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_u32.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrbq_gather_offset_u8.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrbq_s16.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrbq_s32.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrbq_s8.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrbq_u16.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrbq_u32.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrbq_u8.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrwq_gather_base_s32.c: Likewise.
* gcc.target/arm/mve/intrinsics/vldrwq_gather_base_u32.c: Likewise.


### Attachment also inlined for ease of reply###


diff --git a/gcc/config/arm/arm-builtins.c b/gcc/config/arm/arm-builtins.c
index 
b285f074285116ce621e324b644d43efb6538b9d..aced55f52d317e8deafdc6a6804db3b80c00fd80
 100644
--- a/gcc/config/arm/arm-builtins.c
+++ b/gcc/config/arm/arm-builtins.c
@@ -612,6 +612,36 @@ arm_strsbu_qualifiers[SIMD_MAX_BUILTIN_ARGS]
   qualifier_unsigned};
 #define STRSBU_QUALIFIERS (arm_strsbu_qualifiers)
 
+static enum arm_type_qualifiers
+arm_ldrgu_qualifiers[SIMD_MAX_BUILTIN_ARGS]
+  = { qualifier_unsigned, qualifier_pointer, qualifier_unsigned};
+#define LDRGU_QUALIFIERS (arm_ldrgu_qualifiers)
+
+static enum arm_type_qualifiers
+arm_ldrgs_qualifiers[SIMD_MAX_BUILTIN_ARGS]
+  = { qualifier_none, qualifier_pointer, qualifier_unsigned};
+#define LDRGS_QUALIFIERS (arm_ldrgs_qualifiers)
+
+static enum arm_type_qualifiers