Re: [Committed] RISC-V: Use MAX instead of std::max [VSETVL PASS]
On 1/7/24 16:07, 钟居哲 wrote: Since in the previous review from Robin, he have ever asked me change std::max into MAX, I thought the policy is preferring MAX instead of std::max. I change the codes to make them consistent but it seems I am wrong. So is it reasonable that I change all RVV-related codes back to use std::max/min ? If yes, I can send a patch to adapt all of them in RVV related codes. If Robin asked for MAX, let's leave it as-is. It's not a hard requirement, just a general direction towards std:: when we can. It may be the case that with other codes using MAX nearby that keeping consistency is better. jeff
Re: Re: [Committed] RISC-V: Use MAX instead of std::max [VSETVL PASS]
Since in the previous review from Robin, he have ever asked me change std::max
into MAX,
I thought the policy is preferring MAX instead of std::max.
I change the codes to make them consistent but it seems I am wrong.
So is it reasonable that I change all RVV-related codes back to use
std::max/min ?
If yes, I can send a patch to adapt all of them in RVV related codes.
juzhe.zh...@rivai.ai
From: Jeff Law
Date: 2024-01-08 03:11
To: Juzhe-Zhong; gcc-patches
Subject: Re: [Committed] RISC-V: Use MAX instead of std::max [VSETVL PASS]
On 1/6/24 17:36, Juzhe-Zhong wrote:
> Obvious fix, Committed.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-vsetvl.cc: replace std::max by MAX.
Curious why you made this change -- in general we're moving to
std::{min,max,swap} and away from macro-ized min/max/swap.
Jeff
Re: [Committed] RISC-V: Use MAX instead of std::max [VSETVL PASS]
On 1/6/24 17:36, Juzhe-Zhong wrote:
Obvious fix, Committed.
gcc/ChangeLog:
* config/riscv/riscv-vsetvl.cc: replace std::max by MAX.
Curious why you made this change -- in general we're moving to
std::{min,max,swap} and away from macro-ized min/max/swap.
Jeff
