Re: [gdal-dev] Motion: grant github commit rights to Nyall Dawson
+1 -Jukka Rahkonen- -Alkuperäinen viesti- Lähettäjä: gdal-dev Puolesta Even Rouault Lähetetty: keskiviikko 26. tammikuuta 2022 1.34 Vastaanottaja: gdal-dev@lists.osgeo.org Aihe: [gdal-dev] Motion: grant github commit rights to Nyall Dawson Hi, I'd like to motion to grant github commit rights to Nyall. We don't have much people currently doing reviews of pull requests and pressing the "Merge" button, and Nyall is definitely in a capacity of fulfilling this responsibility, at least in the areas where he fills comfortable. His own pull requests are of excellent quality and he's one of the few to review my work. Starting with my +1 Even -- http://www.spatialys.com My software is free, but my time generally not. ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] Motion: grant github commit rights to Nyall Dawson
+1 FrankW On Tue, Jan 25, 2022 at 9:12 PM Daniel Morissette wrote: > +1 > > Daniel > > > On 2022-01-25 18:34, Even Rouault wrote: > > Hi, > > > > I'd like to motion to grant github commit rights to Nyall. We don't have > > much people currently doing reviews of pull requests and pressing the > > "Merge" button, and Nyall is definitely in a capacity of fulfilling this > > responsibility, at least in the areas where he fills comfortable. His > > own pull requests are of excellent quality and he's one of the few to > > review my work. > > > > Starting with my +1 > > > > Even > > > > > -- > Daniel Morissette > Mapgears Inc > T: +1 418-696-5056 #201 > ___ > gdal-dev mailing list > gdal-dev@lists.osgeo.org > https://lists.osgeo.org/mailman/listinfo/gdal-dev > -- ---+-- I set the clouds in motion - turn up | Frank Warmerdam, warmer...@pobox.com light and sound - activate the windows | +1 650-701-7823 and watch the world go round - Rush| Geospatial Software Developer ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] Motion: grant github commit rights to Nyall Dawson
+1 Daniel On 2022-01-25 18:34, Even Rouault wrote: Hi, I'd like to motion to grant github commit rights to Nyall. We don't have much people currently doing reviews of pull requests and pressing the "Merge" button, and Nyall is definitely in a capacity of fulfilling this responsibility, at least in the areas where he fills comfortable. His own pull requests are of excellent quality and he's one of the few to review my work. Starting with my +1 Even -- Daniel Morissette Mapgears Inc T: +1 418-696-5056 #201 ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] Motion: grant github commit rights to Nyall Dawson
+1 KurtS On Tue, Jan 25, 2022 at 3:34 PM Even Rouault wrote: > Hi, > > I'd like to motion to grant github commit rights to Nyall. We don't have > much people currently doing reviews of pull requests and pressing the > "Merge" button, and Nyall is definitely in a capacity of fulfilling this > responsibility, at least in the areas where he fills comfortable. His > own pull requests are of excellent quality and he's one of the few to > review my work. > > Starting with my +1 > > Even > > -- > http://www.spatialys.com > My software is free, but my time generally not. > > ___ > gdal-dev mailing list > gdal-dev@lists.osgeo.org > https://lists.osgeo.org/mailman/listinfo/gdal-dev > ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
[gdal-dev] Motion: grant github commit rights to Nyall Dawson
Hi, I'd like to motion to grant github commit rights to Nyall. We don't have much people currently doing reviews of pull requests and pressing the "Merge" button, and Nyall is definitely in a capacity of fulfilling this responsibility, at least in the areas where he fills comfortable. His own pull requests are of excellent quality and he's one of the few to review my work. Starting with my +1 Even -- http://www.spatialys.com My software is free, but my time generally not. ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] cmake status update - 99% good news!
HDF5 is a bit confusing. Here I use the same settings that I use to build
NetCDF, some settings are likely repeated but it works to build netCDF
set(HDF5_path C:/programs/compa_libs/hdf5-1.10.5)
set(HDF5_ROOT_DIR ${HDF5_path}/compileds/VC14_64)
set(HDF5_INCLUDE_DIRS ${HDF5_path}/compileds/VC14_32/include)
set(HDF5_LIBRARIES ${HDF5_path}/compileds/VC14_64/lib/hdf5.lib
${HDF5_path}/compileds/VC14_64/lib/hdf5_hl.lib
${HDF5_path}/compileds/VC14_${BITAGE}/lib/hdf5_hl_cpp.lib
${HDF5_path}/compileds/VC14_${BITAGE}/lib/hdf5_cpp.lib)
set(HDF5_HL_LIBRARIES ${HDF5_path}/compileds/VC14_64/lib/hdf5.lib
${HDF5_path}/compileds/VC14_${BITAGE}/lib/hdf5_hl.lib
${HDF5_path}/compileds/VC14_${BITAGE}/lib/hdf5_hl_cpp.lib
${HDF5_path}/compileds/VC14_${BITAGE}/lib/hdf5_cpp.lib)
but the build complains with
-- Could NOT find HDF5 (missing: HDF5_LIBRARIES HDF5_INCLUDE_DIRS) (found version
"1.10.5")
GDAL use the FindHDF5.cmake module provided by CMake itself :
https://cmake.org/cmake/help/latest/module/FindHDF5.html /
https://github.com/Kitware/CMake/blob/master/Modules/FindHDF5.cmake
I doubt you can directly specify HDF5_INCLUDE_DIRS, HDF5_LIBRARIES and
HDF5_HL_LIBRARIES as they are output variables of the FindHDF5 module,
not input variables
I'd say you should rather set HDF5_ROOT=${HDF5_path}/compileds/VC14_64
You may instrument the FindHDF5.cmake file to have more details
For ECW, it looks like I tested on Windows with ECW 5.5
I use SDK 3.3 and
-- Could NOT find ECW (missing: ECWnet_LIBRARY ECWC_LIBRARY NCSUtil_LIBRARY) (found
version "NCS_VERSION_NUMBER 3.3.0.161")
If you have a standard layout ( ${prefix}/include and ${prefix}/lib )
then specifying ECW_ROOT=${prefix} should normally work out of the box.
Logic is at
https://github.com/OSGeo/gdal/blob/master/cmake/modules/packages/FindECW.cmake
For MrSID, not sure I tested on Windows. Works on Linux with
DSDK-9.5.4.4709-rhel6
I don't really know what to set in this one. I have MrSID_DSDK-8.5.0.3422, that
works in the nmake build
set(MRSID_INCLUDE_DIR
"C:/programs/compa_libs/MrSID_DSDK-8.5.0.3422/compileds/VC14_64/include")
set(MRSID_LIBRARY
"C:/programs/compa_libs/MrSID_DSDK-8.5.0.3422/compileds/VC14_64/lib/lti_dsdk.lib")
Looks good. If you want to debug the logic, it is at
https://github.com/OSGeo/gdal/blob/master/cmake/modules/packages/FindMRSID.cmake
and get
-- Could NOT find ECW (missing: ECWnet_LIBRARY ECWC_LIBRARY NCSUtil_LIBRARY) (found
version "NCS_VERSION_NUMBER 3.3.0.161")
That's not the right message
--
http://www.spatialys.com
My software is free, but my time generally not.
___
gdal-dev mailing list
gdal-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] cmake status update - 99% good news!
>> I made also an attempt on Windows and so far my findings are:
>> The docs say that the PROJ variables should be
>> PROJ_INCLUDE_DIR
>> PROJ_LIBRARY_RELEASE
>> But the lib var must in fact be
>> PROJ_LIBRARY
> How do you build exactly ?
> If you build with "cmake --build . --config Release" then I believe
> PROJ_LIBRARY_RELEASE should be honored. Perhaps if you don't specify a
> configuration (is it possible with MSVC CMake builds ? I don't have a VM
> started right now), then PROJ_LIBRARY will be used.
I build with Ninja and by including a ConfigUser.make file (like GMT and NetCDF
do) that is made of lines like
set(PROJ_INCLUDE_DIR
"C:/programs/compa_libs/proj5_GIT/compileds/VC14_64/include")
set(PROJ_LIBRARY
"C:/programs/compa_libs/proj5_GIT/compileds/VC14_64/lib/proj.lib")
I also built all the dependencies myself. I do this because I want to be able
to control the dll file name (I'll get back to this in a future thread).
>> Couldn't yet find a way to build with HDF5, ECW and MRSID, which I can do
>> with no problems with the current nmake solution.
> HDF5 1.12.1 is tested with Windows Conda builds
HDF5 is a bit confusing. Here I use the same settings that I use to build
NetCDF, some settings are likely repeated but it works to build netCDF
set(HDF5_path C:/programs/compa_libs/hdf5-1.10.5)
set(HDF5_ROOT_DIR ${HDF5_path}/compileds/VC14_64)
set(HDF5_INCLUDE_DIRS ${HDF5_path}/compileds/VC14_32/include)
set(HDF5_LIBRARIES ${HDF5_path}/compileds/VC14_64/lib/hdf5.lib
${HDF5_path}/compileds/VC14_64/lib/hdf5_hl.lib
${HDF5_path}/compileds/VC14_${BITAGE}/lib/hdf5_hl_cpp.lib
${HDF5_path}/compileds/VC14_${BITAGE}/lib/hdf5_cpp.lib)
set(HDF5_HL_LIBRARIES ${HDF5_path}/compileds/VC14_64/lib/hdf5.lib
${HDF5_path}/compileds/VC14_${BITAGE}/lib/hdf5_hl.lib
${HDF5_path}/compileds/VC14_${BITAGE}/lib/hdf5_hl_cpp.lib
${HDF5_path}/compileds/VC14_${BITAGE}/lib/hdf5_cpp.lib)
but the build complains with
-- Could NOT find HDF5 (missing: HDF5_LIBRARIES HDF5_INCLUDE_DIRS) (found
version "1.10.5")
>> For ECW, it looks like I tested on Windows with ECW 5.5
I use SDK 3.3 and
-- Could NOT find ECW (missing: ECWnet_LIBRARY ECWC_LIBRARY NCSUtil_LIBRARY)
(found version "NCS_VERSION_NUMBER 3.3.0.161")
> For MrSID, not sure I tested on Windows. Works on Linux with
DSDK-9.5.4.4709-rhel6
I don't really know what to set in this one. I have MrSID_DSDK-8.5.0.3422, that
works in the nmake build
set(MRSID_INCLUDE_DIR
"C:/programs/compa_libs/MrSID_DSDK-8.5.0.3422/compileds/VC14_64/include")
set(MRSID_LIBRARY
"C:/programs/compa_libs/MrSID_DSDK-8.5.0.3422/compileds/VC14_64/lib/lti_dsdk.lib")
and get
-- Could NOT find ECW (missing: ECWnet_LIBRARY ECWC_LIBRARY NCSUtil_LIBRARY)
(found version "NCS_VERSION_NUMBER 3.3.0.161")
___
gdal-dev mailing list
gdal-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] Motion: adopt RFC 85: Policy regarding substantial code additions
I declare this motion passed with +1 from PSC members: MateuszL, KurtS, TamasS, SeanG, HowardB, JukkaR and me. Le 21/01/2022 à 11:18, Even Rouault a écrit : Hi, As the discussion seems to have calmed down, I move to adopt RFC 85: Policy regarding substantial code additions: https://github.com/OSGeo/gdal/pull/5128 Starting with my +1 Even -- http://www.spatialys.com My software is free, but my time generally not. ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
Re: [gdal-dev] cmake status update - 99% good news!
Hi Kai, Le 25/01/2022 à 08:23, Kai Pastor, DG0YT a écrit : I made an initial attempt on gdal with cmake for vcpkg: https://github.com/microsoft/vcpkg/pull/22392 Now vcpkg's default is static linkage on Linux and macOS. AFAICT static linkage is not covered very well. Trying to understand the issue: so the problems you face is when GDAL's dependencies are static libs, and you want gdal.pc, gdal-config or the CMake exported config to keep track all direct and indirect dependencies, right ? Otherwise, I can do a BUILD_SHARED_LIBS=OFF build currently against dynamic dependencies. Is it better covered on the autoconf side ? I've some doubts, as this isn't tested by CI. Not saying we can't improve this, but we'll need help from knowledgeable people. (can't you fallback on dynamic linkage for vcpkg?) Fixing this needs a lot of work either on the find modules, or on getting dependencies to provide exported config. In some cases (e.g. GEOS), config files already exist, but they are neither used nor a drop-in replacement (target names differ). Not sure what you mean. Example ? | including user-facing changes. Example ? Even -- http://www.spatialys.com My software is free, but my time generally not. ___ gdal-dev mailing list gdal-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/gdal-dev
