Re: [Geany-devel] editing big files can be too slow with tag reparsing - HTML
On Tue, Sep 27, 2011 at 14:17, Nick Treleaven nick.trelea...@btinternet.com wrote: On 26/09/2011 23:00, Colomban Wendling wrote: Le 26/09/2011 13:48, Nick Treleaven a écrit : I'm reduced to using Windows. I guess the reason is the regex code that is really old which is used for Windows builds. Maybe yeah, but I find it a little weird you see *so much* slowness... For comparison, on my machine [1] parsing and updating the list takes less than 60ms for geany.html. Just to be sure, are you seeing the 'built-in regex' debug message: 12:42:07: (null) INFO : GTK 2.22.0, GLib 2.26.0, built-in regex It might help to update it from CTags (we had a patch from Jiri Techet but it didn't look like it would build on Windows, i.e. wasn't from CTags). Maybe we could use GRegex now we have a GLib recent enough? Anyway tagamanger/regex.c looks like a few glibc source file concatenated with a 0xff separator, I'd then guess any POSIX RE implementation (e.g. today's glibc's one) would do, wouldn't it? That's probably what Jiri did, but I noticed CTags had some modifications to build on Windows. Perhaps glibc would work, but I think taking it from ctags is safer. Basically I took the (then) latest versions of the regex files plus the makefile from ctags. The patch still applies by the way. I've just diffed the result of my patch with the ctags regex and there aren't big differences. What I've forgotten include into my patch is a conditional include under windows in regex_internal.h so if you want to use my patch, substitute this file with the ctags one. I haven't tested it under Windows myself so I don't know what happens. Cheers, Jiri ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] editing big files can be too slow with tag reparsing - HTML
On 27/09/2011 01:53, Colomban Wendling wrote: Le 27/09/2011 01:44, Lex Trotman a écrit : [...] Pentium 4, 1.9 GHz, 512 MB ram. I'm no windows expert, but isn't 512mb considered kinda marginal, 1gb better. Whats your general windows performance like? I doubt that, even on Windows, it would so drastically reduce the performances. Was your RAM completely full so it needed to swap? Windows performance is fine, I run Firefox with tons of tabs easily. I have Windows XP BTW, so 512MB is not unusually low. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] editing big files can be too slow with tag reparsing - HTML
On 26/09/2011 23:00, Colomban Wendling wrote: Le 26/09/2011 13:48, Nick Treleaven a écrit : I'm reduced to using Windows. I guess the reason is the regex code that is really old which is used for Windows builds. Maybe yeah, but I find it a little weird you see *so much* slowness... For comparison, on my machine [1] parsing and updating the list takes less than 60ms for geany.html. Just to be sure, are you seeing the 'built-in regex' debug message: 12:42:07: (null) INFO : GTK 2.22.0, GLib 2.26.0, built-in regex It might help to update it from CTags (we had a patch from Jiri Techet but it didn't look like it would build on Windows, i.e. wasn't from CTags). Maybe we could use GRegex now we have a GLib recent enough? Anyway tagamanger/regex.c looks like a few glibc source file concatenated with a 0xff separator, I'd then guess any POSIX RE implementation (e.g. today's glibc's one) would do, wouldn't it? That's probably what Jiri did, but I noticed CTags had some modifications to build on Windows. Perhaps glibc would work, but I think taking it from ctags is safer. I don't know if GRegex would work, CTags parsers may use non-POSIX features - are \w \s part of POSIX? OK... with a fresh configdir? Just tried that, same problem. Task manager showed I still had about 230MB memory free whilst having the problem - the freeze caused 100% CPU as expected. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] editing big files can be too slow with tag reparsing - HTML
On 24/09/2011 11:59, Colomban Wendling wrote: Le 22/09/2011 18:30, Nick Treleaven a écrit : Hi, Whilst opening doc/geany.html I found it takes5s on my machine to load. It's a big document though, still perhaps the HTML tag parser performance could be improved. I think 5s is weird in the first place. I know geany.html is 6.5k-lines file, and that it may have say, 150 tags, but 5s seems way too much IMHO. Maybe we should try to find out why this is so slow on your machine, there might show a Geany bug, performance problem or something else. I'm reduced to using Windows. I guess the reason is the regex code that is really old which is used for Windows builds. It might help to update it from CTags (we had a patch from Jiri Techet but it didn't look like it would build on Windows, i.e. wasn't from CTags). * What kind of machine did you run (basically, CPU's MHz) Pentium 4, 1.9 GHz, 512 MB ram. * Had you many HTML files open, with many tags each? * Had you many non-HTML files open? Just that one file. ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] editing big files can be too slow with tag reparsing - HTML
Le 26/09/2011 13:48, Nick Treleaven a écrit : On 24/09/2011 11:59, Colomban Wendling wrote: Le 22/09/2011 18:30, Nick Treleaven a écrit : Hi, Whilst opening doc/geany.html I found it takes5s on my machine to load. It's a big document though, still perhaps the HTML tag parser performance could be improved. I think 5s is weird in the first place. I know geany.html is 6.5k-lines file, and that it may have say, 150 tags, but 5s seems way too much IMHO. Maybe we should try to find out why this is so slow on your machine, there might show a Geany bug, performance problem or something else. I'm reduced to using Windows. I guess the reason is the regex code that is really old which is used for Windows builds. Maybe yeah, but I find it a little weird you see *so much* slowness... For comparison, on my machine [1] parsing and updating the list takes less than 60ms for geany.html. It might help to update it from CTags (we had a patch from Jiri Techet but it didn't look like it would build on Windows, i.e. wasn't from CTags). Maybe we could use GRegex now we have a GLib recent enough? Anyway tagamanger/regex.c looks like a few glibc source file concatenated with a 0xff separator, I'd then guess any POSIX RE implementation (e.g. today's glibc's one) would do, wouldn't it? * What kind of machine did you run (basically, CPU's MHz) Pentium 4, 1.9 GHz, 512 MB ram. Not any kind of slow machine... Could anybody else try the same on another Windows machine, just to see if it is Windows-related or something? (Enrico, Matthew?) * Had you many HTML files open, with many tags each? * Had you many non-HTML files open? Just that one file. OK... with a fresh configdir? Regards, Colomban [1] OK, it is a little more powerful (i3 2.93GHz), but still ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] editing big files can be too slow with tag reparsing - HTML
[...] Pentium 4, 1.9 GHz, 512 MB ram. I'm no windows expert, but isn't 512mb considered kinda marginal, 1gb better. Whats your general windows performance like? Cheers Lex ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Re: [Geany-devel] editing big files can be too slow with tag reparsing - HTML
Le 27/09/2011 01:44, Lex Trotman a écrit : [...] Pentium 4, 1.9 GHz, 512 MB ram. I'm no windows expert, but isn't 512mb considered kinda marginal, 1gb better. Whats your general windows performance like? I doubt that, even on Windows, it would so drastically reduce the performances. Was your RAM completely full so it needed to swap? Cheers, Colomban ___ Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
