Re: gEDA-user: pcb-20091103
Hello there, I see the build places refcard to the docdir. Is it outdated or legacy documentation? In PCB's GUI there is already a Key Bindings menu. I believe this one entails uptodate key bindings rather than the refcard. If it is outdated, then I think it should be removed from pcb sources. Again in the make install process, pcb.html, pcb.ps and pcb.pdf are dumped into docdir. I think that everyone is using a modern linux distro with a pdf reader install by default on every desktop environment. So is it wise to ship only the pcb.pdf ? This will decrease the size of the pcb RPM/deb to be downloaded by the user. pcb.pdf is the only one shipped by fedora rpms. What do you think ? Chitlesh ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: More GL stuff to test
Just a quick note on perspective. In my experience with 3D CAD (solidworks) perspective is optional, and most skilled CAD designers that I know work without it. That means that parallel lines are parallel on the screen. (is this called orthographic? - well... its the same idea as isometric projection mentioned above) I'm no expert and its been many years since I have coded openGL, but I think that there is a 'projection matrix' that can turn perspective on and off... -- ╒═╕ Andrew Whyte MEng CEng ⌨ - www.paramita-electronics.com ╘═╛ ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 - Merge*** tools
Hi there, During make install, MergePCBPS and Merge_dimPCBPS are placed in both /usr/bin/ and /usr/share/pcb/tools. I think it is better that they land into /usr/share/pcb/tools only. Small patch attached. Chitlesh pcb-0.20091103-tools.patch Description: Binary data ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 - examples and tutorials
hi there again,
Examples and tutorials are also landing in /usr/share/pcb instead of
doc dir where users expect to find them.
Please accept this small path, coupled with the following changes:
* Add extension to the pcb files
mv example/LED example/LED.pcb
mv example/LED2 example/LED2.pcb
sed -i \
's|examplesdir = $(pkgdatadir)/examples|examplesdir = @docdir@/examples|' \
example/libraries/Makefile.*
sed -i \
's|tutdir = $(pkgdatadir)/tutorial|tutdir = @docdir@/tutorial|' \
tutorial/Makefile.*
* Add pad, thermal and puller into sub directories in the examples directory
dest=%{_docdir}/%{name}-%{version}/examples
for d in thermal pad puller ; do
echo -n -e ... Fixing path of $d \t
mkdir -p $dest/$d
mv $dest/../$d.* $dest/$d
install -pm 0644 doc/$d.{pcb,pdf} $dest/$d
echo done
done
These changes are already made in fedora's pcb rpm. It would be nice
that they are applied in upstream sources as well.
thanks,
Chitlesh
pcb-0.20091103-example.patch
Description: Binary data
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
gEDA-user: pcb-20091103 for Gentoo, working on ebuild
Two questions:
ste...@amd64-x2 ~/pcb/pcb-20091103 $ ./configure --help |grep lpr
--with-printer= Specify the printer: lpr [default=lpr]
I think lpr is the only available choice, and I read that leaving this
option out gives us all available printers. So I think we should not
specify this option at all for gentoo ebuild. But what is the
usage/benefit of this option, it is only a placeholder for future?
We have --enable-toporouter-output now.
It needs cairo. Is this true for lesstif HID too.
Two remarks:
--docdir=/usr/share/doc/pcb-20091103
seems to generate an obsolete empty directory
/usr/share/pcb-20091103/
For gentoo we like to have examples and tutorials in the doc
directories, so gentoo developers employ these patches:
# sed -i -e 's/example//' -e 's/tutorial//' -e 's/ win32//' Makefile.in
|| die sed failed
# sed -i -e 's/DOC=doc/DOC=doc example tutorial/' configure || die sed
failed
# sed -i -e 's/$(pkgdatadir)/$(docdir)/' {example,tutorial}/Makefile.in
|| die sed failed
And some warnings from gcc4.4.2 on AMD64:
AMD64-X2 pcb # cat /var/tmp/portage/sci-electronics/pcb-20091103/temp/build.log
|grep arning
autoroute.c:3431: warning: ‘add_clearance’ defined but not used
djopt.c:2461: warning: ‘nudge_corner’ defined but not used
draw.c:381: warning: passing argument 3 of ‘DrawSilk’ discards qualifiers from
pointer target type
file.c:1129: warning: ignoring return value of ‘chdir’, declared with attribute
warn_unused_result
file.c:1142: warning: ignoring return value of ‘chdir’, declared with attribute
warn_unused_result
file.c:1148: warning: ignoring return value of ‘chdir’, declared with attribute
warn_unused_result
file.c:1166: warning: ignoring return value of ‘chdir’, declared with attribute
warn_unused_result
file.c:1218: warning: ignoring return value of ‘chdir’, declared with attribute
warn_unused_result
flags.c:226: warning: cast from pointer to integer of different size
flags.c:227: warning: cast from pointer to integer of different size
flags.c:228: warning: cast from pointer to integer of different size
flags.c:229: warning: cast from pointer to integer of different size
flags.c:230: warning: cast from pointer to integer of different size
flags.c:231: warning: cast from pointer to integer of different size
flags.c:232: warning: cast from pointer to integer of different size
flags.c:233: warning: cast from pointer to integer of different size
flags.c:234: warning: cast from pointer to integer of different size
flags.c:235: warning: cast from pointer to integer of different size
flags.c:237: warning: cast from pointer to integer of different size
flags.c:238: warning: cast from pointer to integer of different size
flags.c:240: warning: cast from pointer to integer of different size
flags.c:241: warning: cast from pointer to integer of different size
flags.c:243: warning: cast from pointer to integer of different size
flags.c:245: warning: cast from pointer to integer of different size
parse_l.l:198: warning: ignoring return value of ‘fwrite’, declared with
attribute warn_unused_result
parse_l.c:1508: warning: ‘input’ defined but not used
report.c:680: warning: no return statement in function returning non-void
res_lex.l:64: warning: ignoring return value of ‘fwrite’, declared with
attribute warn_unused_result
res_lex.c:1139: warning: ‘input’ defined but not used
rtree.c:203: warning: ‘__r_tree_is_good’ defined but not used
hid/gtk/gui-dialog.c:101: warning: format not a string literal and no format
arguments
hid/gtk/gui-dialog.c:145: warning: format not a string literal and no format
arguments
hid/gtk/gui-dialog.c:172: warning: format not a string literal and no format
arguments
hid/gtk/gui-top-window.c:2512: warning: format not a string literal and no
format arguments
/usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might
overflow destination buffer
/usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might
overflow destination buffer
hid/common/actions.c:88: warning: passing argument 1 of
‘hid_register_actions_context’ discards qualifiers from pointer target type
hid/common/actions.c:214: warning: ignoring return value of ‘fwrite’, declared
with attribute warn_unused_result
hid/common/actions.c:215: warning: ignoring return value of ‘fwrite’, declared
with attribute warn_unused_result
hid/png/png.c:313: warning: ‘save_flags.f’ may be used uninitialized in this
function
hid/png/png.c:313: warning: ‘save_flags.t[0u]’ may be used uninitialized in
this function
hid/png/png.c:313: warning: ‘save_flags.t[1u]’ may be used uninitialized in
this function
hid/png/png.c:313: warning: ‘save_flags.t[2u]’ may be used uninitialized in
this function
hid/png/png.c:313: warning: ‘save_flags.t[3u]’ may be used uninitialized in
this function
hid/png/png.c:313: warning: ‘save_flags.t[4u]’ may be used uninitialized in
this function
hid/png/png.c:313: warning: ‘save_flags.t[5u]’ may be used uninitialized in
Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild
On Sat, Nov 7, 2009 at 2:07 PM, Stefan Salewski wrote:
For gentoo we like to have examples and tutorials in the doc
directories, so gentoo developers employ these patches:
# sed -i -e 's/example//' -e 's/tutorial//' -e 's/ win32//' Makefile.in
|| die sed failed
# sed -i -e 's/DOC=doc/DOC=doc example tutorial/' configure || die
sed failed
# sed -i -e 's/$(pkgdatadir)/$(docdir)/' {example,tutorial}/Makefile.in
|| die sed failed
I support this :) I've just sent an email with respect to this.
Chitlesh
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild
On Sat, 2009-11-07 at 14:15 +0100, Chitlesh GOORAH wrote:
On Sat, Nov 7, 2009 at 2:07 PM, Stefan Salewski wrote:
For gentoo we like to have examples and tutorials in the doc
directories, so gentoo developers employ these patches:
# sed -i -e 's/example//' -e 's/tutorial//' -e 's/ win32//'
Makefile.in || die sed failed
# sed -i -e 's/DOC=doc/DOC=doc example tutorial/' configure || die
sed failed
# sed -i -e 's/$(pkgdatadir)/$(docdir)/'
{example,tutorial}/Makefile.in || die sed failed
I support this :) I've just sent an email with respect to this.
And looking at the debian package..
mv debian/$(package)/usr/share/pcb/*.pdf
debian/$(package)/usr/share/doc/$(package)
rm debian/$(package)/usr/share/pcb/*.ps
mv debian/$(package)/usr/share/pcb/examples
debian/$(package)/usr/share/doc/$(package)
mv debian/$(package)/usr/share/pcb/tutorial
debian/$(package)/usr/share/doc/$(package)
rmdir debian/$(package)/usr/share/pcb-*
So I guess that is 3:0 distros making very very similar changes. Sounds
like a good reason to get this changed.
Any votes from OpenSuSE?
Best wishes,
Peter C.
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild
On Sat, 2009-11-07 at 14:07 +0100, Stefan Salewski wrote: Two questions: ste...@amd64-x2 ~/pcb/pcb-20091103 $ ./configure --help |grep lpr --with-printer= Specify the printer: lpr [default=lpr] I think lpr is the only available choice, and I read that leaving this option out gives us all available printers. So I think we should not specify this option at all for gentoo ebuild. But what is the usage/benefit of this option, it is only a placeholder for future? We have --enable-toporouter-output now. It needs cairo. Is this true for lesstif HID too. I believe this is a debugging option, and distros should not be building with it enabled. Best wishes, Peter C. ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild
On Sat, 2009-11-07 at 15:53 +, Peter Clifton wrote: On Sat, 2009-11-07 at 14:07 +0100, Stefan Salewski wrote: Two questions: ste...@amd64-x2 ~/pcb/pcb-20091103 $ ./configure --help |grep lpr --with-printer= Specify the printer: lpr [default=lpr] I think lpr is the only available choice, and I read that leaving this option out gives us all available printers. So I think we should not specify this option at all for gentoo ebuild. But what is the usage/benefit of this option, it is only a placeholder for future? We have --enable-toporouter-output now. It needs cairo. Is this true for lesstif HID too. I believe this is a debugging option, and distros should not be building with it enabled. OH -- I was going to make --enable-toporouter-output an option for gentoo (USEFLAG toporouter-output). I have found no hint that this is for debugging only before. I have just compiled for motif GUI with --enable-toporouter-output. Compiles fine, and ldd command shows MD64-X2 pcb # ldd /var/tmp/portage/sci-electronics/pcb-20091103/image/usr/bin/pcb |grep cairo libcairo.so.2 = /usr/lib/libcairo.so.2 (0x7f4f198e6000) But if this is for debugging only I think we should drop this option. Best regards Stefan ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 - examples and tutorials
On Sat, 2009-11-07 at 14:02 +0100, Chitlesh GOORAH wrote:
hi there again,
* Add pad, thermal and puller into sub directories in the examples directory
dest=%{_docdir}/%{name}-%{version}/examples
for d in thermal pad puller ; do
echo -n -e ... Fixing path of $d \t
mkdir -p $dest/$d
mv $dest/../$d.* $dest/$d
install -pm 0644 doc/$d.{pcb,pdf} $dest/$d
echo done
done
I'm not sure I agree with this one..
Looking at the makefile, it would seem that the intention is the .pdf
file is not installed, as it is in fact a temporary build result on the
way to creating a larger piece of documentation. (pcb.pdf)
You also _break_ the HTML documentation by moving away the deliberately
installed .png / .gif files which it places there.
Since it doesn't appear the HTML docs use the .gif files, we ought not
to bother building them in the first place.
By all means delete the installed HTML files if you wish (along with
{thermal,pad,puller}.{png,gif}), but please don't install
intermediate .pcb of .pdf files.
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild
On Sat, 2009-11-07 at 17:27 +0100, Stefan Salewski wrote: We have --enable-toporouter-output now. It needs cairo. Is this true for lesstif HID too. I believe this is a debugging option, and distros should not be building with it enabled. OH -- I was going to make --enable-toporouter-output an option for gentoo (USEFLAG toporouter-output). I have found no hint that this is for debugging only before. I have just compiled for motif GUI with --enable-toporouter-output. Compiles fine, and ldd command shows MD64-X2 pcb # ldd /var/tmp/portage/sci-electronics/pcb-20091103/image/usr/bin/pcb |grep cairo libcairo.so.2 = /usr/lib/libcairo.so.2 (0x7f4f198e6000) But if this is for debugging only I think we should drop this option. Lets just check with Anthony (CC'd), he will know - as he wrote the code! ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild
On Sat, 2009-11-07 at 14:07 +0100, Stefan Salewski wrote:
--docdir=/usr/share/doc/pcb-20091103
seems to generate an obsolete empty directory
/usr/share/pcb-20091103/
That directory is somewhat of an annoyance on my box..
For gentoo we like to have examples and tutorials in the doc
directories, so gentoo developers employ these patches:
# sed -i -e 's/example//' -e 's/tutorial//' -e 's/ win32//' Makefile.in
|| die sed failed
What is the purpose of the above?
Does it stop the build of those dirs?
# sed -i -e 's/DOC=doc/DOC=doc example tutorial/' configure || die
sed failed
What is the purpose of the above?
# sed -i -e 's/$(pkgdatadir)/$(docdir)/' {example,tutorial}/Makefile.in
|| die sed failed
Does this fix it so it installs in $docdir/example/
$docdir/tutorial/ etc..?
IE. same as the other distros?
I'd support making that change, but I'm not sure what your other sed
substitutions are for.
(Hacking Makefile.in is a pain to follow, since we just need to fix
Makefile.am upstream, and it will almost certainly be a much more
readable fix!)
Best wishes,
Peter C.
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild
On Sat, 2009-11-07 at 16:51 +, Peter Clifton wrote:
On Sat, 2009-11-07 at 14:07 +0100, Stefan Salewski wrote:
--docdir=/usr/share/doc/pcb-20091103
seems to generate an obsolete empty directory
/usr/share/pcb-20091103/
That directory is somewhat of an annoyance on my box..
I am not sure if I really understand your comment.
By default documentation goes into /usr/share/doc/pcb directory. For
gentoo convention is to have a subdirectory for each version, so we
have /usr/share/doc/pcb-20091103. Works fine with --docdir= but this
seems to generate the empty usr/share/pcb-20091103/ also.
For gentoo we like to have examples and tutorials in the doc
directories, so gentoo developers employ these patches:
# sed -i -e 's/example//' -e 's/tutorial//' -e 's/ win32//'
Makefile.in || die sed failed
What is the purpose of the above?
Does it stop the build of those dirs?
# sed -i -e 's/DOC=doc/DOC=doc example tutorial/' configure || die
sed failed
What is the purpose of the above?
# sed -i -e 's/$(pkgdatadir)/$(docdir)/'
{example,tutorial}/Makefile.in || die sed failed
Does this fix it so it installs in $docdir/example/
$docdir/tutorial/ etc..?
Yes, but I have to admit that I do not really understand these patches.
IE. same as the other distros?
I'd support making that change, but I'm not sure what your other sed
substitutions are for.
(Hacking Makefile.in is a pain to follow, since we just need to fix
Makefile.am upstream, and it will almost certainly be a much more
readable fix!)
Personally I always do not like patches of Makefile.in too much, because
I do not understand it good enough to be sure that it does only good
things. Some Gentoo developers use mv commands (I would prefer this
myself), but Denis of sci-electronics area seems to like patches of
Makefile.in. (And I am sure he knows what he did.)
My gues is:
sed -i -e 's/example//' -e 's/tutorial//' -e 's/ win32//' Makefile.in
|| die sed failed
sed -i -e 's/DOC=doc/DOC=doc example tutorial/' configure || die sed
failed
sed -i -e 's/$(pkgdatadir)/$(docdir)/' {example,tutorial}/Makefile.in
|| die sed failed
First line removes example and tutotial (and win32) directories
from /usr/share/pcb.
Second line generates example and tutorial
in /usr/share/doc/pcb-20091103/
Third line fixes the empty usr/share/pcb-20091103/
Best regards
Stefan Salewski
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103
Chitlesh GOORAH chitlesh.goo...@gmail.com wrote: I see the build places refcard to the docdir. Is it outdated or legacy documentation? In PCB's GUI there is already a Key Bindings menu. I believe this one entails uptodate key bindings rather than the refcard. If it is outdated, then I think it should be removed from pcb sources. I wonder if it builds unbroken (there is a recent report on SF tracker). Again in the make install process, pcb.html, pcb.ps and pcb.pdf are dumped into docdir. I think that everyone is using a modern linux distro with a pdf reader install by default on every desktop environment. I think you are not quite right. not everyone. even not everyone on this list. So is it wise to ship only the pcb.pdf ? This will decrease the size of the pcb RPM/deb to be downloaded by the user. pcb.pdf is the only one shipped by fedora rpms. What do you think ? Following http://www.gnu.org/server/fsf-html-style-sheet.html, I think that it is wise to offer a document in as many formats as supported. even when running a desktop with XWindow system I typically prefer documentation in text format, and I could explain why. You are free to decide whether users of your GNU/Linux distribution will benefit from including or removing documentation in particular formats, but I believe the OS-neutral tarball should include and install all of them. BTW, what packagers from different distros are going to do with this NEWS entry?: - [docs]Add getting started guide Best regards, Ineiev ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild
Stefan Salewski m...@ssalewski.de wrote: autoroute.c:3431: warning: ‘add_clearance’ defined but not used djopt.c:2461: warning: ‘nudge_corner’ defined but not used draw.c:381: warning: passing argument 3 of ‘DrawSilk’ discards qualifiers from pointer target type file.c:1129: warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result report.c:680: warning: no return statement in function returning non-void rtree.c:203: warning: ‘__r_tree_is_good’ defined but not used hid/common/actions.c:88: warning: passing argument 1 of ‘hid_register_actions_context’ discards qualifiers from pointer target type hid/common/hidnogui.c:279: warning: ignoring return value of ‘scanf’, declared with attribute warn_unused_result hid/common/hidnogui.c:303: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result hid/common/hidnogui.c:321: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result hid/gtk/gui-dialog.c:101: warning: format not a string literal and no format arguments hid/gtk/gui-dialog.c:145: warning: format not a string literal and no format arguments hid/gtk/gui-top-window.c:2512: warning: format not a string literal and no format arguments Very nice reports (see attachment). hid/gtk/gui-dialog.c:172: warning: format not a string literal and no format arguments Should be like it is: the function semantics differ from the printf() ones. flags.c:226: warning: cast from pointer to integer of different size OffsetOf() shall not overflow even 16 bits when MAX_LAYERS 2048. parse_l.l:198: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result parse_l.c:1508: warning: ‘input’ defined but not used res_lex.l:64: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result res_lex.c:1139: warning: ‘input’ defined but not used Parser generator artifacts IMVHO. /usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might overflow destination buffer /usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might overflow destination buffer No idea. hid/common/actions.c:214: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result hid/common/actions.c:215: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result If an error occurs while writing into stderr, probably the most useful reaction is to ignore it. hid/png/png.c:313: warning: ‘save_flags.f’ may be used uninitialized in this function One of the least PNG exporter issues addressed by this branch: http://repo.or.cz/w/geda-pcb/dti.git/shortlog/refs/heads/kai-martin-scriptaction Thanks, Ineiev 0001-fix-some-warnings-suggested-by-Stefan-Salewski.patch Description: Binary data ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
gEDA-user: PCB+GL branch - labels hidden under pads
Peter C. When pressing 'D' for Pins/Via show Name/Number the number is hidden under the pins/pads. This is from the PCB+GL branch local_customisation_no_pours which I just grabbed last night. -Mark Stanley ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 - examples and tutorials
On Sat, Nov 7, 2009 at 5:39 PM, Peter Clifton wrote:
You also _break_ the HTML documentation by moving away the deliberately
installed .png / .gif files which it places there.
Well I was thinking not to ship the html file.
Since it doesn't appear the HTML docs use the .gif files, we ought not
to bother building them in the first place.
Actuallly, if it is built by one of pcb's function, i would say leave
it as it is.
This currently helps me as a distributor qualify if this export gif
feature of pcb is working as intended.
By all means delete the installed HTML files if you wish (along with
{thermal,pad,puller}.{png,gif}), but please don't install
intermediate .pcb of .pdf files.
These will be then be removed.
Chitlesh
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: Kudos
On Wed, Nov 4, 2009 at 3:31 AM, Gabriel Paubert paub...@iram.es wrote: On Tue, Nov 03, 2009 at 01:02:33PM -0700, Eric Brombaugh wrote: On 11/03/2009 12:35 PM, Duncan Drennan wrote: * gschem magnetic nets - always seem to snap to the wrong thing for me so I end up turning them off always. Need to tweak my config file. You can temporarily disable this feature by holding in the CTRL key. I guess that should be added to the wiki somewhere By golly, it works. Thanks for the tip! I would for one prefer to have the capability of inverting the way the Ctrl key works. I really like this idea. It is possible? I hope so. Gabriel ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user -- http://evanfoss.googlepages.com/ ___ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild
On Sat, 2009-11-07 at 18:26 +0100, Stefan Salewski wrote:
On Sat, 2009-11-07 at 16:51 +, Peter Clifton wrote:
On Sat, 2009-11-07 at 14:07 +0100, Stefan Salewski wrote:
--docdir=/usr/share/doc/pcb-20091103
seems to generate an obsolete empty directory
/usr/share/pcb-20091103/
That directory is somewhat of an annoyance on my box..
I am not sure if I really understand your comment.
By default documentation goes into /usr/share/doc/pcb directory. For
gentoo convention is to have a subdirectory for each version, so we
have /usr/share/doc/pcb-20091103. Works fine with --docdir= but this
seems to generate the empty usr/share/pcb-20091103/ also.
Until recently, even builds where files were going
in /usr/share/pcb/..., PCB would produce an empty
folder /usr/share/pcb-$VERSION/ it is completely unrelated to docs, and
looks to be related to the Win32 build.
I've been annoyed by the empty dir before, but never really bothered to
track down its source.
My gues is:
sed -i -e 's/example//' -e 's/tutorial//' -e 's/ win32//' Makefile.in
|| die sed failed
sed -i -e 's/DOC=doc/DOC=doc example tutorial/' configure || die sed
failed
sed -i -e 's/$(pkgdatadir)/$(docdir)/' {example,tutorial}/Makefile.in
|| die sed failed
First line removes example and tutotial (and win32) directories
from /usr/share/pcb.
Second line generates example and tutorial
in /usr/share/doc/pcb-20091103/
Third line fixes the empty usr/share/pcb-20091103/
These substitutions probably only work correctly because those sub-dirs
aren't putting anything in $(pkgdatadir) legitimately.
I've got some patches queued up which should fix these issues upstream -
assuming no other developers complain about me applying them.
Best regards,
Peter C.
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild
On Sat, 2009-11-07 at 17:47 +, Ineiev wrote:
hid/gtk/gui-dialog.c:172: warning: format not a string literal and no
format arguments
Should be like it is: the function semantics differ from the printf() ones.
The correct fix for any bug sprewing this message is usually to pass the
format string as %s, then the message as a format argument. This
aviods the possibility of exploits from a user-derived message string
getting into the printf type routine:
In this case, CHANGE:
dialog = gtk_message_dialog_new (GTK_WINDOW (out-top_window),
GTK_DIALOG_MODAL |
GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_QUESTION,
GTK_BUTTONS_NONE, message);
TO:
dialog = gtk_message_dialog_new (GTK_WINDOW (out-top_window),
GTK_DIALOG_MODAL |
GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_QUESTION,
GTK_BUTTONS_NONE, %s, message);
flags.c:226: warning: cast from pointer to integer of different size
OffsetOf() shall not overflow even 16 bits when MAX_LAYERS 2048.
We could probably cast the warning away. Our OffsetOf macro should use
a large enough integer type to match the pointer on the system, and by
in specific cases, we might choose to cast that into a smaller integer
type.
parse_l.l:198: warning: ignoring return value of ‘fwrite’, declared with
attribute warn_unused_result
parse_l.c:1508: warning: ‘input’ defined but not used
res_lex.l:64: warning: ignoring return value of ‘fwrite’, declared with
attribute warn_unused_result
res_lex.c:1139: warning: ‘input’ defined but not used
Parser generator artifacts IMVHO.
Looks like. You might be able to kludge around the input one, possibly
by taking the address of that function into some void* pointer in the
source .l file, then casting it away, but it is probably not worth it.
I don't get the fwrite one, as presumably later flex has fixed the
generated code for that case.
/usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk
might overflow destination buffer
/usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk
might overflow destination buffer
No idea.
This definition looks like the required call:
extern __inline __attribute__ ((__always_inline__)) __attribute__
((__gnu_inline__, __artificial__)) char *
__attribute__ ((__nothrow__)) strncat (char *__restrict __dest, __const char
*__restrict __src, size_t __len)
{
return __builtin___strncat_chk (__dest, __src, __len, __builtin_object_size
(__dest, 2 1));
}
That file calls strncat in several places, on a string accel which
is 64 char long. Each call is passed sizeof (accel) as its n
argument, so it shouldn't overflow as far as I can see.
AHHA...
From man 3 strncat:
If src contains n or more characters, strncat() writes n+1 characters
to dest (n from src plus the terminating null byte). Therefore, the
size of dest must be at least strlen(dest)+n+1.
So we need to pass sizeof (accel) - 1.
hid/common/actions.c:214: warning: ignoring return value of ‘fwrite’,
declared with attribute warn_unused_result
hid/common/actions.c:215: warning: ignoring return value of ‘fwrite’,
declared with attribute warn_unused_result
If an error occurs while writing into stderr, probably the most useful
reaction is to ignore it.
True.. I'm not sure if we can cast it away or not. I remember reading
some notes about GCC not liking you to cast such warnings away.
if (fwrite...) { /* NOP */ }
Or some portable, non-compiler whining alternative?
Thanks for looking into all of these Ineiev. (BTW, Please bug me if you
have any outstanding patches I promised to review / apply. I recall
layer colours.. )
Best wishes,
Peter C.
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
