Re: gEDA-user: pcb: Some code-cleanup-patches

2010-10-16 Thread Felix Ruoff 



Am 10.10.2010 10:03, schrieb Felix Ruoff:

 Am 10.10.2010 02:55, schrieb Peter Clifton:

On Sat, 2010-10-09 at 23:29 +0200, Felix Ruoff wrote:

(...)
The first one (0002...) removes some unused functions from the 
gtk-gui-code.

How is removing APIs required by the HID interface and replacing them
with NULL pointers removing unused functions?
I am sure, you are right, but I found no situation in the code, where 
this functions are called. For this reason, I removed them and had no 
problems with compiling. I also discovered no problems with using pcb, 
but sure, I have not tested ALL functions.


Can you give me a hint, where my faults are?
I just discovered the error myself. Sorry for sending such a 
'destructive' patch!

Felix


___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: pcb: Some code-cleanup-patches

2010-10-10 Thread Felix Ruoff 

 Am 10.10.2010 02:55, schrieb Peter Clifton:

On Sat, 2010-10-09 at 23:29 +0200, Felix Ruoff wrote:

Hello,

today I am trying to make patches from my recent days work. I am new to
git, so it takes much more time than I expected...
But, here are two more patches.

The first one (0002...) removes some unused functions from the gtk-gui-code.

How is removing APIs required by the HID interface and replacing them
with NULL pointers removing unused functions?
I am sure, you are right, but I found no situation in the code, where 
this functions are called. For this reason, I removed them and had no 
problems with compiling. I also discovered no problems with using pcb, 
but sure, I have not tested ALL functions.


Can you give me a hint, where my faults are?

Thank you,
Felix


___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: pcb: Some code-cleanup-patches

2010-10-10 Thread Ineiev 

Hello,

Felix Ruoff wrote:
The second one (0004...) introduces the gtk-default-dialog for 
'overwrite-existing-file - confirmation'.


gtk_file_chooser_get_do_overwrite_confirmation() was introduced in gtk-2.8;
PCB current requirement is 2.4.0.


___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user

Re: gEDA-user: pcb: Some code-cleanup-patches

2010-10-09 Thread Peter Clifton 
On Sat, 2010-10-09 at 23:29 +0200, Felix Ruoff wrote:
 Hello,
 
 today I am trying to make patches from my recent days work. I am new to 
 git, so it takes much more time than I expected...
 But, here are two more patches.
 
 The first one (0002...) removes some unused functions from the gtk-gui-code.

How is removing APIs required by the HID interface and replacing them
with NULL pointers removing unused functions?

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)



___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user